Commit graph

11 commits

Author SHA1 Message Date
Jeremy Bicha
07c1de1893 night-light: Move Off to the schedule switcher row
As recommended by the mockup:
https://gitlab.gnome.org/Teams/Design/settings-mockups/blob/master/displays/night-light.png
2019-01-07 14:13:37 +00:00
Jeremy Bicha
e5d8b6275a night-light: Drop the sunrise/sunset indicator
It's not in the latest design mockup:

https://gitlab.gnome.org/Teams/Design/settings-mockups/raw/master/displays/night-light.png
2019-01-07 14:13:37 +00:00
Georges Basile Stavracas Neto
ed36688c58 night-light: Rework implementation
This commit improves the Night Light code in various
ways:

 * Turn it into a template class, subclass of GtkDialog,
   and adapts all the code to reflect that.

 * Update the code style in various places, to make it
   more conformant with the documented code style.

 * Reorganize the code a bit, moving functions around,
   to make it more conformant with the documented order.
2018-05-29 12:30:16 -03:00
Robert Ancell
4aee26cc77 display: Fix double free of GError 2018-05-29 15:01:03 +12:00
Andrea Azzarone
f9b65046e9 night-light-dialog: Ignore G_IO_ERROR_CANCELLED errors
We should ignore G_IO_ERROR_CANCELLED errors and avoid displaying useless
warnings. Also use g_clear_object instead of g_object_unref.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/87
2018-05-12 02:31:12 +00:00
Andrea Azzarone
1d26f63b18 night-ligth-dialog: Avoid dereferencing invalid pointer
dialog_got_proxy_cb and dialog_got_proxy_props_cb may be called after the
instance of CcNightLightDialog has been disposed. Make sure 'self' pointer is
not dereferenced if not valid.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/86
2018-05-10 00:56:19 +02:00
Georges Basile Stavracas Neto
cbf0dc99da display: Cache the D-Bus proxy 2018-04-06 22:23:38 -03:00
danielps
77aaf3146b display: Fix night light minute selection
The night light schedule dialog stores the time as a single floating
point value, which is then converted into hours and minutes for the
time selection fields.

Previously, the minutes were calculated using the remainder of the
stored value and the hours. This caused undesired behaviour when the
hour field was set to zero, as fmod(value, 0) returns NaN. As a result,
the user was not able to set the time between 00:00 and 00:59.

This patch rewrites the time retrieval logic using modf.

https://bugzilla.gnome.org/show_bug.cgi?id=792944
2018-01-30 09:38:11 -02:00
Richard Hughes
9725efd3e4 display: Tweak night light dialog UI to match latest mockups 2017-02-16 19:56:51 +00:00
Richard Hughes
2f1af82a4e display: Only show the sunset/sunrise icons when not manually specified 2017-02-14 11:20:08 +00:00
Richard Hughes
fdbd788b96 display: Rename 'Natural Light Filter' to 'Night Light' 2017-02-10 16:32:24 +00:00
Renamed from panels/display/cc-natural-light-dialog.c (Browse further)