The 'on_fullscreen' function which handles the 'window-state-event'
signal should be returning a gboolean value. Fix the function
signature and have it return FALSE to allow the event to continue to
propagate.
https://bugzilla.gnome.org/show_bug.cgi?id=751129
Don't break out of loop if we weren't primary, as this
is stopping the user swapping back and forward between
primary and secondary with a tiled monitor.
i.e. user sets monitor to secondary and attempts to
go back to primary and it fails to move it.
https://bugzilla.gnome.org/show_bug.cgi?id=751680
When changing the airplane mode, either from the Bluetooth panel, or
through gnome-shell's status menu, we would receive signals from the
Rfkill gnome-settings-daemon service, even after the network panel was
closed, as we didn't unref' it. Except that the panel was mostly gone.
So splat.
https://bugzilla.gnome.org/show_bug.cgi?id=751482
Making a new connection available to other users requires being an
admin, or entering an admin password.
If we enable that option by default for new connections, we effectively
prevent non-admin users from connecting to new networks when they go to
the coffee shop without their laptop admin.
https://bugzilla.gnome.org/show_bug.cgi?id=751378
Upstream of openssh does not yet ship a systemd service file, so distros
add them downstream and unfortunately use different names: E.g. on
Fedora the unit is called sshd.service, on Debian/Ubuntu it is called
ssh.service.
Therefore make it possible to override SSHD_SERVICE via CFLAGS.
https://bugzilla.gnome.org/show_bug.cgi?id=751326
The GtkStack page which shows the label 'No printers detected' in the
'New printer dialog' misses border.
This commit places the GtkLabel into a GtkFrame to achieve that.
https://bugzilla.gnome.org/show_bug.cgi?id=749883
Hong Kong people expect to use a little endian date in English. (and a
big endian date in Chinese)
The D_FMT format string for en_HK is '%A, %B %d, %Y', which the current
code parses as middle endian.
This commit makes the code parse it as little endian, that is it doesn't
ignore the %A formatter any more.
en_HK is the only UTF-8 locale with this D_FMT format string, so this
shouldn't change anything for other locales.
https://bugzilla.gnome.org/show_bug.cgi?id=750781
This moves the two functions to the top of the file, changes the
get_geometry to return x/y if requested, and refactors the callers to
use it.
It also refactors some code that open coded the same basic code.
https://bugzilla.gnome.org/show_bug.cgi?id=750312
Set 'PageSize' instead of 'media' for new printers since we use PPD
for construction of the combo for selecting of default paper size.
Previously, we've been setting 'media' attribute for new printers.
Attribute 'media' is used by IPP but we set paper size using 'PageSize'
which comes from PPD in the options dialog. Sometimes (quite often) IPP
gets priority over PPD in print systems. Therefore there was inconsistency
of what user set as default paper size on the options dialog and what was used.
Also don't mark IPP and user's local options as default in PpPPDOptionWidget
since it should use just PPD (we can change PPD values only in this widget).
Since we use PPD for setting of paper size in the options dialog, we shouldn't
show a value which user does not change actually (IPP's 'media' vs. PPD's
'PageSize').
https://bugzilla.gnome.org/show_bug.cgi?id=748569
Only the networks with existing connection should have gear buttons.
This is a regression from 9ffaff7472.
If the widget we add as a stack page isn't visible, the page will not be
shown. As we later add another page with that button, we'd end up
showing that by default.
https://bugzilla.gnome.org/show_bug.cgi?id=750841
Show the 'New printer dialog' after setting transient parent for it
so that the warning about missing transient parent is not shown
to the user and the dialog is correctly focused.
https://bugzilla.gnome.org/show_bug.cgi?id=748206
If there's an accelerometer builtin to the display, don't show the
rotation buttons, it will be handled by the user rotating the display,
eventually with the rotation lock in use.
https://bugzilla.gnome.org/show_bug.cgi?id=750410
When the main battery isn't called BAT0, as happens on a dual-battery,
convertible Toshiba laptop, we would tag both batteries as "Extra". Mark
the first one as being the main battery.
In the longer-term, we'll have UPower exporting the exact information
about which is in the "dock" and which is in the same package as the
processing unit, when the kernel exports it.
See https://bugzilla.kernel.org/show_bug.cgi?id=97841https://bugzilla.gnome.org/show_bug.cgi?id=748592
When a virtual device is removed and the instance gets finalized we're
not disconnecting from the real NMDevice's notify signal and thus end
up crashing when the signal fires afterwards.
Avoid that by using g_signal_connect_object() so that when we're
finalized the disconnection happens automatically.
https://bugzilla.gnome.org/show_bug.cgi?id=749972
From coverity:
gnome-control-center-3.14.5/panels/network/connection-editor/firewall-helpers.c:75:9: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [enabled by default]
https://bugzilla.gnome.org/show_bug.cgi?id=749897
With UPower 1.0, the critical action to take when the battery level
is too low isn't in the hands of the user anymore, but in the hands
of the system.
It's now handled by UPower directly, through the CriticalPowerAction
configuration option. Instead of asking logind whether the system
supports hibernation, remove the action label altogether.
https://bugzilla.gnome.org/show_bug.cgi?id=749436
If the gsettings key for the command or name of a custom shortcut is not
writable, the keyboard panel still lets you edit them. This commits
makes the corresponding widgets unsensitive when the gsettings key is
not writable.
https://bugzilla.gnome.org/show_bug.cgi?id=749381
It's part of CcKeyboardItem but nothing uses it. It's also parsed
when loading KeyListEntry XML, but never used. The key description is
translated using Keylist::package before gettext_package is assigned.
https://bugzilla.gnome.org/show_bug.cgi?id=749381
When a Bluetooth airplane mode isn't available (whether hardware or
software) it means there are no Bluetooth adapters, even turned off.
Hide the Bluetooth section in that case.\
https://bugzilla.gnome.org/show_bug.cgi?id=749140
