Commit graph

25 commits

Author SHA1 Message Date
Robert Ancell
0baacee873 background: Use g_auto for variables
https://bugzilla.gnome.org/show_bug.cgi?id=788155
2018-01-26 16:22:23 +13:00
Robert Ancell
378e837a06 background: Use G_DEFINE_TYPE 2017-09-25 14:16:09 -04:00
Bastien Nocera
99acb323d2 background: Add more information to run-time warning
It was impossible to know which background XML had an error with the
original message.
2017-06-07 18:24:26 +02:00
Debarshi Ray
b37165de9c background: Fix a few memory leaks
https://bugzilla.gnome.org/show_bug.cgi?id=757189
2015-10-27 17:32:50 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Kalev Lember
3491c6625c background: Fix reference counting in background XML loader
Commit b9e3603ba4 added an unref to fix a
memory leak, but it went to a wrong place -- in XML loader, all items
are stored in a hash table that takes ownership of them, and destroyed
when the hash table goes away.

This commit fixes the reference counting in the XML loader and adds
explicit g_object_ref / g_strdup when inserting values to the hash table
to make the memory management more obvious.

The following commit fixes the real leak.

https://bugzilla.gnome.org/show_bug.cgi?id=709453
2013-10-07 10:35:52 +02:00
Bastien Nocera
5d16f81821 background: Fix a memory leak when monitoring directories
Destroy directory monitors on when the XML object is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:27:10 +02:00
Bastien Nocera
b9e3603ba4 background: Fix memory leak in XML signal handling
When emitted in an idle, the item was correctly unref'ed, but not
when emitting the signal straight away.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:03:02 +02:00
Bastien Nocera
a0ab6d527f background: Fix memory leaks in slideshow handling
A string was leaked when loading the name of the slideshow,
and a file object was left lingering as well.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
00d8f80586 background: Use g_clear_* helpers when possible
https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:37 +02:00
Michael Meeks
527945b29e re-license GPLv2-only code to GPLv2+ permission from SUSE/RH legal
cf. https://bugzilla.gnome.org/show_bug.cgi?id=681834
2012-11-12 15:57:09 +00:00
Cosimo Cecchi
7b7f67fbae background: fix a compilation warning 2011-04-05 12:08:42 -04:00
Bastien Nocera
e46c3267ba background: Don't assert() for typos in XML files
https://bugzilla.gnome.org/show_bug.cgi?id=646250
2011-03-31 13:08:29 +01:00
Bastien Nocera
d361022907 background: Don't show errors when loading default bg
Check whether the file exists so we don't get warnings
when loading the default wallpaper on startup.

https://bugzilla.gnome.org/show_bug.cgi?id=646056
2011-03-29 16:39:40 +01:00
Thomas Wood
9d1d8534b8 background: only reset item_added_id when the source is removed
Make sure item_added_id is set to zero only when the idle source id is
actually removed. This ensures that the source is removed during finalize
if it still exists when the object is destroyed.
2011-02-19 17:25:20 +00:00
Alexander Larsson
4e06cd6236 Fix includes for gdesktop-enums.h
The file is in $incdir/gsettings-desktop-schemas/gdesktop-enums.h,
and pkg-config returns -I$incdir/gsettings-desktop-schemas, so the
right way is to #include <gdesktop-enums.h> which is what other modules
do.

https://bugzilla.gnome.org/show_bug.cgi?id=642369
2011-02-17 20:59:55 +01:00
Bastien Nocera
7aca4e1ab2 background: Add support for source-url in XML 2011-02-14 19:11:20 +00:00
Bastien Nocera
5ca5367018 background: Remove files that don't exist
If an xml file references a wallpaper that doesn't exist
(as seen by installing the desktop-backgrounds-basic package
on Fedora), then just don't add it to the list of wallpapers.

Reported by Matthias Clasen
2011-02-14 15:11:17 +00:00
Bastien Nocera
bad4e389ef background: Avoid warning when XML file doesn't exist 2011-02-14 14:28:46 +00:00
Bastien Nocera
ecdcb2c235 background: Implement saving a single item 2011-02-14 09:44:05 +00:00
Bastien Nocera
66ee58bf52 background: Add function to load a single XML file
And its item out of it. So that we can load a file on startup
and check whether it corresponds to our configuration.
2011-02-14 09:44:05 +00:00
Bastien Nocera
ee62ca5e9b background: Add note about saving location
To the unused XML save code.
2011-02-12 03:17:02 +00:00
Bastien Nocera
c4baa04942 background: Add ability to parse single XML file
To load a particular file by hand.
2011-02-12 03:13:59 +00:00
Bastien Nocera
c2e84e2c8a background: Add "added" signal to CcBackgroundXml
So that the front-end can load the wallpapers piece-meal, and
avoid overloading the UI on startup.
2011-02-12 03:13:55 +00:00
Bastien Nocera
415d4c1111 background: GnomeWpXml to CcBackgroundXml
and into a GObject.
2011-02-12 03:13:53 +00:00
Renamed from panels/background/gnome-wp-xml.c (Browse further)