Commit graph

120 commits

Author SHA1 Message Date
Felipe Borges
5796d83ccd sharing: Move the "Remote Login" dialog Switch into the dialog
https://bugzilla.gnome.org/show_bug.cgi?id=786650
2018-01-25 23:42:02 -02:00
Iñigo Martínez
0dd386f405 build: Migrate from Intltool to Gettext
Recent versions of Gettext are able to translate several formats
that are used in GNOME applications. This patch migrates from
Intltool to Gettext by using meson's i18n features.

https://bugzilla.gnome.org/show_bug.cgi?id=787588
2018-01-23 10:49:31 +01:00
Jeremy Bicha
40fe964a65 sharing: Drop the "Personal" from "Personal File Sharing" description
https://bugzilla.gnome.org/show_bug.cgi?id=772355
2018-01-21 12:37:01 -02:00
Piotr Drąg
3807e45755 sharing: add XML declaration to the .policy file
Without it, gettext mangles UTF-8 characters.

See https://savannah.gnu.org/bugs/?52932

https://bugzilla.gnome.org/show_bug.cgi?id=787588
2018-01-19 16:41:25 +01:00
Iñigo Martínez
dc0988d47c build: Remove autotools
To avoid the burden of maintaining multiple build systems, this
patch removes autotools support.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-18 12:20:08 +01:00
Piotr Drąg
b65e31323a panels: Remove soft hyphens from .desktop files
With the old shell gone, there is no need to work around cut off panel
names (bug #647087). As it stands now, it only confuses translators
(invisible characters are hard to, well, see).

https://bugzilla.gnome.org/show_bug.cgi?id=792629
2018-01-18 00:12:04 -02:00
Felipe Borges
afbdddc2ed sharing: properly resize listbox rows
https://bugzilla.gnome.org/show_bug.cgi?id=767646
2018-01-17 23:54:33 -02:00
Georges Basile Stavracas Neto
eca7f39782 sharing: Use gtk_menu_popup_at_pointer
Instead of the deprecated gtk_menu_popup().
2018-01-17 23:23:59 -02:00
Georges Basile Stavracas Neto
0af9a5ad64 sharing: Ensure CcHostnameEntry GType before initialization
The exact same reasoning of 35e670c6da.
2018-01-17 23:18:37 -02:00
Iñigo Martínez
32edd6789e build: Port to meson build system
Meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-17 20:09:35 -02:00
Georges Basile Stavracas Neto
b23ef59926 shell-model: Remove old categories
Since we don't maintain two different shells anymore, there
is no need to maintain the two different sets of categories
in the desktop files.

This commit also drops the "#ifdef CC_ENABLE_ALT_CATEGORIES"
blocks, since the previous commit removed that define.

https://bugzilla.gnome.org/show_bug.cgi?id=790923
2017-11-28 17:03:51 -02:00
Rui Matos
2556fd5e2c sharing: Make use of the cancellable for async hostname calls
We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.

https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
94045b8418 sharing: Remove an unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
f959b9127b sharing: Make panel initialization asynchronous
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
58bad723ee sharing: Show the networks widget in the screen sharing dialog
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 19:26:58 +02:00
Jonas Ådahl
ecb0e6dd23 sharing: Add Wayland screen sharing support
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.

So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 18:55:42 +02:00
Allan Day
87568e9250 Harmonize list box row layouts
While it isn't possible, or even advisable, to make all the list
box rows the same height, using a number of standard heights will
make the control center feel more harmoneous.

Adust the height of the list box rows in Color, Date & Time,
Mouse & Touchpad, Network, Privacy, Region & Language, Sharing
and Universal Access. Makes standard rows that contain labels
and/or controls 58px tall. Some other rows, such as those which
contain two lines of text, are allowed to be taller.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:48 +02:00
Allan Day
8a8e53ab8a Standardize vertical spacing of panels
Ensure that the vertical spacing inside each panel is similar.
This makes the transition between each panel smoother and makes
the control center feel more cohesive.

Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

Bluetooth, displays and printers are not addressed.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:42 +02:00
Georges Basile Stavracas Neto
f7bdd3c969 panels: Minor adjustments for the new shell 2017-08-09 19:31:41 +02:00
Mohammed Sadiq
4c0928f324 sharing: Don't leak path
g_file_get_path() allocates new memory for path.
So using g_strdup() later would leak the previous allocation.

https://bugzilla.gnome.org/show_bug.cgi?id=782045
2017-05-02 12:55:26 +02:00
Felipe Borges
02ab69bd8f sharing: Hide Vino when using Wayland
Since we don't support "Screen Sharing" under Wayland yet.

https://bugzilla.gnome.org/show_bug.cgi?id=774553
2016-11-17 16:04:32 +01:00
Felipe Borges
da1d8f0d39 sharing: Update "Remote Login" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-15 14:19:36 +02:00
Felipe Borges
f3b7c16132 sharing: Drop the "Personal" from "Personal File Sharing"
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-15 11:20:56 +02:00
Georges Basile Stavracas Neto
2777fd583d panels: use the new categories
Following the previous patch, this patch adds the new alternative
categories to the panels' Desktop files. These alternative categories
are only relevant for the alternative Shell, and do not break the
current Shell in any way.

https://bugzilla.gnome.org/show_bug.cgi?id=767301
2016-06-14 12:16:43 -03:00
Felipe Borges
8e414f88b1 sharing: Move "Remote Login" switch to headerbar
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 16:00:54 +02:00
Felipe Borges
8b68961431 sharing: Use a checkbutton in the "Screen Sharing" dialog
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing
We should use a checkbutton instead of a switch for
the "Allow connections to control the screen" option.
Also, this commit changes this option label accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 16:00:01 +02:00
Felipe Borges
612ac49205 sharing: Update "Screen Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:59:19 +02:00
Felipe Borges
4d001f7989 sharing: Update "Media Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:58:55 +02:00
Bastien Nocera
5c10ce45b8 panels: Fix translators comments being truncated
Commit b3be076 added soft hyphens along with a comment for translators
to use those soft hyphens. Except that gettext would only grab the one
line out of the four we wrote for translators to read. Put them all on
the same line so that gettext actually extracts those.

https://bugzilla.gnome.org/show_bug.cgi?id=765778
2016-04-28 23:38:00 +02:00
Bastien Nocera
b3be07609a panels: Fix truncated panel names for larger fonts
Note that this fix will not automatically fix translations, which will
need to add soft-hyphens (U+00AD) to their translations themselves, and
will not fix larger fonts for which the split up syllables end up
being bigger than the maximum text width.

It's the best we can do without redesigning the Settings shell, which is
already something planned.

https://bugzilla.gnome.org/show_bug.cgi?id=647087#c13
2016-04-07 16:06:35 +02:00
Bastien Nocera
70672c3658 sharing: Fix "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764150
2016-03-24 17:01:37 +01:00
Jiro Matsuzawa
a3a8255b97 sharing: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Bastien Nocera
0d4b2bc49b sharing: Ensure Tracker rygel plugin is disabled
The Tracker plugin is enabled by default, and will replace the
MediaExport plugin is enabled. This means that instead of sharing files
listed in the paths set in the UI, we'd be sharing the user's files as
configured in the Search panel. Not what we want to do if this contains
private files.
2016-01-10 10:24:41 +01:00
Bastien Nocera
9315eb0251 sharing: Fix crash when disabling sharing
Left-over code from 9d45904f3c meant that
we'd try to disable a non-existent switch.

https://bugzilla.gnome.org/show_bug.cgi?id=756391
2015-10-11 17:41:04 +02:00
Bastien Nocera
9d45904f3c sharing: Remove "Bluetooth" (Obex) sharing
It will be moved to the Bluetooth panel instead.

https://bugzilla.gnome.org/show_bug.cgi?id=740369
2015-07-30 20:13:29 +02:00
Joanmarie Diggs
cfb12e4e22 sharing: Accessibility improvements
* Add label-for/labelled-by AtkRlation pair between the "Computer Name"
  label and its entry.
* Give an accessible name to the switch in the header bar. In order to
  not break string freeze, used "Sharing" since that's what's shown in
  the header bar.
* Fix the incorrect mnemonic widget for media sharing so that Orca speaks
  the label in the main sharing panel, and the name in the media sharing
  dialog

https://bugzilla.gnome.org/show_bug.cgi?id=746759
2015-07-27 19:48:49 +02:00
Michael Biebl
1f4f6ded0f Make it possible to override SSHD_SERVICE
Upstream of openssh does not yet ship a systemd service file, so distros
add them downstream and unfortunately use different names: E.g. on
Fedora the unit is called sshd.service, on Debian/Ubuntu it is called
ssh.service.

Therefore make it possible to override SSHD_SERVICE via CFLAGS.

https://bugzilla.gnome.org/show_bug.cgi?id=751326
2015-06-28 23:20:03 +02:00
Mario Sanchez Prada
fd7d7d4c10 sharing: Use g_variant_get_{string|variant}() instead of g_variant_get()
Besides being a better practice, this changes also fixes 2 memory leaks
when handling strings boxed inside GVariant objects.

https://bugzilla.gnome.org/show_bug.cgi?id=748411
2015-04-27 15:55:20 +01:00
David King
b4c02fa3b3 sharing: Update help URI
https://bugzilla.redhat.com/show_bug.cgi?id=1193806
https://bugzilla.gnome.org/show_bug.cgi?id=745590
2015-03-04 15:49:53 +00:00
Rui Matos
38180662cd sharing: Don't add the folder if the dialog isn't explicity accepted
E.g. selecting a folder and then dismissing the dialog via the cancel
button or by pressing escape would still add the folder to the shared
folders list.
2015-02-09 17:25:36 +01:00
Yosef Or Boczko
d6c7e67d4f sharing: Put a real description string in the media dialog
https://bugzilla.gnome.org/show_bug.cgi?id=736537
2015-01-18 11:32:25 -05:00
Rui Matos
7d1a8db47e sharing: Drop deprecated API usage
https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Rui Matos
7121f03564 sharing: Prevent an endless loop and resulting stack overflow
We need to block ourselves around the gtk_switch_set_active() call in
the error path, when we can't speak to the sharing dbus service, or we
end up in an endless loop since we're the ::state-set handler.

https://bugzilla.gnome.org/show_bug.cgi?id=739886
2014-11-13 11:28:24 +01:00
Bastien Nocera
658bcc86e6 sharing: Fix empty folder list by default
https://bugzilla.gnome.org/show_bug.cgi?id=736536
2014-09-12 12:04:58 +02:00
Bastien Nocera
884bf3b2dc sharing: Make it possible to share remote folders
rygel can actually share media if the remote folder is mounted.
2014-08-07 13:05:01 +02:00
Bastien Nocera
22c4db538f sharing: Avoid truncated folders list in media sharing
When XDG user dirs are badly setup, and the folders list contains items
such as @VIDEOS@ or @MUSIC@, g_get_user_special_dir() returns NULL and
we would insert NULL into the string array. That would cause the code
reading it to assume the end of the array was reached.

Go through a temporary array instead to build it.

https://bugzilla.gnome.org/show_bug.cgi?id=733489
2014-07-24 12:39:08 +02:00
Bastien Nocera
056784e60e sharing: Fix crash in media preferences
When XDG user dirs are badly setup, g_get_user_special_dir() will return
NULL, causing us to crash. Use g_strcmp0() instead.

https://bugzilla.gnome.org/show_bug.cgi?id=733489
2014-07-24 12:39:08 +02:00
Yosef Or Boczko
da22bddc1a Mark a string as translatable 2014-06-27 12:52:20 +03:00
Rui Matos
c2ad24e804 sharing: Use the selected URI from the file chooser
Using the current folder is counter-intuitive. The chooser already
only allows users to select folders.
2014-06-26 16:17:19 +02:00
Bastien Nocera
bd531b477e sharing: Update for list box API change 2014-06-26 16:00:45 +02:00