Commit graph

7029 commits

Author SHA1 Message Date
Georges Basile Stavracas Neto
0aed0c5ecd applications: Tweak screenshot description
As per design feedback, tweak the screenshot description text to
"Take pictures of the screen at any time."
2022-08-10 16:50:41 -03:00
Kate Hsuan
82b6e2c7bb firmware-security: Tweak panel style
Fix the spacing issues of several widgets, including the status icon,
label, and subtitle in a expander row.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1999
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-10 16:31:26 -03:00
Georges Basile Stavracas Neto
17b018a9fb applications: Add support for the screenshot permission
Add support for managing the screenshot permission, used by apps
who request non-interactive screenshots from the portal.

See also https://github.com/flatpak/xdg-desktop-portal/pull/851
2022-08-10 19:03:15 +00:00
Kate Hsuan
57fb0e28ae panels: firmware-security: Fix incorrect secure boot icon
If Secure boot is enabled, secure_boot_icon should be channel-secure-symbolic.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1998
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-10 11:47:52 +08:00
Georges Basile Stavracas Neto
6fd7164837 Revert "applications: Add support for the screenshot permission"
This reverts commit 49486dba68.
2022-08-08 17:24:42 -03:00
Georges Basile Stavracas Neto
78434394b2 applications: Add missing end period to Storage row 2022-08-08 19:32:20 +00:00
Georges Basile Stavracas Neto
94b591ac42 applications: Fix header capitalization of background row 2022-08-08 19:32:20 +00:00
Georges Basile Stavracas Neto
49486dba68 applications: Add support for the screenshot permission
Add support for managing the screenshot permission, used by apps
who request non-interactive screenshots from the portal.

See also https://github.com/flatpak/xdg-desktop-portal/pull/851
2022-08-08 19:32:20 +00:00
Kate Hsuan
784f83eb44 panels: firmware-security: new panel UX design implementation
The new UX implementation includes
1. Showing the security level using a number.
2. Showing descriptions of events and HSI checking items.
3. Change the style of the security level number.
4. Add the status icon and label for each HSI checking item.

Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-04 19:46:28 +00:00
Felipe Borges
c2145cacf4 user-accounts: Use "title" styling for login history dialog header
See https://docs.gtk.org/gtk4/class.HeaderBar.html#gtkheaderbar-as-gtkbuildable

Fixes #1958
2022-08-03 11:16:26 +00:00
Hendrik Müller
48497080b3 wifi: Fix bug in Known Wi-Fi Networks dialog
The "Forget" button would only update it's sensitivity after the first
select and deselect, when selecting and deselecting rows in the
"Known Wi-Fi Networks" dialog.
When selecting the first row, it would go from disabled to enabled.
Then deselecting that row would cause the button to go from enabled to
disabled.
Selecting any rows after that would no longer update the sensitivity and
make the dialog essentially useless.

The issue was, that the signals "add" and "remove" where being
expected to be emitted when the connection list updates its rows.
However, neither CcWifiConnectionList nor GtkListBox emit these signals.
The fix was, to emit these two signals at the appropriate locations.
The signals have also been renamed to "add-row" and "remove-row" to
make their purpose more clear.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1824
2022-08-03 11:05:16 +00:00
Mpho Jele
dea4ce1d48 user-accounts: Remove status icons from password entries
Adding the 'error' css class to icons visually indicates that
there's an issue with the input. This is the same purpose served
by the status icons. Another reason to remove the status icons
is that with the error class added to entries the entries dim
except for the status icons.
2022-08-03 09:58:41 +00:00
Mpho Jele
33a445f12e user-accounts: Make password dialog use libadwaita password entries 2022-08-03 09:58:41 +00:00
Felipe Borges
c381c633af user-accounts: Show "automatic login" option when locked
It should be made insensitive when the panel is locked, and sensitive
when locked.

We only hide this row for non-local users, where this setting doesn't
make much sense.

Fixes #1944
2022-08-03 09:39:59 +00:00
Hendrik Müller
c44ee6fa80 wifi: Add padding to Known Wi-Fi Networks dialog
The "Known Wi-Fi Networks" dialog is missing some padding to really
make it look polished.

By switching from a normal dialog to an AdwPreferencesWindow, we can
take advantage of libadwaita's automatic padding.
This will make sure the dialog is more in line with the rest of the
GNOME ecosystem.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1956
2022-08-03 09:18:39 +00:00
Dirk Su
83278d2724 panels: wwan: Add WWAN 5G connection support 2022-08-01 20:06:51 +00:00
Richard Hughes
e0d599bb40 firmware-security: Do not show the 'Processor Supported' attribute
This is really just saying "the HSI tests make sense" and is not really
useful to show in the UI.
2022-08-01 19:53:15 +00:00
Kate Hsuan
68ca4e5a3f Show a description for each event
Show the HSI event description to improve the UX and match the new mockups.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1938

Signed-off-by: Kate Hsuan <hpa@redhat.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
2022-07-29 07:35:30 +01:00
Marco Trevisan (Treviño)
72863a8f56 screen: Add Screen Privacy section to show Privacy screen toggle
The privacy screen toggle is visible only when there's a monitor that
supports it and it's modifiable only when there's not hardware lock.

Fixes: #909
2022-07-28 22:47:14 +00:00
Marco Trevisan (Treviño)
2f6d086c6f display-config: Parse privacy screen property and expose it per monitor
Each monitor can have a privacy screen property, so read it and expose
so that it can be at upper levels.
2022-07-28 22:47:14 +00:00
Marco Trevisan (Treviño)
b327301951 Panels: Rename lock panel into screen panel
This was designed some time ago [1] but never actually implemented, so:
 - Change the screen lock section to "screen"
 - Move the screen section up, so it's next to the other types of
   hardware
 - Added a Screen lock section in there

[1] https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/909#note_737827
2022-07-28 22:47:14 +00:00
Felipe Borges
ec2c3d477d sharing: Use AdwEntryRow for remote-desktop setup
See #1930
2022-07-26 20:11:56 +00:00
Mpho Jele
272b73795d user-accounts: Make back button switch to current user or panels list
When the window AdwLeaflet is folded the back button should either
switch to the panels list if the selected user is the current user
or switch to the current user if the selected user is from the
"other users" list
2022-07-24 15:29:46 +00:00
Mpho Jele
311268c4f7 user-accounts: Show the back button when window leaflet folds
Currently the back button is only shown when viewing a user from the
"other users" list.
These changes show the back button when the window AdwLeaflet is
folded or when the selected is from the "other users" list but never
when the window is not folded and the selected user is the current
user.

Fixes: #1719
2022-07-24 15:29:46 +00:00
Lukáš Tyrychtr
cf99eb4529 user-accounts: Set a11y label for login history dialog title
This was originally https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1402
2022-07-24 09:36:51 -05:00
Georges Basile Stavracas Neto
caa9b59f41 online-accounts: Mark run_goa_helper_sync as NULL-terminated
Spotted while porting GNOME Initial Setup [1]

[1]
https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/merge_requests/134
2022-07-21 16:54:25 -03:00
Kate Hsuan
1e53da4720 panels: firmware-security: Reduce the length of description
The descriptions of secure boot status were made simpler to improve the
user friendly.

Link: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1937
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-07-21 22:50:06 +08:00
Richard Hughes
e11929e0c1 firmware-security: Hide the panel when using a VM
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1972
2022-07-21 13:21:12 +01:00
David King
590351051f network: Fix VPN with unescaped ampersand
Much like in commit 47c586a82e for the
wifi panel, fix escaping of titles for VPNs.

https://bugzilla.redhat.com/show_bug.cgi?id=2090996
2022-07-20 17:53:11 +00:00
Kate Hsuan
d38a570efa firmware-security: Set the HSI row icon correctly for higher HSI levels
Set icon image to "emblem-default-symbolic" for higher HSI value.
2022-07-20 15:58:07 +00:00
Richard Hughes
032f8a4556 firmware-security: Correctly show SecureBoot status with new fwupd versions
Adapt to the org.fwupd.hsi.Uefi.SecureBoot HSI being fixed in
https://github.com/fwupd/fwupd/pull/4835 (level 0 isn't a valid number
unless it is a runtime issue, and the docs have always said HSI-1).

The org.fwupd.hsi.Uefi.Pk attribute has always been HSI-1, and so the
wrong hashtable was being queried -- which is probably my fault for
making SecureBoot an invalid value in the first place.

We also do not have to track the HSI-0 failures now, so delete the
hashtable completely.
2022-07-20 15:58:07 +00:00
Richard Hughes
5954dffda4 firmware-security: Set the HSI row colors correctly for higher HSI levels
If we get HSI-2 then the HS1-2 row should be 'success', as should HSI-1.
2022-07-20 15:58:07 +00:00
Bilal Elmoussaoui
bb86c36147 panels: Use icon-name property instead
Don't embed a custom GtkImage as that would lack the appropriate style
classes
that GtkButton/GtkMenuButton would automatically add for us
2022-07-20 14:15:57 +02:00
Pablo Correa Gómez
624023d633
display: avoid unnecessary gtk_style_context_get_margin call
The margin went unused after the monitor labels moved to the center
of the displays.

Fixes: e7e80efc ("display: Change appearance and size of monitor labels")
2022-07-18 17:58:46 +02:00
Jens Alpers
b9bf21a016 Issue 1846, Check for NULL pointer before gtk_editable_set_text 2022-07-11 02:20:50 +00:00
Carlos Garnacho
4eb075e5a5 display: Set a smaller width to display arrangement widget
This default size happens to expand the panel content horizontally,
this is seen as small jumps changing between joined and cloned views.
With this slightly smaller size, no further size jumps happen.
2022-07-08 13:41:30 -03:00
Carlos Garnacho
e8fcfc05a6 display: Make "Mirror" option show a single configuration for all displays
Since all displays are constrained to the same options, promote one so it's
shown in the main panel, the rest does work itself out.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1849
2022-07-08 13:41:30 -03:00
Carlos Garnacho
dc8eb2c22c display: Set "Multiple Displays" option on top
And make the display arrangements widget a row of the displays
preferences group, as per the latest mockups.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1851
2022-07-08 13:41:30 -03:00
Carlos Garnacho
e7e80efcbc display: Change appearance and size of monitor labels
Make these rounded everywhere, and have a lighter background and be
centered as per the latest mockups.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1850
2022-07-08 13:28:44 -03:00
Carlos Garnacho
2f9ec8b0a8 display: Set CSS class on the display arrangement widget
Instead of doing it via push/pop on the style context at draw time.
This way we will be able to specify and propagate some font style
to the monitor label, since style fonts are per-widget.
2022-07-08 13:28:44 -03:00
Jakub Steiner
064c6a807d timezone: Use blank map 2022-07-07 11:37:39 +00:00
Carlos Garnacho
f923c3ca01 datetime: Drop timezone highlighting
In most situations it is sufficient with the hint bubble being
displayed, or city name search, rely on these.
2022-07-07 11:37:39 +00:00
Carlos Garnacho
65d83189e9 datetime: Drop colormap
This image file is nowadays unused, except for loading/destroying it.
We can simply drop this.
2022-07-07 11:37:39 +00:00
Hendrik Müller
f0890ca1b6 wifi: Allow accessing settings of known wifi networks
Currently it is only possible to access the settings for the currently
connected wifi network.
Being able to configure a wifi network, even though it is not connected,
would be useful for example to share the password for a network that is
not in range.

To achieve this, a new property was added to CcWifiConnectionRow.
The new property "known_connection" signals whether this connection is
known and thus whether the options button for configuring it should be
displayed.

The property "known_connections" will be set to TRUE in two cases:
- when the list of connections is shown in the "Known Networks" dialog
- when the connection is known, but not the active connection

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1906
2022-07-06 19:34:56 +00:00
Andy Holmes
3d5be3b1fd
notifications: fix potential null dereference in app_info_get_id()
Although apparently unlikely, `strlen()` is called on the return value
of `desktop_id` instead of `ret`, which may result in a null
dereference.
2022-06-30 11:11:06 -07:00
Alexander Mikhaylenko
38442303e0 background: Adjust preview header bar style
There has been a slight change, sync to it.
2022-06-28 22:36:36 +04:00
Kate Hsuan
69598b9e08 Add Firmware Security panel
The Firmware Security panel exposes the host security levels
and details. The information is generated by fwupd. The panel
also exposes hardware configuration changes to pinpoint the
configuration changing time.

Currently this panel shows:

 - HSI and secure boot status
 - Details of HSI and secure boot
 - Configuration changelog
 - Digested security level
 - Extended protection
2022-06-27 13:53:30 -03:00
Jonas Ådahl
9e4f15353c display: Use virtual clone modes when mirroring
These are not real modes, but just as place holders when generating
'mirror' configurations. The clone modes will be just to match the
flag/dimension, while the actual mode applied will be individual for
each monitor.

This allows monitors to have their own refresh rates, which is possible
since a few mutter versions back. This also matches how mutter itself
generates mirror modes when doing so via the key binding.
2022-06-27 14:06:16 +00:00
Jonas Ådahl
6087c0397b display: Add 'is_preferred()' mode getter 2022-06-27 14:06:16 +00:00
Lubomir Rintel
dad011062b wwan: do not insist SIM ID being present
It is perfectly possible for mm_sim_dup_identifier() to return NULL if
the SIM ID wasn't provided by the modem for any reason, leading to an
assertion failure:

  (gnome-control-center:910641): cc-wwan-data-CRITICAL **: 12:43:51.573:
    cc_wwan_data_set_default_apn: assertion 'self->sim_id != NULL' failed

Handle the NULL SIM ID gracefully.
2022-06-20 23:48:31 +00:00