Commit graph

7609 commits

Author SHA1 Message Date
Christopher Davis
590506add3 vpn-helpers: Use GtkFileDialog and AdwMessageDialog
GtkFileChooser and GtkMessageDialog are both deprecated.
This commit replaces them with the most appropriate API
for each use case.
2023-06-06 13:33:29 +00:00
Christopher Davis
b73ce78230 background: Use GtkFileDialog
The GtkFileChooser interface is deprecated. Instead of using it,
we should use the new GtkFileDialog APIs.
2023-06-06 13:33:29 +00:00
sunflowerskater
266c55715a general: Add tooltips to headerbar controls
Acc. HIG, "controls in the header bars of primary windows should all have tooltips".

https://developer.gnome.org/hig/patterns/feedback/tooltips.html
2023-06-06 13:27:00 +00:00
Lukáš Tyrychtr
75b4d0b2bc default-apps: Don't crash when there are no apps for a mimetype
When a mimetype has no apps, we get a selection notification anyway, but the selected item is NULL.
So, account for that and don't crash.
2023-06-06 13:07:46 +00:00
Robert Ancell
09e45e03d9 info-overview: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
c7ce4e8962 display: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
1485414714 datetime: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
0b850560a8 background: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
606957c048 color: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
256e52b0f7 network: Fix name of parent class variable 2023-06-06 07:54:38 +00:00
Robert Ancell
9020cfb1a3 wacom: Use self for object variable name 2023-06-06 07:54:38 +00:00
Robert Ancell
9e13088515 thunderbolt: Use self for object variable name 2023-06-06 07:54:38 +00:00
Robert Ancell
90d83f072e sound: Use self for object variable name 2023-06-06 07:54:38 +00:00
Robert Ancell
868dd6cf7e power: Use self for object variable name 2023-06-06 07:54:38 +00:00
Robert Ancell
d951856294 online-accounts: Use self for object variable name 2023-06-06 07:54:38 +00:00
Robert Ancell
73e63225e2 notifications: Use self for object variable name 2023-06-06 07:54:38 +00:00
Christopher Davis
bd069bee92 default-apps: Use new adwaita widgetry, drop deprecated API
GTK has deprecated the AppChooser interface and related widgets.
These APIs will be gone in GTK5, so we should move away from
them as soon as possible.

This MR takes the opportunity to change the design to match newer
mockups while dropping deprecated APIs.
2023-06-06 03:32:59 +00:00
Timotej Šulík
8bf042cf56 display: Fix invalid panel state after canceling changes
When switching from Mirror mode to Join mode
and opening a monitor leaflet child by clicking
its row, clicking Cancel on the title bar would
get the UI into an invalid state.

Closes #2513.
2023-06-01 08:30:20 +00:00
Felipe Borges
f6d5080ffd user-accounts: Fix pointer cast in sort_users function
Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1812>
2023-06-01 01:38:20 +00:00
Felipe Borges
c8fe38c4f1 user-accounts: Move "Add User" button out of the user listbox
Per mockups at
78b6a0506b/users/users.png

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1812>
2023-06-01 01:38:20 +00:00
Felipe Borges
f444852449 common: Fix name of internal InfoButton get/set functions
This was a copy-pasta mistake when creating the CcListRowInfoButton
class from the CcListRow class.

The mistake was harmless but fixing it is good for the sake of
consistency and to avoid confusion in backtraces.
2023-05-31 21:34:03 +00:00
Michael Catanzaro
718af17905 info-overview: show only the GNOME major version
What we have is the GNOME Shell version, which is NOT the same as the
GNOME version. I thought it'd be nicest to rename this to "GNOME Shell
Version" but it seems we want to keep that as an internal codename not
exposed to users. So instead, let's just show only the major version,
which should hopefully match. This is very generic and much less useful
but I don't see a better solution.

See previous discussion in:

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1481
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1805

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1814>
2023-05-31 21:03:23 +00:00
Gunnar Hjalmarsson
d5becccc7c keyboard: Drop "Left Alt" as compose key option
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2509
2023-05-31 20:43:24 +00:00
Marcos Miller
478b3b4346 keyboard: change message dialog in 'reset all shortcuts'
The class Gtk.MessageDialog is deprecated in gtk 4.10.

This change remove class deprecated and uses the new class
AdwMessageDialog for view the message of 'reset all shortcut'.

keyboard: fix white space in function

keyboard: align arguments

keyboard: fix alignment of arguments in function
2023-05-31 13:51:26 +00:00
Robert Ancell
dc988e476b notifications: Fix panel object reference never being dereferenced 2023-05-31 08:17:01 +00:00
Marcos Miller
b0063d015f keyboard: fix "Add Custom Shortcut" in others sections
Clicking on the 'Custom Shortcuts' row when there are no custom
shortcuts causes the 'Add Custom Shortcuts' dialog to be shown for
all subsequent sessions. This is because the first stack defined was
'Add Custom Shortcuts', it would always be visible, as it was no
longer defined which stack was going to be shown.

Fixes (https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2479)
2023-05-31 08:15:59 +00:00
Felipe Borges
b80f154f80 network: Close Connection Editor dialog when clicking Apply button
Fixes #2499
2023-05-31 08:15:32 +00:00
Robert Ancell
e1c8f9b291 firmware: Fix capitalization in class name 2023-05-30 08:36:22 +00:00
Robert Ancell
426f9a9302 common: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
543f24a754 wacom: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
3ad1f01b34 online-accounts: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
5d65e8df9e firmware-security: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
b041c9df6d notifications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f756184e3b display: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
3bd3f82bca thunderbolt: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
39ccf2c610 user-accounts: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
a06914a60c keyboard: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
ae93ded618 search: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
c78eb3d2f8 region: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
89c054a31b network: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
644df7697b datetime: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f23218e037 background: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
642833509b applications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Automeris naranja
901f395e9e user-add-dialog: Use CCListRowInfoButton for the "Administrator" AdwActionRow
Follow-up from Follow-up from https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1571
2023-05-30 08:35:12 +00:00
Timotej Šulík
4102a16b40 display: Fix stuck window subtitle in the Displays panel
In case an inapplicable display configuration
is attempted, and the issue is then resolved,
the warning window subtitle remains displayed
even under the "Apply Changes?" title.

Closes #2512.
2023-05-30 00:58:16 +02:00
Timotej Šulík
4fe26944d8 display: Fix gaps when numbering unusable displays 2023-05-28 22:16:10 +00:00
Felipe Borges
e6336ec433 network: Add ToastOverlay to connection-editor 2023-05-26 02:04:52 +00:00
Felipe Borges
3f482559ea network: Make "Import VPN from file" use GtkFileDialog
Since the gtk_file_chooser_dialog APIs are deprecated.
2023-05-26 02:04:52 +00:00
Felipe Borges
e580c309e8 network: Drop legacy vpn_export function
This was a leftover from the old connection-editor.
2023-05-26 02:04:52 +00:00
Ismael
497f599517 network-panel: fix crash when importing wrong vpn file 2023-05-26 02:04:52 +00:00