A source file with 4k lines of code is not understandable, and the glade file
was becoming quite a challenge for glade.
To add more features we need to split things up just to keep them maintainable.
This is the first patch that just splits out the proxy bits. Other device types
will follow in the next few days.
Keep the active network at the top, and 'Other' at the bottom.
the other access points are sorted by strength now.
https://bugzilla.gnome.org/show_bug.cgi?id=678505
Signed-off-by: Richard Hughes <richard@hughsie.com>
The libnm objects can survive the disposal of the network panel.
If we don't disconnect the signal handlers on them, bad things
can happen. Use g_signal_connect_object to tie the life-cycle
of the signal handlers to the panel.
https://bugzilla.gnome.org/show_bug.cgi?id=677969
Signed-off-by: Richard Hughes <richard@hughsie.com>
Sort the strength and security indicators in the combo box
popup to be in the same order as the shell menu.
https://bugzilla.gnome.org/show_bug.cgi?id=677788
Signed-off-by: Richard Hughes <richard@hughsie.com>
APs that don't broadcast their SSID will return NULL from
nm_access_point_get_ssid() (since that's easier to check in C
using an if statement than returning a zero-length GByteArray).
Thus the code shouldn't try to dereference the SSID byte array
since it could be NULL.
But in fact, the panel shouldn't be showing hidden APs anywhere
in the UI, since the user needs to manually enter the SSID to
connect to it anyway. So just ignore hidden APs like nm-applet
does.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
This prevents the chicken-and-egg problem as described in #653296 by launching
nm-connection-editor for the inactive connection for the device.
This only works when there is one possible connection for the device, which is
helpfully typical for wired ethernet devices.
Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=653296
The network panel ignored the request of showing the wireless
dialog if there is no active AP, and the user was not able to
set up the advanced wireless settings, such as WPA-EAP settings.
https://bugzilla.gnome.org/show_bug.cgi?id=661526
When invoked with certain arguments, show the wireless and 3g
dialogs from libnm-gtk. Previously they were provided by nm-applet,
but now gnome-shell conflicts with it and it makes sense anyway
to have one place for network configuration. Also added a "show-device"
command, that just selects a device in the tree view.
https://bugzilla.gnome.org/show_bug.cgi?id=657093
We warn if there is no connection to the internet (questionable
to create a hotspot in that case) or if creating the hotspot
would drop the default connection to the internet (ditto).
Dan recommends that we do not discriminate between WPA and WPA2,
so we don't have to bother with showing multiple strings at all
anymore, it is just None or WEP or WPA now.
This is an implementation of network sharing (aka 'Hotspot').
The new 'Use as hotspot' button lets you use a wifi device
as a hotspot for sharing network connections with others.
Currently, the panel generates a ssid based on the hostname,
sets the security to WEP, and generates a random key. These
parameters can be edited afterwards.
It is currently not possible to show how many connections
are using the hotspot. Apart from this, the implementation
is pretty much complete.
