theme-thumbnail-engine.c: In function 'message_from_capplet':
theme-thumbnail-engine.c:642: warning: 'pixels' may be used uninitialized in
this function
theme-thumbnail-engine.c:641: warning: 'rowstride' may be used uninitialized in
this function
These are actually false positives but no warnings is good (bug #590990).
The theme thumbnail rendering code gets the rendering of folder icons somewhat
wrong, ie it frequently shows a gnome-fs-directory icon from gnome even if the
actual theme has a folder icon. Improve things by using modern GtkIconTheme
api in a better way.
+
+ * Get rid of a number of unnecessary gnome.h includes
+
+ * capplets/keybindings/gnome-keybinding-properties.c: Use
+ gtk_init() instead of gnome_program_init().
+
+ * A couple of formatting fixes
+
svn path=/trunk/; revision=9098
2008-04-20 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (message_from_child): unref the thumbnail image
after passing it to the callback. Callers will have to ref it if they
want to keep it until after the callback has returned
2008-04-20 Jens Granseuer <jensgr@gmx.net>
* appearance-style.c: (update_thumbnail_in_treeview):
* appearance-themes.c: (theme_thumbnail_update),
(theme_thumbnail_generate): adapt to modified refcounting in the
thumbnailer; thumbnails don't need to be unref'ed unless we explicitly
retain a reference
svn path=/trunk/; revision=8661
2008-04-13 Jens Granseuer <jensgr@gmx.net>
Disable theme thumbnailing on MacOS. Some CoreFoundation functionality
can apparently no longer be used from forked processes (see bug
#525058). Unfortunately, it is used by freetype/pango/cairo/gtk, and
as such by our forked thumbnailer. This change means no thumbnails on
MacOS, but I suppose that's better than crashing. Reworking the
thumbnailer to work without forking is going to be a major effort.
* theme-thumbnail.c: (theme_thumbnail_factory_init): only enable the
asynchronous thumbnailer if not on MacOS
svn path=/trunk/; revision=8649
2008-03-11 Jens Granseuer <jensgr@gmx.net>
Encountering a theme that could not be thumbnailed (e.g. because the
metacity theme for a metatheme isn't installed) would make the
thumbnailer crash. Since it's not restarted by the appearance capplet
this would result in all themes encountered after the broken one not
to be thumbnailed either. This change fixes up error handling in the
thumbnailer so that the broken theme is simply skipped and processing
can continue with the next one. (bug #521009)
* theme-thumbnail.c: (create_meta_theme_pixbuf),
(create_metacity_theme_pixbuf), (message_from_capplet),
(message_from_child), (read_pixbuf),
(generate_theme_thumbnail_async), (theme_thumbnail_factory_init):
properly handle failed thumbnailing attempts
svn path=/trunk/; revision=8576
2008-02-25 Thomas Wood <thos@gnome.org>
* theme-thumbnail.c: (message_from_child): Return FALSE on error or EOF,
which should also fix bug 516413, in addition to checking for G_IO_HUP.
svn path=/trunk/; revision=8523
2008-02-25 Thomas Wood <thos@gnome.org>
* theme-thumbnail.c:
(create_meta_theme_pixbuf), (create_metacity_theme_pixbuf):
Use the new meta_preview_get_clip_region() function in Metacity to fix
bug 460018 (Rounded window borders don't get rendered correctly).
(message_from_child): Do not attempt to read from the pipe when
the connection has been broken. Fixes bug 516413 (Theme thumbnailer
causes UI to stop drawing when encountering an error).
svn path=/trunk/; revision=8521
2007-09-29 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (generate_gtk_theme_thumbnail),
(generate_theme_thumbnail_async),
(generate_gtk_theme_thumbnail_async): move the code for setting the
color scheme for gtk thumbnails to the gtk-specific function. This
means we will probably extract it twice for most thumbnails, but it
makes for much cleaner code. Also add the scheme bit to the synchronous
version.
svn path=/trunk/; revision=8144
2007-09-25 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: patch up an outdated comment about how the
thumbnailer protocol works
svn path=/trunk/; revision=8137
2007-09-25 Jens Granseuer <jensgr@gmx.net>
Prevent lots of thumbs from being created with the color scheme of the
currently active theme (see comment #15 in bug 460023). Maybe it also
helps with some of the other color-related issues.
* theme-thumbnail.c: (create_gtk_theme_pixbuf),
(generate_theme_thumbnail_async): when creating GTK theme thumbnails,
explicitly pass the theme's color scheme to override the xsetting
svn path=/trunk/; revision=8135
2007-08-08 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (create_meta_theme_pixbuf):
Create the icon theme representative before the GTK stock button. Since
we explicitly set the icon theme for the first, this ensures both are
drawn with the same icon theme. Before it was possible when changing
icon themes (especially on slower machines) that the GtkSettings were
not yet updated and the stock button still used the old theme.
svn path=/trunk/; revision=7981
2007-06-25 Denis Washington <denisw@svn.gnome.org>
* theme-thumbnail.[ch]:
Generate all types of thumbnails in a seperate process, not just those for
metathemes.
svn path=/trunk/; revision=7774
2007-06-09 Denis Washington <denisw@svn.gnome.org>
* theme-thumbnail.c: (generate_gtk_theme_thumbnail):
Fix the appearance capplet windows not reacting to gtk+ theme changes.
svn path=/trunk/; revision=7707
2007-06-06 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (message_from_child),
(generate_theme_thumbnail), (generate_theme_thumbnail_async),
(theme_thumbnail_factory_init):
* theme-thumbnail.h: remove caching from the thumbnailer since
all of the current users work around it anyway, and resources
aren't managed properly
svn path=/trunk/; revision=7699
2007-06-06 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (generate_theme_thumbnail_async):
* theme-thumbnail.h: add a parameter to circumvent the internal
thumbnail cache to the asynchronous generator
svn path=/trunk/; revision=7695
2007-05-28 Jens Granseuer <jensgr@gmx.net>
* theme-thumbnail.c: (generate_theme_thumbnail): drop unnecessary strlen
(generate_theme_thumbnail_async): save some casts
(generate_gtk_theme_thumbnail): don't leak the theme name
svn path=/trunk/; revision=7671
* theme-thumbnail.[ch]:
Add functions to generate thumbnails for specific types of themes, for
instance a metacity theme thumbnail.
svn path=/trunk/; revision=7653
2007-03-04 Thomas Wood <thos@gnome.org>
* gnome-theme-info.c: (gnome_theme_read_meta_theme): Don't try and open null
filenames
* theme-thumbnail.c: (message_from_capplet): Reset the gtk_color_scheme after
a thumbnail has been generated.
svn path=/trunk/; revision=7359
2007-02-28 Thomas Wood <thos@gnome.org>
* gnome-theme-apply.c: (gnome_meta_theme_set): Set the gtk-color-scheme even
if it is blank.
* theme-thumbnail.c: (create_image), (handle_bytes),
(generate_theme_thumbnail), (generate_theme_thumbnail_async),
(theme_thumbnail_factory_init): Set the gtk-color-scheme when creating the
thumbnail.
svn path=/trunk/; revision=7344
2007-01-14 Thomas Wood <thos@gnome.org>
* theme-thumbnail.c: (generate_theme_thumbnail): Remove
g_return_if_fail_warning as this doesn't need to be a critical
warning. Fixes bug 353620.
svn path=/trunk/; revision=7140
2006-09-30 Thomas Wood <thos@gnome.org>
* theme-thumbnail.c: (create_image): Set the gtk icon theme setting.
Fixes bug 355268 - "Open" icon on button preview not working
2005-08-14 Rodney Dawes <dobey@novell.com>
* theme-thumbnail.c (create_image): Get the Example icon that is
specified by the icon theme, if it exists, and then fall back through
a better list of icons to use. Gnome uses gnome-fs-directory currently
for folders, so we should prefer that over folder, but the icon naming
spec lists x-directory-normal for standard folders, so we should prefer
that above other folders
This fixes issues with the wrong icon being drawn in the thumbnail, due
to the icon theme providing the gnome folder icon, but inheriting from
another theme which provides a different icon named "folder" for KDE or
other desktops
2005-02-08 Sebastien Bacher <seb128@debian.org>
* gnome-theme-installer.c: (file_theme_type), (transfer_done_cb),
(install_dialog_response), (gnome_theme_installer_run):
patch by Kjartan Maraas <kmaraas@gnome.org>, remove a load of leaks
and make sure newly installed themes show up in the relevant lists
without having to close/open the dialog again (Closes: #166267).
2005-02-08 Sebastien Bacher <seb128@debian.org>
* gnome-keyboard-properties-xkb.c: (setup_xkb_tabs):
* gnome-keyboard-properties-xkblt.c: (def_group_in_gconf_changed):
patch by Kjartan Maraas <kmaraas@gnome.org>, some code cleanups
(Closes: #166267).
2005-02-08 Sebastien Bacher <seb128@debian.org>
* eggcellrendererkeys.c: (egg_cell_renderer_keys_start_editing):
patch by Kjartan Maraas <kmaraas@gnome.org>, some code cleanups
(Closes: #166267).
2005-02-08 Sebastien Bacher <seb128@debian.org>
* main.c: (wrap_in_label):
patch by Kjartan Maraas <kmaraas@gnome.org>, some code cleanups
(Closes: #166267).
2005-02-08 Sebastien Bacher <seb128@debian.org>
* gnome-theme-info.c: (update_common_theme_dir_index):
* theme-thumbnail.c: (create_image):
patch by Kjartan Maraas <kmaraas@gnome.org>, move to use GtkIconTheme
and remove a load of leaks in the theme manager code (Closes: #166267).
2003-07-02 Mark McLoughlin <mark@skynet.ie>
Handle crashes of the thumbnailer child process a
little more gracefully.
* theme-thumbnail.c:
(generate_theme_thumbnail): if we get an EOF from
the child close the pipe, return NULL and return
NULL from any subsequent calls.
(generate_theme_thumbnail_async): return NULL if
the pipe has been closed.
(theme_thumbnail_factory_init): set pipe descriptos
to zero after closing them.
