Commit graph

52 commits

Author SHA1 Message Date
Robert Ancell
93b14a4339 panel: Move shared GCancellable code into panel class
Make the panel class provide a cancellable that will be cancelled when the panel
is destroyed. Panel implementations can use this and not have to mangage the
cancellable themselves. Consolidate cases where panels had multiple cancellables
that were all being used for this behaviour.
2020-02-03 09:36:24 +13:00
Robert Ancell
af1ffd76e1 bluetooth: Move all UI into the GtkTemplate 2019-09-09 22:03:36 +00:00
Georges Basile Stavracas Neto
75f150d5a2 shell: Add position to cc_shell_embed_widget_in_header()
So we can control where the widget should be added to. The
main window only supports left and right positions.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/528
2019-05-21 12:59:36 -03:00
Robert Ancell
631e83ec0e bluetooth: Use g_auto for variables 2018-11-14 10:11:44 +00:00
Robert Ancell
14f20f3784 bluetooth: Move class_init to end of file
As specified in docs/HACKING.md and removes the need for function prototypes.
2018-11-14 10:11:44 +00:00
Robert Ancell
5c821bad71 bluetooth: Connect signals in swapped form 2018-11-14 10:11:44 +00:00
Robert Ancell
5ff8a88747 bluetooth: Fix indentation error 2018-11-14 10:11:44 +00:00
Robert Ancell
325c3c9446 bluetooth: Align struct members 2018-11-14 10:11:44 +00:00
Robert Ancell
4f97e8cb07 bluetooth: Use widget data types
Replace GtkWidget with the widget data types.
2018-11-14 10:11:44 +00:00
Robert Ancell
281827f70f bluetooth: Rename generic variable name
Rename from 'widget' to 'settings_widget'
2018-11-14 10:11:43 +00:00
Robert Ancell
5b55519db2 bluetooth: Replace GtkStack page names with widgets
This is less likely to be accidentally broken in the future
2018-11-14 10:11:43 +00:00
Robert Ancell
e5ee278393 bluetooth: Make .ui filename match the .c filename 2018-11-14 10:11:43 +00:00
Robert Ancell
256dccb7d6 bluetooth: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-10 04:01:11 +00:00
Adrien Plazas
30e58787b2 bluetooth: Allow the Bluetooth panel to reach narrower sizes 2018-09-24 10:05:36 +02:00
Georges Basile Stavracas Neto
d6535f82f0 bluetooth: Cache the D-Bus proxy 2018-04-06 22:23:38 -03:00
Georges Basile Stavracas Neto
1643674a24 bluetooth: Replace GtkAlignment by halign and valign properties
This removes the last deprecation warning in the Bluetooth panel.
2018-03-16 13:51:25 -03:00
Robert Ancell
88bf8cfc57 bluetooth: Use G_DEFINE_TYPE 2017-09-25 16:04:21 -04:00
Miguel Vaello Martínez
88b6561c8e bluetooth: Center empty states in the panel
For the new or alternative version of Control Center, the Bluetooth
empty state will be vertically alligned to the center for any
app window size. Otherwise when the Bluetooh is powered and available,
the align will be as always.

This changes do not affect to the old version because the windows
size (for the old version) is always the same and small
enought to be in the center in any case.

https://bugzilla.gnome.org/show_bug.cgi?id=784720
2017-07-11 21:02:21 -03:00
Bastien Nocera
afcfa995fc bluetooth: Better debug output
With the output using the name of the D-Bus variables, rather than the
local variable name.
2016-03-10 11:53:45 +01:00
Bastien Nocera
4a009da483 bluetooth: Don't change the switch status when transitioning
When transitioning from an enabled platform rfkill to disabled, the
Bluetooth adapter's power will lag behind. Make sure to not change the
switch's status when we get into this temporary state.

https://bugzilla.gnome.org/show_bug.cgi?id=760168
2016-01-10 15:59:25 +01:00
Bastien Nocera
40117a0ed5 bluetooth: Avoid broken state when enabling Bluetooth
When enabling Bluetooth, and with older versions of the rfkill
gnome-settings-daemon D-Bus service, we could get into a state where the
Bluetooth rfkill was off, but the hciX rfkill associated with the
adapter is blocked.

Avoid showing filler text in that case.

https://bugzilla.gnome.org/show_bug.cgi?id=760168
2016-01-10 15:59:25 +01:00
Bastien Nocera
2fbac9b23b bluetooth: More tweaks to "off mode" pages
Some small changes labels, spacing and icons changes.
2015-07-31 15:08:17 +02:00
Bastien Nocera
15c8f0d012 bluetooth: Better UI when Bluetooth is disabled
We now offere separate "Bluetooth is off" and "Airplane mode is on"
pages. The "Airplane mode is on" offers to turn off airplane mode
altogether.

We also have better explanations for all the other modes, and a filler
Bluetooth logo to make the page seem less empty.

https://bugzilla.gnome.org/show_bug.cgi?id=751483
2015-07-30 20:13:29 +02:00
Bastien Nocera
8d6bdda036 bluetooth: Remove useless FIXME
Who knows what that was for...
2015-07-30 20:13:29 +02:00
Bastien Nocera
28fecc01c4 bluetooth: Updated design
With the majority of the implementation living in gnome-bluetooth.

https://bugzilla.gnome.org/show_bug.cgi?id=719565
2013-12-06 11:59:03 +01:00
Bastien Nocera
de226c703b bluetooth: Remove setup plugins support
It was used by a test plugin we ship ourselves for Geoclue 1.x,
and NetworkManager. Given that NetworkManager doesn't make use
of it anymore, let's remove it.
2013-12-06 11:59:03 +01:00
Rui Matos
37b31bec3b bluetooth: Remove unused toplevel window from .ui file
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:01 +02:00
Rui Matos
be3965a76b bluetooth: Remove dead code
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:01 +02:00
Bastien Nocera
ba4eb42778 bluetooth: Fix crash when exiting during a connection
If a connection is on-going, make sure to cancel it before
when finalizing the panel, or we will be crashing once
we've finished connecting/disconnecting.

https://bugzilla.gnome.org/show_bug.cgi?id=708478
2013-09-22 22:24:54 +02:00
Yosef Or Boczko
888db9b453 bluetooth: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:57:37 +03:00
Gustavo Padovan
c7b02d716a bluetooth: use uuids to set switch_connection sensitiveness
Since the Services information is now gone, we need to rely on the uuids
to get the same behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=700915
2013-06-13 15:16:33 +02:00
Bastien Nocera
2c0de31bb6 Revert "bluetooth: use uuids to set switch_connection sensitiveness"
This reverts commit 6e9a352256 which
was committed by error.
2013-06-11 16:53:32 +02:00
Gustavo Padovan
6e9a352256 bluetooth: use uuids to set switch_connection sensitiveness
Since the Services information is now gone, we need to rely on the uuids
to get the same behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=700915
2013-06-11 16:49:40 +02:00
Emilio Pozuelo Monfort
ac43647ac0 Update adapter interface for BlueZ 5
And move it to a define while at it.

https://bugzilla.gnome.org/show_bug.cgi?id=700915
2013-06-03 15:35:24 +02:00
Cosimo Cecchi
ddf9d29f66 bluetooth: use a GResource for GtkBuilder UI definition
https://bugzilla.gnome.org/show_bug.cgi?id=691132
2013-01-07 10:57:05 +01:00
Bastien Nocera
63af1169b5 bluetooth: Move killswitch to the header 2012-12-17 10:52:49 +01:00
Bastien Nocera
3686cf7eb8 shell: Make all control-center plugins static
This makes loading faster, with less I/O, avoids unnecessary
code duplication (around 1k lines shaved), and ensures that
all the panels link and work appropriately.

By the same token, it will stop external panels from being
created, and loaded.

https://bugzilla.gnome.org/show_bug.cgi?id=690036
2012-12-11 17:07:39 +01:00
Bastien Nocera
2e0ab4ef09 bluetooth: Correct debug output 2012-12-10 08:28:39 +01:00
Bastien Nocera
6b95bb27d8 bluetooth: Remove ObexFTP file browsing from the UI
https://bugzilla.gnome.org/show_bug.cgi?id=685038
2012-12-03 08:54:18 +01:00
Bastien Nocera
c148fb2836 bluetooth: Use spinner when connecting
Rather than having an unusable switch (which wouldn't represent
the real state of the connection), show a spinner until the
connection is finished doing.
2012-11-08 18:52:28 +01:00
Bastien Nocera
77d134c4df bluetooth: Simplify ->finalize 2012-11-08 18:37:48 +01:00
Bastien Nocera
9818f3b256 bluetooth: Fix main switch acting bizarrely
The only time we were looking at the powered state of the adapter
is when the killswitch state was changing. Except that we're fast enough
that bluetoothd didn't have time to power up the adapter, so its
state was unpowered, which we would set the switch to.

The switch was off, the adapter was on.

We fix that problem by tracking the powered state of the adapter
separately.

https://bugzilla.redhat.com/show_bug.cgi?id=841881
2012-11-08 18:37:48 +01:00
Bastien Nocera
f1e20c395d bluetooth: Remove unused variable 2012-11-08 18:37:48 +01:00
Bastien Nocera
876e4d4559 bluetooth: Avoid possible loops when Connection fails
If we switch "Connection" on via the switch, the disabling on failure
will create a loop where it always tries to connect again. Break that
loop.
2012-11-08 18:37:47 +01:00
Bastien Nocera
12a319875a bluetooth: Don't break the custom widgets on connect
We used to destroy and recreate the custom widgets whenever any of
the properties changed. Now we make sure that the custom widgets are
only destroyed and recreated when the device selected is a different one.

This fixes NetworkManager's Bluetooth plugins getting destroyed
because the Connected property changed, as it was trying to connect to
the device.

https://bugzilla.gnome.org/show_bug.cgi?id=681456
2012-09-07 13:32:06 +01:00
Ray Strode
b0e7a5efa8 panels: add register macro
Bastien says he doesn't like the blank class_finalize
functions in every panel and he would like a wrapper
macro to hide them.

This commit does that.
2012-08-21 14:32:33 -04:00
Bastien Nocera
8776700a73 bluetooth: Update for killswitch API change 2012-07-26 17:56:08 +02:00
Florian Müllner
bc18595051 bluetooth: Add get_help_uri() implementation
https://bugzilla.gnome.org/show_bug.cgi?id=675471
2012-05-18 18:48:37 +02:00
Bastien Nocera
e3565989e0 bluetooth: Fix wrong panel name in warning 2012-01-26 19:10:10 +00:00
Bastien Nocera
0f79fbc785 bluetooth: Update for changed BluetoothChooser API 2012-01-18 17:00:25 +00:00