Commit graph

91 commits

Author SHA1 Message Date
Georges Basile Stavracas Neto
8141af469c printers: Port to GTK4
Fortunately for us GtkTreeView still operates pretty
much exactly like in GTK3. Other than that, it's a
dense junction of all that we've done so far to port
other panels.
2021-12-14 22:34:21 -03:00
Eric
1fc8b772a4 printers: Make "Add…" button consistent with user accounts panel
The "Add..." toolbar button on the printers panel is currently hidden until the panel is unlocked.
This commit makes the button visible but insensitive when the panel is locked (becoming sensitive when unlocked),
as suggested in #1213. It also changes the text from "Add..." to "Add Printer..."
and updates the subtitle in the infobar to "Unlock to Add Printers and Change Settings."
These changes make the button's UI consistent with the Accounts panel's "Add User..." toolbar button.

Closes #1213
2021-06-09 13:34:01 +00:00
Robert Ancell
ae1a37b009 printers: Remove use of gtk_widget_show_all
It is removed in GTK 4.
2020-11-26 16:02:57 +00:00
Felipe Borges
57eae62c6e printers: Add whitespace between top right buttons
Fixes #895
Fixes #685
2020-03-29 22:34:17 +00:00
Felipe Borges
875df8d758 printers: Show the CcPermissionInfobar for all views
We were only presenting the permission infobar when there were
already printers added (printer-list view).

We also want users to see the infobar when they don't have any
printers (empty-page).
2020-02-25 17:59:30 +00:00
Felipe Borges
c9eb8ebf41 printers: Use CcPermissionInfobar
This makes the Printers panel consistent with the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/blob/master/users/users.png

See #685, #771 and !671
2020-01-31 14:28:01 +00:00
Sam Hewitt
e91208eeb5 printers: update pixel_size of icons to avoid aliasing 2018-07-10 18:04:32 -04:00
Felipe Borges
c776ab1808 printers: Apply the vertical spacing standard
Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Felipe Borges
6a6f4b71d9 printers: Wrap GtkListBox inside a GtkBox
In order to vertically align the printers panel content by the
same standards as the other panels, we should set the GtkListBox
top and bottom margins to 32px.

This commit wraps GtkListBox inside a GtkBox to handle the Gtk+
issues discussed in Bug 773459 regarding the background of ListBox
margins.

This commit can be cleanly reverted once the issue is fixed in
Gtk+.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Felipe Borges
272bad14a0 printers: The scrolled window should vertically expand
In the new Shell the Printers panel scrolled window doesn't
necessarily fills the whole vertical space available.

https://bugzilla.gnome.org/show_bug.cgi?id=786674
2017-08-23 11:08:02 +02:00
Felipe Borges
6dcf057a53 printers: Scroll view to show newly added Printer
In scenarios with a long list of printers, it might be difficult
to find a newly added printer.

This patch make the view scroll to the allocated position of the
printer entry.

https://bugzilla.gnome.org/show_bug.cgi?id=779506
2017-05-29 17:49:11 +02:00
Felipe Borges
f065f5005f printers: Allow undoing deletion of a printer
Instead of directly applying the deletion of a printer, we should
follow the GNOME in-app notification deletion guidelines.

This patch introduces the in-app notification following the HIG[0]
for the deletion of a printer. It allows to "undo" the deletion.

The default behavior for these notification is to dismiss a previous
notification. In doing so, when deleting multiple printers, the
"Undo" button only restores the last deleted one. We don't do batch/
bulk removal in the printers panel.

[0] https://developer.gnome.org/hig/stable/in-app-notifications.html.en

https://bugzilla.gnome.org/show_bug.cgi?id=693187
2017-05-26 13:16:39 +02:00
Felipe Borges
34aedbe992 printers: Add search capabilities to the panel
Due to the recent changes towards the new design, it became slightly
harder to find a printer given a long list of entries.

This patch introduces search capabilities to the panel, filtering
based on the printer name.

https://bugzilla.gnome.org/show_bug.cgi?id=779656
2017-05-09 15:52:12 +02:00
Felipe Borges
e26756d7e3 printers: Make printers-list a GtkListBox
By making the printers list a GtkListBox instead of a GtkBox, we
can use listbox's capabilities for sorting and filter.

https://bugzilla.gnome.org/show_bug.cgi?id=779656
2017-05-09 15:47:04 +02:00
Jeremy Bicha
479f04904c printers: Use ellipsis for "Add a Printer"
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-14 19:09:33 +01:00
Felipe Borges
ae17ba1f47 printers: Set min-content-height on the scrolled window
Set a minimum content height of 490px for the panel when the
allocated height is smaller than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:45:35 +01:00
Felipe Borges
378e04125d printers: Make the printers panel a single column
This patch purges all the former TreeView machinery and makes the
Printers panel have the printers listed in a scrolled window, as
designed at https://wiki.gnome.org/Design/SystemSettings/Printers

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:45:35 +01:00
Felipe Borges
37e37961e5 printers: introduce PpPrinterEntry widget
This commit introduces the following regressions:
- no possibility of renaming properties such as printer names,
location, or changing model/driver. This issue is going to be
solved nextly by the introduction of the PpDetailsDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:27:49 +01:00
Piotr Drąg
555e230508 Remove no longer necessary contexts from translatable strings
These strings changed recently and now their contexts don't disambiguate
anything.
2017-02-12 16:02:22 +01:00
Felipe Borges
cc738c8223 printers: Update "Add Printer" button to just "Add"
The mockups at https://wiki.gnome.org/Design/SystemSettings/Printers
show just the word "Add" for the button which opens the "Add Printer"
dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=778268
2017-02-07 12:16:18 +01:00
Piotr Drąg
9e14dd2c6f Add context to "Add Printer" to disambiguate the string
Many languages may need to translate a button differently than
a window title.
2017-01-18 15:42:41 +01:00
Piotr Drąg
1a38c240d1 printers: use Unicode in translatable strings
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772199
2016-10-03 15:21:07 +02:00
Felipe Borges
cf99cebfb9 printers: Move "Add Printer" button to header bar
This patch introduces a change to the Lock/Unlock logic. From now
on, unlocking the panel causes the "Lock" button to turn into the
"Add Printer" button.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2016-09-20 15:23:20 +02:00
Felipe Borges
93f71e5260 printers: present spinner while populating the panel
https://bugzilla.gnome.org/show_bug.cgi?id=767600
2016-06-15 15:58:27 +02:00
Felipe Borges
8c71b0bc8b printers: enforce the empty-state patterns
https://bugzilla.gnome.org/show_bug.cgi?id=767600
2016-06-15 15:46:19 +02:00
Felipe Borges
11dd608f94 printers: use panel-wide page for empty-state
Instead of having the empty-state and no-cups-page states displayed
as tabs of the printer notebook, go for panel-wide pages, which
better highlight these states and doesn't unnecessarily shows the
empty printers list.

This change is also part of the effort of the panel redesign,
according to the mockups at
https://wiki.gnome.org/Design/SystemSettings/Printers

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2016-06-15 15:46:19 +02:00
Felipe Borges
e9413b4b6a printers: polish empty state
If you don't have any printers, the panel used to look rather bare.
There was also a "No printers available" label, which was confusing,
and the insensitive list might be hard to understand.

https://bugzilla.gnome.org/show_bug.cgi?id=690351
2015-10-22 16:40:19 +02:00
Martin Hatina
000dae6e98 printers: Replace deprecated widgets
Replace some deprecated widgets.

https://bugzilla.gnome.org/show_bug.cgi?id=723378
2015-07-26 23:49:39 +02:00
Marek Kasik
da15e2ebcf printers: Remove border around model name
The border was not there in 3.10 and it is not
intended to be there in 3.14.

https://bugzilla.gnome.org/show_bug.cgi?id=740811
2014-11-27 15:24:26 +01:00
Marek Kasik
49b71fa843 printers: Don't use properties of deprecated widgets
Replace xalign and yalign properties by halign and
valign wherever needed.

https://bugzilla.gnome.org/show_bug.cgi?id=739737
2014-11-25 12:01:17 +01:00
Marek Kasik
8c67e72821 printers: Fix padding of a progress text
Set padding of the text "Setting new driver" at runtime so that
it is aligned with other fields properly.

https://bugzilla.gnome.org/show_bug.cgi?id=739737
2014-11-25 12:01:17 +01:00
Marek Kasik
38958903ee printers: Add GtkLabel with printer model name
Place a custom GtkLabel with name of printer model
into "printer-model-button". This is needed for us to be
able to align the text and keep the button filling all available
horizontal space.

https://bugzilla.gnome.org/show_bug.cgi?id=739737
2014-11-25 12:01:17 +01:00
Marek Kasik
d32408c051 printers: Ellipsize long names and locations
Ellipsize long names of printers and long location strings
in the printers panel.

https://bugzilla.gnome.org/show_bug.cgi?id=661667
2014-04-30 11:32:42 +02:00
Marek Kasik
ad9c640f5c printers: Use "Default printer" instead of "Default"
Use "Default printer" in the main panel to clarify
what the check button represents.

https://bugzilla.gnome.org/show_bug.cgi?id=706896
2014-02-12 16:18:40 +01:00
Yosef Or Boczko
84c792c7f4 printers: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:28:28 +02:00
Allan Day
95eb8868ac printers: Reduce vertical and horizontal padding
There was too much space between rows and columns. Reduce the
padding a bit.

https://bugzilla.gnome.org/show_bug.cgi?id=690375
2013-01-09 14:17:32 +01:00
Matthias Clasen
3d27d8caaf shell: Fittsify panels
Make it possible for panels to go all the way to the edge of the
shell. This is particularly important for panels that scroll, such
as the new power panel. All other panels are changed to compensate
for the loss of external padding.

https://bugzilla.gnome.org/show_bug.cgi?id=691229
2013-01-07 10:51:29 +01:00
Jeremy Bicha
190052ff74 printers: Use the proper Unicode ellipsis (…) instead of three dots
https://bugzilla.gnome.org/show_bug.cgi?id=689497
2012-12-03 09:12:47 -05:00
Jeremy Bicha
7e7a690d12 printers: Add more a11y relations, change 'Show' btn to 'Show Jobs'
https://bugzilla.gnome.org/show_bug.cgi?id=688960
2012-11-26 17:49:17 -05:00
Marek Kasik
71db59d9a2 printers: Remove obsoleted notebook page
This commit removes the notebook page which consists
old printer options. It was replaced by separate dialog.
2012-08-09 14:23:49 +02:00
Marek Kasik
c6d8b9c825 printers: Place jobs to separate dialog
This commit places list of jobs to separate dialog. The dialog
is updated through calling of pp_jobs_dialog_update()
from "Printers" panel because the panel is already subscribed
to cups notifications.
2012-08-07 14:09:33 +02:00
Marek Kasik
dd7479caea printers: Allow users to change printer's PPD file
This commit adds popup window which when activated allows
user to select PPD from local database of installed PPDs,
select directly PPD from filesystem or select one from 3
recommended PPDs (#678637).
The popup is activated by clicking on model field (the panel
has to be unlocked). It starts to search for the best PPDs
available immediately after its popup.
All operations are asynchronous.
2012-07-16 13:53:40 +02:00
Bastien Nocera
152398ff1f printers: Add label to toolbar buttons 2011-10-25 17:43:48 +01:00
Bastien Nocera
9aaef2614c printers: Force icons toolbar style
https://bugzilla.gnome.org/show_bug.cgi?id=651599
2011-06-21 15:47:16 +01:00
Marek Kasik
8f4895559a Printers: Allow editing of printer name and location
Use CcEditableEntry for editing name and location of local printers
(#649511).
2011-05-27 13:38:15 +02:00
Matthias Clasen
c513d2b3aa Printers: Improve a11y of inline toolbars
Mark the labels of the add/remove buttons as translatable. While
these are not shown in the ui, orca reads them.
2011-05-15 23:53:11 -04:00
Matthias Clasen
f9c8d63585 Fix a11y/keynav issues in the printer panel
This adds some missing mnemonics.
2011-05-15 21:09:11 -04:00
Marek Kasik
7e976baf86 printers: Show computer-fail icon when can not connect to CUPS
Show "computer-fail" under the text "Sorry! The system printing
service doesn't seem to be available." if we can not connect to
CUPS server (#641421).
2011-03-21 15:50:12 +01:00
William Jon McCann
f9bcc485e3 printer: use inline-toolbar style on all listview toolbars 2011-03-20 00:04:38 -04:00
William Jon McCann
e2cb3282e2 printers: fix alignment in secondary notebook pages 2011-03-20 00:03:18 -04:00