Commit graph

18 commits

Author SHA1 Message Date
Jakub Steiner
13376ecb8b Add individual app icons 2022-01-31 14:08:22 +00:00
Georges Basile Stavracas Neto
4300a4a290 panels: Use new CcPanel helpers for title widgets
This should significantly simplify these panels, by not forcing
them to override GObject.constructed all the time. Most panels
were quite straightfoward.
2022-01-20 02:23:42 +00:00
Georges Basile Stavracas Neto
0ab20af9ba panels: Switch to CcPanel content
Start porting panels to the new panel format. This commit
temporarily makes panels have two titlebar, which will be
fixed soon.
2022-01-20 02:23:42 +00:00
Mohammed Sadiq
14181fbbbd wwan: Port to use AdwPreferencesPage
And adapt to changes.

This helps avoid using widgets like AdwClamp as it will be
handled by AdwPreferencesPage and AdwPreferencesGroup.
2022-01-10 12:41:56 +00:00
Jan Beich
37b29c32cb meson: drop unused argument for i18n.merge_file()
Ignored in Meson < 0.60.0, deprecated since 0.60.1 and fatal since 0.61.0.

panels/applications/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/background/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/camera/meson.build:10:5: ERROR: Function does not take positional arguments.
[...]
2022-01-07 17:22:43 +00:00
Christopher Davis
e637f47e78 cc-list-row: Subclass AdwActionRow
AdwActionRow handles many of the properties we use
CcListRow for. We can re-use it instead of re-creating it.

CcListRow is now an AdwActionRow with three suffixes.
The `activatable-widget` is set when the switch is visible.

Since our `icon-name` property was only used for the arrow
icon, it has been replaced with a `show-arrow` property.

The `bold` property has been removed - it was only used in
one place, and it's not a pattern used in other apps.

I decided to go this route because replacing all the
instances of CcListRow with AdwActionRow directly would
end up being more code.
2022-01-06 08:56:12 -08:00
Mohammed Sadiq
81a5390c30 wwan: Use button icon-name property to set button image
This simplifies setting button image and improves the way they
are presented as the css will then be handled better this way.
2022-01-06 15:04:28 +00:00
Mohammed Sadiq
fbb2f98c44 wwan: Port to GTK4 2022-01-06 15:04:28 +00:00
Christopher Davis
981a8cea7b panels: Use .boxed-list instead of .content
The `.content` style class is deprecated in favor
of the `.boxed-list` style class, which is named
after the design pattern it's used for.
2021-12-16 12:52:44 -08:00
grumpey
f8e0558ebd Use proper unicode ellipses in strings
Fixes: #1458
2021-09-28 09:15:00 -04:00
Jeremy Bicha
496c719d7b wwan: Remove duplicate line from .desktop 2021-09-26 12:50:37 +00:00
Mohammed Sadiq
d762d93f38 wwan: Fix enabling data after APN is set
Since we don't use gtk_dialog_run(), the dialog was shown in a non-blocking
way.  So instead of handling the APN details immidiately after the APN
dialog is shown, handle them in a signal callback.

Fixes #1465
2021-09-17 21:18:55 +00:00
Mohammed Sadiq
191a179612 wwan-device: Fix network mode strings to be translatable
creating the mode strings by simply concating them
blindly can result in hard to translate strings.

Fixes #1446
2021-09-05 22:01:52 +00:00
Mohammed Sadiq
d975f56e66 wwan: Avoid translation of some strings
Many strings are not shown in the UI. Let's not overwhelm translators
2021-08-24 15:40:49 +00:00
Mohammed Sadiq
b3f4f9cafd wwan: Fix a typo
Fixes dc840f0aec (note_1249116)
2021-08-14 12:34:04 +00:00
Sebastian Krzyszkowiak
6e5169ad4d wwan: Fix signal strength display when extended signal retrieval is disabled
MMModemSignal interface is used to retrieve extended signal information that
requires periodic polling. Therefore, it needs to be manually enabled in order
to use. There if a fallback to use mm_modem_get_signal_quality when MMModemSignal
interface is unavailable, but it didn't check whether it's actually enabled,
leaving the UI with empty label.
2021-08-13 19:25:41 +00:00
Kyle Rankin
585fe8c94a Lower WWAN DNS Priority
The current DNS priority settings for WWAN were set far too low. Most
connections (including WiFi) do not set DNS priority (set to 0) and per
https://developer.gnome.org/NetworkManager/stable/nm-settings.html :

"A lower value is better (higher priority). Zero selects a globally
configured default value. If the latter is missing or zero too, it
defaults to 50 for VPNs and 100 for other connections."

By setting both the "low" and "high" settings to 15 and 20 respectively,
the WWAN DNS servers were always appearing above WiFi, even though WiFi
had routing priority. This caused latency and other problems when the
wwan connection was slow because the system would query those DNS
servers before WiFi ones. Beyond that, it would even cause WWAN to
override VPN DNS settings which isn't what we want.

This change puts the "low priority" setting above the default 100 that
connections get when they don't otherwise set a priority, and the "high
priority" slightly below 100. I did this instead of setting the values
to 0 because I noticed that NM doesn't seem to be aware it should
prioritize WiFi in that case so WWAN DNS servers were still sometimes
taking precedence.
2021-08-13 19:25:41 +00:00
Mohammed Sadiq
dc840f0aec wwan: Add new panel for modem management
The panel supports 2G/3G/4G GSM/LTE modems. CDMA2000 Modems are not supported.
If a supported modem is present, the panel will be shown and the modem will be
handled, else, network-panel shall manage the modem as it did in the past.

If more than one modem with data enabled is present, the user is allowed to set
priority of one SIM over the other (the priority is for SIM, not modem).

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/issues/132
2021-08-13 19:25:41 +00:00