Commit graph

7429 commits

Author SHA1 Message Date
Automeris naranja
13e4e0c242 general: Set a minimum size for various dialogs
This change prevents some dialogs from being shrunk
to a really small size by setting a minimum size for them.
2023-05-04 09:54:07 +00:00
Automeris naranja
fe36282b26 network: AdwStatusPage consistency tweaks
Both Wi-Fi and Network panels shows a status page when Network Manager isn't running.
However, they don't use the same writing style:

- https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/gnome-44/panels/network/cc-wifi-panel.ui#L221
- https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/gnome-44/panels/network/cc-network-panel.c#L672

This change makes both status pages to use the same writing style.
2023-05-03 11:25:24 +00:00
Nelson Benítez León
6fb6ba1dc9 meson: improve comment and fix deprecated functions
- Clarify that 'mm-glib' dep is for ModemManager (not Network
   Manager which is below). The comment also helps people
   which may confuse it with glibmm library.

 - Fix following Meson warning about two deprecated functions:
   WARNING: Deprecated features used:
   * 0.56.0: {'dependency.get_pkgconfig_variable', 'meson.source_root'}
2023-05-02 11:33:31 +00:00
Ray Strode
b1850b5c8a background: Clear out dconf if user picks defaults
If a user chooses the default background in control-center, then
they still end up with a change in dconf. This change means that
on upgrades, they'll keep the old distro background configured.

That's probably unexpected and may lead them to believe the upgrade
didn't work.

This commit checks if the user goes back to the distro defaults and
clears out dconf in that case, so that when the disto defaults change
they get the new defaults.
2023-05-02 11:32:49 +00:00
Felipe Borges
15145bd20e universal-access: Make Hearing page string translatable
Fixes #2457
2023-04-25 07:00:06 +00:00
Automeris naranja
1a0bf81cad format-chooser: Drop ellipsis from placeholder text of search entry
None of the placeholders suggested by Allan Day have ellipsis, so
this change drops the ellipsis from the placeholder text of the search entry
from format-chooser, thus keeping consistency.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1526#note_1609984
2023-04-21 12:40:42 +00:00
sunflowerskater
c95dcf2a9a general: Add placeholder text to various search entries
Acc. HIG, "text fields should have placeholder text or a label".

https://developer.gnome.org/hig/patterns/controls/text-fields.html

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2190
2023-04-21 12:40:42 +00:00
Felipe Borges
58a0d8fd32 network: Add quotes to network name in Forget Connection dialog
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1765#note_1726456
2023-04-20 17:30:55 +02:00
Felipe Borges
e0dc75bcfc mouse: Hide entire "Touchpad" row when touchpad cannot be disabled
The touchpad row has a switch suffix that allows enabling/disabling
touchpad.

To prevent users from being left with no pointer device, we were
hiding the suffix switch of the touchpad row, making the row look
weird with a label and no action.

Let's hide the entire row instead, as suggested by designers in
comment https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1649#note_1643002

Fixes #1649
2023-04-20 14:09:04 +00:00
Felipe Borges
7e12d653ba common: Don't set the CcHostnameEntry widget sensitivity twice 2023-04-20 14:08:29 +00:00
Felipe Borges
61ba210c99 user-accounts: Remove autologin row tooltip when unlocked
Fixes #2451
2023-04-20 09:24:48 +00:00
Felipe Borges
e3965a6586 wifi: Include network name in the Forget dialog
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1701#note_1719089
2023-04-20 09:24:21 +00:00
Chris Mayo
bd6c61ab06 wacom: Fix WacomPage crash due to unknown type in UI description
Error building template class 'CcWacomPage' for an instance of type 'CcWacomPage': .:0:0 Invalid object type 'CcListRow'
2023-04-17 12:14:58 +00:00
Chris Mayo
0d1ae3d4f4 datetime: Fix Time Format ComboRow
Failed to set property AdwEnumListModel.enum-type to GDesktopClockFormat: Unsupported GType 'GDesktopClockFormat' for value of type 'GType'

meson.build code adapted from background/meson.build.
2023-04-17 12:14:58 +00:00
Chris Mayo
92c4b6a706 Fix panel crashes due to unknown types in UI descriptions
Error building template class 'CcSearchPanel' for an instance of type 'CcSearchPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcDisplayPanel' for an instance of type 'CcDisplayPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcMousePanel' for an instance of type 'CcMousePanel': .:0:0 Invalid object type 'CcIllustratedRow'

Error building template class 'CcKeyboardPanel' for an instance of type 'CcKeyboardPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcRegionPanel' for an instance of type 'CcRegionPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcUaPanel' for an instance of type 'CcUaPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcUserPanel' for an instance of type 'CcUserPanel': .:0:0 Invalid object type 'CcAvatarChooser'
Error building template class 'CcUserPanel' for an instance of type 'CcUserPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcDateTimePanel' for an instance of type 'CcDateTimePanel': .:0:0 Invalid object type 'CcTzDialog'
cc_tz_dialog_get_selected_location: assertion 'CC_IS_TZ_DIALOG (self)' failed
dumped core
Error building template class 'CcDateTimePanel' for an instance of type 'CcDateTimePanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcInfoOverviewPanel' for an instance of type 'CcInfoOverviewPanel': .:0:0 Invalid object type 'CcHostnameEntry'
2023-04-17 12:14:58 +00:00
Automeris naranja
9b940c27ca network: Use the "labelled-by" property to avoid repeating strings unnecessarily 2023-04-12 18:35:20 -03:00
Automeris naranja
fe5257bc9e general: Remove a11y labels when they aren't needed
A11y labels aren't needed when using the "activatable-widget"
property, because the relation is set automatically:

https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/adw-action-row.c#L661
2023-04-12 18:34:20 -03:00
Automeris naranja
fe435b9e93 general: Use the "activatable-widget" property in several rows 2023-04-12 18:27:37 -03:00
Gotam Gorabh
8cb77b4d3a sharing:removed global master switch
These changes remove the global master switch from
sharing panel and set main_list_box active.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2415
2023-04-12 13:47:31 +00:00
Jonathan Kang
14b3652289 network/connection-editor: fix crash when removing a connection
This was caused by commit 6f1567f23.
2023-04-12 16:01:51 +08:00
Christopher Davis
74e6964fd1 region: Use AdwBanner instead of GtkInfoBar
AdwBanner is a new adaptive widget that should be used
in place of GtkInfoBar. It provides an API close
to how we use InfoBars in GNOME, and fits better at smaller
window sizes.

This commit swaps out the GtkInfoBar used in the Region panel
for an AdwBanner.
2023-04-11 12:23:16 +00:00
Christopher Davis
d25c0e345d general: Use AdwBanner in CcPermissionInfobar
AdwBanner is a new adaptive widget that replaces GtkInfoBar.
AdwBanner adapts better to mobile sizes and has an API
that fits with how we use infobars.

This commit changes CcPermissionInfobar to use an AdwBanner
internally instead of a GtkInfoBar. It also re-implements
part of GtkLockButton, as AdwBanner does not support adding
arbitrary widgets.
2023-04-11 12:23:16 +00:00
Timotej Šulík
4702757b93 display: Fix display enabled toggle visibility 2023-04-11 12:16:54 +00:00
Gotam Gorabh
ad063dfa55 wi-fi:Updated Forget Connection dialog of saved networks with AdwMessageDialog
This changes update the Forget Connection dialog of saved networks
using AdwMessageDialog instead of GtkMessageDialog. And set Cancel
as a default responce instead of Forget to overcome accidental forget.
2023-04-11 11:56:05 +00:00
iampkumar02
27d5e7dd26 wifi: Center panel title when subtitle isn't visible
We used to have a custom title widget containing a label for the
title and another for the subtitle (status). When the subtitle label
wasn't visible, the title label wouldn't get centered vertically in
the headerbar.

By porting the custom title widget to AdwWindowTitle we get the title
centered for free.

Fixes #1891
2023-04-11 13:49:09 +02:00
Cyber Phantom
4b450409c5 wifi: Add a confirmation dialog when forgetting a connection
Destructive actions are supposed to have a dialog asking the user for confirmation.

This commit adds the confirmation dialog when user tries to forget a wifi network.

Fixes #2371
2023-04-11 11:28:26 +00:00
Sayan Bhattacharjee
0524a6eee6 info-overview: Show each GPU in it's own line
When having multiple GPUs, each GPUs are now seperated by a newline
instead of the previously used seperator: " / ".
This particular fix works ONLY for systems that use switcheroo-control.

Also, this commit allows the 'secondary_label' of 'CcListRow' to have
'lines' set to '4' and 'wrap' to 'True', along with 'hexpand'
and 'halign' set to 'True' to accommodate long strings on all labels
which previously suffered from a issue of getting truncated if
the strings are too long.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2125
2023-04-11 11:20:28 +00:00
Felipe Borges
ff4394da40 Revert "cc-wifi-connection-list: Don't show empty listbox"
This causes the "Saved Networks" list to never show rows.

This reverts commit ba13ca1f4a.
2023-04-07 13:37:23 +00:00
Emad Saadat
ce9c7c289a
display: Make nightlight widgets clamped to same size as other panels
by using an AdwPreferencesPage instead of a plain GtkBox. And also
move disabled infobar out of night_light_settings.
2023-04-06 00:38:32 -07:00
Jonas Ådahl
e561f32d9c display/night-light: Don't leak config manager proxy 2023-04-04 13:39:36 +00:00
Jonas Ådahl
80af5137c1 display/night-light: Disconnect config manager changed handler
Use g_signal_connect_object() to automatically disconnect the signal
handle when the listener object gets destroyed.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2333
2023-04-04 13:39:36 +00:00
velsinki
e61b270fb7 sharing: Fix network row visible name bug
In `cc_sharing_networks_new_row`, the `network_name` is not being set to
the new row, but to `self->current_row`. This is incorrect behavior,
as it leaves the new row without any title, and overwrites the title of
the current row incorrectly to the last network entry in the enabled
networks list. This fix correctly sets the name to the new row instead.

This problem is at least discussed in #2318 (point 3) and causes some
confusion in #2299 as well.
2023-04-03 08:46:36 +00:00
Automeris naranja
8f8b2a7ea8 keyboard-shortcut-dialog: Add ellipsis to the "Add Shortcut" button label
Acc. HIG, "use an ellipsis (…) at the end of a label
if further input or confirmation is required from the user".

https://developer.gnome.org/hig/guidelines/writing-style.html?highlight=ellipsis
2023-03-31 10:36:00 +00:00
Automeris naranja
1722002728 keyboards: Add "Character" keyword 2023-03-31 10:33:57 +00:00
Automeris naranja
b3e4a40630 keyboards: Add "Compose" keyword
It isn't possible to open the Keyboards panel by searching for "Compose".
Compose key is an important feature, so this change adds a "Compose" keyword to improve the discoverability of this setting.
2023-03-31 10:33:57 +00:00
Robert Ancell
dd06bf7c11 datetime: Fix NTP switch getting out of sync.
The state needs to be set to the state that was requested before the D-Bus call.
The existing code used the state received from D-Bus, which will be the previous state.
2023-03-30 09:19:34 +13:00
Robert Ancell
00e303998e datetime: Use g_object_bind_property to show NTP state 2023-03-30 09:17:21 +13:00
Robert Ancell
a3d99c78f6 datetime: Fix widget names and types 2023-03-29 11:04:24 +00:00
Maksym Hazevych
9b155f6c5c user-accounts: Set language-chooser to hide on close 2023-03-29 14:26:55 +13:00
Maksym Hazevych
08c2e69851 Resolving suggestions 2023-03-29 14:26:55 +13:00
Maksym Hazevych
81d7a8a85e Use gtk_window_present and gtk_window_close 2023-03-29 14:26:55 +13:00
Maksym Hazevych
e00f773b2f Remove unnecessary visibility change 2023-03-29 14:26:55 +13:00
Maksym Hazevych
5b988a6943 Replace all occurrences of 'gtk_widget_hide'
Replace all occurrences of 'gtk_widget_hide(smth)' with
'gtk_widget_set_visible(smth, FALSE)'.
2023-03-29 14:26:55 +13:00
Maksym Hazevych
d831e5cb48 Replace all occurrences of 'gtk_widget_show'
Replace all occurrences of 'gtk_widget_show(smth)' with
'gtk_widget_set_visible(smth, TRUE)'.
2023-03-29 14:26:55 +13:00
Marco Trevisan (Treviño)
da0f0ec021 illustrated-row, split-row: Add widget name and css class
It's not possible to theme them right now, while it could be useful so
make them more recognizable in the widget tree.
2023-03-28 13:52:12 +00:00
Gunnar Hjalmarsson
33659beb90 region: Fix label of formats for the login screen
When system_region equals system_language, the UI should state the
country of the system_language as the selected login screen formats,
and that is not always "United States".

Fixes: GNOME/gnome-control-center#2418
2023-03-28 13:49:53 +00:00
Emad Saadat
54b97e0781 thunderbolt: Have normal page contents clamped like others
By converting the normal stack page (when thunderbolt
is present) to an AdwPreferencesPage and making all
constituent groups of widgets on the page AdwPreferenceGroups,
we can make the page's content be clamped more similarly to
other pages.
2023-03-28 13:32:50 +00:00
Lukáš Tyrychtr
ded85c5423 panels/wifi: Make the security status and signal strength read by screen readers
Before this MR, the signal level was not available at all, and the security
status only as an a11y description of an image. Now, these pieces of information
are part of the description of the item itself.
2023-03-28 08:18:27 +00:00
Automeris naranja
5ec6538c4d notifications: Change "Apps" header to "App Notifications"
With this change, the header will clearly indicate that the user
will tweak app notification settings, specially when using a screen reader.

This is aligned with the following mockup:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/notifications/notifications.png
2023-03-27 23:25:52 +00:00
Cyber Phantom
524ffefdea cc-wifi-connection-list: Fix incorrect styling
There should be a space before opening parenthesis.
2023-03-24 21:28:45 +05:30