Commit graph

4413 commits

Author SHA1 Message Date
Zeeshan Ali (Khattak)
76e3a53b2d privacy: Fix margins around location dialog widgets
https://bugzilla.gnome.org/show_bug.cgi?id=763259
2016-03-11 13:42:13 +00:00
Michael Catanzaro
3496b0594a printers: Manual ppd selection dialog should have a parent
https://bugzilla.gnome.org/show_bug.cgi?id=755713
2016-03-10 13:54:17 -06:00
Bastien Nocera
d6765b0378 wacom: Use the fully qualified D-Bus name for the OSD
So that we don't end up seeing the fallback button mapping dialogue when
running gsd-test-wacom.
2016-03-10 17:19:30 +01:00
Bastien Nocera
afcfa995fc bluetooth: Better debug output
With the output using the name of the D-Bus variables, rather than the
local variable name.
2016-03-10 11:53:45 +01:00
Felipe Borges
16d32c4e33 printers: renew cups subscriptions asynchronously
https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-03-10 11:04:27 +01:00
Debarshi Ray
cc144a0707 online-accounts: Fix the add account dialog's size with newer GTK+
We should be pairing gtk_window_get_size with
gtk_window_set_default_size to avoid inconsistencies between the size
reading and setting code. eg., in recent GTK+ versions,
gtk_window_get_size and gtk_widget_set_size_request differ in their
interpretation of the CSD chrome.

However, gtk_window_set_default_size didn't work with non-resizable
GtkWindows, until now.

https://bugzilla.gnome.org/show_bug.cgi?id=762548
2016-03-09 13:47:27 +01:00
Debarshi Ray
84b65ddea0 wacom: Use the right API for setting the window width
We should be pairing gtk_window_get_size with
gtk_window_set_default_size to avoid inconsistencies between the size
reading and setting code. eg., in recent GTK+ versions,
gtk_window_get_size and gtk_widget_set_size_request differ in their
interpretation of the CSD chrome.

However, gtk_window_set_default_size didn't work with non-resizable
GtkWindows, until now.

https://bugzilla.gnome.org/show_bug.cgi?id=762548
2016-03-09 13:47:09 +01:00
Debarshi Ray
628f34b259 background: Ensure that the chooser is tall enough with newer GTK+
We should be pairing gtk_window_get_size with
gtk_window_set_default_size to avoid inconsistencies between the size
reading and setting code. eg., in recent GTK+ versions,
gtk_window_get_size and gtk_widget_set_size_request differ in their
interpretation of the CSD chrome.

However, gtk_window_set_default_size didn't work with non-resizable
GtkWindows, until now.

https://bugzilla.gnome.org/show_bug.cgi?id=762548
2016-03-09 13:47:09 +01:00
Felipe Borges
72591c26ba printers: drop border of the "Add" new printer button
https://bugzilla.gnome.org/show_bug.cgi?id=763225
2016-03-07 14:00:30 +01:00
Zeeshan Ali (Khattak)
e7509321a5 privacy: Per-app location access control
Latest gnome-shell (3.19.91) now asks user if they'd want to allow the
application to gain access to their location information when an
application tries to access this information. The user's choice is saved
in xdg-app's permission store and user can no longer can change their
mind about this later on. Hence the need to provide these per-application
controls in control-center.

https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Zeeshan Ali (Khattak)
d77ec8e821 privacy: Indicate location service being used
As per the new mockup, we should indicate when location service is in
use:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/privacy/privacy-3.20.png

https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Zeeshan Ali (Khattak)
5ebf3d8ddf common: Fix codying-style in cc_util_get_smart_date()
https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Zeeshan Ali (Khattak)
3ca5b11d7a privacy: Move "Location Services" into a dialog
We are about to add per-application settings for geolocation access and
they won't really fit well in the main view. This is as per design
mockup:

https://dl.dropboxusercontent.com/u/5031519/privacy/privacy-3.20.png

https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Zeeshan Ali (Khattak)
afebec5d9a common: Move get_smart_date() to common utils
And rename it to cc_util_get_smart_date().

In a following patch, we'll need to use it from privacy panel.

https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Felipe Borges
dc7b78ca42 printers: get printer job attributes async
https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-03-03 16:05:56 +01:00
Felipe Borges
9f9c63fe8d printers: cancel cups subscriptions asynchronously
https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-03-02 17:16:15 +01:00
Sebastien Bacher
ecaafb11bc user-accounts: Don't link directly to GStreamer
The panel uses cheese and not GStreamer directly

https://bugzilla.gnome.org/show_bug.cgi?id=761915
2016-03-02 11:46:40 +01:00
Bastien Nocera
82fce2e0ff universal-access: Fix empty panel with newer GTK+
There's very few chances that the universal-access will fit in the
minimum height of the shell for panels, so just nuke that.

This also fixes the panel taking 1px in height until we switch away from
it and back to it.

https://bugzilla.gnome.org/show_bug.cgi?id=761939
2016-03-01 16:17:08 +01:00
Bastien Nocera
7229af6bdf display: Bump the minimum resolution shown
There's really no point showing a resolution that's smaller than the
fixed width of the shell, and isn't the preferred resolution for the
screen either. This stops the problematic 720x576 resolution showing on
an HD screen.
2016-03-01 16:05:04 +01:00
Felipe Borges
1d365545cf printers: set current page async
https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-02-25 16:14:53 +01:00
Felipe Borges
0a7cfa47fb printers: do async connection test during launch of panel
https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-02-25 16:14:37 +01:00
Felipe Borges
9dd58c0f77 printers: make sure the printer job state_string is initialized
https://bugzilla.gnome.org/show_bug.cgi?id=762630
2016-02-25 13:56:37 +01:00
Felipe Borges
73b07a0b52 printers: use pp_cups_get_dests_async on printers panel
Instead of using the synchronous/blocking cupsGetDests function.

https://bugzilla.gnome.org/show_bug.cgi?id=748336
2016-02-19 15:53:02 +01:00
Cosimo Cecchi
8dbd9ed592 region: don't access priv pointer before checking no error
If the GCancellable is cancelled by the finalize() function, the
callback will still be called potentially with an instance of the
panel that's not valid anymore.
To avoid crashing in that case, only access the priv pointer
when we have no error.

https://bugzilla.gnome.org/show_bug.cgi?id=761846
2016-02-11 20:01:25 +01:00
Felipe Borges
1ea4452b0a mouse: fix panel labels alignment
Also removed shadow_type duplicates on GtkFrames UI file.

https://bugzilla.gnome.org/show_bug.cgi?id=761762
2016-02-10 11:10:08 +01:00
Rui Matos
2e7b23aa00 network: Fix a crash when clicking to forget a VPN on the editor
We need to keep a reference to the NetVpn instance or it might already
be finalized when the editor window closes.
2016-01-26 18:40:47 +01:00
Rui Matos
d57be89340 network: Avoid warnings while closing connection editor
It doesn't make sense to try to validate pages because widgets are
changing due to the whole dialog being destroyed and it causes a bunch
of warnings because some resources are cleared on each page dispose
method.

Avoid all that by disconnecting the page "changed" signal handler
before we start destroying widgets.
2016-01-26 18:40:47 +01:00
Rui Matos
2e6149b4b8 network: Don't try to get secrets for new connections
We don't need secrets for new connections and, in fact, trying to
retrieve secrets in that case will fail because we have a plain
NMConnection instead of a NMRemoteConnection.

The above mentioned error would result in the page never being
initialized.
2016-01-26 18:40:47 +01:00
Lubomir Rintel
62683047c5 network: read secrets for the VPN connections
The VPN page needs secrets too. Don't initialize it until the secrets are
loaded, otherwise the secrets are lost on each connection edit.

https://bugzilla.gnome.org/show_bug.cgi?id=761004
2016-01-26 16:51:09 +01:00
Carlos Garnacho
ff2cfece51 wacom: Avoid deprecated Clutter API 2016-01-22 21:57:49 +01:00
Carlos Garnacho
c0e854a6dd wacom: Workaround deadlocks in Clutter event handlers
The way we destroy the window during the handling of a clutter event may
cause the window to generate a focus event that gets processed immediately,
causing Clutter to deadlock on its global lock.

Bypass these issues in the places where we finalize out of Clutter events,
The Esc key presses are now handled at the GTK+ level, and we postpone
finalization (with either success or failure) to an idle.

Works around https://bugzilla.gnome.org/show_bug.cgi?id=747880
2016-01-22 21:51:46 +01:00
Carlos Garnacho
65bd735937 wacom: Refactor calibrator finalization into separate function
Instead of calling the delete event handler everywhere.
2016-01-22 21:50:38 +01:00
Felipe Borges
23881eaeac printers: have a "view" style for the Jobs dialog empty state
To match the mockups at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines
2016-01-21 15:15:33 +01:00
Felipe Borges
8baaa81a39 printers: redesign the Printer Jobs Dialog
Update the Printer Jobs Dialog to match the current designs at
https://wiki.gnome.org/Design/SystemSettings/Printers

https://bugzilla.gnome.org/show_bug.cgi?id=755626
2016-01-21 15:08:05 +01:00
Jiro Matsuzawa
04a8943cfd user-accounts: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Jiro Matsuzawa
a3a8255b97 sharing: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Jiro Matsuzawa
472fd9d33d notifications: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Rui Matos
e96e87a282 universal-access: Fix mnemonic conflicts 2016-01-18 16:17:48 +01:00
Rui Matos
cde6a3eb3a universal-access: Add missing mnemonic widget to the Large Text label 2016-01-18 16:16:33 +01:00
Jiro Matsuzawa
7b9a76c609 datetime: Fix mnemonic conflict
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Jiro Matsuzawa
5ae47f0305 region: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Jiro Matsuzawa
9dc11e66bd background: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Jiro Matsuzawa
e49495408a universal-access: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Jiro Matsuzawa
cc2fad82bc color: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Jiro Matsuzawa
5b189ea0e3 printers: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 15:50:20 +01:00
Rui Matos
888e40eae8 wacom: Avoid crashing when opening the panel on wayland sessions
We don't yet support wacom devices under wayland and GsdWacomDevice
uses X APIs unconditionally which makes us crash under wayland.

Instead, let's return early and leave the GsdWacomDevice in an invalid
state which means that we just present the default UI for "no wacom
devices detected".
2016-01-18 14:53:28 +01:00
Rui Matos
30470d7213 region: Ensure that system and user formats are consistent
The formats (or 'region') setting might be unset meaning that it's the
same as the language since that's what LC_TIME et al default to when
unset.

We already handle this for the user setting but for the system setting
we're losing that semantic when getting it from localed since we don't
allow priv->system_region to remain unset. This means that when users
change the system language, the system formats will be explicitly set
to the previous value of the system language instead of remaining
unset and thus follow the new value for the system language.

This isn't that bad on multi user systems where we display system
settings separately from user settings, but on single user systems we
change the system values to match the user values which, due to the
above mentioned semantic difference regarding the region setting,
means that when changing the language, the (unset) region will be
displayed as the same as the language but the system region will be
explicitly set to the previous language.

Fix this by making the system region have the same semantic as the
user's, i.e. allow it to remain unset until explicitly set by the
user.

https://bugzilla.gnome.org/show_bug.cgi?id=755648
2016-01-18 14:53:05 +01:00
Andrew Cowie
ad6a00ae16 network: Elipsize device metadata fields
Excessively long metadata fields cause the the control-center panel to
blow out to wider than screen width. Probably the right thing is to
limit the allocation to the device detail pane from somewhere up the
stack, but for now, enable ellipsizing and set an max-width to
constrain the width of things which are there just for information
anyway; true values are available in the edit dialog.

Closes #759766.

Signed-off-by: Andrew Cowie <andrew@operationaldynamics.com>
2016-01-15 16:29:26 +01:00
Felipe Borges
7cd6800da0 printers: port pp_cups_get_dests* to GTask
As of GLib 2.46, GSimpleAsyncResult is deprecated
in favor of GTask, which provides a simpler API.

https://bugzilla.gnome.org/show_bug.cgi?id=760581
2016-01-15 11:49:53 +01:00
Debarshi Ray
46f19022ef region: Use listbox header helper
https://bugzilla.gnome.org/show_bug.cgi?id=760582
2016-01-13 16:56:11 +01:00