The `source_object` parameter for the callback functions called from
the `realm_join_as_user` and `real_join_as_admin` resp. `realm_join_as_owner`
functions is not `CC_REALM_OBJECT` type as one would expect, but
`CC_REALM_KERBEROS_MEMBERSHIP` type. Let's modify the code to ensure that
it is `CC_REALM_OBJECT` type.
The implementation is based on the cc-add-user-dialog.c codes, but it is
not a pure copy&paste. It has to be changed to fit the skeleton and reflect
changes from the mockup. I've also tried to simplify the code where possible.
It also fixes some memory leaks.
When the row is a subpage it has a parent_id, which should be activated
instead of panel_id. So we construct a parameters GVariant so that
panels can handle it.
- Make all buttons as suffix widgets,
which makes unnecessary to wrap them in
a GtkBox that is set as a suffix widget
- Don't set a margin end to the Wi-Fi
icon[1]
- Remove halign from the buttons, because
it isn't necessary
- Remove halign from the buttons, as it
isn't necessary because halign works only
if hexpand is set to TRUE
- Add margin end to the spinner so it
doesn't appear misaligned with the other
widgets at the end of the row
[1] In latest mockups, the margin between
the Wi-Fi icon and network name is also
shorter: cfb7cae4a9
This allows us to open subpages of the "System" panel. The arguments/
parameters are expected to match the panel's subpage tags (as in
AdwNavigationPage.tag).
With this, a future change could reintroduce desktop files for the
subpages, and just change the Exec line to accomodate the new format.
Graphics labels under system details did not have enough padding
between them similar to other labels in the panel
Add a default spacing of 10 to children rows of gtk_box that sets the
graphic rows dynamically to fix the issue
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2916
Commit 90a131a2 (!2164) split off the translation of the sound panel
name "Sound". However, "Sound" might need a unique translation in
this case.
So, add a context string to allow for that.
Closes#2915