Commit graph

585 commits

Author SHA1 Message Date
Jiro Matsuzawa
04a8943cfd user-accounts: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Rui Matos
958c0140bb user-accounts: Avoid a crash when gdm's schemas aren't installed
Commit de821d5922 implicitly added a
runtime dependency on gdm's settings schemas being installed. Since
GSettings aborts if schemas aren't installed this means we new crash
on systems without gdm.

See https://bugzilla.redhat.com/show_bug.cgi?id=1259935 .

https://bugzilla.gnome.org/show_bug.cgi?id=754682
2015-09-07 16:45:03 +02:00
Ondrej Holy
7ce6ce6807 user-accounts: Fix enterprise user login permitting
Commit 3e6b741a introduced check for NULL on um_realm_object_get_common.
Unfortunatelly one check is wrong and breaks the login permitting.
The patch fixes the wrong check.

https://bugzilla.gnome.org/show_bug.cgi?id=752405
2015-07-15 17:34:49 +02:00
Bastien Nocera
93414609fa user-accounts: Fix gtk_tree_model_get_iter_first() retval
https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Ondrej Holy
afe0a62267 user-accounts: show restart notification when account type changed
https://bugzilla.gnome.org/show_bug.cgi?id=674429
2015-04-15 16:27:24 +02:00
Matthias Clasen
165be44369 users: Fix fingerprint delete dialog formatting
The manual borderwidth setting breaks message dialog appearance.
While we are here, remove some unnecessary calls.

https://bugzilla.gnome.org/show_bug.cgi?id=745908
2015-03-10 06:43:12 -04:00
Ondrej Holy
3e6b741ad2 user-accounts: check for NULL on um_realm_object_get_common
um_realm_object_get_common can return NULL, which shouldn't be passed
into subsequent functions to avoid crashes.

https://bugzilla.gnome.org/show_bug.cgi?id=705351
2015-02-25 15:50:17 +01:00
Ondrej Holy
de821d5922 user-accounts: don't show fingerprint options if disabled
Don't show fingerprint configuraiton if the administrator disabled
fingerprint authentication:
https://help.gnome.org/admin/system-admin-guide/stable/login-fingerprint.html

https://bugzilla.gnome.org/show_bug.cgi?id=744332
2015-02-23 12:57:18 +01:00
Ondrej Holy
a4521c15d5 user-accounts: update padding on style-updated
Padding is updated for some widgets once, when creating the widgets.
But it seems style may not be loaded yet. Therefore the padding has
to be updated on "style-updated" signal to reflect style changes.

https://bugzilla.gnome.org/show_bug.cgi?id=743180
2015-01-27 16:35:48 +01:00
Ondrej Holy
dba7bf76c4 user-accounts: hidpi support for user's icons in tree view
This patch adds UmCellRendererUserImage object which respect scale factor.

https://bugzilla.gnome.org/show_bug.cgi?id=742395
2015-01-20 17:08:19 +01:00
Ondrej Holy
5c30530271 user-accounts: hidpi support for user's icons
This patch adds UmUserImage widget which respect scale factor.

https://bugzilla.gnome.org/show_bug.cgi?id=742395
2015-01-20 17:08:15 +01:00
Ondrej Holy
006b5970a6 user-accounts: render user's icons as surface with scale
This patch is needed for future hidpi support.

https://bugzilla.gnome.org/show_bug.cgi?id=742395
2015-01-20 17:08:11 +01:00
Ondrej Holy
8bd1a5f18d user-accounts: do not show notification if not needed
Restart notification is shown if there is different language in
accountsservice. However restart isn't needed if user selects original
language (after several changes), which is already used in the system.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2015-01-19 13:12:34 +01:00
Ondrej Holy
b0e6526c46 user-accounts: do not set the language twice
The act_user_set_language function is called twice as a result of
commit 96c0c0a, which is not necessary.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2015-01-19 13:05:36 +01:00
Ondrej Holy
b61c74aa60 user-accounts: don't show empty row for remote users
Empty row is shown instead of hidden autologin switch, because autologin
box is still visible. Set visibility on autologin box to hide this empty
row.

https://bugzilla.gnome.org/show_bug.cgi?id=742926#c0
2015-01-15 09:34:46 +01:00
Rui Matos
283f6b4ce3 user-accounts: Fix deprecated API usage
https://bugzilla.gnome.org/show_bug.cgi?id=740986
2015-01-07 16:43:34 +01:00
Rui Matos
ca7421efa2 user-accounts/crop-area: Enforce a minimum size
Otherwise, since the dialog is resizable, users could resize us so
small that we'd crash inside gdk_pixbuf_scale() .

https://bugzilla.gnome.org/show_bug.cgi?id=740986
2015-01-07 16:43:34 +01:00
Rui Matos
a56693207d user-accounts/crop-area: Fix background rendering around the picture
Instead of trying to fill the displayed pixbuf with the background
color (and failing at that), just make the pixbuf be an aspect correct
scaled size of the original picture and draw it at the correct offset
on the draw vfunc.

This allows us to get rid of deprecated gtk+ API usage and fixes the
background around the picture ending up black despite de code's
intent.

https://bugzilla.gnome.org/show_bug.cgi?id=740986
2015-01-07 16:43:34 +01:00
Ondrej Holy
f0e8f9d161 user-accounts: fix crash when network changes
Add user dialog crashes if it has been closed and network configuration
changes, because the dialog is already disposed, but on_network_changes
callback is executed. To fix this crash network monitor signal handler
has to be disconnected on dispose.

https://bugzilla.gnome.org/show_bug.cgi?id=742439
2015-01-06 12:20:55 +01:00
Ondrej Holy
af93bb814e user-accounts: don't crash when closing fingerprint dialog
Enroll data are used after destroying when closing dialog. It causes
crash while setting label. Therefor we have to store the pointer for
fingerprint button and use it to set the label after destroying the
data.

https://bugzilla.gnome.org/show_bug.cgi?id=741635
2014-12-17 12:34:30 +01:00
Rui Matos
85fc10d9d2 user-accounts: Add the password input purpose to all relevant entries 2014-12-05 16:52:07 +01:00
Rui Matos
a880013b3e user-account: Don't stroke the down arrow with the border color
Besides using deprecated gtk+ API this color is actually fully
transparent in the current GNOME theme, meaning that the arrow ended
up looking smaller than intended.

https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Rui Matos
33404f1ea8 user-accounts/photo-dialog: Remove needless frame
Now that the crop area isn't all black around the picture, this frame
is just visual noise.

https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Ondrej Holy
33052abe9c user-accounts: change default size for avatar cropping
Change default size for avatar cropping to correspond with changes in cheese.
The default size should be based on maximal size of the image instead of
minimal size for cropping.

https://bugzilla.gnome.org/show_bug.cgi?id=739871
2014-11-25 15:20:39 +01:00
Ondrej Holy
320f6e617b user-accounts: replace deprecated stuff 2014-11-20 11:32:33 +01:00
Lapo Calamandrei
d227fa4a88 user-accounts: remove superfluous frame from history dialog
See https://bugzilla.gnome.org/show_bug.cgi?id=739820
2014-11-10 20:05:43 +01:00
Ondrej Holy
5790368643 user-accounts: fix enterprise accounts deleting
Deleting enterprise accounts using act_user_manager_delete_user fails
with error: userdel failed, because enterprise accounts are added
using act_user_manager_cache_user and don't have entries in passwd
file. Thus enterprise accounts should be removed by
act_user_manager_uncache_user.

https://bugzilla.gnome.org/show_bug.cgi?id=727871
2014-11-03 18:13:10 +01:00
Ondrej Holy
ed13a62c1d user-accounts: use common function for error messages
https://bugzilla.gnome.org/show_bug.cgi?id=727871
2014-11-03 18:13:10 +01:00
Ondrej Holy
96c0c0a838 user-accounts: simplify language changing thru users panel
Do not show combo box with common languages and show the language
chooser immediately as it is done in the region panel.

https://bugzilla.gnome.org/show_bug.cgi?id=738077
2014-10-31 09:19:54 +01:00
Ondrej Holy
946ff4eb3c um-editable-combo: avoid using deprecated GtkAlignment and GtkMisc
https://bugzilla.gnome.org/show_bug.cgi?id=736013
2014-10-31 08:53:24 +01:00
Ondrej Holy
d6a0c18f09 um-editable-button: avoid using deprecated GtkAlignment and GtkMisc
https://bugzilla.gnome.org/show_bug.cgi?id=736013
2014-10-31 08:53:24 +01:00
David King
d3c93d9249 user-accounts: Rename UmCropArea to CcCropArea
Cheese has an internal copy of UmCropArea, and exports the corresponding
um_crop_area_get_type() as part of libcheese-gtk. This leads to a crash
when taking a photo in the avatar chooser, as the control center copy of
the get_type() function is used. Renaming the function in Cheese would
be an ABI break, so at this stage it is best to do the rename in the
control center instead.

https://bugzilla.gnome.org/show_bug.cgi?id=697039
2014-10-15 15:08:46 +01:00
Ondrej Holy
37a54b69d6 user-accounts: remove dead code
This lines are dead code, because act_user_get_language() returns empty
string if language isn't set. We don't want to fix the condition, because
cc_common_language_get_current_language is wrong for other users.

https://bugzilla.gnome.org/show_bug.cgi?id=737216
2014-10-07 12:19:01 +02:00
Ondrej Holy
4c6ef8568d user-accounts: fix language chooser response if language is unknown
If language is unknown and language chooser is cancelled, panel crash
with the following error:

(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_path:
assertion 'iter->stamp == priv->stamp' failed

(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_value:
assertion 'iter_is_valid (iter, list_store)' failed

(gnome-control-center:24952): GLib-GObject-WARNING **: gtype.c:4221:
type id '0' is invalid

(gnome-control-center:24952): GLib-GObject-WARNING **:
can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)

https://bugzilla.gnome.org/show_bug.cgi?id=738002
2014-10-07 12:09:43 +02:00
Ondrej Holy
6b3b223668 user-accounts: preset language chooser if language is known
Preset the language chooser similary as it is done in the region panel.
Also remove one goto command and share code.

https://bugzilla.gnome.org/show_bug.cgi?id=738002
2014-10-07 12:08:55 +02:00
Ondrej Holy
6f13d0ad8b user-accounts: fix language chooser response
If the language chooser is confirmed and no language is selected,
"Other..." is shown as user's language and the following error is printed:

(gnome-control-center:14608): AccountsService-CRITICAL **:
act_user_set_language: assertion 'language != NULL' failed
2014-10-07 12:08:38 +02:00
Ondrej Holy
49e3fe482d user-accounts: be sure widgets has same height
Autologin widgets are different in height as compared with other widgets,
which looks odd. Put all the widgets in the sizegroups, to have same
height.

https://bugzilla.gnome.org/show_bug.cgi?id=737343
2014-09-25 11:50:29 +02:00
Ondrej Holy
50bed210e5 user-accounts: show correct language if it isn't set
Determine the language for the logged in user if it isn't set in the
acountsservice.

https://bugzilla.gnome.org/show_bug.cgi?id=737216
2014-09-24 18:28:38 +02:00
Sandeep Sheshrao Shedmake
8980b82e00 Updated Marathi Translations 2014-09-21 10:00:10 +05:30
Ondrej Holy
d82a2101d5 user-accounts & region: allow multiline notifications
The notification is wider then window for some languages (e.g.
France). This patch allows wrapping, limits chars and changes
margin as a result of discussion on #gnome-design.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2014-09-19 13:35:15 +02:00
Matthias Clasen
177166c65b user-accounts: Fix focus in the account dialog
Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.

https://bugzilla.gnome.org/show_bug.cgi?id=736223
2014-09-12 08:14:26 -04:00
Ondrej Holy
c218a2198e user-accounts: replace fingerprint widgets by the UmEditableButton
The patch fixes also a wrong padding and replaces GtkNotebook.

https://bugzilla.gnome.org/show_bug.cgi?id=736009
2014-09-05 13:05:46 +02:00
Ondrej Holy
6ce59765dc user-accounts: fix wrong label padding
Hardcoded value is avoided and the label offset is calculated from
style context now.

https://bugzilla.gnome.org/show_bug.cgi?id=736009
2014-09-05 13:05:46 +02:00
Ondrej Holy
3695f858dd user-accounts: use GtkStack instead of GtkNotebook in Add user dialog
https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-15 17:21:40 +02:00
Ondrej Holy
ed4653627b cc-editable-button: use GtkStack instead of GtkNotebook
https://bugzilla.gnome.org/attachment.cgi?bugid=694325
2014-08-15 17:12:30 +02:00
Ondrej Holy
0f3575b317 user-accounts: avoid removing non-existent GSources
Source id have to be zeroed correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=734548
2014-08-14 13:51:56 +02:00
Ondrej Holy
e4efd5eafd user-accounts: prefill domain entry
If we already have any configured realm, prefill one.

https://bugzilla.gnome.org/show_bug.cgi?id=711675
2014-08-09 14:33:16 +02:00
Ondrej Holy
608fa9609c user-accounts: fix enterprise toggle
Enterprise toggle isn't shown due to header bar buttons. Don't add
the toggle in to the dialog action area to fix the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-09 14:33:12 +02:00
Ondrej Holy
0002313af8 user-accounts: Add restart notification
Show restart notification when language is changed.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2014-08-07 13:55:37 +02:00
Ondrej Holy
08a00388be user-accounts: fix warning caused by invalid signal 2014-08-07 11:55:43 +02:00