Commit graph

20 commits

Author SHA1 Message Date
Jody Goldberg
b4995826e8 http://bugzilla.gnome.org/show_bug.cgi?id=85397
2002-06-15  Jody Goldberg <jody@gnome.org>

	http://bugzilla.gnome.org/show_bug.cgi?id=85397
	http://bugzilla.gnome.org/show_bug.cgi?id=84545
	* mime-types-model.c (mime_types_model_get_value) :
	  gtk_tree_view_search_equal_func does not like NULL.
	(IS_CATEGORY) : check for NULL.
	* file-types-capplet.c (create_dialog) : search the description not
	  the mime type.

2002-06-08  Jody Goldberg <jody@gnome.org>

	* mime-types-model.c (IS_CATEGORY) : test for null in case we are
	  stupid.

2002-06-07  Jody Goldberg <jody@gnome.org>

	* file-types-capplet.c (dialog_done_cb) : no need to save things
	  again.  The only caller had already done that.

	* mime-type-info.c (mime_type_info_save) : Don't mess with the
	  application here, it should already be setup.  However, be really
	  really anal about verifying it because I do not trust the
	  surrounding code or know it well enough to trust it.  Make sure that
	  the assigned app is on the short list of associated apps.

	* mime-category-edit-dialog.c (store_data) : Use
	  mime_edit_dialog_get_app.
	* mime-edit-dialog.c (store_data) : Use it here too.
	(mime_edit_dialog_get_app) : new.  split some duplicated code out of
	  the type and category dialogs and move it here.  Then make it
	  readable and less stupid about creating copies of existing
	  applications.  While we're at it have it handle the creation of new
	  applications, merging commands with existing applications and other
	  useful stuff.

2002-06-07  Jody Goldberg <jody@gnome.org>

	* mime-category-edit-dialog.c (store_data) : clarify and remove the
	  custom flag.

	* mime-type-info.c (mime_category_info_using_custom_app) : delete.
	(mime_type_info_using_custom_app) : delete.

	* mime-edit-dialog.c (validate_data) : correct the warning about
	  invalid type, we would _not_ create one for the user :-(
	  Allow a user to optionally overwrite an existing mime type.
	  This is useful when editing.
	* mime-edit-dialog.c (store_data) : clarify and remove the custom flag.


2002-06-10  Jody Goldberg <jody@gnome.org>

	* accessibility-keyboard.c : tweak the layout as requested and adjust
	  the max slowkey delay to 500 to avoid losing the keyboard due to some
	  sort of an X problem.

2002-06-13  Jody Goldberg <jody@gnome.org>

	* gnome-keyboard-properties.c (accessibility_button_clicked) : produce
	  a better warning for failure to launch the keyboard accessibility
	  capplet.
2002-06-18 18:55:14 +00:00
Jody Goldberg
49d1a5af36 Improve help handling.
2002-05-26  Jody Goldberg <jody@gnome.org>

	* capplet-util.c (capplet_help) : new utility.

2002-05-24  Jody Goldberg <jody@gnome.org>

	* mime-type-info.c (mime_category_info_load_all) : make this more paranoid.
	* mime-category-edit-dialog.c (update_subcategories) : Move this over
	  here.

2002-05-17  Jody Goldberg <jody@gnome.org>

	* mime-type-info.c (mime_category_info_using_custom_app) : add some
	  protection.
2002-05-27 02:53:33 +00:00
Bradford Hovinen
0018db8569 Fill the name entry with the description, not the name field
2002-02-17  Bradford Hovinen  <hovinen@ximian.com>

	* mime-category-edit-dialog.c (fill_dialog): Fill the name entry
	with the description, not the name field

	* mime-types-model.c (mime_types_model_get_value): Use description
	field when returning the description column for a category

	* mime-type-info.c (mime_type_info_set_category_name): Accept
	pointer to category description and pass that to get_category
	(mime_category_info_new): Initialize description; accept pointer
	to description
	(get_category): Accept a pointer to the description and initialize
	the category with that as well if necessary
	(get_category_description): Implement. Copy from
	get_category_name, but use the translated description name

	* mime-type-info.h (struct _MimeCategoryInfo): Add description
	field; holds the translated name

	* mime-type-info.c (mime_category_info_get_full_description):
	Implement. Copy from mime_category_info_get_full_name, but use
	description field rather than name field
	(mime_type_info_get_category_name): Use _get_full_description
	rather than _get_full_name
2002-02-17 18:48:49 +00:00
Bradford Hovinen
a2b1d26374 Implement
2002-01-28  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (mime_type_info_using_custom_app)
	(mime_category_info_using_custom_app): Implement

	* mime-edit-dialog.c (store_data): Update: don't use custom_line,
	needs_terminal

	* mime-type-info.[ch]: Eliminate custom_line and needs_terminal;
	will use default_action for that now
2002-01-28 18:39:42 +00:00
Bradford Hovinen
2073f4108f Fix logic (mime_type_info_load_all): Don't load default_action if
2002-01-28  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (update_subcategories): Fix logic
	(mime_type_info_load_all): Don't load default_action if
	custom_line is set

	* mime-category-edit-dialog.c (store_data): Call
	mime_category_info_update
	(store_data): Don't notify the model -- nothing there could have
	changed

	* mime-type-info.c (mime_category_info_update): Implement
	(update_subcategories): Update; split from set_subcategory_ids

	* mime-category-edit-dialog.c (populate_application_list): Notify
	destruction with gnome_vfs_mime_application_free
	(store_data): Store default action
	(store_data): Store custom line, needs terminal
	(populate_application_list): Set needs_terminal_toggle

	* mime-type-info.c (mime_type_info_get_use_category):
	Implement. Factor from mime_type_info_load_all
	(find_possible_supported_apps, reduce_supported_app_list): Use
	mime_type_info_get_use_category
	(get_gconf_base_name): Replace parentheses with '-'
	(mime_category_info_load_all): Only load default action, custom
	line if not already loaded

	* mime-edit-dialog.c (populate_component_list): Use get_all_components
	(populate_application_list): Use get_all_applications
2002-01-28 16:43:40 +00:00
Bradford Hovinen
9b549da9bf Implement
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (get_gconf_base_name): Implement

	* mime-category-edit-dialog.c (fill_dialog): Disable
	use_category_toggle if this is a toplevel category
	(populate_application_list, default_action_changed_cb)
	(use_category_toggled_cb, update_sensitivity): Set widget
	sensitivity based on various values

	* mime-type-info.c (mime_type_info_load_all)
	(mime_category_info_load_all): Check use_[parent_]cat_loaded
	(mime_category_info_load_all): Override use_parent_category with
	FALSE if this is a toplevel category
2002-01-27 19:54:56 +00:00
Bradford Hovinen
3e7ed33e41 Don't set subcategory ids unless use_parent_category is set
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (set_subcategory_ids): Don't set subcategory
	ids unless use_parent_category is set
	(mime_category_info_save, mime_category_info_load_all): Get/set
	use_parent_category
	(reduce_supported_app_list, find_possible_supported_apps): Check
	use_parent_category field
2002-01-27 19:09:37 +00:00
Bradford Hovinen
569a91f30c Use mime_category_info_get_full_name
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* mime-edit-dialog.c (choose_cat_cb): Use
	mime_category_info_get_full_name

	* mime-type-info.c (mime_type_info_load_all, mime_type_info_save):
	Rename override_category as use_category; give it the opposite
	meaning
	(reduce_supported_app_list, find_possible_supported_apps): Update
	according to the above
	(set_subcategory_ids): Implement
	(mime_category_info_save): Implement
	(mime_category_info_load_all): Implement
	(mime_category_info_get_full_name): Implement; copy from
	mime_type_info_get_category_name
	(mime_type_info_get_category_name): Call
	mime_category_info_get_full_name
2002-01-27 19:02:15 +00:00
Bradford Hovinen
e83a9693b3 Rename override_category as use_category; give it the opposite meaning
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (mime_type_info_load_all, mime_type_info_save):
	Rename override_category as use_category; give it the opposite
	meaning
	(reduce_supported_app_list, find_possible_supported_apps): Update
	according to the above
2002-01-27 18:37:07 +00:00
Bradford Hovinen
5b53898068 Set use_category_defaults_toggle (store_data): Set override_category
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* mime-edit-dialog.c (fill_dialog): Set
	use_category_defaults_toggle
	(store_data): Set override_category
	(mime_edit_dialog_init): Connect to
	use_category_defaults_toggled_cb
	(use_category_defaults_toggle_cb): Implement
	(default_action_changed_cb, populate_application_list)
	(populate_component_list): Call update_sensitivity; set
	sensitivity-controlling flags
	(update_sensitivity): Implement
2002-01-27 17:41:06 +00:00
Bradford Hovinen
e32444ef56 Call get_service_info to handle case where the service was created and not
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* service-edit-dialog.c (validate_data): Call get_service_info to
	handle case where the service was created and not yet committed

	* mime-type-info.c (get_mime_type_info, get_mime_type_info_int):
	Implement

	* mime-edit-dialog.c (validate_data): Check if the MIME type is
	already known and we are adding a new type

	* service-edit-dialog.c (service_edit_dialog_init): Change dialog
	title

	* file-types-capplet.c (edit_count_cb): Rename from count_cb
	(selection_changed_cb): Initialize count
	(selection_changed_cb): Iterate on remove_count_cb and use that to
	set the sensitivity of the remove button
	(create_dialog): Desensitize the remove button
2002-01-27 16:58:43 +00:00
Bradford Hovinen
6a3797bfc5 Accept model (get_services_category_entry): Accept model
2002-01-27  Bradford Hovinen  <hovinen@ximian.com>

	* service-info.c (load_all_services): Accept model
	(get_services_category_entry): Accept model
	(service_info_new): Accept model
	(get_services_category_entry): Set the parent pointer

	* model-entry.c (get_model_entries): Accept model

	* mime-type-info.c (mime_type_info_new, load_all_mime_types):
	Accept model

	* mime-edit-dialog.c (store_data): Don't perform notification

	* model-entry.c (model_entry_insert_child)
	(model_entry_remove_child): Perform notification here

	* mime-type-info.c (mime_type_info_set_category_name): Accept
	model for notification purposes
	(get_category): Ditto; notify the model that the new category has
	been created

	* mime-types-model.c (mime_types_model_iter_parent): Make the
	iterator invalid if the parent is the root node

	* mime-edit-dialog.c (collect_filename_extensions): Return NULL if
	there are no nodes in the tree at all
2002-01-27 16:18:36 +00:00
Bradford Hovinen
d8c7752324 Implement (find_possible_supported_apps): Implement
2002-01-26  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (intersect_lists, reduce_supported_app_list)
	(mime_category_info_find_apps): Implement
	(find_possible_supported_apps): Implement

	* mime-category-edit-dialog.c (mime_category_edit_dialog_init):
	Use mime_category_edit_widget for the dialog source

	* model-entry.c (model_entry_remove_from_dirty_list): Accept a
	ModelEntry structure

	* mime-category-edit-dialog.c (store_data): Call
	model_entry_append_to_dirty_list

	* service-edit-dialog.c (store_data): Call
	model_entry_append_to_dirty_list
2002-01-26 16:24:45 +00:00
Bradford Hovinen
7b769d453f Free icon_path
2002-01-25  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.c (mime_type_info_free): Free icon_path

	* mime-edit-dialog.c (fill_dialog): Set icon entry with the full
	path of the icon

	* mime-type-info.c (mime_type_info_get_icon_path):
	Implement. Factor from get_pixbuf

	* mime-edit-dialog.c (store_data): Reset the icon pixbufs so that
	they get reloaded

	* mime-type-info.c (get_icon_pixbuf): Use
	gnome_vfs_icon_path_from_filename and install the nautilus/ hack
	from the old capplet *sigh*
2002-01-25 17:27:02 +00:00
Bradford Hovinen
1a3c89e420 Code cleanup; create our own model rather than using GtkTreeStore Update
2002-01-24  Bradford Hovinen  <hovinen@ximian.com>

	* mime-type-info.[ch], mime-types-model.[ch], service-info.[ch]:
	Code cleanup; create our own model rather than using GtkTreeStore
	* All: Update to reflect the above
2002-01-25 16:12:01 +00:00
Bradford Hovinen
d6d5ff20d9 Implement. Mostly a copy from the corresponding function in
2002-01-14  Bradford Hovinen  <hovinen@ximian.com>

	* mime-category-edit-dialog.c (populate_application_list):
	Implement. Mostly a copy from the corresponding function in
	mime-edit-dialog.c

	* mime-types-model.c (get_insertion_point): Make this public
	(find_supported_apps_for_category, reduce_supported_app_list)
	(intersect_lists, find_possible_supported_apps): Implement

	* mime-edit-dialog.c (fill_dialog): Fill category_entry
	(choose_cat_cb): Implement
	(mime_edit_dialog_init): Connect choose_button to choose_cat_cb

	* mime-type-info.c (mime_type_info_load): Load category name
	(mime_type_info_save): Call reinsert_iter to affect category name
	change

	* mime-types-model.c (mime_types_model_new): Add parameter
	is_category_select; TRUE iff this model should be only for
	selecting a category and not list the actual file types or
	Internet services
	(get_category_name): Implement

	* mime-edit-dialog.c (mime_edit_dialog_init): Add category_label
	to first size group

2002-01-13  Bradford Hovinen  <hovinen@ximian.com>

	* file-types-capplet.c (edit_cb, row_activated_cb): Don't try to
	create a category edit dialog if this is the Internet Services
	category
	(count_cb): Only count other than internet services category

	* mime-types-model.c (model_entry_is_category): Implement
	(model_entry_is_protocol): Use categories[INTERNET_SERVICES_IDX]
	rather than string
	(model_entry_is_internet_services_category): Implement

	* Makefile.am (gnome_file_types_properties_SOURCES): Add
	mime-category-edit-dialog.[ch]

	* file-types-capplet.c (edit_cb): Construct a category edit dialog
	if the tree iterator has children
	(row_activated_cb): Ditto
2002-01-14 15:28:36 +00:00
Bradford Hovinen
b11fd58903 Set sensitivity of needs_terminal_toggle (store_data): Set needs_terminal
2002-01-11  Bradford Hovinen  <hovinen@ximian.com>

	* mime-edit-dialog.c (default_action_changed_cb): Set sensitivity
	of needs_terminal_toggle
	(store_data): Set needs_terminal
	(fill_dialog): Set needs_terminal_toggle
2002-01-11 20:54:55 +00:00
Bradford Hovinen
ee6a2823a4 Terminate column list with -1
2002-01-11  Bradford Hovinen  <hovinen@ximian.com>

	* mime-edit-dialog.c (add_ext_cb): Terminate column list with -1

	* service-edit-dialog.c (store_data): Call service_info_update

	* mime-edit-dialog.c (store_data): Call mime_type_info_update

	* mime-type-info.c (mime_type_info_update): Implement. Updates the
	model with data from the structure

	* service-info.c (service_info_update): Implement. Updates the
	model with data from the structure

	* mime-type-info.c (form_extensions_string): Implement. Factor
	from mime_type_info_save

	* service-info.c (service_info_load): Accept model and iter rather
	than protocol name; read protocol name from model

	* mime-type-info.c (mime_type_info_load): Accept model and iter
	rather than mime type; read the mime type from the model

	* mime-types-model.c (get_icon_pixbuf): Make this public
2002-01-11 15:32:10 +00:00
Bradford Hovinen
b097229244 Implement (program_sensitive_cb): Implement (response_cb): Call store_data
2002-01-11  Bradford Hovinen  <hovinen@ximian.com>

	* service-edit-dialog.c (store_data): Implement
	(program_sensitive_cb): Implement
	(response_cb): Call store_data if response_id is OK
	(service_edit_dialog_init): Connect toggled signal on
	run_program_toggle to program_sensitive_cb

	* mime-type-info.h: Add #include gnome-vfs-mime-info.h

	* service-edit-dialog.c (populate_app_list): Implement

	* mime-edit-dialog.c (populate_component_list): Make sure custom
	menu item is shown
2002-01-11 14:17:40 +00:00
Bradford Hovinen (Gdict maintainer)
98e37477fa Near total rewrite 2002-01-08 21:25:33 +00:00