Using a GtkStack isn't necessary to display the "Not set up"
row. Instead, use a GtkListBox placeholder widget in the main
VPN list box.
This improves consistency with the placeholders from "Privacy >
Location/Camera/Microphone" when there are no apps; same thing
in "Search > Search Locations > Custom Locations" when no custom
locations were added.
https://docs.gtk.org/gtk4/class.ListBox.html#gtklistbox-as-gtkbuildable
Even though `cc-keyboard-item.c` contains no translateable strings, it
does contain a `g_dpgettext2()` call for the "gtk40" domain. Damned Lies
still picks this up.
So, add `cc-keyboard-item.c` to POTFILES.skip, which also fixes the
updated ci from the previous commit.
Change the `gettext` grep to also include a possible `g_dpgettext2`.
This also changes the grep command to "normal" (extended) regex,
which is perhaps easier to read without all the escaping backslashes.
- Add a tooltip
- Remove the a11y label because Orca also reads tooltips
- Remove the .image-button style class as it's automatically
added if a GtkButton has an icon
- Remove the use-underline property as it's pointless in
a button without a label
HIG says that "Text generally shouldn’t end with a period.
This applies [...] text that is written as a complete sentence",
but the page description text isn't written as a complete sentence,
so the guideline isn't applicable in this case.
https://developer.gnome.org/hig/guidelines/writing-style.html
Some of our list rows launch dialogs. Our callbacks were plain
adw_dialog_present (dialog, parent) calls.
Lets delete that code and call adw_dialog_present directly where it
makes sense.
When using the copy buttons from Desktop Sharing/Remote Login pages,
the toasts don't show that the values were copied to the clipboard,
unlike in System > Secure Shell/About > System Details, for example.
So, fix this inconsistency.
The .tls-cert-fingerprint style class is part of "Verify Encryption"
dialog from the Remote Desktop feature, which is now present in the
System panel. sharing.css isn't needed anymore.
"Add" and "Enroll" buttons can still be sensitive without
calling main_page_validate() and enroll_page_validate()
respectively. Add an assertion check in both cases to
prevent these buttons being sensitive incorrectly.
Co-authored-by: Matthijs Velsink <mvelsink@gnome.org>
Doing so, the firmware-security-dialog and
firmware-security-boot-dialog can show more text (which can
increase in some translations) without having a scrollbar.
This complements the following commit:
c252c3c861
Commit b76d6d0d (!2130) added a thousands separator to the speed label
for ethernet. This did not affect the tests, as they are run under the
`C` locale, meaning no separator was present in the tests and the label
test matched.
However, running tests with locale set to `en_US.UTF-8` for example
fails, as the label then reads "1,234 Mb/s" instead.
Fix this by adding a wildcard in the place of the separator.
Now that the CI checks for any mistakes in POTFILES.in, let's fix it
completely.
I manually checked any removed files if strings were accidentally not
marked as translatable, but there were none. Note that this is a benefit
of also checking for files that are in POTFILES.in but are not
translatable; accidental removal of translation markers can be caught.
The `*gettext()` function family is only translatable for us if it
contains string literals or uses our `GETTEXT_PACKAGE` domain. A broad
`'gettext *('` grep will therefore not work.
So, narrow the grep a bit to only work for `*gettext()` call where the
first argument is a string literal or `GETTEXT_PACKAGE`.
This script checks for files that are translatable, but are missing from
POTFILES.in. Also, it checks whether files that are in POTFILES.in are
translatable at all or are missing.
Based on nautilus!1418.
Closes#2845
- add new assets for clicking and scrolling view switcher
- adjust the scroll test arrow display
- remove old inappropriate asset
- use gresource for new assets
Rename the following strings (and use header capitalization):
- "When on battery power" to "On Battery Power"
- "When plugged in" to "When Plugged In" (in the Automatic Suspend
dialog too)
Reference 1bb482ed19
"Language" and "Format" rows show their value as a subtitle,
but this is inconsistent with Settings design pattern in which
the value label is shown at the right, so fix this inconsistency.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2914
