Commit graph

11 commits

Author SHA1 Message Date
Felipe Borges
affa60edcf Revert "system: Replace dynamic System row subtitles with static text"
This reverts commit ea224c4045.

This was accidentally included in another MR.
2023-12-05 15:17:11 +01:00
Felipe Borges
ea224c4045 system: Replace dynamic System row subtitles with static text
Row subtitles in Settings are typically a description of the main label or setting.
You can see this in Mouse & Touchpad, Privacy, Sharing, and Wi-Fi.
For the System panel we did something a bit different and used the subtitle to show
the status of each panel.

Given the standard use of subtitles elsewhere, this feels a bit surprising which,
as a result, makes the panel harder to read. I think that a standard description
would probably also be more useful than the current labels.

Mockups https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png?ref_type=heads

This also removes the thin CcSystemPage abstract class because it was
only introduced to add the support for dynamic System row subtitle. Now
this abstraction is no longer necessary.

Fixes #2776
2023-12-05 14:07:13 +00:00
Felipe Borges
3a40e95dcf system: Bind Remote Desktop gsetting state to widgets
So that the main switch and the page summary are updated when the
backend changes.

With this, the UI reacts to external calls such as
`grdctl rdp enable`.
2023-11-30 12:38:14 +00:00
Felipe Borges
80d476d9d7 system: Update subtitle of Remote Desktop row earlier
The Remote Desktop page subtitle was updated asynchronously when
the System panel was loaded but after the following steps:

1. Connection established to `org.gnome.SettingsDaemon.Sharing`
(handled on `sharing_proxy_ready`).
2. Then a check whether Remote Desktop is available by watching
the `org.gnome.Mutter.RemoteDesktop` bus name appear.
3. Then we are finally populating the UI (and updating the
subtitle).

Now we bypass the panel initialization and check directly for the
"enable" state of the backend GSetting and the availability of the
gnome-remote-desktop.service, using `is_remote_desktop_enabled()`.

Fixes #2772
2023-11-30 12:38:14 +00:00
Automeris naranja
85403f7563 remote-desktop-page: Add link to instruct how to use remote desktop
As shown in the following mockups:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/remote-desktop/remote-desktop.png

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2045>
2023-11-20 02:43:46 +00:00
Automeris naranja
1d5045a5b8 remote-desktop-page: Add tooltip to copy buttons 2023-11-13 10:28:33 +00:00
Automeris naranja
bbf3e35c4b remote-desktop-page: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-13 10:28:33 +00:00
Felipe Borges
91057652d4 system/remote-desktop: Initialize GCancellable and cancel it page dispose
Fixes #2733
2023-11-13 08:57:07 +00:00
Maximiliano Sandoval R
0ead2414d7 remote-desktop-page: Give pill style to button
Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2000>
2023-11-06 15:20:05 +00:00
Felipe Borges
79f1b84964 system: Show page summaries as row subtitles in the main page
Per mockups in
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/system/system-panel.png

This adds a thin abstract CcSystemPage object with a "summary" property.

Each CcListRow::subtitle is binded to its corresponded
CcSystemPage::summary.

See #2241
2023-11-02 12:15:11 +00:00
Gotam Gorabh
34fcaa0654 system: Add 'Remote Desktop' panel to system panel
See #2241
2023-11-02 12:15:11 +00:00