applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
20206 commits 324 branches 641 tags 195 MiB
Commit graph

551 commits

Author SHA1 Message Date
Robert Ancell
2ee5f1422a printers: Ensure PPD copy is always deleted 2021-02-15 10:34:32 +13:00
Robert Ancell
81392210f2 printers: Add note about callback that passed ownership 2021-02-15 10:34:32 +13:00
Robert Ancell
797c36dc0a printers: Improve memory management of backend list 2021-02-15 10:34:32 +13:00
Robert Ancell
5b086c44e8 printers: Don't pass ownership in get_all_ppds_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
98fd38278a printers: Don't pass ownership in get_ipp_attributes_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
d970ae48b4 printers: Don't pass ownership in get_ppd_names_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
0d913f7283 printers: Remove use of goto 2021-02-15 10:34:32 +13:00
Robert Ancell
cede2f5a81 printers: Use g_autoptr for utility functions 2021-02-15 10:34:32 +13:00
Robert Ancell
005b18f2f1 printers: Make helper functions for callback data 2021-02-15 10:34:32 +13:00
Brandon Nielsen
c239521e9d Change PpPPDSelectionDialog to GtkDialog 
The dialog is now displayed by calling gtk_dialog_run and
gtk_window_set_transient_for in the window displaying the dialog.
Cleanup is handled using gtk_widget_destroy.

Destructors in the windows using the dialog no longer cleanup the dialog
as it is assumed it will be either cleaned up after the response
callback, or handled by the destroy_with_parent property set on the
dialog itself.
 2021-01-08 02:49:32 +00:00
Robert Ancell
6622b39632 printers: Make PpJobRow widget 2020-12-14 09:51:19 +13:00
Robert Ancell
cd070d2e5a printers: Clear up use of gpointer value 2020-12-14 09:51:19 +13:00
Robert Ancell
ae1a37b009 printers: Remove use of gtk_widget_show_all 
It is removed in GTK 4.
 2020-11-26 16:02:57 +00:00
Robert Ancell
ce23d7e0b1 printers: Ensure objects are destroyed when dialog destroyed 2020-11-24 12:31:21 +13:00
Robert Ancell
2c46436636 printers: Remove redundant variable set to NULL 2020-11-24 12:24:38 +13:00
Robert Ancell
5e2e4a55af printers: Cancel adding printer if PPD dialog is cancelled 2020-11-24 12:23:42 +13:00
Robert Ancell
388e59e66a printers: Fix string leaks in new printer dialog 2020-11-24 12:23:42 +13:00
Robert Ancell
7fb336e17b printers: Make printers panel have a smaller minimum width. 
Allow the ink-level to overlap with the buttons.
 2020-11-19 23:24:31 +00:00
Robert Ancell
06eb07bbd6 printers: Remove dead PPD dialog code 2020-11-10 14:47:20 +13:00
Robert Ancell
7bbbef5fde printers: Fix autoptr object not being initialized to NULL. 
Won't cause a problem in this case but should be done for safety.

Introduced in ad226b420c
 2020-11-02 09:25:04 +13:00
Robert Ancell
509beee6dc printers: Fix leak of printer name in callbacks. 
printer_set_ppd_async and printer_set_ppd_file_async copy the printer name, but
this isn't freed in any cases that use these callback (the string isn't even
used at all).
 2020-10-29 23:10:05 +00:00
Robert Ancell
ad226b420c printers: Use g_autoptr with GThread 2020-10-30 11:42:14 +13:00
Robert Ancell
902f90e5ea printers: Add methods for getting printer name and location 
Remove the GObject properties that aren't type safe.
 2020-10-29 20:36:48 +00:00
Marek Kasik
c18875c623 printers: Do not cleanup task after getting bus 
Use g_steal_pointer() on task in get_bus_cb() in pp-printer.c
to not invalidate a pointer passed to a DBus call.
Cleanup the task in callback of the DBus call.
 2020-10-29 20:19:01 +00:00
Robert Ancell
2def271824 printers: Add pp_job_new and associated methods. 
The previous code was leaking a string (job title), used an integer pointer
instead of an integer for an id and requited a lot of memory management for a
string array. There was a lot of boilerplate code required for property
management which was not being used much. This is why type safe methods are a
much better idea than GObject properties. :)
 2020-10-27 13:03:56 +00:00
Brandon Nielsen
9364deba3e Code cleanup as per HACKING. 2020-09-25 01:59:57 +00:00
Brandon Nielsen
68dca0e748 Consumers clean up the PPD list, not the dialog itself. 2020-09-25 01:59:57 +00:00
Brandon Nielsen
bee87f1b0a Spaces over tabs. 2020-09-25 01:59:57 +00:00
Brandon Nielsen
26e8f11566 component: PpPPDSelectionDialog 
G_IS_OBJECT checks fail when calling g_signal_connect_object because
PpPPDSelectionDialog is a struct, not a type descending from G_OBJECT.

This makes the changes required for PpPPDSelectionDialog to be a
GObject, and defines PpPPDSelectionDialog as a GObject. It also updates
consumers of PpPPDSelectionDialog to destroy created PpPPDSelectionDialogs as GObjects.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1126
 2020-09-25 01:59:57 +00:00
Robert Ancell
68042c95c1 printers: Use a shared PpCups object 2020-09-22 21:23:05 +00:00
Robert Ancell
f8204635ce printers: Fix location where GTask is unreffed 2020-09-22 21:23:05 +00:00
Robert Ancell
b25db4f601 printers: Don't pass PpJob references around 
An internal GTask will hold a reference to it for the duration of the async calls.
 2020-09-22 21:23:05 +00:00
Robert Ancell
f42d7cca9a printers: Don't pass PpNewPrinter references around 
An internal GTask will hold a reference to it for the duration of the async calls.
 2020-09-22 21:23:05 +00:00
Robert Ancell
9d0815bb90 printers: Don't pass PpCups references around 
An internal GTask will hold a reference to it for the duration of the async calls.
 2020-09-22 21:23:05 +00:00
Robert Ancell
519c390b04 printers: Don't pass PpHost references around 
An internal GTask will hold a reference to it for the duration of the async calls.

Correctly unref these objects in finalize.
 2020-09-22 21:23:05 +00:00
Robert Ancell
7ebf0f22aa printers: Don't pass PpSamba references around 
An internal GTask will hold a reference to it for the duration of the async calls.
 2020-09-22 21:23:05 +00:00
Robert Ancell
703d833e2f printers: Don't pass PpPrinter references around 
An internal GTask will hold a reference to it for the duration of the async call.
 2020-09-22 21:23:05 +00:00
Robert Ancell
e6a05e535e printers: Fix PpPrinter reference leaks 
They were not unreferenced in the callback.
 2020-09-22 21:23:05 +00:00
Robert Ancell
7c1f84b4d3 printers: Don't pass PpMaintenanceCommand references around 
An internal GTask will hold a reference to it for the duration of the async call.
 2020-09-22 21:23:05 +00:00
Robert Ancell
5f4599d649 printers: Don't pass GFile references around 
An internal GTask will hold a reference to it for the duration of the async call.
 2020-09-22 21:23:04 +00:00
Robert Ancell
f3bf0080d7 printers: Don't pass GDBusConnection references around 
An internal GTask will hold a reference to it for the duration of the async call.
 2020-09-22 21:23:04 +00:00
Robert Ancell
b2c5056031 printers: Use g_autoptr 2020-09-22 21:23:04 +00:00
Robert Ancell
ec23d22ada printers: Use g_clear_object 2020-09-22 21:23:04 +00:00
Robert Ancell
6db24acc49 Replace whitelist/blacklist terms 
For rationale see here:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md#racially-neutral
 2020-07-21 10:41:55 +12:00
Yuri Chornoivan
e7050ab6f4 Fix minor typos 2020-07-20 10:38:09 +03:00
Robert Ancell
bc648d9c92 printers: Replace PpDevicesList with standard GPtrArray 2020-07-20 14:14:44 +12:00
Robert Ancell
958a7766fd printers: Remove unused finalize methods 2020-07-02 16:20:25 +00:00
Robert Ancell
b994237acd printers: Remove unused class members 2020-07-02 16:20:25 +00:00
Robert Ancell
287aee4371 printers: Don't initialize classes members to NULL/0/FALSE 
These are the default values.
 2020-07-02 16:20:25 +00:00
Robert Ancell
99c9186fd8 printers: Fix crash on close 
It was calling g_free on an object and a warning trying to set a NULL object.
 2020-06-30 10:12:55 +00:00