Currently, the previous cc_realm_manager_discover calls are not cancelled
when validating domain field. This might lead to the situation when valid
domain might be mislabeled as invalid and vice versa. Let's simply cancel
the cancellable to avoid this situation.
The `source_object` parameter for the callback functions called from
the `realm_join_as_user` and `real_join_as_admin` resp. `realm_join_as_owner`
functions is not `CC_REALM_OBJECT` type as one would expect, but
`CC_REALM_KERBEROS_MEMBERSHIP` type. Let's modify the code to ensure that
it is `CC_REALM_OBJECT` type.
The implementation is based on the cc-add-user-dialog.c codes, but it is
not a pure copy&paste. It has to be changed to fit the skeleton and reflect
changes from the mockup. I've also tried to simplify the code where possible.
It also fixes some memory leaks.
- Make all buttons as suffix widgets,
which makes unnecessary to wrap them in
a GtkBox that is set as a suffix widget
- Don't set a margin end to the Wi-Fi
icon[1]
- Remove halign from the buttons, because
it isn't necessary
- Remove halign from the buttons, as it
isn't necessary because halign works only
if hexpand is set to TRUE
- Add margin end to the spinner so it
doesn't appear misaligned with the other
widgets at the end of the row
[1] In latest mockups, the margin between
the Wi-Fi icon and network name is also
shorter: cfb7cae4a9
This allows us to open subpages of the "System" panel. The arguments/
parameters are expected to match the panel's subpage tags (as in
AdwNavigationPage.tag).
With this, a future change could reintroduce desktop files for the
subpages, and just change the Exec line to accomodate the new format.
Graphics labels under system details did not have enough padding
between them similar to other labels in the panel
Add a default spacing of 10 to children rows of gtk_box that sets the
graphic rows dynamically to fix the issue
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2916
Commit 90a131a2 (!2164) split off the translation of the sound panel
name "Sound". However, "Sound" might need a unique translation in
this case.
So, add a context string to allow for that.
Closes#2915
Update the "Email" and "Calendars, Contacts, Files" to match the
GOA design for GNOME 46, as "E-mail" and "Calendar, Contacts and
Files", respectively.
See: Teams/Design/settings-mockups!68
In the "File & Link Associations" dialog, a handler
can be removed by clicking on the entire row. However,
this can lead to an accidental handler remove; also,
this behavior isn't present in other rows (from other
panels) that have a remove button.
The calibrator gets a GdkDevice from the GtkGesture but that device is
the "Logical device for $TABLET", not the actual device. So all our
clicks are discarded as coming from the wrong device.
Fix this by passing the GsdDevice through and comparing against that.
Closes#1871
The sandbox_banner title shows "<app_name> is
not sandboxed". However, if the app name is too
long, the banner text will overlap the
CCListRowInfoButton that is inside the banner.
To fix this, remove the app name from the banner
and only show "App is not sandboxed".
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2846
When a Search Provider can be toggled, we show an AdwSwitchRow but
when it can't (disabled) we show a normal row with the "Disable"
suffix. This way we end up with two rows that are very similar and
have the same title and subtitle.
Let's bind the title and subtitles of the "no_search" row to the
"search" row as they are always expected to be identical.
See #2903
The set_background() function changes settings, and even though the
underlying GSettings are set to `delay-apply`, every change still fires
a "changed" callback. This results in many intermediate and
unnecessary calls to on_settings_changed().
Fix this by blocking that callback during the set_background() calls,
and manually doing a single on_settings_changed().
The checkmark indicating the active background based on GtkFlowBox
selection does not work when changing the selection with the arrow keys.
Moreover, it is not set when the panel opens.
We fix this by sending the active CcBackgroundItem to the chooser, so
that it can add an "active-item" CSS class to the true active item.
Fixes#1756#2505
Manually tracking which properties are set on a CcBackgroundItem is only
properly done in the background XML loader. Doing this manually is
error-prone and should instead be done inside the relevant property
setters. That would avoid forgetting to set some of the flags, which is
especially relevant for comparing two background items.
This adds automatic setting of background item flags to fix this.
When colored backgrounds were a thing, these where set with style
G_DESKTOP_BACKGROUND_STYLE_NONE. Presumably, changes to these
backgrounds were stored in a local XML file.
Since the colored backgrounds were removed, let's also remove the code
tracking these colored background changes.
These symbols were soft-renamed in libmalcontent 0.5.0 (released in
February 2020), and we already depend on 0.7.0.
Signed-off-by: Philip Withnall <pwithnall@gnome.org>
After the port to AdwPreferencesPage and the
main switch being moved out from the headerbar,
the content of the sharing dialogs got a bit hidden,
which requires more scrolling.
Fix such issue by removing the height-request
property, so the window height can follow the content
height. Do the same for the Media Sharing dialog
to keep consistency. Also, use the same window width
in both dialogs (to also keep consistency).
Commit c0c357c3 (!2211) moved the "Remote Login" code to the System
panel. There are some leftover bits of code in the sharing panel though.
This cleans that up.
Closes#2895
Sorting providers and accounts by features flags makes it difficult to
thme how we like, so hard-code the sorting order based on the
non-localized provider name.
