The Search panel providers listbox has a placeholder label that is
visible when there are no listbox items.
The placeholder label is being considered in the list of children
of the listbox while estimating whether "Moving down" is allowed for
the listbox reorder feature.
The current placeholder that appears when no
providers are available has some problems:
- The row is activatable, but this is unnecessary
- The row has no padding
- The "No Apps Found" string doesn't use header
capitalization
Fix this by using a GtkListBox placeholder widget, with
margins and with header capitalization in the string.
Using the systemd-hostnamed chassis-type to detect when running on
"tablet", "handset", or "watch" and setting a more reasonable list
of suspend time options for them.
As discussed in #2870 the current way of displaying insensitve rows when
no apps are availbe to handle a mime type is confusing.
Fix this by showing a "No Apps Available" label in the aforementioned case.
Fixes#2870
Let's manually wire the row activation to the panel creation so that
we can create panels on demand.
This also makes calls to subpages directly avoid initializing the
other panels.
Fixes#2857
I'm no longer engaged enough to be a maintainer so it's best to make that clear.
Still happy to review and be involved if others need it!
This is a great project and if you want to be more involved in GNOME I'd recommend it.
At init it will verify whether the panel can be constructed in the
check_desktop_sharing_available call, and with that hide/show the
panel accordingly.
Fixes#2955
Now that we match against all words in the query, if any of them matches
with a row it is "found".
However, it is more useful if all of the words must match, as narrowing
down the results is much quicker that way.
Splitting the search query on spaces results in empty strings if there
are double spaces in the query. These would always match.
Therefore, do not do anything with empty search words.
A crash possibility has been fixed in libgnome-volume-control!25.
A similar crash was reported on the Settings side, so update to the
latest gvc commit to hopefully prevent further crashes.
Related: gnome-shell#7173
Related: #2924
Unfortunately I sneaked in a move of the gvc_mixer_control_open() call from
earlier in the function to the end of the function with commit 2152899354.
That change didn't actually move the call though, but introduced a second
call instead, leading to a critical error on opening of the sound panel.
Fix it by removing the first call to gvc_mixer_control_open() and keeping
the second one around. We want to keep the second one instead of the earlier
one because the signal handlers should be connected before we initialize gvc
and it connects to pulse, emitting all the input/output-added signals etc.
The reason why this wasn't broken before was likely because the connection
to pulse happens async, and therefore the initial emission of the signals
would effectively still have happened after we connected our handlers.
Fwiw, calling gvc_mixer_control_open() after
cc_volume_slider_set_mixer_control(), cc_subwoofer_slider_set_mixer_control()
and cc_device_combo_box_set_mixer_control() is not a problem, as those
functions all call into gvc to get static values (and as explained above,
at this point gvc wouldn't have established connection to pulse anyway).
Reported-by: Matthijs Velsink <mvelsink@gnome.org>
Fixes: 2152899354 ("sound: Listen to signals from GvcMixerControl only in sound panel")
Each page had its AdwNavigationPage tag updated in [1],
but the tags in the Privacy panel main page weren't
updated, which made all the subpages fail to open.
[1] 917248d7bf
