Commit graph

73 commits

Author SHA1 Message Date
Maksym Hazevych
e00f773b2f Remove unnecessary visibility change 2023-03-29 14:26:55 +13:00
Maksym Hazevych
d831e5cb48 Replace all occurrences of 'gtk_widget_show'
Replace all occurrences of 'gtk_widget_show(smth)' with
'gtk_widget_set_visible(smth, TRUE)'.
2023-03-29 14:26:55 +13:00
Georges Basile Stavracas Neto
59bdf81028 common: Port to GTK4
This is only the bare minimum to make everything under panels/common
build. Since these widgets are used by the main window, port them
first.

CcTimeEntry was particularly hard to port. That's because GtkEntry
is a final class now. Overall, though, I'm happy with how it turned
out to be - much cleaner, less code, more obvious.
2021-12-14 22:34:21 -03:00
Robert Ancell
e50de0def6 common: Use self variable name for CcLanguageChooser 2021-02-01 04:02:22 +00:00
Robert Ancell
d7c8ecee60 common: Move CcLanguageChooser signal handlers into GtkBuilder 2021-02-01 04:02:22 +00:00
Robert Ancell
c7d2b0945d common: Consolidate CcLanguageChooser functions 2021-02-01 04:02:22 +00:00
Robert Ancell
7b07b5d060 common: Use widget types for CcLanguageChooser 2021-02-01 04:02:22 +00:00
Robert Ancell
878f5191db common: Move CcLanguageChooser more row into GtkBuilder 2021-02-01 04:02:22 +00:00
Robert Ancell
35ef98806b common: Move CcLanguageChooser language placeholder widget into GtkBuilder 2021-02-01 04:02:22 +00:00
Robert Ancell
4fb52c8496 common: Split out CcLanguageRow from CcLanguageChooser 2021-02-01 04:02:22 +00:00
Gunnar Hjalmarsson
5aee280a29 common: Display locale @modifiers properly
Fixes GNOME/gnome-desktop#50
2020-09-21 13:13:10 +00:00
Adrien Plazas
9e2a2836d9 Use GtkDialog instead of HdyDialog
HdyDialog has been dropped in libhandy 1.
2020-07-20 08:04:28 +02:00
Robert Ancell
f1b84e29ef common: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Mohammed Sadiq
23a7401467 language-chooser: Port to HdyDialog
so that it works well on small screens
2019-09-09 22:14:18 +00:00
Robert Ancell
e85816f83b common: Fix crash in language chooser
A report in Red Hat bugzilla [1] shows for some reason the country is set to
NULL and this causes a crash when comparing against search terms. The solution
is to handle the NULL without crashing.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1685251
2019-03-26 22:02:32 +00:00
Robert Ancell
f649308f1f common: Fix ... row not showing in language chooser
Broken in 67a9f47464
2018-11-12 20:33:05 +00:00
Robert Ancell
700b857ab8 common: Fix language chooser showing all languages as checked
If the language chooser was created and a language not set all the
checks are shown beside each entry. Solved by hiding these checks
by default.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/250
2018-10-26 16:59:04 +13:00
Robert Ancell
67a9f47464 common: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-11 22:21:34 +00:00
Robert Ancell
b2cd50019f common: Change language chooser layout to match design
Have the language name on the left and the country on the right dimmed as per:
https://wiki.gnome.org/Design/SystemSettings/RegionAndLanguage
2018-09-17 16:32:52 +00:00
Robert Ancell
a2401d8f9a common: Update language chooser dialog title and buttons to match design
Update to use "Select Language" and "Select" as per:
https://wiki.gnome.org/Design/SystemSettings/RegionAndLanguage
2018-09-14 15:18:42 +00:00
Robert Ancell
8af63dc40a common: Disable language chooser confirm button until a language is selected
Make the button insenstive until a language is chosen as per:
https://wiki.gnome.org/Design/SystemSettings/RegionAndLanguage
2018-08-27 18:33:52 +00:00
Robert Ancell
828024e225 common: Make language chooser dialog match design
Update the chooser to:

* Use a search bar at the top of the dialog, not the bottom
* Have a larger window
* Remove space from around listbox

https://wiki.gnome.org/Design/SystemSettings/RegionAndLanguage

Merges !129
2018-07-22 09:54:21 -03:00
Robert Ancell
148e4c8fd0 common: Use GtkTemplate for the language chooser dialog 2018-07-18 22:39:32 +00:00
Robert Ancell
65c43b4fac common: Fix missing reference
Was introduced in 86d1d30
2018-07-02 21:11:42 +00:00
Robert Ancell
86d1d30c63 common: Use g_auto for variables 2018-06-07 01:08:07 +00:00
Gunnar Hjalmarsson
0bd90ca34b region: Show scrollbars if needed
If we are initially showing more entries than can be fit, we should
scroll then too rather than deciding in code when to do this.

https://bugzilla.gnome.org/show_bug.cgi?id=793861
2018-05-31 12:36:54 +12:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Rui Matos
ae7b1a97eb common: Tick an unselected row when enter is pressed
This makes the dialog easier to use via keyboard navigation since
otherwise we would just dismiss the dialog with the current selection
on enter when the user actually intended to change the selection.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Rui Matos
32653a0a65 common: Dismiss dialog if the activated row was already ticked
This makes the dialog a bit friendlier to use.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Ondrej Holy
e9af927e5f cc-language-chooser: remove deprecated GtkMisc 2014-11-20 11:32:33 +01:00
Ondrej Holy
066d66383e cc-language-chooser: Reset dialog to original state when used the 2nd time
The language chooser dialog is used in the users panel repeatedly.
When we click to show more languages and/or select language, close
the dialog and show it again e.g. for different user, the chooser
isn't in an original state. So filter entry isn't hidden (and all
languages are shown) and/or the last selected language is focused.
But the dialog should be in the original state when it is open.

This patch changes cc_language_chooser_clear_filter to clear the
dialog into the original state that we can reuse the dialog later.

https://bugzilla.gnome.org/show_bug.cgi?id=738077
2014-10-15 16:26:16 +02:00
Bastien Nocera
e722599ac7 common: Use new listbox helpers
https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-24 11:35:30 +02:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Yosef Or Boczko
bd1422980b common: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:29:53 +02:00
Jasper St. Pierre
2f1d233a64 language-chooser: Remove unneeded variables 2013-08-02 09:24:45 -04:00
Jasper St. Pierre
2d1f1e8131 language-chooser: Fix code style 2013-08-02 09:24:36 -04:00
Bastien Nocera
36ad07fdc7 common: Use new delayed search entry API
https://bugzilla.gnome.org/show_bug.cgi?id=705151
2013-07-30 16:57:34 +02:00
Alexander Larsson
a07825a58e language-chooser: Convert to GtkListBox
https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-07-02 16:19:09 +01:00
Rui Matos
260a739eb8 language-chooser: Fix a compiler warning 2013-05-27 17:43:03 +02:00
Rui Matos
fe85605180 Revert "language-chooser: Add separators between choices"
This reverts commit d3faf9cf8a.
2013-05-27 17:33:34 +02:00
Rui Matos
6183b09d86 language-chooser: Fix previous commit
Commit 2d3ed3468a moved code around but
introduced an older version which doesn't quite work.
2013-05-27 17:31:34 +02:00
Jasper St. Pierre
2d3ed3468a language-chooser: Rearrange code
This will make the diff to the new chooser less mysterious
2013-05-22 16:23:19 -04:00
Jasper St. Pierre
d3faf9cf8a language-chooser: Add separators between choices 2013-05-22 16:23:19 -04:00
Rui Matos
7c341ed630 common: Keep language chooser labels centered
In order to prevent the labels from moving around when hiding and
showing the check mark we need to keep the check mark always visible
and instead tweak its opacity.

We also add an always transparent widget the same size as the check
mark on the other side of the label to make sure that the label is
globally centered.

https://bugzilla.gnome.org/show_bug.cgi?id=695536
2013-04-15 11:53:27 +02:00
Rui Matos
998b662d60 common: Fix language chooser check marks being cleared
https://bugzilla.gnome.org/show_bug.cgi?id=695536
2013-04-15 11:53:27 +02:00
Rui Matos
d7cecdca2f region: Use view-more-symbolic for the "More" list item
We've had some early reports that the ellipsis used to label the
"More" item in some of the lists isn't clear.

https://bugzilla.gnome.org/show_bug.cgi?id=694927
2013-04-15 11:53:27 +02:00
Rui Matos
e1c563d38b common: Add separators to the language chooser list
https://bugzilla.gnome.org/show_bug.cgi?id=695465
2013-04-15 11:53:27 +02:00
William Jon McCann
3d5b6fd2bc common: Fix language chooser to be centered
https://bugzilla.gnome.org/show_bug.cgi?id=694323
2013-02-26 15:07:43 +01:00
Rui Matos
ef4576b4f4 Check gtk_builder_add_from_resource() return value 2013-02-19 12:25:56 +01:00
Rui Matos
bc3307b492 Prevent potential segfault 2013-02-19 12:25:56 +01:00