Commit graph

4757 commits

Author SHA1 Message Date
Rui Matos
2556fd5e2c sharing: Make use of the cancellable for async hostname calls
We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.

https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
94045b8418 sharing: Remove an unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
f959b9127b sharing: Make panel initialization asynchronous
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
58bad723ee sharing: Show the networks widget in the screen sharing dialog
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 19:26:58 +02:00
Jonas Ådahl
ecb0e6dd23 sharing: Add Wayland screen sharing support
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.

So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 18:55:42 +02:00
Rui Matos
99f26e4d0b search: Set a minimum height to avoid toplevel being resized too small 2017-08-28 18:58:05 +02:00
Jonathan Kang
a108ee19b9 search: don't allow horizontal scrolling
Set hscrollbar_policy property of GtkScrolledWindow to never to
disable horizontal scrolling.

https://bugzilla.gnome.org/show_bug.cgi?id=785397
2017-08-28 18:58:05 +02:00
Rui Matos
23d5ea29aa display: Round the displayed scale values logically
Mutter currently generates 4 scales per integer scale. Knowing that,
we can nicely "round" the values we display to what the ideal scales
are even though the real values might be skewed since mutter creates
scale values close to the ideal ones that yield integer logical sizes.

https://bugzilla.gnome.org/show_bug.cgi?id=786922
2017-08-28 18:58:05 +02:00
Rui Matos
bbccf27488 display: Simplify scale filtering
This is prone to miss intermediate values that users might actually
want to use so, for now, just show the 5 first scales.
2017-08-28 18:58:05 +02:00
Rui Matos
a4a243cee4 display: Round scaled logical monitor sizes the same way mutter does
Mutter uses round() while we are just truncating via the implicit
double -> int type conversion, meaning that mutter will reject some
configurations that should work. Fix that by using the same rounding
as mutter.

https://bugzilla.gnome.org/show_bug.cgi?id=786919
2017-08-28 18:58:05 +02:00
Rui Matos
5622704b74 info: Avoid a crash when we're cancelled
If we're cancelled, the panel is being finalized so return immediately
instead of iterating further and crashing.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Rui Matos
6ee793118a info: Don't leak GUnixMountEntry instances if we're cancelled
If we're cancelled the mount entries list might not have been totally
consumed so free it on finalize if needed.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Rui Matos
546752f79e info: Don't leak GCancellables
We were just plainly leaking them and there's really no need since
GCancellable instances can be re-used.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Alexandre Franke
9db096e6e6 Add translator comment 2017-08-27 14:19:50 +02:00
Rui Matos
7ed4efef50 display: Show refresh rates with two digits after the radix
One digit isn't enough to distinguish between some modes. We probably
should do better mode filtering and/or grouping but that needs to
happen in mutter.
2017-08-25 16:49:02 +02:00
Rui Matos
6a9274a165 display: Don't show inactive monitors in the arrangement widget
Inactive monitors are not part of the configuration global geometry,
i.e. they don't have a position set, so it doesn't make sense to show
them.
2017-08-25 16:49:02 +02:00
Rui Matos
dae238cc5f display: Avoid crashing when a monitor doesn't have a mode set
In this case just avoid showing information we don't have.
2017-08-25 16:49:02 +02:00
Rui Matos
337802315c display: Ensure we generate the UI initially on two output mode
We rely on visible-child-name notifications to generate the
appropriate UI, unfortunately it doesn't happen for the first added
stack page if the widget is already visible. Work around this by
adding a dummy page first.
2017-08-25 16:49:02 +02:00
Rui Matos
6c4eb9fc86 display: Fix the two output UI to start with the current configuration
gtk_stack_set_visible_child_name() doesn't actually make a child
visible if the child widget isn't visible already which means we'd
always start in the first ("join") stack page even if the currently
applied configuration is one of the others.

https://bugzilla.gnome.org/show_bug.cgi?id=786767
2017-08-25 15:17:12 +02:00
Felipe Borges
c776ab1808 printers: Apply the vertical spacing standard
Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Felipe Borges
6a6f4b71d9 printers: Wrap GtkListBox inside a GtkBox
In order to vertically align the printers panel content by the
same standards as the other panels, we should set the GtkListBox
top and bottom margins to 32px.

This commit wraps GtkListBox inside a GtkBox to handle the Gtk+
issues discussed in Bug 773459 regarding the background of ListBox
margins.

This commit can be cleanly reverted once the issue is fixed in
Gtk+.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Rui Matos
57a82a89cd display: Cancel pending changes on Escape key press 2017-08-23 18:32:28 +02:00
Rui Matos
566d2cf6ac display: Add mnemonics to Cancel and Apply buttons 2017-08-23 18:32:28 +02:00
Rui Matos
a8071322a7 display: Move scale row above refresh rate
It's a bit closer to the mockups, in spirit at least.
2017-08-23 18:32:28 +02:00
Rui Matos
566b0c137c display: Make rows created for a new current output be the same size
We need the rows size group to exist when creating output UIs.
2017-08-23 18:32:27 +02:00
Rui Matos
0a0ac31b51 display: Handle lid being closed a bit better
If the lid is closed we shouldn't allow the builtin display to be
configured.
2017-08-23 18:32:27 +02:00
Rui Matos
088f35617c display: Make scale row be the same height as others 2017-08-23 18:32:27 +02:00
Georges Basile Stavracas Neto
4922f370fb network: Update NetDeviceSimple layout
Following the previous commit, this patch adapts the
NetDeviceSimple layout to be consistent with the other
devices in the Network panel.

This is, however, a temporary solution, for simple devices
will be handled in a separate panel in the future.

https://bugzilla.gnome.org/show_bug.cgi?id=786662
2017-08-23 15:15:52 +02:00
Georges Basile Stavracas Neto
d5de1d2b3c network: Show simple devices in an isolated section
As a temporary solution until we don't have the Mobile Broadband
panel, the Network panel should take care of simple devices such
as Bluetooth and metered connections, and should do so in such a
way that is consistent with how the rest of devices is managed.

Currently, however, NetDeviceSimple objects still present the old,
grid-based layout, breaking the expectations and completely destroying
the consistency of the panel

This patch moves simple devices to a section of its own. The next
patch will update the visuals to match the other devices.

https://bugzilla.gnome.org/show_bug.cgi?id=786662
2017-08-23 15:15:52 +02:00
Exalm
1e82b65674 wifi: Fix title centering
The stack switcher shown for multiple wireless devices can
have arbitrarily large width, so it can shift the title to
to the left. Setting hhomogenous to False prevents this

https://bugzilla.gnome.org/show_bug.cgi?id=786410
2017-08-23 14:40:24 +02:00
Rui Matos
535c5d1fa2 printers: Disconnect the search bar from the shell's key-press-event
Using g_connect_object() ensures the disconnection happens when the
search bar is finalized.

https://bugzilla.gnome.org/show_bug.cgi?id=786603
2017-08-23 14:30:20 +02:00
Felipe Borges
272bad14a0 printers: The scrolled window should vertically expand
In the new Shell the Printers panel scrolled window doesn't
necessarily fills the whole vertical space available.

https://bugzilla.gnome.org/show_bug.cgi?id=786674
2017-08-23 11:08:02 +02:00
Piotr Drąg
847f29c844 Update Polish translation 2017-08-23 03:57:27 +02:00
Piotr Drąg
fd9a646ff5 info: Correct translator comments 2017-08-23 03:27:51 +02:00
Rui Matos
e5a1afee9c display: Fix a crash when opening the panel with the lid closed
The configuration manager might not be ready yet when we're called
from the lid state monitor handler. Don't do anything in that case.

https://bugzilla.gnome.org/show_bug.cgi?id=786080
2017-08-22 19:26:39 +02:00
Rui Matos
ef0cbf45f3 display: Make arrangement and scale rows non-activatable 2017-08-22 19:21:41 +02:00
Rui Matos
47919bcfb1 display: Fix underscanning switch [de]activating the output instead 2017-08-22 19:21:41 +02:00
Rui Matos
7c7c0b75d5 display: Switch to a toggle buttons design for scale
The slider design wasn't fit for this since we allow only a finite set
of scales.
2017-08-22 19:21:41 +02:00
Rui Matos
c50062a48b display: Update the two display mode switcher design
This makes us follow the updated design mockups more closely.
2017-08-22 19:21:41 +02:00
Rui Matos
90cf23a70a display: Redraw the arrangement area widget when outputs change
This ensures the arrangement area always reflects the current
changes.
2017-08-22 19:21:41 +02:00
Rui Matos
e4dc2995a3 display: Add a signal for scale changes
This will allows other bits of the UI to monitor scale changes.
2017-08-22 19:21:41 +02:00
Rui Matos
52d61d52b2 display: Force content to always have a fixed minimum width
This makes switching between configurations and/or active monitor look
a bit more polished.
2017-08-21 14:47:17 +02:00
Rui Matos
d0ca7e0abc display/config-manager-dbus: Clear the current state on error
This ensures that the higher levels notice that there was an error and
show the appropriate UI instead of showing the previous state.
2017-08-21 14:47:17 +02:00
Rui Matos
93a3bbe0fc display: Remove a few no longer needed variables
These are not needed since last commit.
2017-08-21 14:47:17 +02:00
Jonas Ådahl
ff30244c5c panels/display: Remove support for old config system
As mutter now has removed the legacy monitor config system and the
associated property on org.gnome.Mutter.DisplayConfig, also remove the
support from gnome-control-center.

https://bugzilla.gnome.org/show_bug.cgi?id=777732
2017-08-21 12:33:38 +08:00
Allan Day
87568e9250 Harmonize list box row layouts
While it isn't possible, or even advisable, to make all the list
box rows the same height, using a number of standard heights will
make the control center feel more harmoneous.

Adust the height of the list box rows in Color, Date & Time,
Mouse & Touchpad, Network, Privacy, Region & Language, Sharing
and Universal Access. Makes standard rows that contain labels
and/or controls 58px tall. Some other rows, such as those which
contain two lines of text, are allowed to be taller.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:48 +02:00
Allan Day
8a8e53ab8a Standardize vertical spacing of panels
Ensure that the vertical spacing inside each panel is similar.
This makes the transition between each panel smoother and makes
the control center feel more cohesive.

Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

Bluetooth, displays and printers are not addressed.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:42 +02:00
Allan Day
c7fea8894f Give search and notifications consistent row layouts
The search and notification panels have similar list rows,
as they both list applications. This gives the list rows more
consistent layouts - application icons are made to be 32px
throughout and row heights are made to be the same.

Note that the row widths are unfortunately still different.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:23 +02:00
Georges Basile Stavracas Neto
a9bf8b5b04 online-accounts: Fix parameter parsing
The Online Accounts panel supports two commands: 'add'
and 'show-account'. The 'add' command must receive an
additional parameter, the 'provider' name, and an
optional 'preseed' parameter.

In the past, Settings would just push all the parameters
to a GVariant and pass to the panels. Now, however, it
skips the first one, making the parameter parsing code
in Online Accounts panel wrong.

This patch fix that by refactoring add_account() code,
and fixing the GVariant parameter parsing.
2017-08-19 11:31:18 -03:00
Scott Cohen
87c69ed955 network: Fix typo in error message
Replaced "conneciton" with "connection" (both without quotes) in
panels/network/connection-editor/net-connection-editor.c:860.

https://bugzilla.gnome.org/show_bug.cgi?id=785100
2017-08-18 11:36:21 -03:00