We also remove support for WiMAX (now unsupported by NetworkManager),
and InfiniBand (Enterprise feature), and the use of
the deprecated NM_SETTING_WIRELESS_SEC property.
With help from network-manager-applet patches by Jiří Klimeš and
Dan Winship.
https://bugzilla.gnome.org/show_bug.cgi?id=765910
Currently, if firewalld is not running, then the firewall zone combo is
always insensitive. This would make sense if firewalld was great and we
were to consider it a distro bug to not have firewalld running and
enabled, then users would be able to see the option is disabled and
think "maybe my distro has done something wrong."
But in actuality, firewalld is not really great, only Fedora ships it
and we're not really recommending it to other distros. So hide the combo
if it's not running, else it's just broken on $NOTFEDORA.
https://bugzilla.gnome.org/show_bug.cgi?id=763477
Since LIBDIR of gnome-control-center and the VPN plugins aren't
necessarily the same, use the paths as specified by the VPN plugins and
only reconstruct the path if it is not absolute or we fail to load the
plugin.
Patch from Debian package, by Michael Biebl <biebl@debian.org>
https://bugzilla.gnome.org/show_bug.cgi?id=764509
It doesn't make sense to try to validate pages because widgets are
changing due to the whole dialog being destroyed and it causes a bunch
of warnings because some resources are cleared on each page dispose
method.
Avoid all that by disconnecting the page "changed" signal handler
before we start destroying widgets.
We don't need secrets for new connections and, in fact, trying to
retrieve secrets in that case will fail because we have a plain
NMConnection instead of a NMRemoteConnection.
The above mentioned error would result in the page never being
initialized.
From coverity:
gnome-control-center-3.14.5/panels/network/connection-editor/firewall-helpers.c:75:9: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [enabled by default]
https://bugzilla.gnome.org/show_bug.cgi?id=749897
When switching from a particular IPv4 or IPv6 "addresses" method to
another, make sure that "address", "DNS" and "routes" are applied or
ignored depending on that method's capabilities.
For example, when switching from manual to automatic IPv4 "addresses"
method, we need to make sure that the old IP address, gateway, etc.
aren't actually used in the new setting.
https://bugzilla.gnome.org/show_bug.cgi?id=734337
The call to nm_setting_connection_get_zone() returns a pointer to
memory that will be freed before the D-Bus reply handler is called.
Make sure to take a copy of the string, and free it when finished.
https://bugzilla.gnome.org/show_bug.cgi?id=739971
The previous code would stop validating when an error occurred which
meant that when a page contained multiple errors, only the first one(s)
to be checked would appear in red.
Now, all the errors will appear in red.
https://bugzilla.gnome.org/show_bug.cgi?id=734472
When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.
This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.
https://bugzilla.gnome.org/show_bug.cgi?id=734446
g_warning() is for environment errors, not user errors. Not being
able to click OK is enough to understand that something is wrong,
and if not we should highlight the faulty setting, not spam the logs,
expecially in the middle of digitation. Keep a log anyway, for
debugging.
https://bugzilla.gnome.org/show_bug.cgi?id=724312
The connection editor connects to permission-changed on its NMClient,
but didn't disconnect from that signal when dropping the NMClient
reference in finalize.
https://bugzilla.gnome.org/show_bug.cgi?id=700989
The connection editor window is shown before all of its pages are
initialized, causing it to jump when it gets its final size. Avoid
that by not showing it before it is ready.
https://bugzilla.gnome.org/show_bug.cgi?id=693781
Disable the type-ahead search in the connection editor, the
number of items, and their positional stability means that
a search feature isn't warranted.
As a precaution, also check the success of
gtk_tree_selection_get_selected() to avoid crashes.
https://bugzilla.gnome.org/show_bug.cgi?id=693685
When this got rewritten to be different from nm-connection-editor's,
some of the ce_page_changed() calls accidentally got dropped, so
certain changes on these pages would not cause the "Apply" button to
become sensitive.
https://bugzilla.gnome.org/show_bug.cgi?id=693659
