While it isn't possible, or even advisable, to make all the list
box rows the same height, using a number of standard heights will
make the control center feel more harmoneous.
Adust the height of the list box rows in Color, Date & Time,
Mouse & Touchpad, Network, Privacy, Region & Language, Sharing
and Universal Access. Makes standard rows that contain labels
and/or controls 58px tall. Some other rows, such as those which
contain two lines of text, are allowed to be taller.
https://bugzilla.gnome.org/show_bug.cgi?id=786384
According to the lastest mockups [1], the Proxy section is now
composed of a row with the state of the proxy, and a settings
button that leads to a dialog where one can configure the different
proxy settings.
This commit ports the current code to do that, and various changes
took place to made this happen. Namely:
* A new ProxyMode enum was added to improve readability and
improve the semantic of the code. No more random numbers
are present.
* The current widgets for editing proxy settings were repacked
into a GtkStack (so that we keep an homogeneous sizing), and
the GtkStack itself was moved into a new dialog. With that,
we can just set the stack page, rather than controlling the
visibility of all individual widgets.
* Many unused widgets were removed.
* The combo box was replaced by 3 radio buttons. Now, there's
no need to deal with GtkTreeIters anymore. Another refactoring
of the code that led to more readable and smaller code.
Overall, these changes made the code be more readable, smaller
codebase with a smaller surface for mistakes.
https://bugzilla.gnome.org/show_bug.cgi?id=785581
If you click the sections in the left side treeview, some of the
elements in the right page headers will move a couple of pixels.
Also, since the WPAD warning label was always visible, the alignment of
the controls section in the Proxy page was suboptimal.
https://bugzilla.gnome.org/show_bug.cgi?id=693357
In bug 689638, the designers only asked for the list icons
to be symbolic, not the big icons in the page headings. The
current code was failing on both ends: virtual devices like
vlan still had non-symbolic icons in the list, and several
pages (e.g mobile and proxy) had symbolic icons in the headings.
https://bugzilla.gnome.org/show_bug.cgi?id=693001
This is consistent with the guideline to use symbolic icons for
classes and reserve full color icons for "things" like apps, people,
documents, pages, etc.
It is also consistent with how these devices are displayed in the
network menu, notifications, and dialogs.
https://bugzilla.gnome.org/show_bug.cgi?id=689638
A source file with 4k lines of code is not understandable, and the glade file
was becoming quite a challenge for glade.
To add more features we need to split things up just to keep them maintainable.
This is the first patch that just splits out the proxy bits. Other device types
will follow in the next few days.
