Commit graph

3948 commits

Author SHA1 Message Date
Dave Airlie
3d8cd197c9 display: Use correctly typed pointer
We already assign list->data to output.

https://bugzilla.gnome.org/show_bug.cgi?id=750312
2015-06-15 16:18:33 +02:00
Dave Airlie
4c7189d1b4 display: Refactor get_geometry helper
This moves the two functions to the top of the file, changes the
get_geometry to return x/y if requested, and refactors the callers to
use it.

It also refactors some code that open coded the same basic code.

https://bugzilla.gnome.org/show_bug.cgi?id=750312
2015-06-15 16:16:16 +02:00
Marek Kasik
b5b421288c printers: Fix setting of page size
Set 'PageSize' instead of 'media' for new printers since we use PPD
for construction of the combo for selecting of default paper size.
Previously, we've been setting 'media' attribute for new printers.
Attribute 'media' is used by IPP but we set paper size using 'PageSize'
which comes from PPD in the options dialog. Sometimes (quite often) IPP
gets priority over PPD in print systems. Therefore there was inconsistency
of what user set as default paper size on the options dialog and what was used.

Also don't mark IPP and user's local options as default in PpPPDOptionWidget
since it should use just PPD (we can change PPD values only in this widget).
Since we use PPD for setting of paper size in the options dialog, we shouldn't
show a value which user does not change actually (IPP's 'media' vs. PPD's
'PageSize').

https://bugzilla.gnome.org/show_bug.cgi?id=748569
2015-06-12 16:23:45 +02:00
Marek Kasik
80dce1ee4c printers: Remove unused function
Function printer_set_default_media_size() is not used anywhere
in Printer panel.

https://bugzilla.gnome.org/show_bug.cgi?id=748569
2015-06-12 16:23:42 +02:00
Bastien Nocera
99d675856a network: Fix all Wi-Fi networks having gear buttons
Only the networks with existing connection should have gear buttons.
This is a regression from 9ffaff7472.

If the widget we add as a stack page isn't visible, the page will not be
shown. As we later add another page with that button, we'd end up
showing that by default.

https://bugzilla.gnome.org/show_bug.cgi?id=750841
2015-06-12 15:40:48 +02:00
Marek Kasik
da9b74061f printers: Install selected printer when the row is activated
Allow user to install printer by activating a row with a found device.

https://bugzilla.gnome.org/show_bug.cgi?id=748206
2015-06-10 11:35:04 +02:00
Marek Kasik
7672eddec9 printers: Fix focus chain of the 'New printer dialog'
Disable 'can-focus' for widgets which don't need that
in the 'New printer dialog'.

https://bugzilla.gnome.org/show_bug.cgi?id=748206
2015-06-10 11:35:01 +02:00
Marek Kasik
bfd6423dc9 printers: Set focus of the 'New printer dialog' correctly
Show the 'New printer dialog' after setting transient parent for it
so that the warning about missing transient parent is not shown
to the user and the dialog is correctly focused.

https://bugzilla.gnome.org/show_bug.cgi?id=748206
2015-06-10 11:34:57 +02:00
Martin Hatina
7b6b3aac39 printers: Fix possible crash after closing the panel
Disconnect on_lockdown_settings_changed and on_permission_changed signals
when printers panels is being disposed, so they won't get called after panel
no longer exists.

https://bugzilla.redhat.com/show_bug.cgi?id=1218003
https://bugzilla.gnome.org/show_bug.cgi?id=750019
2015-06-09 14:35:01 +02:00
Bastien Nocera
b6d7bb856d display: Don't show rotation for builtin display on tablets
If there's an accelerometer builtin to the display, don't show the
rotation buttons, it will be handled by the user rotating the display,
eventually with the rotation lock in use.

https://bugzilla.gnome.org/show_bug.cgi?id=750410
2015-06-08 15:07:56 +02:00
Bastien Nocera
f31c3b16c7 power: Describe batteries properly when not called BAT0
When the main battery isn't called BAT0, as happens on a dual-battery,
convertible Toshiba laptop, we would tag both batteries as "Extra". Mark
the first one as being the main battery.

In the longer-term, we'll have UPower exporting the exact information
about which is in the "dock" and which is in the same package as the
processing unit, when the kernel exports it.
See https://bugzilla.kernel.org/show_bug.cgi?id=97841

https://bugzilla.gnome.org/show_bug.cgi?id=748592
2015-06-04 18:32:07 +02:00
Bastien Nocera
9134fe0239 power: Remove unused variables
Follow-up to commit 008d7c1468, a number
of variables ended up being unused, so remove them.
2015-06-01 14:47:32 +01:00
Rui Matos
c42f7d2d91 network: Prevent a use after free crash when removing virtual devices
When a virtual device is removed and the instance gets finalized we're
not disconnecting from the real NMDevice's notify signal and thus end
up crashing when the signal fires afterwards.

Avoid that by using g_signal_connect_object() so that when we're
finalized the disconnection happens automatically.

https://bugzilla.gnome.org/show_bug.cgi?id=749972
2015-05-27 17:36:01 +02:00
Bastien Nocera
3b283b78b0 network: Fix freeing const pointer
From coverity:
gnome-control-center-3.14.5/panels/network/connection-editor/firewall-helpers.c:75:9: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [enabled by default]

https://bugzilla.gnome.org/show_bug.cgi?id=749897
2015-05-27 11:06:02 +02:00
Bastien Nocera
3569b2d289 network: Fix gtk_tree_model_get_iter_first() retval
And don't select the first item when removing the item fails.

https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Bastien Nocera
93414609fa user-accounts: Fix gtk_tree_model_get_iter_first() retval
https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Bastien Nocera
b410ec353c sound: Fix gtk_tree_model_get_iter_first() retval
https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Bastien Nocera
71de309ff2 keyboard: Fix gtk_tree_model_get_iter_first() retval
https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Bastien Nocera
41bb1a6ff2 common: Fix gtk_tree_model_get_iter_first() retval
https://bugzilla.gnome.org/show_bug.cgi?id=749892
2015-05-27 11:06:02 +02:00
Matthias Clasen
0622883025 network: Follow through on the original design
GTK+ can now do circular buttons with ease, so make
this page a little more fancy by following the original
design.

https://bugzilla.gnome.org/show_bug.cgi?id=745703
2015-05-23 11:57:30 -04:00
Matthias Clasen
2093f6c7ea network: Move firewall zone to security
This is where people expect it (whether that is correct or not).

https://bugzilla.gnome.org/show_bug.cgi?id=745702
2015-05-23 11:57:19 -04:00
Richard Hughes
63ca2fd1b8 power: Add support for dimming using an ambient light sensor 2015-05-22 14:22:58 +01:00
Bastien Nocera
008d7c1468 power: Remove "When battery power is critical" label
With UPower 1.0, the critical action to take when the battery level
is too low isn't in the hands of the user anymore, but in the hands
of the system.

It's now handled by UPower directly, through the CriticalPowerAction
configuration option. Instead of asking logind whether the system
supports hibernation, remove the action label altogether.

https://bugzilla.gnome.org/show_bug.cgi?id=749436
2015-05-18 14:47:20 +02:00
Christophe Fergeau
5f7ee29a44 keyboard: Honor immutable command/name in custom commands
If the gsettings key for the command or name of a custom shortcut is not
writable, the keyboard panel still lets you edit them. This commits
makes the corresponding widgets unsensitive when the gsettings key is
not writable.

https://bugzilla.gnome.org/show_bug.cgi?id=749381
2015-05-15 19:44:00 +02:00
Christophe Fergeau
4257d8723d keyboard: Remove unused CcKeyboardItem::group
The BindingGroupType is stored in the section tree model instead.

https://bugzilla.gnome.org/show_bug.cgi?id=749381
2015-05-15 19:44:00 +02:00
Christophe Fergeau
b442126db1 keyboard: Remove 'gettext_package' handling
It's part of CcKeyboardItem but nothing uses it. It's also parsed
when loading KeyListEntry XML, but never used. The key description is
translated using Keylist::package before gettext_package is assigned.

https://bugzilla.gnome.org/show_bug.cgi?id=749381
2015-05-15 19:44:00 +02:00
Christophe Fergeau
241b4034ce keyboard: Remove unused cc_keyboard_item_get_binding
https://bugzilla.gnome.org/show_bug.cgi?id=749381
2015-05-15 19:44:00 +02:00
Christophe Fergeau
b7a2d17548 keyboard: Make CcKeyboardItem::binding private
It's not used outside of CcKeyboardItem

https://bugzilla.gnome.org/show_bug.cgi?id=749381
2015-05-15 19:44:00 +02:00
Bastien Nocera
86374b2545 power: Hide Bluetooth power section when w/o BT
When a Bluetooth airplane mode isn't available (whether hardware or
software) it means there are no Bluetooth adapters, even turned off.
Hide the Bluetooth section in that case.\

https://bugzilla.gnome.org/show_bug.cgi?id=749140
2015-05-15 17:32:23 +02:00
Martin Hatina
75df3ebe87 notifications: Align icons
Icons are now aligned even when they don't have same size.

https://bugzilla.gnome.org/show_bug.cgi?id=711389
2015-05-11 18:30:18 +02:00
Martin Hatina
ed37aa2cae notifications: Do not show nameless apps
Apps with no name are not added to list.

https://bugzilla.gnome.org/show_bug.cgi?id=693622
2015-05-11 18:05:39 +02:00
Martin Hatina
3c710f1f32 notifications: Make section headings accessible
The section headings are useful to understand the content of this panel.

https://bugzilla.gnome.org/show_bug.cgi?id=746757
2015-05-11 17:23:10 +02:00
Carlos Garnacho
adb82f0d00 wacom: Drop usage of last-calibration-resolution
This is gone from the g-s-d schema, so just stop setting it.

https://bugzilla.gnome.org/show_bug.cgi?id=748660
2015-04-29 19:35:34 +02:00
Mario Sanchez Prada
fd7d7d4c10 sharing: Use g_variant_get_{string|variant}() instead of g_variant_get()
Besides being a better practice, this changes also fixes 2 memory leaks
when handling strings boxed inside GVariant objects.

https://bugzilla.gnome.org/show_bug.cgi?id=748411
2015-04-27 15:55:20 +01:00
Mario Sanchez Prada
9ff192ab2e power: Use g_variant_get_string() instead of g_variant_get()
Fixes a memory leak as the "(s)" format string was being used, but no
call to g_free() was happening afterwards.

https://bugzilla.gnome.org/show_bug.cgi?id=748411
2015-04-27 15:55:20 +01:00
Matthias Clasen
93427f8b35 network: Stop "gateway" entry from becoming too wide
https://bugzilla.gnome.org/show_bug.cgi?id=732974
2015-04-21 14:29:33 +02:00
Bastien Nocera
98221832a8 network: Stop "Bridge slaves" entry from becoming too wide
https://bugzilla.gnome.org/show_bug.cgi?id=732974
2015-04-21 14:29:33 +02:00
Marek Kasik
30a743a94c printers: Update printer options correctly
Set 'ppd_filename_set' and 'destination_set' always to FALSE
before requesting the destination and updated PPD file so we can
distinguish when we have all information needed for update
of the PpPPDOptionWidget.

https://bugzilla.redhat.com/show_bug.cgi?id=1211580
2015-04-16 15:14:07 +02:00
Ondrej Holy
afe0a62267 user-accounts: show restart notification when account type changed
https://bugzilla.gnome.org/show_bug.cgi?id=674429
2015-04-15 16:27:24 +02:00
Ondrej Holy
b1f3f3e458 mouse: Fix tap-to-click toggle sensitivity with libinput
Set tap_to_click_toggle sensitive if there is any device which supports
tapping.

https://bugzilla.gnome.org/show_bug.cgi?id=745601
2015-04-15 15:33:44 +02:00
Ondrej Holy
155d440623 mouse: Fix sensitivity of two-finger toggle with libinput
Check "libinput Scroll Methods Available" and set two_finger_scroll_toggle
sensitivity appropriately. Many libinput devices don't have edge scroll,
see http://who-t.blogspot.cz/2015/03/why-libinput-doesnt-support-edge.html
Allow changing scroll methods only if both two-finger and edge scroll is
supported.

https://bugzilla.gnome.org/show_bug.cgi?id=745601
2015-04-15 15:18:54 +02:00
Ondrej Holy
2f84534388 mouse: Fix checking capabilities for multiple devices
Two finger scroll toggle should be sensitive if at least one of the
devices support it. g-s-d is responsible to set edge-scroll for the
devices which don't support double touch.

https://bugzilla.gnome.org/show_bug.cgi?id=745601
2015-04-15 15:18:54 +02:00
Prince781
e01951ede8 printers: Recognize more supply types
Recognize 'inkCartridge' and 'tonerCartridge' supply types.

https://bugzilla.gnome.org/show_bug.cgi?id=743331
2015-04-14 16:29:05 +02:00
Ondrej Holy
3594f12cea mouse: remove unused graphics
Commit eee381a introduced unused graphics file double-click-gegl.png.
The file should be removed.

https://bugzilla.gnome.org/show_bug.cgi?id=746344
2015-04-14 13:57:14 +02:00
Damián Nohales
073d49ea88 color: Allow to change profile color by activating the list box row 2015-04-14 12:54:41 +01:00
Debarshi Ray
d45f093fbf online-accounts: Widen the accounts list
https://bugzilla.gnome.org/show_bug.cgi?id=746538
2015-04-13 15:05:40 +02:00
Bastien Nocera
cff4336032 online-accounts: Prevent the attention-needed icon from getting hidden
By making sure that the label inside each of the list items gets
only whatever space is left by the left and right-side icons.

https://bugzilla.gnome.org/show_bug.cgi?id=746538
2015-04-13 15:05:40 +02:00
Carlos Garnacho
6365dafd92 wacom: Sync gsd-wacom-device.[ch] with g-s-d
And use the GdkDevice getter where it applies.
2015-04-13 14:38:24 +02:00
Debarshi Ray
b24bfa8197 online-accounts: Disable the remove button for locked accounts
Bump required GOA version for the IsLocked property.

https://bugzilla.gnome.org/show_bug.cgi?id=737665
2015-04-13 14:19:59 +02:00
Rui Matos
03d9a96c67 display: Close the dialog when the RR configuration changes
We assume that the RR configuration is valid in various callbacks from
both our modal dialogs which doesn't hold if there's an hotplug while
a dialog is open (e.g. monitor is plugged/unplugged).

Closing the dialog in that case seems the right thing to do since it
would be operating on an outdated view of the world otherwise and
likely end up crashing.

https://bugzilla.gnome.org/show_bug.cgi?id=655041
2015-04-13 14:05:49 +02:00