Commit graph

235 commits

Author SHA1 Message Date
Jens Granseuer
2ba498e0c2 move function here from common/
2007-10-27  Jens Granseuer  <jensgr@gmx.net>

	* theme-util.c: (theme_is_writable):
	* theme-util.h: move function here from common/

	* appearance-style.c: (gtk_theme_changed), (window_theme_changed),
	(icon_theme_changed), (cursor_theme_changed):
	* appearance-themes.c: (theme_selection_changed_cb): adapt callers

2007-10-27  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c (gnome_theme_is_writable):
	* gnome-theme-info.h: move this function to the appearance capplet

svn path=/trunk/; revision=8211
2007-10-27 11:29:11 +00:00
Jens Granseuer
29e6e09e13 revert this part from the last commit since this was already handled by
2007-10-25  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_init): revert this part from the
	last commit since this was already handled by rev 8166

svn path=/trunk/; revision=8200
2007-10-25 19:09:48 +00:00
Denis Washington
891f7ac4c1 More fixes regarding integration of cursor themes into metathemes.
2007-10-25  Denis Washington  <denisw@svn.gnome.org>

	More fixes regarding integration of cursor themes into metathemes.

	* appearance/appearance-themes.c: Take cursor size into account in
	theme_is_equal(), and also watch the cursor theme/size gconf keys for
	changes.

	* common/gnome-theme-apply.c: Fix the cursor size being only being
	updated if the cursor theme changed too.
	* common/gnome-theme-info.c: Also watch 
/usr/share/cursors/xorg-x11
	for cursor themes (path used by Gentoo Linux).

svn path=/trunk/; revision=8198
2007-10-25 16:01:44 +00:00
Jens Granseuer
d420730347 This change hopefully fixes bug #484797 which I suspect is caused by the
2007-10-24  Jens Granseuer  <jensgr@gmx.net>

	This change hopefully fixes bug #484797 which I suspect is caused by
	the capplet getting stale data from from the themes module which in
	turn is caused by deleted themes being freed but not removed from the
	hash cache.

	* gnome-theme-info.c: (update_common_theme_dir_index): actually remove
	theme data from the hash when the theme gets deleted; also don't
	unconditionally cast to icon theme

svn path=/trunk/; revision=8194
2007-10-24 21:18:10 +00:00
Jens Granseuer
2b27aac116 fix invalid use after free I caused with the last commit
2007-10-14  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_init): fix invalid use after free I
	caused with the last commit

svn path=/trunk/; revision=8170
2007-10-14 14:54:58 +00:00
Jens Granseuer
d28037d3b2 move the code for setting the color scheme for gtk thumbnails to the
2007-09-29  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (generate_gtk_theme_thumbnail),
	(generate_theme_thumbnail_async),
	(generate_gtk_theme_thumbnail_async): move the code for setting the
	color scheme for gtk thumbnails to the gtk-specific function. This
	means we will probably extract it twice for most thumbnails, but it
	makes for much cleaner code. Also add the scheme bit to the synchronous
	version.

svn path=/trunk/; revision=8144
2007-09-29 09:37:33 +00:00
Jens Granseuer
fb5f03d31e patch up an outdated comment about how the thumbnailer protocol works
2007-09-25  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: patch up an outdated comment about how the
	thumbnailer protocol works

svn path=/trunk/; revision=8137
2007-09-25 19:46:23 +00:00
Jens Granseuer
b2a41685b8 Prevent lots of thumbs from being created with the color scheme of the
2007-09-25  Jens Granseuer  <jensgr@gmx.net>

 	Prevent lots of thumbs from being created with the color scheme of the
	currently active theme (see comment #15 in bug 460023). Maybe it also
	helps with some of the other color-related issues.

	* theme-thumbnail.c: (create_gtk_theme_pixbuf),
	(generate_theme_thumbnail_async): when creating GTK theme thumbnails,
	explicitly pass the theme's color scheme to override the xsetting

svn path=/trunk/; revision=8135
2007-09-25 19:36:18 +00:00
Jens Granseuer
eddd1b3d9b Patch by: Darren Kenny <darren.kenny@sun.com>
2007-09-16  Jens Granseuer  <jensgr@gmx.net>

	Patch by: Darren Kenny <darren.kenny@sun.com>

	* theme-thumbnail.c: (generate_meta_theme_thumbnail_async),
	(generate_gtk_theme_thumbnail_async),
	(generate_metacity_theme_thumbnail_async),
	(generate_icon_theme_thumbnail_async): don't return values from void
	functions. Fixes building with Sun's Forte compiler (bug #473967)

svn path=/trunk/; revision=8115
2007-09-16 15:46:49 +00:00
Jens Granseuer
1e5c9968e2 fix leaks (bug #469531)
2007-08-23  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (theme_get_thumbnail_from_cache):
	* gnome-wp-item.c: (gnome_wp_item_update_description): fix leaks (bug
	#469531)

2007-08-23  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_is_writable): cast to proper type
	* theme-thumbnail.c: (create_metacity_theme_pixbuf): free the metacity
	theme after use (bug #469531)

svn path=/trunk/; revision=8040
2007-08-23 19:02:28 +00:00
Jens Granseuer
777a257df8 Properly check all stored themes if necessary. This fixes cases where e.g.
2007-08-21  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_info_find_by_type_helper):
	Properly check all stored themes if necessary. This fixes cases where
	e.g. a metacity theme in ~/.themes would hide a GTK theme with the
	same name in the system theme dir

svn path=/trunk/; revision=8032
2007-08-21 21:22:50 +00:00
Luca Cavalli
4998b3f2d5 add new function similar to gnome_vfs_format_uri_for_display but that
2007-08-21  Luca Cavalli <loopback@slackit.org>

	* file-transfer-dialog.c: (format_uri_for_display),
	(file_transfer_dialog_set_prop): add new function similar to
	gnome_vfs_format_uri_for_display but that hides the password if
	needed. Taken from gedit by Paolo Maggi. Closes bug #339551.

svn path=/trunk/; revision=8027
2007-08-21 10:53:59 +00:00
Matthias Clasen
1c7188caa7 Fixes #467552
2007-08-20  Matthias Clasen <mclasen@redhat.com>

	Fixes #467552

	* gnome-theme-info.c (gnome_theme_init): avoid double-freed for cursor
	theme infos.

svn path=/trunk/; revision=8023
2007-08-20 11:02:37 +00:00
Jens Granseuer
2f48b99c2a fix double-free, and make the builtins non-static to save relocations
2007-08-17  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_fonts): fix double-free, and make
	the builtins non-static to save relocations

svn path=/trunk/; revision=8013
2007-08-17 17:33:05 +00:00
Jens Granseuer
3b08e16e7f don't leak the cursor font
2007-08-17  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_fonts): don't leak the cursor font

svn path=/trunk/; revision=8010
2007-08-17 15:48:27 +00:00
Jens Granseuer
2a25f23559 various small tweaks and optimizations
2007-08-12  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_folder_icon),
	(create_gtk_theme_pixbuf), (handle_bytes), (message_from_capplet),
	(message_from_child), (read_pixbuf), (generate_theme_thumbnail):
	various small tweaks and optimizations

svn path=/trunk/; revision=7991
2007-08-12 15:30:07 +00:00
Jens Granseuer
4279e8b062 Create the icon theme representative before the GTK stock button. Since we
2007-08-08  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_meta_theme_pixbuf):
	Create the icon theme representative before the GTK stock button. Since
	we explicitly set the icon theme for the first, this ensures both are
	drawn with the same icon theme. Before it was possible when changing
	icon themes (especially on slower machines) that the GtkSettings were
	not yet updated and the stock button still used the old theme.

svn path=/trunk/; revision=7981
2007-08-08 21:46:28 +00:00
Jens Granseuer
3d0bb8f59d make sure we don't run off the end of the array
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme): make sure we don't run off
	the end of the array

svn path=/trunk/; revision=7972
2007-08-07 20:16:18 +00:00
Jens Granseuer
69749b7dcb copy the name for the default cursor, too, lest we crash on free, and only
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme),
	(gnome_theme_cursor_info_free): copy the name for the default cursor,
	too, lest we crash on free, and only unref the thumbnail if we have
	one

svn path=/trunk/; revision=7971
2007-08-07 19:44:18 +00:00
Denis Washington
5cfe0df8a6 Also load the "default" cursor theme as GnomeThemeCursorInfo so we know
2007-08-04  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.c: (read_cursor_theme), (look_for_cursor_theme):
	Also load the "default" cursor theme as GnomeThemeCursorInfo so
	we know about the available sizes. (bug #462409)

	* appearance/appearance-style.c: (prepare_list):
	Only add a "Default Pointer" list item if there is
	no such GnomeThemeCursorInfo.

svn path=/trunk/; revision=7960
2007-08-04 13:05:24 +00:00
Jens Granseuer
aa9ddd3739 reduce metatheme thumbnail size to 128x128 in preparation of using
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* data/appearance.glade:
	* data/theme-thumbnailing.png: reduce metatheme thumbnail size to
	128x128 in preparation of using gnome-thumbnail-factory

2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: reduce metatheme thumbnail size to 128x128

svn path=/trunk/; revision=7954
2007-08-03 19:49:32 +00:00
Jens Granseuer
d31c4f7b75 no need for an expensive parse to initialize the colors
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): no need for an
	expensive parse to initialize the colors

svn path=/trunk/; revision=7949
2007-08-02 21:26:03 +00:00
Jens Granseuer
1ab61b2bbc don't generate GTK thumbnails when we want metacity or icon (bug #462724)
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (generate_metacity_theme_thumbnail),
	(generate_icon_theme_thumbnail): don't generate GTK thumbnails when we
	want metacity or icon (bug #462724)

svn path=/trunk/; revision=7948
2007-08-02 18:26:43 +00:00
Jens Granseuer
147912ed01 fix cut'n'paste errors for the tooltip colors and use new color enum
2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): fix cut'n'paste errors
	for the tooltip colors and use new color enum

	* data/appearance.glade: repair the mess glade3 made of the file

2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse),
	(gnome_theme_color_scheme_equal):
	* gnome-theme-info.h: add symbolic colors enum and use it

svn path=/trunk/; revision=7936
2007-07-30 18:22:00 +00:00
Thomas Wood
12faf7f40e Add tooltip foreground and background colours to the list of recognised
2007-07-30  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (update_color_buttons_from_string),
	(check_color_schemes_enabled), (color_button_clicked_cb),
	(style_init):
	* data/appearance.glade:

	Add tooltip foreground and background colours to the list of recognised
	symbolic colours.

2007-07-30  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): Add tooltip foreground
	and background colours to the list of recognised symbolic colours.

svn path=/trunk/; revision=7933
2007-07-30 16:49:28 +00:00
Thomas Wood
a316e82ccc Expand check for empty metatheme colour scheme to include blank colour
2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_read_meta_theme): Expand check for empty
	metatheme colour scheme to include blank colour scheme strings.

svn path=/trunk/; revision=7926
2007-07-29 17:26:47 +00:00
Thomas Wood
23c161aa35 Prevent some memory leaks
2007-07-29  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (cursor_theme_sort_func), (prepare_list),
	(style_init): Prevent some memory leaks

2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-apply.c: (gnome_meta_theme_set):
	* gtkrc-utils.c: (gtkrc_get_details), (gtkrc_get_color_scheme):

	Prevent some memory leaks

svn path=/trunk/; revision=7920
2007-07-29 13:05:29 +00:00
Denis Washington
2834baf127 Read a cursor theme's name from it's index.theme file if it has one.
2007-07-28  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.h:
	* common/gnome-theme-info.c: (look_in_cursor_theme),
	(gnome_theme_cursor_info_free):
	Read a cursor theme's name from it's index.theme file if it has one.

	* appearance/appearance-style.c: (prepare_list):
	Show readable_name in cursor theme list instead of name.

svn path=/trunk/; revision=7914
2007-07-28 13:53:15 +00:00
Denis Washington
b608a53acb Prevent cursor themes from being recognized as icon themes.
2007-07-28  Denis Washington  <denisw@svn.gnome.org>

	* gnome-theme-info.c: (read_icon_theme):
	Prevent cursor themes from being recognized as icon themes.

svn path=/trunk/; revision=7913
2007-07-28 13:05:59 +00:00
Thomas Wood
f437b8f99d Add missing include
2007-07-28  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.h: Add missing include

2007-07-28  Thomas Wood  <thos@gnome.org>

	* theme-util.c: Add missing include

svn path=/trunk/; revision=7906
2007-07-28 10:53:57 +00:00
Jens Granseuer
307679f2e2 connect to the GtkTreeViewSelection::changed signal instead of
2007-07-26  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_tree_view_widget_changed),
	(gconf_peditor_new_tree_view): connect to the GtkTreeViewSelection::changed
	signal instead of GtkTreeView::cursor_changed, so we actually get notified
	whenever the selection changes

svn path=/trunk/; revision=7899
2007-07-26 21:13:45 +00:00
Jens Granseuer
abd1b52762 move some utility code here from appearance
2007-07-26  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_read_meta_theme),
	(gnome_theme_color_scheme_parse), (gnome_theme_color_scheme_equal):
	* gnome-theme-info.h:
	* gtkrc-utils.c: (str_nequal), (gtkrc_get_color_scheme),
	(gtkrc_get_color_scheme_for_theme):
	* gtkrc-utils.h: move some utility code here from appearance

	* gnome-theme-apply.c: (gnome_meta_theme_set): when applying a metatheme,
	check whether to set/unset the color scheme gconf key (should fix bug
	#421866)

svn path=/trunk/; revision=7897
2007-07-26 19:48:14 +00:00
Denis Washington
78b4743519 Re-add basic support for cursor themes for X servers without the Xcursor
2007-07-26  Denis Washington <denisw@svn.gnome.org>

	* appearance/data/appearance.glade:
	* appearance/appearance-style.c: 
	* appearance/appearance-themes.c: (theme_load_from_gconf),
	(cursor_theme_changed), (prepare_list), (style_init):
	* appearance/theme-save.c: (write_theme_to_disk):
	* appearance/theme-util.h:
	* common/gnome-theme-apply.c: (gnome_meta_theme_set):
	* common/gnome-theme-info.c: 
(add_common_icon_theme_dir_monitor),
	(gnome_theme_init):
	* common/gnome-theme-info.h:
	Re-add basic support for cursor themes for X servers without the Xcursor
	extension, like the one on Solaris.

svn path=/trunk/; revision=7890
2007-07-26 16:15:35 +00:00
Denis Washington
2126b49c6e ChangeLog whitespace fix.
svn path=/trunk/; revision=7884
2007-07-25 17:31:25 +00:00
Denis Washington
ce7f03bdc3 Add support for cursor theme names saved in metathemes.
2007-07-25  Denis Washington <denisw@svn.gnome.org>

  * gnome-theme-info.h:
  * gnome-theme-info.c: (gnome_theme_read_meta_theme):
  * gnome-theme-apply.c: (gnome_meta_theme_set):
  Add support for cursor theme names saved in metathemes.

svn path=/trunk/; revision=7883
2007-07-25 17:30:21 +00:00
Denis Washington
222d100c2d Fix abug introduced by the changes in revision 7856 which caused cursor
2007-07-25  Denis Washington <denisw@svn.gnome.org>

	* gnome-theme-info.c: (add_common_icon_theme_dir_monitor),
	(look_for_cursor_theme):
	Fix abug introduced by the changes in revision 7856 which caused
	cursor themes to not being found anymore.

svn path=/trunk/; revision=7882
2007-07-25 15:43:51 +00:00
Jens Granseuer
2286497f8e general cleanup and leak-plugging add cursor theme info
2007-07-13  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gdk_pixbuf_from_xcursor_image),
	(look_for_cursor_theme), (add_common_icon_theme_dir_monitor),
	(gnome_theme_cursor_info_new): general cleanup and leak-plugging
	* gnome-theme-test.c: (main): add cursor theme info

svn path=/trunk/; revision=7856
2007-07-13 18:32:25 +00:00
Frederic Crozat
e62cc67971 Fix crash when no cursor is specified in theme (fixes bug #455952).
2007-07-13  Frederic Crozat  <fcrozat@mandriva.com>

        * gnome-theme-info.c: (look_for_cursor_theme):
        Fix crash when no cursor is specified in theme (fixes bug #455952).


svn path=/trunk/; revision=7854
2007-07-13 07:35:29 +00:00
Jens Granseuer
fa41845299 include gdk-pixbuf.h (fixes bug #454634)
2007-07-08  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.h: include gdk-pixbuf.h (fixes bug #454634)

svn path=/trunk/; revision=7833
2007-07-08 15:23:08 +00:00
Denis Washington
df0060e59d Silly me...
svn path=/trunk/; revision=7826
2007-07-05 17:51:07 +00:00
Denis Washington
bbee377d3f Add support for cursor themes (GnomeThemeCursorInfo); probably still a bit
2007-07-01  Denis Washington  <denisw@svn.gnome.org>

	* gnome-theme-info.[ch]:
	Add support for cursor themes (GnomeThemeCursorInfo); probably still a bit
	rough around the edges, but it works.

svn path=/trunk/; revision=7823
2007-07-05 17:43:09 +00:00
Jens Granseuer
2d521a0b6e add safeguards for NULL values (closes bug #441036)
2007-07-01  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_string_value_changed),
	(peditor_color_value_changed): add safeguards for NULL values (closes
	bug #441036)

svn path=/trunk/; revision=7810
2007-07-01 15:01:23 +00:00
Jens Granseuer
87fb51d921 compare the string from the widget against the converted gconf value, not
2007-06-29  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_string_value_changed): compare the
	string from the widget against the converted gconf value, not the
	unmodified one

svn path=/trunk/; revision=7807
2007-06-29 20:53:25 +00:00
Michael Terry
6b9550b491 use icon theme for app icons, bug #450777
svn path=/trunk/; revision=7784
2007-06-26 23:29:58 +00:00
Denis Washington
443068f132 Remove redundant newline in ChangeLog.
svn path=/trunk/; revision=7775
2007-06-25 15:11:22 +00:00
Denis Washington
4ac577360b Generate all types of thumbnails in a seperate process, not just those for
2007-06-25  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.[ch]:
	Generate all types of thumbnails in a seperate process, not just those for
	metathemes.

svn path=/trunk/; revision=7774
2007-06-25 15:10:21 +00:00
Denis Washington
34adc6a2db Make metatheme thumbnails original-sized and add check box + radio button.
2007-06-22  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.c: (create_image):
	Make metatheme thumbnails original-sized and add check box + radio button.

svn path=/trunk/; revision=7758
2007-06-22 15:32:44 +00:00
Jens Granseuer
33dd3f654a fix function signatures
2007-06-20  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_icon_info_find,
	gnome_theme_is_writable):
	* gnome-theme-info.h: fix function signatures

svn path=/trunk/; revision=7754
2007-06-20 20:14:18 +00:00
Jens Granseuer
4d5c158170 remove obsolete files
2007-06-18  Jens Granseuer  <jensgr@gmx.net>

	* Makefile.am: remove obsolete files

svn path=/trunk/; revision=7745
2007-06-18 17:56:39 +00:00
Jens Granseuer
556f49a625 plug leak fix comment
2007-06-12  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_icon_info_free): plug leak
	* theme-thumbnail.c: (message_from_child): fix comment

svn path=/trunk/; revision=7722
2007-06-12 20:57:39 +00:00