Commit graph

497 commits

Author SHA1 Message Date
Robert Ancell
fe91d17b43 printers: Remove nesting on a GVariant iteration 2020-03-30 03:24:58 +00:00
Robert Ancell
02d001564a printers: Simplify D-Bus error case branches 2020-03-30 03:24:58 +00:00
Robert Ancell
e256dd57c3 printers: Replace D-Bus unrefs with g_autoptr
This case could leak the GDBusConnection
2020-03-30 03:24:58 +00:00
Robert Ancell
6b79e7ffa1 printers: Replace D-Bus unrefs with g_autoptr 2020-03-30 03:24:58 +00:00
Robert Ancell
2b9815dbf8 printers: Remove unnecessary checks on result of g_variant_get
This always returns a value or hits an assertion.
2020-03-30 03:24:58 +00:00
Robert Ancell
815db8f404 printers: Replace explicit g_variant_unref calls with g_autoptr 2020-03-30 03:24:58 +00:00
Robert Ancell
3a7533da1b printers: Use g_autoptr for the results of D-Bus calls 2020-03-30 03:24:58 +00:00
Robert Ancell
67074b7aea printers: Fix GVariantIter leaks 2020-03-30 03:24:58 +00:00
Robert Ancell
46443af0ca printers: Replace GVariant iteration with direct call to copy value 2020-03-30 03:24:58 +00:00
Robert Ancell
9065850b92 printers: Replace g_variant_iter_next_value with the simpler g_variant_iter_next 2020-03-30 03:24:58 +00:00
Robert Ancell
b7fbe4a72d printers: Use consistent value for GtkBuilder signal properties 2020-03-30 16:18:50 +13:00
Robert Ancell
4502673b6c printers: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Felipe Borges
57eae62c6e printers: Add whitespace between top right buttons
Fixes #895
Fixes #685
2020-03-29 22:34:17 +00:00
Felipe Borges
875df8d758 printers: Show the CcPermissionInfobar for all views
We were only presenting the permission infobar when there were
already printers added (printer-list view).

We also want users to see the infobar when they don't have any
printers (empty-page).
2020-02-25 17:59:30 +00:00
Robert Ancell
93b14a4339 panel: Move shared GCancellable code into panel class
Make the panel class provide a cancellable that will be cancelled when the panel
is destroyed. Panel implementations can use this and not have to mangage the
cancellable themselves. Consolidate cases where panels had multiple cancellables
that were all being used for this behaviour.
2020-02-03 09:36:24 +13:00
Felipe Borges
c9eb8ebf41 printers: Use CcPermissionInfobar
This makes the Printers panel consistent with the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/blob/master/users/users.png

See #685, #771 and !671
2020-01-31 14:28:01 +00:00
Marek Kasik
c54db039f8 printers: Avoid read of freed memory
This fixes an issue when on_get_job_attributes_cb()
was called after Printers panel has been finished.
It adds a GCancellable to pp_job_get_attributes_async()
calls.
2020-01-31 14:06:32 +00:00
Robert Ancell
4fe973022a printers: Simplify function 2020-01-28 14:46:53 +00:00
Robert Ancell
c0cd99d2a8 printers: Convert jobs dialog to use GtkTemplate 2020-01-28 14:46:53 +00:00
Robert Ancell
d03da03ee9 printers: Set transient window externally to dialog code 2020-01-28 14:46:53 +00:00
Robert Ancell
181a496a4e printers: Return a GPtrArray instead of GList
This makes the memory able to be managed with g_autoptr.
This fixes a memory leak where the job list was leaked if the operation was cancelled.
2020-01-21 23:12:14 +00:00
Marek Kasik
923b726b3b printers: Provide a scheme to address parser
Add a scheme to the address which we test for correctness
by g_network_address_parse_uri(). It does not work without it.
Use "none" scheme if user did not entered one.
Use port number 0 if user did not specify any.

Fixes #679
2019-10-08 18:05:56 +02:00
Robert Ancell
9a2e821fe5 Initialize autoptr values to NULL.
These cases were safe, but if the code changed this risked freeing uninitialized
memory.
2019-10-03 10:58:38 +13:00
Felipe Borges
e497ad900d printers: Check whether URI is valid while searching for printers
Fixes #679
2019-10-01 18:56:23 +02:00
Philip Chimento
8c08abd0a3 printers: Give printer name fewer characters in width
At the default window size, the printer name label is too wide and
collapses the UI into phone mode. (This is the only panel that shows up
in phone mode by default.) Giving the printer name fewer characters
avoids this.
2019-09-17 07:15:28 +00:00
Philip Chimento
389ee0dfe5 printers: Use CUPS httpConnect2() if available
In CUPS 1.7 httpConnect() and httpConnectEncrypt() were deprecated and
replaced with httpConnect2(). This checks if httpConnect2() is available
and if so, replaces the uses of the deprecated functions.

In the CUPS source code, httpConnect() and httpConnectEncrypt() are now
wrappers around httpConnect2(), so we make sure to use the same
arguments as in the CUPS source code so the two code paths are sure to
be identical:
2c030c7a06/cups/http.c (L412)
2c030c7a06/cups/http.c (L477)
2019-09-16 14:09:40 -07:00
Philip Chimento
96137369a5 build: Fix CUPS PPD deprecation warning
In https://bugzilla.gnome.org/show_bug.cgi?id=696766 it was decided to
build with _PPD_DEPRECATED defined, to suppress the warnings about the
deprecation of the CUPS PPD API, since there was no full replacement
yet. Unfortunately this didn't make it intact through the port to Meson,
so fix it here.
2019-09-16 14:09:40 -07:00
Robert Ancell
b842a33316 printers: Move callbacks into .ui file 2019-09-10 12:36:39 +12:00
Robert Ancell
015c79411a printers: Use gtk_stack_set_visible_child instead of names 2019-09-10 12:36:39 +12:00
Robert Ancell
0ca1632890 printers: Drop unused GtkBuilder IDs 2019-09-10 12:36:39 +12:00
Robert Ancell
60ea08cc64 printers: Make the options dialog a full widget using GtkTemplate 2019-09-10 12:36:38 +12:00
Robert Ancell
6d23ac0892 printers: Make .ui filename match the .c filename 2019-09-10 12:33:11 +12:00
Robert Ancell
d4b47bd9ff printers: Sort variables 2019-09-10 00:18:53 +00:00
Robert Ancell
1b999f36e2 printers: Use gtk_stack_set_visible_child instead of names 2019-09-10 00:18:53 +00:00
Robert Ancell
2c28987e41 printers: Connect signals in swapped form 2019-09-10 00:18:53 +00:00
Robert Ancell
d4adf67549 printers: use gtk_dialog_run 2019-09-10 00:18:53 +00:00
Robert Ancell
a50ce39689 printers: Drop unused class structure 2019-09-10 00:18:53 +00:00
Robert Ancell
3a027bddd0 printers: Set transient window externally to dialog code 2019-09-10 00:18:53 +00:00
Robert Ancell
7f67f6b24f printers: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2019-09-10 00:18:53 +00:00
Robert Ancell
fcde07c770 printers: Remove pp_details_dialog_free, use gtk_widget_destroy 2019-09-10 00:18:53 +00:00
Robert Ancell
fb92795854 printers: Make .ui filename match the .c filename 2019-09-10 00:18:53 +00:00
Robert Ancell
97985a664e Remove unused GNOMELOCALEDIR defines 2019-09-09 21:45:53 +00:00
Marek Kasik
2b1f76f8ea printers: Revert previous 2 commits
I'm sorry, I pushed to wrong branch. This code is
for testing now and will be proposed later, after
https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/108
will be merged.
2019-05-24 19:12:00 +02:00
Marek Kasik
21df888699 printers: Do not notify about job edited by user
Let gnome-settings-daemon know about intention to edit a job
so it does not show notification for this action as it
was initiated manually by user.
Do this via g-s-d's DBus method DoNotNotifyJob.
2019-05-24 19:07:55 +02:00
Marek Kasik
86c7505dee printers: Use correct type for print job id
There was pointer to integer used instead of integer for job_id in 2 functions.
This actually works somehow but I'm changing it to proper integer.
2019-05-24 19:07:52 +02:00
Georges Basile Stavracas Neto
75f150d5a2 shell: Add position to cc_shell_embed_widget_in_header()
So we can control where the widget should be added to. The
main window only supports left and right positions.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/528
2019-05-21 12:59:36 -03:00
Benjamin Berg
bec0f5f588 printers: Add context to Resolution printing option
For now, this patch only adds the context to the Resolution option to
disambiguate it from the display panel. This makes the code more complex
though, and will be changed again to add the context to all options
(making the strings identical to the ones in GTK+).

Fixes #394 for the printing panel
2019-02-26 19:42:13 +01:00
Robert Ancell
092f24d62d printers: Remove unused variables 2019-02-07 11:22:33 +13:00
Robert Ancell
2105e27bde printers: Fix compile warning
Missing GTK_LABEL cast.
2019-02-06 21:28:42 +00:00
Robert Ancell
e9b9966e7d printers: Use g_autoptr with strings 2019-02-05 10:26:15 +13:00