Commit graph

7034 commits

Author SHA1 Message Date
Jan Tojnar
c9448f76c2 region: Fix critical when changing language
Changing user’s language resets the formats (region) by passing `NULL` to `update_region`.
However, updating the region calls `maybe_notify`, whose callback `maybe_notify_finish`
tries to parse the `mnd->target_locale` (the `NULL`), producing a critical:

    GLib-CRITICAL **: g_regex_match_full: assertion 'string != NULL' failed

Since updating the language itself already triggers the notification check,
let’s just skip calling `maybe_notify` here in that case.
2022-05-26 19:05:16 +00:00
Jan Tojnar
7c4428eb59 region: Fix creating rows for locales without country
When creating a language row for Esperanto (eo.UTF-8), gnome-desktop throws a critical:

    gnome_get_country_from_code: assertion 'code != NULL' failed
2022-05-26 19:05:16 +00:00
Lukáš Tyrychtr
eece14f1cd Add a missing a11y label to the search box in the country selection dialog 2022-05-25 23:43:28 +00:00
Robert Ancell
99f27e802f applications: Update snap permissions code to recent changes
Fixes #1845
2022-05-25 23:02:46 +00:00
Georges Basile Stavracas Neto
261545b6cb keyboard: Set mnemonics to header buttons
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1863
2022-05-25 16:41:28 +00:00
Felipe Borges
e5dbc0dcc1 appearance: Add "Appearance" keyword to desktop file
With the panel getting renamed from "Background" to "Appearance", users
like myself will start getting accustomed to search for the new term
instead.
2022-05-25 10:09:06 +00:00
Lukáš Tyrychtr
9c54390320 Add missing a11y labels and fix accessibility related markup in UI files in the search panel 2022-05-19 12:05:01 +00:00
Jonas Ådahl
fc984e90a1 display: Show infobar if night light isn't supported
This may be the case on e.g. fully remote / headless sessions, or as of
now, when using the NVIDIA driver to run a Wayland session.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1659
2022-05-17 12:32:48 +02:00
Jonas Ådahl
44293e9db2 display: Add 'NightLightSupported' property support 2022-05-17 12:31:07 +02:00
Robert Ancell
fc1b750f19 applications: Fix CcInfoRow having the wrong parent.
Introduced in 9e38b89752
2022-05-17 12:14:56 +12:00
Robert Ancell
64768de705 keyboard: Fix typo in a11y label 2022-05-16 10:05:29 +12:00
Felipe Borges
44fdf9a492 sharing: Let GtkWindowControls add its own buttons
On the Verify Encryption dialog we were adding a GtkWindowControls
widget with a button child. This is a misunderstanding of the behavior
of GtkWindowControls, which adds its own buttons to the window.

Let's remove our custom close-button and its callback, since the
previous commit disabled this codepath for hiding the dialog.
2022-05-13 13:18:01 +02:00
Felipe Borges
a701ab0b8b sharing: Set Verify Encryption dialog to "hide-on-close"
This way GtkWindow handles the hiding of the dialog instead of the
callback of the close-button.

Fixes #1832
2022-05-13 13:18:01 +02:00
Ritik Bhandari
46e8eafa92 user-accounts: Fixed typo from "organisation" to "organization" 2022-05-12 23:11:00 +00:00
Ritik Bhandari
8320d17825 region: Fixed typo from "formats is.." to "formats are" 2022-05-12 23:11:00 +00:00
Adrien Plazas
d548309f34 info-overview-panel: Use the external link icon for the updates link
This makes it explicit it opens another application to perform the
action.
2022-05-12 23:04:51 +00:00
lsnow
1523ab6c6b applications: crash when switching between two apps
The GIcon returned by g_app_info_get_icon() does
not need to be freed.

See: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1817
2022-05-11 12:39:39 +08:00
Robert Ancell
b7302348cf online-accounts: Add CcOnlineAccountRow 2022-05-11 14:51:53 +12:00
Robert Ancell
32a807b964 online-accounts: Add CcOnlineAccountProviderRow 2022-05-11 14:49:12 +12:00
Robert Ancell
7bf240ca3f online-accounts: Use g_autoptr 2022-05-11 14:04:22 +12:00
Robert Ancell
7d4c8346ca online-accounts: Rename panel class to match filename 2022-05-11 14:04:18 +12:00
Jeremy Bicha
f94c96577b sharing: Turn off RDP gsettings key when turning off RDP
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1825
2022-05-11 00:28:25 +00:00
Robert Ancell
f9fd2587ca printers: Fix missing const on string parameter 2022-05-11 12:16:25 +12:00
Robert Ancell
0118598763 display: Fix typo in a11y attribute 2022-05-11 12:07:31 +12:00
Michael Catanzaro
69f51bdab0 info-overview: add build option to control distributor logo
Currently, we display a 256x256 version of the OS icon from
/etc/os-release. This is too big for my taste, and it's also not
sufficient for distros that want to display a logo that is not an icon.
For instance, because we no longer display the operating system name
immediately beneath the logo, it may be desirable to use a logo variant
that includes text. This patch adds a meson build option that
distributions can use to override the logo, and a second build option to
specify a different logo for use in dark mode.
2022-05-10 23:16:40 +00:00
Bastien Nocera
88f87de748 info-overview: Remove old version.xml loading code 2022-05-10 23:00:59 +00:00
Bastien Nocera
bfc567955f info-overview: Load GNOME version from gnome-shell
See https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5406
2022-05-10 23:00:59 +00:00
Bastien Nocera
d253fe188c info-overview: Add a placeholder while the GNOME version loads 2022-05-10 23:00:59 +00:00
Bastien Nocera
8914fae8da info-overview: Don't load version.xml info we don't use
We don't use the distributor or date info from gnome-desktop's version.xml
so no need to parse it.
2022-05-10 23:00:59 +00:00
Lukáš Tyrychtr
4a421d0abc Ensure that the activatable widgets of the multitasking rows have the proper labels 2022-05-10 22:29:10 +00:00
Lukáš Tyrychtr
e26f28d1fd Add a label to the close notification button in online account settings 2022-05-10 22:19:52 +00:00
Lukáš Tyrychtr
de8d28c3eb Improve accessibility of the power panel 2022-05-10 22:14:35 +00:00
Lukáš Tyrychtr
df30f44709 Fix indent 2022-05-10 21:35:50 +00:00
Lukáš Tyrychtr
450c05471b Label the device name textbox for a11y 2022-05-10 21:35:50 +00:00
Lukáš Tyrychtr
861d762ce5 Address review feedback 2022-05-10 21:26:05 +00:00
Lukáš Tyrychtr
3151598aef Make the network settings panel more screen reader friendly 2022-05-10 21:26:05 +00:00
Lukáš Tyrychtr
46673670d9 Fix indentation 2022-05-10 21:11:57 +00:00
Lukáš Tyrychtr
a477684f20 Improve accessibility of the background panel 2022-05-10 21:11:57 +00:00
Jonas Ådahl
48354fde43 sharing/remote-desktop/fingerprint: Add missing period to string 2022-05-10 20:58:40 +00:00
Jonas Ådahl
6affceebee sharing/remote-desktop: Show toasts when copying 2022-05-10 20:58:40 +00:00
Bastien Nocera
aa7ebe5d7c bluetooth: Add a few edge cases in Bluetooth tester
Use a non-ASCII filename as well as an ampersand, both things that could
cause problems.
2022-05-10 11:03:50 +02:00
Corey Berla
df51bed16c printers: Check for invalid characters in printer names
Currently when you rename a printer through the print details page
there is no indication of errors produced by CUPS, most notable
about any invalid characters used. Adds a function to check
for invalid characters and shows a warning to users.  No
attempt will be made to rename the printer if it contains an
invalid character.  Users are currently shown an elevation prompt
before this fix
https://www.cups.org/doc/man-lpstat.html

Partially addresses #1008
2022-05-10 05:11:51 +00:00
Corey Berla
54341cae07 printers: Add label for invalid characters in printer name
Add a label immediately below the printer name entry in printer
details that warns the user if the printer name contains
invalid characters (or other errors) per the CUPS spec.
2022-05-10 05:11:51 +00:00
Pablo Correa Gómez
b7c545a1e7 printers: Wrap job dialog GtkInfoBar label to fit in narrower screens 2022-05-10 04:37:42 +00:00
Pablo Correa Gómez
92ee00e39b display: Wrap Night Light GtkInfoBar label to fit in narrower screens 2022-05-10 04:37:42 +00:00
Pablo Correa Gómez
42cb548115 common: Wrap CcPermissionInfobar labels to fit in narrower screens 2022-05-10 04:37:42 +00:00
Pablo Correa Gómez
ddfacc6b81 power: Only update ALS state if it has changed
Ambient light sensors can be quite sensitive and the LightLevel
property might be changing very often. That has two undesired
consequences:
* The `als_enabled_state_changed` callback gets constantly called
  due to a change in a property which it does not care about, as
  only `HasAmbientLight` is relevant. Therefore, limit the code
  execution to when something needs to be changed.
* During debugging, the terminal gets spammed with "ALS enabled: on/off"
  messages.
2022-05-10 04:32:12 +00:00
Mohammed Sadiq
1204b91f52 wwan: Use AdwToasts for notifications
AdwToasts replaces the GtkLabel inside revealer for notifications
and this simplifies handling the notifications and the toast-overlay
handles the complexities of when to show/withdraw them, the order
they are displayed, etc.
2022-05-10 04:24:49 +00:00
Mohammed Sadiq
9aff773564 wwan: Strip remote dbus error before it's presented
That's more useful for the users
2022-05-10 04:24:49 +00:00
Mohammed Sadiq
1dccede9a7 wwan: Return "No Error" if error is NULL 2022-05-10 04:24:49 +00:00