Commit graph

6 commits

Author SHA1 Message Date
Automeris naranja
329e8c8fae remote-session-page: Fix to avoid a string freeze break
A previous commit[1] attempted to prevent "How to Connect"
section string from being translated twice[2].
Desktop Sharing and Remote Login pages have this same
string, but the latter was missing a period at the
end of the phrase, which caused the duplicated issue.

The commit[1] didn't fix the issue entirely, because
the string from the Desktop Sharing page was using
a different apostrophe symbol than the Remote Login page
counterpart (which is the recommended apostrophe symbol
acc. to HIG[3]).

Fix the issue by using the same apostrophe symbol mentioned
above in the string from the Remote Login page. This will
cause the translation from the Desktop Sharing string to be
reused, thus a string freeze break won't happen.

See also: https://gitlab.gnome.org/Teams/Translation/Coordination/-/issues/133

[1] b4131d3b0a
[2] https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2936
[3] https://developer.gnome.org/hig/guidelines/typography.html
2024-03-04 12:22:39 -03:00
Automeris naranja
b4131d3b0a remote-session-page: Add missing period to a phrase
The description text from the "How to Connect" session
doesn't end with a period, unlike the same description
that is located in the Desktop Sharing page[1]. This
unnecessarily duplicate the strings in Damned Lies
and creates an inconsistency.

Add a period to that description text to fix the issue.

[1] https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/46.rc/panels/system/remote-desktop/cc-remote-session-page.ui?ref_type=tags#L42

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2936
2024-03-04 05:05:34 +00:00
Automeris naranja
d9be89a5de remote-desktop: Fix page contents being cut when window is small
- Use halign correctly ("left" and "right" aren't
valid values) and use hexpand in the
"Verify Encryption" button, since halign needs
hexpand set to "true"

- Ditch the spacer box, as it causes the page contents
to not scale correctly when the window width is small

- Add can-shrink property to "Generate New Password" and
"Verify Encryption" buttons so they can shrink when
the window width is small

- Also, set the margin-top only in the GtkBox to avoid
redundancy

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2933
2024-03-02 22:49:45 -03:00
Automeris naranja
e84623473c remote-session-page: Several small fixes
- Fix the activatable-widget from port_row,
which was pointing to copy_address_button

- Remove a11y labels from copy buttons
because Orca also reads tooltips

- Remove .property style class from entry rows
since this class is only meant to be used
in AdwActionRow and AdwExpanderRow[1]

- Set the copy buttons as suffix widgets
directly, because wrapping them in a GtkBox
is unnecessary

- Fix indentation

[1] https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#property-rows
2024-03-02 19:58:47 -03:00
Ray Strode
10ac3e8440 system, remote-desktop: Add Generate New Password button
The designs for remote desktop include a generate password
button, so this commit adds one.
2024-03-02 11:10:54 -05:00
Felipe Borges
b001b2dde5 system, remote-desktop: Add "Remote Session" settings
See 85110609cd/remote-desktop/remote-desktop.png
2024-03-02 11:10:54 -05:00