Commit graph

3726 commits

Author SHA1 Message Date
Ondrej Holy
d82a2101d5 user-accounts & region: allow multiline notifications
The notification is wider then window for some languages (e.g.
France). This patch allows wrapping, limits chars and changes
margin as a result of discussion on #gnome-design.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2014-09-19 13:35:15 +02:00
Matthias Clasen
177166c65b user-accounts: Fix focus in the account dialog
Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.

https://bugzilla.gnome.org/show_bug.cgi?id=736223
2014-09-12 08:14:26 -04:00
Debarshi Ray
eaed418f2a background: Use a stack with three views for the chooser dialog
Instead of using a GtkGrid and GtkBox to mimic what GtkStack and
GtkStackSwitcher already does for us, let's just use the latter. As a
result each source now has its separate GtkIconView. The pictures
source has a nested GtkStack to switch between the 'empty' box and the
view, which should simplify size-related issues.

https://bugzilla.gnome.org/show_bug.cgi?id=736366
2014-09-12 13:08:13 +02:00
Bastien Nocera
658bcc86e6 sharing: Fix empty folder list by default
https://bugzilla.gnome.org/show_bug.cgi?id=736536
2014-09-12 12:04:58 +02:00
Bastien Nocera
da160033c0 background: Fix memory leak in Flickr support
When the GrlSourceResultCb callback is called, the media's ownership is
given to the callback function (as per documentation that says "media"
is "transfer full").
2014-09-12 10:36:47 +02:00
Debarshi Ray
16a79ae6e4 background: Remove a useless horizontal size request
There are three cases which affect our size calculation:
  - When the dialog is without a parent in the test application.
  - When the dialog is maximized on small screens.
  - When the dialog is used with an unmaximized parent.

The width of the chooser is much more than half the width of the parent
in the third case. So there is no point in doing it.

The width that we set for the grid in the content area is actually what
is useful.

https://bugzilla.gnome.org/show_bug.cgi?id=736366
2014-09-10 18:51:42 +02:00
Bastien Nocera
72cd2e69e1 keyboard: Add translator comments to new feature
Conflict resolution and automatic "Shift" assignment need some
examples for translators to do their work.

https://bugzilla.gnome.org/show_bug.cgi?id=736336
2014-09-09 17:07:07 +02:00
Bastien Nocera
dbd1a539f6 network: Don't show underlying device for VPN connections
We don't need to see "tun0" with its IP address in there, separate
from the VPN configuration.
2014-09-09 17:07:07 +02:00
Bastien Nocera
034d269fe0 network: Really hide all of the virtualisation bridges
Follow-up to ddc35609bd.
2014-09-08 14:29:21 +02:00
Michael Catanzaro
7b33be9d14 printers: Fix multiple definitions of libprinters_la_CPPFLAGS
CUPS_CPPFLAGS is in AM_CPPFLAGS, so we can just remove the first
definition (which I guess has been ignored).
2014-09-05 22:50:17 -05:00
Bastien Nocera
439eb22ca1 keyboard: Fix a crash if the WM changes (or restarts)
By stopping watching for WM changes when leaving the shortcuts panel.

 #0 reload_sections
 #1 wm_window_event_filter
 #2 gdk_event_apply_filters at gdkeventsource.c:81
 #3 gdk_event_source_translate_event at gdkeventsource.c:195
 #4 _gdk_x11_display_queue_events at gdkeventsource.c:338
 #5 gdk_display_get_event at gdkdisplay.c:313
 #10 g_main_context_iteration at gmain.c:3766
 #11 g_application_run at gapplication.c:1623

See https://bugzilla.redhat.com/show_bug.cgi?id=1094480

https://bugzilla.gnome.org/show_bug.cgi?id=736117
2014-09-05 14:15:59 +02:00
Bastien Nocera
6c43ebe3b0 keyboard: Make it possible to stop watching for WM changes
As we don't want to be doing that anymore if we're not in the keyboard
panel anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=736117
2014-09-05 14:15:59 +02:00
Ondrej Holy
c218a2198e user-accounts: replace fingerprint widgets by the UmEditableButton
The patch fixes also a wrong padding and replaces GtkNotebook.

https://bugzilla.gnome.org/show_bug.cgi?id=736009
2014-09-05 13:05:46 +02:00
Ondrej Holy
6ce59765dc user-accounts: fix wrong label padding
Hardcoded value is avoided and the label offset is calculated from
style context now.

https://bugzilla.gnome.org/show_bug.cgi?id=736009
2014-09-05 13:05:46 +02:00
Bastien Nocera
110bc2ebb5 keyboard: Fix warnings when clearing the help shortcut
(gnome-control-center:20334): GLib-CRITICAL **: g_variant_new_string: assertion 'string != NULL' failed

 #0  g_logv (log_domain=0x7fffec6a040e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffd148) at gmessages.c:1046
 #1  0x00007fffec63ca12 in g_log (log_domain=log_domain@entry=0x7fffec6a040e "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7fffec6a9cbd "%s: assertion '%s' failed") at gmessages.c:1079
 #2  0x00007fffec63ca39 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7fffec6a040e "GLib", pretty_function=pretty_function@entry=0x7fffec6fa860 <__FUNCTION__.5201> "g_variant_new_string", expression=expression@entry=0x7fffec6fc5f2 "string != NULL") at gmessages.c:1088
 #3  0x00007fffec66890a in g_variant_new_string (string=string@entry=0x0) at gvariant.c:1227
 #4  0x00007fffecc34dd4 in g_settings_set_string (settings=settings@entry=0x14b3640, key=key@entry=0x14caac0 "help", value=value@entry=0x0) at gsettings.c:1708
 #5  0x000000000047cd2e in settings_set_binding (value=0x0, key=0x14caac0 "help", settings=0x14b3640) at cc-keyboard-item.c:117
 #6  _set_binding (set_backend=1, value=<optimized out>, item=<optimized out>) at cc-keyboard-item.c:155
 #7  cc_keyboard_item_set_property (object=<optimized out>, prop_id=<optimized out>, value=<optimized out>, pspec=0x146e300) at cc-keyboard-item.c:204
 #8  0x00007fffec93b3eb in object_set_property (nqueue=<optimized out>, value=<optimized out>, pspec=<optimized out>, object=<optimized out>) at gobject.c:1415
 #9  g_object_set_valist (object=0x149fc00, first_property_name=0x146e300 "\320\064\231", var_args=0x7fffffffd378) at gobject.c:2159
 #10 0x00007fffec93bc0f in g_object_set (_object=0x149fc00, first_property_name=first_property_name@entry=0x53a4a6 "binding") at gobject.c:2269
 #11 0x0000000000479652 in accel_cleared_callback (cell=<optimized out>, path_string=<optimized out>, data=<optimized out>) at keyboard-shortcuts.c:1625
2014-09-05 10:05:58 +02:00
Owen W. Taylor
8629632c4d network: Fix build
Last patch refers to nm_device instead of the actual variable device.

https://bugzilla.gnome.org/show_bug.cgi?id=723643
2014-09-04 13:13:32 -04:00
Michael Catanzaro
aa421e09d0 network: report hotspot is running only if device is active
https://bugzilla.gnome.org/show_bug.cgi?id=723643
2014-09-04 18:42:37 +02:00
David King
86b7af3f0e panels: Mark label strings as translatable
https://bugzilla.gnome.org/show_bug.cgi?id=736052
2014-09-04 16:00:20 +01:00
David King
745c7ef9de panels: Fix all but one uses of use-stock property
Avoid the deprecated use-stock.

https://bugzilla.gnome.org/show_bug.cgi?id=736052
2014-09-04 14:14:31 +01:00
David King
cea2c74a3e panels: Avoid deprecated has-resize-grip property
https://bugzilla.gnome.org/show_bug.cgi?id=736052
2014-09-04 14:11:07 +01:00
Bastien Nocera
d7bda0bc2e datetime: Don't hard-code font size
Use a percentage instead.

https://bugzilla.gnome.org/show_bug.cgi?id=735973
2014-09-03 18:04:58 +02:00
Bastien Nocera
c515a6e67e network: Fix more potential crashers for WWAN
And virtual devices. Again, listening on the long-lasting client
object but expecting the user_data (the object) to be around when
it might have been destroyed already.

https://bugzilla.gnome.org/show_bug.cgi?id=735932
2014-09-03 18:04:58 +02:00
Bastien Nocera
a19c7ec977 network: Fix possible crash when wireless-enabled changes
The device we're handling might have disappeared already, but we're
listening on the NMClient object, which is still alive.

https://bugzilla.gnome.org/show_bug.cgi?id=735932
2014-09-03 18:04:58 +02:00
Bastien Nocera
15a98c3fd8 network: Show an error when we fail to turn off hotspot
And reset the switch as well. I don't know in which circumstance it
could happen, but it's all we can do for now.

https://bugzilla.gnome.org/show_bug.cgi?id=723643
2014-09-02 19:17:43 +02:00
Bastien Nocera
b108dedde6 network: Add hotspot_switch struct member
So we can access it directly when needed.
2014-09-02 19:17:43 +02:00
Bastien Nocera
cb93ad9782 network: Fix warning on startup with hotspot enabled
There's no back button anymore, so we shouldn't try to focus it.

Gtk-CRITICAL **: gtk_widget_grab_focus: assertion 'GTK_IS_WIDGET (widget)' failed
2014-09-02 19:11:43 +02:00
Bastien Nocera
df834ae74c network: Center "Wi-Fi hotspot" properties 2014-09-02 19:09:45 +02:00
Bastien Nocera
2ae2eabe2f datetime: Fix crash when setting year to 0
https://bugzilla.gnome.org/show_bug.cgi?id=735352
2014-09-01 14:43:51 +02:00
Bastien Nocera
4b04bc53fc privacy: Change the location label so it's short enough
And doesn't resize the shell width when switching panels.
2014-08-19 19:50:22 +02:00
Zeeshan Ali (Khattak)
7bcf4c189f privacy: Add location setting
For now its just a switch to enable/disable geolocation through
gnome-shell's setting. In future we'll hopefully at least have
controls to enable/disable geolocation for applications from here.

https://bugzilla.gnome.org/show_bug.cgi?id=731119
2014-08-19 19:03:52 +02:00
Christophe Fergeau
2dbcb26f16 keyboard: Use NULL rather than "" to disable keybindings
When disabling a keybinding, we set its value to { "", NULL } in gsettings
(bindings are stored as arrays of strings).
However, when a binding is disabled by default, its value is set to {
NULL }, not to the empty string.

The use of "" dates back to gconf where I think NULL was not a valid
value. Now that we have switched to gsettings, we can use NULL rather
than an artificial "".

https://bugzilla.gnome.org/show_bug.cgi?id=732383
2014-08-17 20:16:27 +02:00
Christophe Fergeau
ba9a8bc8ff keyboard: Add support for hidden keybinding XML data
If a KeyListEntry has a hidden="true" attribute, then the corresponding
binding information will be loaded as usual, but the binding won't be
displayed in the user interface.

This is useful as the keyboard panel will take into account hidden
keybindings when detecting conflicting shortcuts, or to suggest to set a
reverse shortcut.

For now, this will be used for the various reverse mutter keybindings
({switch,cycle}.*-backward) as they should not be shown in the UI, but
we still want the keyboard panel to know about them.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:27 +02:00
Christophe Fergeau
5572fb9a75 region: Remove "Shift" hack from region panel
The region panel hardcodes that to switch input source backward, one
uses the shift modfier with the shortcut to switch input source forward.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:27 +02:00
Christophe Fergeau
c77d164aa9 keyboard: Add 'reverse' metadata to switch-input-source shortcuts
Now that the keyboard panel knows how to handle reverse shortcuts, we
can start annotating the existing ones with the needed XML attributes.
This commit does that with switch-input-source{-backward}.
Note that some changes in some modules are needed for this to work
correctly.
In this case, a default value needs to be set for
switch-input-source-backward in gsettings-desktop-schemas, and the
Meta.KeyBindingFlags.REVERSED flag needs to be removed from the
shortcuts defined in gnome-shell source. Instead of having
mutter handle the reversion with 'shift' by itself, it's now handled
explicitly through gsettings keys.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
5147cf2502 keyboard: Suggest to automatically set reverse bindings
Since we now know when a binding has a 'reverse' binding, we can now
suggest to update the 'reverse' shortcut when the user set a shortcut
for one of them.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
f7c095bfe2 keyboard: Parse 'reverse' and 'is-reversed'
This commit adds support for 'reverse' and 'is-reversed' attributes when
parsing the KeyListEntry XML node.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
f059f42487 keyboard: Add 'reverse' helpers to CcKeyboardItem
In order to handle shortcuts which can be reversed (for example,
super-space and shift-super-space to switch input methods
forward/backward), we are going to add new attributes to the xml files
describing the keyboard shortcuts to show in the panel.

This commit is a first step towards that and adds the notion of
'reverse' items to CcKeyboardItem.

We will then indicate in the xml description files that
'switch-input-source' is reversed by 'switch-input-source-backward' and
that 'switch-input-source-backward' reverses 'switch-input-source'.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
10fd199b02 keyboard: Split accel_edit_callback
This function is getting a bit big, and the next commits will add more
code to it.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Ondrej Holy
3695f858dd user-accounts: use GtkStack instead of GtkNotebook in Add user dialog
https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-15 17:21:40 +02:00
Ondrej Holy
ed4653627b cc-editable-button: use GtkStack instead of GtkNotebook
https://bugzilla.gnome.org/attachment.cgi?bugid=694325
2014-08-15 17:12:30 +02:00
Bastien Nocera
71c76e9688 background: Make switcher button as tall as other buttons
https://bugzilla.gnome.org/show_bug.cgi?id=734803
2014-08-15 16:49:43 +02:00
Bastien Nocera
e397a8ab4e network: Build fixes
The WPA key size was missing, and we were comparing strings by pointer
address.
2014-08-15 16:18:47 +02:00
Stanislaw Gruszka
03bacf6f2c network: Create WPA protected AP hotspot if supported
Check if device supports AP mode hotspot with WPA/RSN (WPA2)
ciphers and set such mode and encryption if so.

http://bugzilla.gnome.org/show_bug.cgi?id=719852
2014-08-15 15:57:20 +02:00
Giovanni Campagna
9b364dfdfc search: add support for default disabled search providers
Search providers that should be disabled by default come with
a DefaultDisabled=true key in their keyfile, and are enabled
with the "enabled" whitelist, not with the "disabled" blacklist.

https://bugzilla.gnome.org/show_bug.cgi?id=734109
2014-08-15 14:46:47 +02:00
Kalev Lember
c5c870a558 keyboard: Port shortcuts tab to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Kalev Lember
c3d2631a9a keyboard: Port typing tab to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Kalev Lember
34d145b40d keyboard: Port custom shortcut dialog to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Ondrej Holy
0f3575b317 user-accounts: avoid removing non-existent GSources
Source id have to be zeroed correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=734548
2014-08-14 13:51:56 +02:00
Bastien Nocera
d9d5124997 network: Don't stop validating when we get an error
The previous code would stop validating when an error occurred which
meant that when a page contained multiple errors, only the first one(s)
to be checked would appear in red.

Now, all the errors will appear in red.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
117cf30500 network: Fix compile-time warning
Missing include.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00