Commit graph

180 commits

Author SHA1 Message Date
Marek Kasik
af40a98f80 Printers: Detect disconnection of printer
Connect to CUPS' "printer-stopped" event so the panel can change state
of the printer when unplugged (rhbz #743884).
2011-11-01 13:51:18 +01:00
Marek Kasik
6029100642 Printers: Set requesting-user-name when getting job info
CUPS has changed its policy for giving informations about jobs.
This fixes problem with actualization of list of print jobs.
2011-10-26 14:17:22 +02:00
Bastien Nocera
152398ff1f printers: Add label to toolbar buttons 2011-10-25 17:43:48 +01:00
Bastien Nocera
34dadb5ac3 printers: Avoid dereferencing NULL variable
If line is NULL, then buffer is NULL, and buffer[0] points
to nowhere.
2011-10-20 15:50:00 +01:00
Bastien Nocera
e9f95249a9 printers: Fix crasher if a or b are NULL in cmp
If a or b are NULL then (c && d) fails, and both a_normalized
and b_normalized are left uninitialised, possibly causing a crash
when we try to free them later.
2011-10-20 15:36:04 +01:00
Marek Kasik
86532624eb Printers: Make +/- buttons insensitive when can not connect to CUPS
Check whether sad computer is displayed and set sensitivity accordingly.
The check doesn't try to connect to CUPS because of performance reasons.
2011-10-14 19:23:50 +02:00
Marek Kasik
619364ff1a Printers: Don't add redundant prefix
Don't add prefix "-default" to options set by
PrinterAddOptionDefault method, it is added automatically.
2011-10-14 14:47:39 +02:00
Marek Kasik
4665e84df4 Printers: Don't hide address entry
Don't hide address entry when there is not firewalld available.
It is still possible that firewall is set up correctly and user
should be able to enter address of his network printer and
install it (rhbz #743694).
2011-10-11 16:32:06 +02:00
Bastien Nocera
0e119e480a printers: Fix build on systems without LC_PAPER
By using gtk_paper_size_get_default() directly to do all
the hard work for us.

https://bugzilla.gnome.org/show_bug.cgi?id=660692
2011-10-03 12:29:49 +01:00
Marek Kasik
710a8d5c1f Printers: check state of CUPS after start
Check whether CUPS is running and add regular check for the case
when it doesn't. Actualize printers list after CUPS' start (#659721).
2011-09-29 14:53:18 +02:00
Marek Kasik
92b64f1cab Printers: Hide spinner after search
Don't show spinner after search for new printers (#659753).
2011-09-23 16:06:23 +02:00
Marek Kasik
0d86715c01 Printers: Show that no printer was found
Notify user that no local/network printer was found after search (#659725).
2011-09-23 14:53:04 +02:00
Rodrigo Moya
82a9cdb2ed Disable remove button if no printer is selected
https://bugzilla.gnome.org/show_bug.cgi?id=659724
2011-09-21 16:49:44 +02:00
Marek Kasik
ffff7a7deb Printers: Match lower-case properly
The lower-cased string needs to be checked against a lower-case
string, or it's never going to match (found by Bastien Nocera in
gnome-settings-daemon).
2011-09-19 14:00:10 +02:00
Marek Kasik
df913a7cf7 Printers: Use system-config-printer's MissingExecutables method
If available, use DBus method MissingExecutables which finds executables
needed by new printer. This method is available in system-config-printer
since version 1.3.5 (#654742). User is offered installation of packages
containing those missing executables then.
2011-08-03 16:27:11 +02:00
Marek Kasik
eb18692613 Printers: Use system-config-printer's GroupPhysicalDevices method
If available, use DBus method GroupPhysicalDevices which removes duplicates
from list of found devices. This method is available in system-config-printer
since version 1.3.5 (#654742).
2011-08-02 17:11:25 +02:00
Marek Kasik
8951bc41a7 Printers: Use system-config-printer's GetBestDrivers method
If available, use DBus method GetBestDriver which determines the best PPD file
for the given printer. This method is available in system-config-printer
since version 1.3.5 (#654742).
2011-08-02 14:20:29 +02:00
Marek Kasik
7962a25ecf Printers: Open firewall for required connections when searching for printers
This commit enables services mdns, ipp, ipp-client and samba-client on
firewall for 5 minutes for detection of network printers (#648784).
It enables required services permanently for printers selected by user
for addition then. It shows a notification for the permanent enable.
It uses firewalld, so if it is not installed or running it shows a warning
message to the user in the place where discovered printers will be shown
(both local and network). The warning disappears after the finish of
printers discovery (but not from network part if no printer was found).
2011-07-27 13:33:48 +02:00
Matthias Clasen
88b47dc25b Add translation context in some places
"Local" and "Network" are not sufficiently unique, otherwise.
See bug 654725
2011-07-20 07:41:36 -04:00
Marek Kasik
337d7535b3 Printers: Make model label and ip address label selectable
This patch add selectable property into CcEditableEntry
and uses it in Printers panel (#651545).
2011-07-15 16:08:31 +02:00
Marek Kasik
47fb197d73 Printers: Remove redundant check
Remove check which is not needed.
2011-06-23 13:39:51 +02:00
Bastien Nocera
9aaef2614c printers: Force icons toolbar style
https://bugzilla.gnome.org/show_bug.cgi?id=651599
2011-06-21 15:47:16 +01:00
Marek Kasik
63edb0dcbe Printers: Include cups/ppd.h explicitly
cups/ppd.h is not included by cups/cups.h since CUPS 1.5.
2011-06-20 17:02:39 +02:00
Marek Kasik
3fe26cfe50 Printers: Move check for availability of CUPS to better place
Fixes problem of not showing information about stopped CUPS and
missing printers.
2011-06-03 12:51:57 +02:00
Marek Kasik
fba02faa49 Printers: Use SNMP CUPS backend to discover printers on given address
Search for printers on address given by user using CUPS's SNMP backend.
This modification typically finds network printers publishing themselves
on port 9100.
2011-05-27 15:38:59 +02:00
Marek Kasik
8f4895559a Printers: Allow editing of printer name and location
Use CcEditableEntry for editing name and location of local printers
(#649511).
2011-05-27 13:38:15 +02:00
Matthias Clasen
3e263c5764 Printers: Don't add a lockbutton
Instead, implement get_permission to get a lockbutton
in the toolbar.

https://bugzilla.gnome.org/show_bug.cgi?id=650292
2011-05-23 16:10:04 +01:00
Matthias Clasen
02c26cd2c0 Printers: use the new sidebar-list icon size
Also add some padding for good looks.
Overwhelmingly approved by #gnome-design.
2011-05-20 12:32:18 -04:00
Marek Kasik
60e9f49673 Printers: Check that GValue holds int before using it
Check that GValue returned as value of GTK_STYLE_PROPERTY_BORDER_RADIUS
holds int.
2011-05-16 10:43:18 +02:00
Matthias Clasen
c513d2b3aa Printers: Improve a11y of inline toolbars
Mark the labels of the add/remove buttons as translatable. While
these are not shown in the ui, orca reads them.
2011-05-15 23:53:11 -04:00
Matthias Clasen
f9c8d63585 Fix a11y/keynav issues in the printer panel
This adds some missing mnemonics.
2011-05-15 21:09:11 -04:00
Bastien Nocera
8dea9d125b printers: Use GTK+ lock button 2011-05-07 17:46:43 +01:00
Marek Kasik
03f49b9e3f printers: Check presence of new printer
Check successful installation of new printer by search
in list of destinations given by CUPS. Add index to the end
of name of new printer if the name is already used.
2011-05-06 13:39:37 +02:00
Marek Kasik
8164c8f7f9 printers: Improve search for PPDs for new devices
Improve logic for selecting PPD from available PPDs.
Try to find the best PPD if there is not an exact match
(rhbz#691808, rhbz#691701).
2011-05-06 12:31:42 +02:00
Marek Kasik
475f3fee9a printers: Make Add button insensitive until user select a printer
Set Add button in the PpNewPrinterDialog sensitive only if user select
a printer in the dialog (#648787).
2011-05-02 15:48:19 +02:00
Matthias Clasen
8a3368be65 Remove the subscription renewal timeout when the panel goes away
Otherwise, bad things (ie crashes) happen after 500 seconds...
2011-04-29 12:07:13 -04:00
Marek Kasik
7b830a3c6a printers: Cache PPD files for later use
Don't get PPD file from CUPS server every time user needs
an information from it. Have PPD files stored on disk and
delete them on exit.
2011-04-22 14:30:26 +02:00
Marek Kasik
6b0c9cacb2 printers: Set default PaperSize of new printer according to the locale
Set Letter or A4 according to the locale when adding new printer (rhbz#691714).
2011-04-19 13:30:02 +02:00
Marek Kasik
6e479859ed printers: Make call of DevicesGet cancellable
Pass a GCancellable object to g_dbus_proxy_call() for DevicesGet
method. This assures that g-c-c won't crash when user cancels addition
of new printer before the call is finished (rhbz#691931).
2011-04-18 16:14:27 +02:00
Marek Kasik
75cfa6db4d printers: Block callback of printer selection when setting treemodel
Don't trigger callback of printer selection when setting treemodel
of printers list. Don't actualize jobs list when printer hasn't changed.
2011-04-13 18:14:13 +02:00
Marek Kasik
2b3da7feb8 printers: Set default printer properly
Clean "~/.cups/lpoptions" file before setting default printer
on local CUPS server. Store default printer to "~/.cups/lpoptions"
if we are connected to a remote CUPS server (#646100).
2011-04-12 16:43:36 +02:00
Marek Kasik
84a2b3e353 printers: Don't set reason when setting AcceptJobs
Set reason to NULL when setting AcceptJobs to TRUE (rhbz#691154).
2011-04-05 17:50:18 +02:00
Marek Kasik
aedbc186a8 printers: Check whether the requested policy is available
Check whether the system has policy
"org.opensuse.cupspkhelper.mechanism.all-edit" before using it (#646813).
2011-04-05 17:10:54 +02:00
Marek Kasik
3349308ea2 printers: Actualize printer list and job list automatically
This patch makes Printers panel to automatically refresh printers list
when a new printer is added or removed. It is refreshed also when a printer
changes its state (to see changes in paused/unpaused state) (rhbz#691718).
It also automatically refresh list of jobs (and also number of active jobs in
main tab) for actual printer (rhbz#691737).
2011-04-05 15:54:09 +02:00
Marek Kasik
885bab172f printers: Do not delete browsed printers
Make "printer-remove-button" button insensitive when
a browsed printer is selected (rhbz#691831).
2011-04-01 16:19:16 +02:00
Marek Kasik
8444b2e38a printers: Make "Print Test Page" button always sensitive
Since "Printer Test Page" prints CUPS' testing page, we don't
need to make it insensitive when the printer doesn't support
"PrintSelfTestPage" maintenance command.
2011-03-29 16:21:14 +02:00
Marek Kasik
cd467f60f1 printers: Use CUPS' test page
Send CUPS' testing ps file to the selected printer when
user press "Print Test Page" button. Fallback to maintenance
command "PrintSelfTestPage" if the file doesn't exist.
2011-03-24 15:12:32 +01:00
Marek Kasik
bb577444b3 printers: Honor "disable-print-setup" setting
Make "Unlock" button and all widgets which depend on it
insensitive if "disable-print-setup" setting is true (#645337).
2011-03-23 15:44:47 +01:00
Marek Kasik
8d77636ac6 printers: Check for "all-edit" policy in "Unlock" button
The policy "all-edit" groups almost all policies from cups-pk-helper,
hence we don't need to authenticate more than once (#645533).
2011-03-23 14:05:31 +01:00
Marek Kasik
7e976baf86 printers: Show computer-fail icon when can not connect to CUPS
Show "computer-fail" under the text "Sorry! The system printing
service doesn't seem to be available." if we can not connect to
CUPS server (#641421).
2011-03-21 15:50:12 +01:00