Commit graph

19324 commits

Author SHA1 Message Date
Robert Ancell
aa59c003fe removable-media: Move signals into GtkBuilder and connect swapped 2019-10-29 10:21:16 +13:00
Robert Ancell
84b6257d36 removable-media: Move other combo box definition into GtkBuilder file 2019-10-29 10:21:16 +13:00
Robert Ancell
2546d02b3d removable-media: Drop unused widget IDs 2019-10-29 10:21:16 +13:00
Mohammed Sadiq
8821a37ed2 info: Implement new design
This is based on the design at
https://teams.pages.gitlab.gnome.org/Design/web-experiments/settings/about
2019-10-29 10:13:23 +13:00
Mohammed Sadiq
8950cd5ec2 common: Add cc-list-row 2019-10-29 09:48:08 +13:00
Robert Ancell
8a36c515e9 info-overview: Drop private structure
This class is not extended, so doesn't need it.
2019-10-29 09:47:41 +13:00
Alexandru Năstase
337e1efda0 info: Add 'hostname' keyword to info overview 2019-10-28 20:16:24 +00:00
Robert Ancell
4afbeff6ed network: Drop broken patches to import code from network-manager-applet
They are disabled, and aren't going to work due to other changes we have landed.
2019-10-24 08:02:43 +00:00
Robert Ancell
a1439b32b1 network: Remove unused virtual method 2019-10-22 20:11:45 +00:00
Robert Ancell
62af171d8b network: Remove net_object_edit virtual method
It didn't need to be virtual and was only used in two cases
2019-10-22 20:11:45 +00:00
Robert Ancell
926063acb3 network: Remove unused GObject property 2019-10-22 20:11:45 +00:00
Robert Ancell
0e10d2cab4 network: Drop class method for signals
These weren't used and contained a copy/paste error.
2019-10-22 20:11:45 +00:00
Robert Ancell
87b98346df network: Remove virtual method
Nothing ever overrode it; just convert to a normal method.
2019-10-22 20:11:45 +00:00
Robert Ancell
4dbea87109 network: Remove unused includes 2019-10-22 20:11:45 +00:00
Robert Ancell
7f410ee1c6 network: Remove helper functions
They're not complex enough or used in enough places to warrant keeping.
They can be better refactored in the classes that use them.
2019-10-22 20:11:45 +00:00
Robert Ancell
75b4e5e061 network: Simplify helper function 2019-10-22 20:11:45 +00:00
Robert Ancell
f03ae7ff93 network: Move common code UI into each widget using it
It was only used twice and better managed in the actual widgets.
2019-10-22 20:11:45 +00:00
Robert Ancell
9b1226aea5 network: Remove helper function with minimal value
This can be more easily optimised away in the modules that use it.
2019-10-22 20:11:45 +00:00
Robert Ancell
96585c1542 network: Remove unused hotspot connected label 2019-10-22 20:11:45 +00:00
Robert Ancell
4100c69d9c network: Move panel properties into GtkBuilder files 2019-10-22 20:11:45 +00:00
Robert Ancell
708b1fdaf7 network: Use self variable name consistently 2019-10-22 20:11:45 +00:00
Robert Ancell
8b6e3fb736 network: Store widgets inside objects
This is a step towards replacing GtkBuilder with GtkTemplate
2019-10-22 20:11:45 +00:00
Robert Ancell
b331d75df5 network: Rename widget IDs to standard names 2019-10-22 20:11:45 +00:00
Robert Ancell
53f9249b83 network: Remove unused GtkBuilder IDs 2019-10-22 20:11:45 +00:00
Robert Ancell
927f0f7954 network: Remove unused widgets 2019-10-22 20:11:45 +00:00
Robert Ancell
879542d92b network: Merge duplicate signal handlers 2019-10-22 20:11:45 +00:00
Robert Ancell
54f8fce47f network: Connect signals in swapped form 2019-10-22 20:11:44 +00:00
Robert Ancell
d549c9e7bd network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
4b9d8ac058 network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
8a3da8b36d network: Remove shared callback and replace with a method 2019-10-22 20:11:44 +00:00
Robert Ancell
f556af6e67 network: Move includes to correct file locations 2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328 network: Remove unused virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6 network: Refactor widget reference out using virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00
Robert Ancell
823a1dbdaa network: Make public struct private 2019-10-22 20:11:44 +00:00
Robert Ancell
bf43c64b63 network: Remove unused callback type 2019-10-22 20:11:44 +00:00
Robert Ancell
a41ad90671 network: Remove unused field 2019-10-22 20:11:44 +00:00
Robert Ancell
96bd167b77 network: Replace deprecated GtkTable with GtkGrid 2019-10-22 20:11:44 +00:00
Robert Ancell
84c53b01c5 network: Remove unused GtkNotebooks
The security widgets were inside GtkNotebooks, but only ever had one page and
tabs hidden. So they weren't doing anything.
2019-10-22 20:11:44 +00:00
Robert Ancell
e7cec00235 network: Remove unused wifi dialog
This seems to have been copied from the connection editor code, but is not
actually used.
2019-10-22 20:11:44 +00:00
Robert Ancell
ab0be62b78 network: Fix incorrect use of *_get_instance_private
These classes don't have a private structure, but the misuse didn't seem to be
causing a specific issue.
2019-10-22 20:11:44 +00:00
Robert Ancell
5183faea04 background: Fix crash if a BgRecentSource is unreffed during an async operation
The BG_RECENT_SOURCE (user_data) call was done before it was checked if is was
cancelled. At this point user_data is pointing to an object that has been deleted.

Fixes #729
2019-10-22 14:03:14 +00:00
Benjamin Berg
0fa4d11477 display: Use correct mode for supported scale checking
Monitors may not always have a mode. This means we cannot look up the
mode on the fly, but instead need to have a heuristic to select a mode
if there is none.

Everything was in place already for this, except that one location was
still doing a fresh lookup, possibly causing a crash.

Fixes: #675
2019-10-21 16:22:25 +13:00
Danial Behzadi
41c2843457 Update Persian translation 2019-10-19 15:04:51 +00:00
Mohammed Sadiq
4fe618254e applications: Fix a memory leak 2019-10-17 20:02:41 +00:00
Fabio Tomat
ab0969be72 Update Friulian translation 2019-10-17 12:45:06 +00:00
Goran Vidović
c35a6ef124 Update Croatian translation 2019-10-17 11:50:11 +00:00
Benjamin Berg
7631faa88f region: Explicitly update LC_* even when matching LANG
localed will not update the LC_* variables if they are not given. This
means that should the user switch the formats away from LANG and then
back, they will not be reset appropriately.

Simply always setting the variables even if the match will fix this.
2019-10-17 00:32:34 +00:00
Andre Klapper
397a0ce673 Correct incorrect timezone on world map for North Korea
Fixes #713
2019-10-17 10:05:56 +13:00
Ian Santopietro
3493b50be9 Use @theme_fg_color for .drag-handle
Instead of using @borders for drag handles, we use @theme_fg_color at 40% opacity. Because these are widgets intended to be interacted with by users instead of drawing borders, we should use a semantically appropriate color which updates according to whether a user has a dark theme selected or not. This ensures that the drag handles contrast with the background no matter what stylesheet the user is using.

This improves the contrast of these widgets in the light theme from 1.7:1 to 2.9:1, which is still rather low, but greatly improves the usability of these widgets without having too large an impact on the look of the widgets in-situ. The contrast ratio is unchanged in the HighContrast style (4.0:1).

This also improves the situation if we eventually adopt a dark style preference for users, and improves the portability of the application.
2019-10-15 18:54:30 +00:00