applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
15919 commits 324 branches 641 tags 195 MiB
Commit graph

280 commits

Author SHA1 Message Date
Piotr Drąg
bd4094d26e Fix grammar in a translators comment 2014-02-11 18:15:20 +01:00
Baptiste Mille-Mathias
c677c7e097 [po/fr] Correct the translation for "Lock Screen" 
In the background capplet, the string for "lock screen" was translated
"Verrouiller l'écran"
(https://git.gnome.org/browse/gnome-control-center/tree/po/fr.po#n59) but lock
is not a verb in this case but a noon.
So the translation should rather be something like "Écran de verrouillage"
Comment added accordingly to builder file.

https://bugzilla.gnome.org/show_bug.cgi?id=723967
 2014-02-09 21:14:43 +01:00
Debarshi Ray
57c83a1d59 background: Add a placeholder icon before creating thumbnails 
We do not wait until the first thumbnail is created to start filling up
the store. This avoids the "No Pictures Found" message from showing up
on slow machines were I/O and decoding the data may take a while.

However, placeholders are not shown for PNGs since they might be
screenshots.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
 2014-02-03 15:56:27 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Debarshi Ray
2e0687c0d3 background: Add JPEG 2000 to the list of valid content types 
https://bugzilla.gnome.org/show_bug.cgi?id=722599
 2014-01-20 15:01:47 +01:00
Debarshi Ray
04ef265fa0 background: Add PNM to the list of valid content types 
https://bugzilla.gnome.org/show_bug.cgi?id=722599
 2014-01-20 14:43:05 +01:00
Debarshi Ray
85a0016b7d background: The chooser should have exactly 3 columns 
The correct way to specify the number of columns is to use
gtk_icon_view_set_columns.

https://bugzilla.gnome.org/show_bug.cgi?id=720652
 2014-01-08 16:48:18 +01:00
Debarshi Ray
50269ab1d9 background: Fix a memory leak when add_single_file failed 
https://bugzilla.gnome.org/show_bug.cgi?id=708942
 2013-11-20 14:08:21 +01:00
Yosef Or Boczko
f5a2b6e2f7 background: Use margin-start/end instead of margin-left/right 
https://bugzilla.gnome.org/show_bug.cgi?id=712661
 2013-11-19 22:24:44 +02:00
Debarshi Ray
c852ece88a background: Consolidate exit path 
https://bugzilla.gnome.org/show_bug.cgi?id=708942
 2013-11-18 15:55:48 +01:00
Jasper St. Pierre
dd52ac9417 Add NoDisplay to all gnome-control-center panel .desktop files 
These aren't apps -- they're simply launchers for gnome-control-center.
They should not be shown as apps in the UI at all.

https://bugzilla.gnome.org/show_bug.cgi?id=712246
 2013-11-15 08:44:53 -05:00
Debarshi Ray
3ec49452a1 background: Consolidate exit path 
https://bugzilla.gnome.org/show_bug.cgi?id=708942
 2013-11-14 15:37:03 +01:00
Bastien Nocera
6edfb82652 background: Fix compilation with libsocialweb support 
The flickr source files were added to the wrong internal shared
library, so that the panel could be linked, but not the test
application.

https://bugzilla.gnome.org/show_bug.cgi?id=710829
 2013-11-12 08:49:20 +01:00
Kalev Lember
f08a22526c background: Fix test-chooser-dialog build with some linkers 
List missing libs for the libbackground-chooser.la convenience library.

https://bugzilla.gnome.org/show_bug.cgi?id=709302
 2013-10-16 13:23:17 +02:00
Kalev Lember
4ecb35ca12 background: Fix a memory leak with wallpaper loading 
This removes an extra g_object_ref when inserting items to GtkListStore:
the list store takes care of incrementing the reference count itself and
the caller doesn't need to do it.

https://bugzilla.gnome.org/show_bug.cgi?id=709453
 2013-10-07 10:35:52 +02:00
Kalev Lember
3491c6625c background: Fix reference counting in background XML loader 
Commit b9e3603ba4 added an unref to fix a
memory leak, but it went to a wrong place -- in XML loader, all items
are stored in a hash table that takes ownership of them, and destroyed
when the hash table goes away.

This commit fixes the reference counting in the XML loader and adds
explicit g_object_ref / g_strdup when inserting values to the hash table
to make the memory management more obvious.

The following commit fixes the real leak.

https://bugzilla.gnome.org/show_bug.cgi?id=709453
 2013-10-07 10:35:52 +02:00
Debarshi Ray
516e2a624f background: Remove unused variable 
Fallout from 79ec684fa4

https://bugzilla.gnome.org/show_bug.cgi?id=708943
 2013-10-04 13:40:11 +02:00
Debarshi Ray
7585b836be background: Set the size request only on the parent 
Instead of setting the size on each child, set it on the parent grid
because only one of those children are visible at any given point.

We are cheating a bit by ignoring the fact there is a second child
which is always shown -- the button box. This will make the other
children lose some height and the dialog will be smaller. However it is
still too big for smaller screens.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
 2013-10-04 13:37:13 +02:00
Debarshi Ray
f06a349a2a Use a consistent set of permissions when creating directories 
https://bugzilla.gnome.org/show_bug.cgi?id=709417
 2013-10-04 12:10:14 +02:00
Debarshi Ray
9ce45bfd3f background: Be robust against missing directories, and warn otherwise 
We want to track the busy state of the source. To do that we will keep
a count of the number of pending operations. Not having a check for
NOT_FOUND makes it slightly easier to do that. Not a big deal, but I
think it outweighs the downfall of showing an extra warning.

Plus we are trying to create the directories before using them, so the
warning means something fishy has been going on with your system.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
 2013-10-04 11:52:29 +02:00
Debarshi Ray
7a843ae428 background: Use the same method to set the initial view and toggle 
This makes it simpler for us to track the busy state of the sources.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
 2013-10-03 18:55:22 +02:00
Debarshi Ray
176e8c3057 background: Make it possible to use gtkparasite with the test 
The dialog has to be non-modal for us to be able to inspect it with
gtkparasite.
 2013-10-03 12:59:18 +02:00
Bastien Nocera
1445700c62 background: Align items in debug output 2013-10-02 19:30:14 +02:00
Bastien Nocera
42ddaffc9a background: Dump the selected item in the test program 2013-10-02 19:30:09 +02:00
Bastien Nocera
5d16f81821 background: Fix a memory leak when monitoring directories 
Destroy directory monitors on when the XML object is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 19:27:10 +02:00
Bastien Nocera
ca77b20062 background: Fix double-free when closing the dialog 
9955f17d introduced a double-free.
 2013-10-02 19:26:09 +02:00
Bastien Nocera
b9e3603ba4 background: Fix memory leak in XML signal handling 
When emitted in an idle, the item was correctly unref'ed, but not
when emitting the signal straight away.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 19:03:02 +02:00
Bastien Nocera
a0ab6d527f background: Fix memory leaks in slideshow handling 
A string was leaked when loading the name of the slideshow,
and a file object was left lingering as well.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
9955f17dd4 background: Fix memory leak in background item object 
Some fields were never freed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
ed589cd5b8 background: Fix memory leak in Pictures source 
The enumerator was never unref'ed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
d331444591 background: Add test program for the selection dialog 
https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
c2413a3c3e background: Fix leak of the Flickr source 
The Flickr source was never disposed of when destroying the
selection dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
e7433f1629 background: Fix leak of the preview picture 
https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Bastien Nocera
3942035180 background: Fix memory leak in the picture sources 
The list store was taking a reference to the background item,
so we need to unref it on our side to avoid leaking it.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
 2013-10-02 18:21:18 +02:00
Debarshi Ray
675bf324f8 background: Remove undefined method declaration 2013-09-30 18:59:37 +02:00
Jasper St. Pierre
a8b83d706b background: Fix crasher when entering/leaving the background panel 
g_application_get_dbus_connection() does not return a ref, so we
shouldn't try to free it.
 2013-09-12 15:53:41 -04:00
Bastien Nocera
015d29604a background: Fix debug message 
We're never capturing the whole screen, only a single monitor.

https://bugzilla.gnome.org/show_bug.cgi?id=706578
 2013-09-10 16:15:34 +02:00
Bastien Nocera
fd4cf7b881 background: Fix top bar location on dual-head 
For testing:
xrandr --addmode VGA1 1024x768
xrandr --output VGA1 --mode 1024x768 --left-of eDP1

https://bugzilla.gnome.org/show_bug.cgi?id=706578
 2013-09-10 16:15:31 +02:00
Bastien Nocera
a2872ff123 background: Remove empty finalize functions 
They were just chaining up.

https://bugzilla.gnome.org/show_bug.cgi?id=707602
 2013-09-09 16:24:56 +02:00
Bastien Nocera
00d8f80586 background: Use g_clear_* helpers when possible 
https://bugzilla.gnome.org/show_bug.cgi?id=707602
 2013-09-09 16:24:37 +02:00
Debarshi Ray
cc17b9d471 background: Don't access possibly invalid object 
The previous value of CURRENT_BG may not be valid after a call to
update_preview.

https://bugzilla.gnome.org/show_bug.cgi?id=707569
 2013-09-09 15:12:55 +02:00
Bastien Nocera
074f55e344 background: Add support for lock screen background 
https://bugzilla.gnome.org/show_bug.cgi?id=696166
 2013-08-20 00:35:30 +02:00
Bastien Nocera
ea16cadce9 background: Remove unused "lock" preview widgets 
https://bugzilla.gnome.org/show_bug.cgi?id=696166
 2013-08-20 00:35:30 +02:00
Bastien Nocera
1097d4ca75 background: Fix memory corruption when creating preview 
When using a single screen, the captured area was too small, and
we were copying data from out-of-bounds of the pixbuf area.

https://bugzilla.gnome.org/show_bug.cgi?id=696166
 2013-08-20 00:35:30 +02:00
Yosef Or Boczko
27e12bb7b0 background: drop GtkStock 
https://bugzilla.gnome.org/show_bug.cgi?id=704178
 2013-07-19 15:55:48 +03:00
Joshua Lock
60260e7b65 background: show explanation of why pictures source might be empty 
Show a message to the user when the Pictures source is empty, inspired both
in design and widget layout by the EmptyResultsBox from gnome-documents.

https://bugzilla.gnome.org/show_bug.cgi?id=630892
 2013-06-04 14:09:36 +01:00
Joshua Lock
9bad43e484 background: ensure background chooser is closed if panel changed 
If the background chooser is open and the user triggers a switch to a
different panel (i.e. from one of the gnome-shell indicators) the chooser
is still the topmost window and modal for g-c-c, however if the chooser is
interacted with in any way other than clicking the cancel button g-c-c
crashes.

Ensure that the chooser is destroyed if the panel is changed.

https://bugzilla.gnome.org/show_bug.cgi?id=700860
 2013-06-04 11:53:26 +01:00
Kalev Lember
35af441e31 background: Add missing semicolons to desktop files 
https://bugzilla.gnome.org/show_bug.cgi?id=696806
 2013-04-16 11:15:12 +02:00
Bastien Nocera
f9c0732a6c background: Fix handling of cancellation in async calls 
A few of the async calls were still handling the user_data before
checking that it was still valid (eg. the operation was not cancelled),
and also printing warnings when the error was a cancellation.
 2013-03-26 15:43:39 +01:00
Michael Wood
ce409d4542 background: Monitor the Pictures and cache directory for new files 
Monitor the pictures directory and cache directory for any new files
added or removed. Re-purposes the add/remove api that was no longer used.

https://bugzilla.gnome.org/show_bug.cgi?id=693329
 2013-03-01 11:13:19 +00:00