Commit graph

33 commits

Author SHA1 Message Date
Bastien Nocera
3942035180 background: Fix memory leak in the picture sources
The list store was taking a reference to the background item,
so we need to unref it on our side to avoid leaking it.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
00d8f80586 background: Use g_clear_* helpers when possible
https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:37 +02:00
Bastien Nocera
f9c0732a6c background: Fix handling of cancellation in async calls
A few of the async calls were still handling the user_data before
checking that it was still valid (eg. the operation was not cancelled),
and also printing warnings when the error was a cancellation.
2013-03-26 15:43:39 +01:00
Michael Wood
ce409d4542 background: Monitor the Pictures and cache directory for new files
Monitor the pictures directory and cache directory for any new files
added or removed. Re-purposes the add/remove api that was no longer used.

https://bugzilla.gnome.org/show_bug.cgi?id=693329
2013-03-01 11:13:19 +00:00
Michael Wood
09baf812ea background: Offload the sorting of the initial list of files
Sorting after the image scale for each image causes the list to change
as you're viewing it depending on the size of the image.
This can be quite jarring visually.

https://bugzilla.gnome.org/show_bug.cgi?id=691800
2013-03-01 11:13:00 +00:00
Michael Wood
c3446cccdc background: Sort Pictures in order of most recently modified
In the picture browser you see the most recently modified pictures
first.

https://bugzilla.gnome.org/show_bug.cgi?id=691800
2013-01-31 11:46:07 +01:00
William Jon McCann
79ec684fa4 background: New background panel design
Implement a new design for the wallpaper selection.

https://bugzilla.gnome.org/show_bug.cgi?id=676539
2012-08-17 17:57:27 -04:00
Cosimo Cecchi
761f5f0b8b background: always pass a cancellable down to I/O operations
So they will be properly cancelled when the panel is disposed.
Also, check early if the operation was cancelled, since it's not safe to
assume the data of the callback is valid anymore before that point.

https://bugzilla.gnome.org/show_bug.cgi?id=672572
2012-06-11 09:16:44 -04:00
Bastien Nocera
3d79e1174e background: Only show the image types we support
And add image/bmp to those types.

https://bugzilla.gnome.org/show_bug.cgi?id=669960
2012-05-17 18:12:49 +01:00
Jon McCann
0bb2e2142a background: Sort Pictures folder by name
https://bugzilla.gnome.org/show_bug.cgi?id=672925
2012-04-26 11:13:12 +01:00
Bastien Nocera
a3055b3202 background: Ignore screenshots
Don't list screenshots coming from gnome-screenshot in our
Pictures source.

https://bugzilla.gnome.org/show_bug.cgi?id=672925
2012-04-26 11:07:08 +01:00
Rodrigo Moya
aa850977a5 background: Allow SVG image files as background
https://bugzilla.gnome.org/show_bug.cgi?id=648764
2011-08-30 10:31:23 +02:00
Alexander Larsson
4e06cd6236 Fix includes for gdesktop-enums.h
The file is in $incdir/gsettings-desktop-schemas/gdesktop-enums.h,
and pkg-config returns -I$incdir/gsettings-desktop-schemas, so the
right way is to #include <gdesktop-enums.h> which is what other modules
do.

https://bugzilla.gnome.org/show_bug.cgi?id=642369
2011-02-17 20:59:55 +01:00
Bastien Nocera
a1dd22ea17 background: Add/Remove features in pictures source
Remember added files, so they cannot be added twice to the pictures
store (using UUID of the URI as key).

Implement removing items from the list.

Fix memory leaks.
2011-02-14 19:11:20 +00:00
Bastien Nocera
e6cb9f5b12 background: Add ability to add a single file
To the pictures backend.
2011-02-14 13:26:39 +00:00
Bastien Nocera
2866a70f6a background: Don't show an error if no cache dir
We don't want to see errors if the directory doesn't exist.
2011-02-14 13:26:39 +00:00
Bastien Nocera
9ac7a0aa32 background: Remove code for impossible situation
We can never have placement be "none" as we create new items
with "scaled" by default. So just set "zoom" all the time.
2011-02-14 13:26:39 +00:00
Bastien Nocera
87f05ef0ed background: Also look for items in ~/.cache
We'll be saving items in ~/.cache/gnome-control-center/backgrounds
for the Flickr and manual additions of items, so look there as well.
2011-02-14 13:26:39 +00:00
Bastien Nocera
329aabf0b1 background: Set the shading for pictures 2011-02-14 09:44:05 +00:00
Bastien Nocera
c016e5cea2 background: Remove the "changed" signal
It wasn't used anyway.
2011-02-12 03:13:50 +00:00
Bastien Nocera
555bf47f51 background: Load bg data when selected
And only when selected. There's no point in loading it straight
away, as we have more than enough metadata to display it in the
icon view, and we'll need to load up the data when we display
it anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=641414
2011-02-11 19:01:20 +00:00
Bastien Nocera
2735c788b4 background: Use URIs everywhere internally
Now we'd just need gnome-bg to make the jump.

This also fixes unique IDs for the wallpapers source, as
multiple backgrounds can be defined in a single XML file.
2011-02-11 18:11:11 +00:00
Bastien Nocera
9e3903a828 background: Set the flags for the pictures source 2011-02-11 03:49:49 +00:00
Bastien Nocera
ca14846ef9 background: Major rework of the CcBackgroundItem code
It now is a full GObject, will be able to track the original
XML file for a wallpaper, as well as which values are set in it.

This will allow us to restore wallpapers properly, and only offer
editing options when those aren't already hard-coded inside the
item.
2011-02-10 20:35:02 +00:00
Bastien Nocera
9a209fa181 background: Rename gnome-wp-item to cc-background-item 2011-02-10 20:35:02 +00:00
Bastien Nocera
391cb33829 background: Avoid empty screens
When switching from a colour to a picture.
2010-12-16 18:37:59 +00:00
Bastien Nocera
44fbef70a2 background: Load ~/Pictures asynchronously
Using the new gdk-pixbuf helper functions in 2.23.0.

https://bugzilla.gnome.org/show_bug.cgi?id=635601
2010-12-13 16:19:58 +00:00
Bastien Nocera
9580be8d17 background: Avoid re-querying the GFileInfo
If we already have it from enumerating the Pictures directory. Saves
us from doing sync queries in certain cases.
2010-12-13 15:30:22 +00:00
Andreas Proschofsky
32f59e6df5 all: Fix build for latest gnome-desktop changes
https://bugzilla.gnome.org/show_bug.cgi?id=634859
2010-11-14 22:12:59 +00:00
Thomas Wood
ce8cd97754 background: implement new UI design from Jakub Steiner 2010-08-25 19:18:05 +01:00
Thomas Wood
2b56a5ea0f background: fix various leaks
Fix various leaks found by valgrind.
2010-08-12 15:12:04 +01:00
Thomas Wood
abdb42e9e2 background: derive background sources from a common source object
Add the BgSource object to define the common aspects of background sources
and make sure the existing sources inherit from it.
2010-08-10 17:01:15 +01:00
Thomas Wood
e721f417ad Add initial implementation of "background" panel
The background settings panel provides a way for users to change the
desktop background by selecting an image and/or colour.
2010-08-10 15:26:07 +01:00