Commit graph

6044 commits

Author SHA1 Message Date
Robert Ancell
3a7533da1b printers: Use g_autoptr for the results of D-Bus calls 2020-03-30 03:24:58 +00:00
Robert Ancell
67074b7aea printers: Fix GVariantIter leaks 2020-03-30 03:24:58 +00:00
Robert Ancell
46443af0ca printers: Replace GVariant iteration with direct call to copy value 2020-03-30 03:24:58 +00:00
Robert Ancell
9065850b92 printers: Replace g_variant_iter_next_value with the simpler g_variant_iter_next 2020-03-30 03:24:58 +00:00
Robert Ancell
5b14e16e9c network: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
e6128c9ffd wacom: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
b7fbe4a72d printers: Use consistent value for GtkBuilder signal properties 2020-03-30 16:18:50 +13:00
Robert Ancell
4502673b6c printers: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
f1b84e29ef common: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
100d3684f2 user-accounts: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
a6d5678dc8 power: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
c0cfbeccff display: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
b4922526c1 applications: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Robert Ancell
7b0dc2ecee default-apps: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
f1893b8e8b color: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
591cd14b57 mouse: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
74eb5d9855 usage: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
3e4c1d3822 sharing: Move GTK code that was innappropriately in a helper function 2020-03-30 16:18:49 +13:00
Robert Ancell
10e73b733b sharing: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
6ae9710a50 universal-access: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
3eb0aaec28 background: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
1862ec50e4 keyboard: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:49 +13:00
Robert Ancell
ece1911f40 online-accounts: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 02:13:43 +00:00
Robert Ancell
97ac89b88f online-accounts: Use GTK widget types 2020-03-30 02:13:43 +00:00
Robert Ancell
e9ca51789c background: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 02:05:38 +00:00
Robert Ancell
7e0a66226b background: Use GTK widget types 2020-03-30 02:05:38 +00:00
Robert Ancell
2f57847381 background: Remove unused variables 2020-03-30 02:05:38 +00:00
Robert Ancell
4b0d47eaa4 background: Connect signals in swapped form 2020-03-30 02:05:38 +00:00
Robert Ancell
23db1e9933 applications: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 01:57:06 +00:00
Robert Ancell
0beed338af applications: Use GTK widget types 2020-03-30 01:57:06 +00:00
Robert Ancell
ef9b0c7313 keyboard: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 01:49:50 +00:00
Robert Ancell
ee4d08ca1d keyboard: Use GTK widget types 2020-03-30 01:49:50 +00:00
Robert Ancell
f00a5e20cb display: Fix wrong widget type used 2020-03-30 01:45:57 +00:00
Robert Ancell
73469d3ba2 display: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 01:45:57 +00:00
Felipe Borges
40c8426f15 background: Allow adding multiple files to backgrounds
Fixes #889
2020-03-29 22:38:55 +00:00
Felipe Borges
57eae62c6e printers: Add whitespace between top right buttons
Fixes #895
Fixes #685
2020-03-29 22:34:17 +00:00
Robert Ancell
7a65d113f2 sound: Remove unused files
These were accidentally added as part of ths sound panel redesign.
2020-03-19 16:22:20 +13:00
Jian-Hong Pan
00081c434c display: Fix the resolution going to be tested
Gnome-control-center checks the display modes by
cc_display_config_is_scaled_mode_valid()
  ...
  cc_display_config_dbus_is_scaled_mode_valid()
to exclude unusable low resolutions.

However, it is the current using resolution that going to be tested by
is_scaled_mode_allowed() in is_scale_allowed_by_active_monitors(), if it
is global scaled required or configured as cloning mode originally.
Therefor, it will check current using resolution again and again,
instead of the enumerated one. This leads gnome-control-center building
wrong resolution list on the panel.

This patch replaces the current mode with the enumerated mode to have
the correct resolution to be tested by is_scaled_mode_allowed().

Fixes #903
2020-03-10 17:49:22 +08:00
Felipe Borges
a09fbc3054 network: Make the VPN gear buttons' style consistent with other butons
Fixes #890
2020-02-29 17:53:00 +00:00
Felipe Borges
20566947ee info-overview: Set "Rename" button insensitive if no changes are made
Fixes #879
2020-02-28 15:43:44 +01:00
Felipe Borges
875df8d758 printers: Show the CcPermissionInfobar for all views
We were only presenting the permission infobar when there were
already printers added (printer-list view).

We also want users to see the infobar when they don't have any
printers (empty-page).
2020-02-25 17:59:30 +00:00
Robert Ancell
dcedf93e72 sharing: Add missing widget cast
Was missed in a5de11c3d6.
2020-02-25 09:46:13 +13:00
Felipe Borges
3785d79ccf background: Don't warn for invalid xml tags
g_warning () is for environment errors. Additional tags than the
ones we require are not necessarily an error.

This behavior causes g-c-c to spam the journal with entries such
as:

Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author

Where "license", "email", and "author" are valid tags that we just
don't use.
2020-02-21 13:47:42 +01:00
Allan Day
4894057b7d applications: update icon
application-x-executable didn't look very good here. 
adwaita-icon-theme now has a dedicated icon for this panel, which is 
better suited - preferences-desktop-apps. Use this instead.
2020-02-20 20:16:00 +00:00
Felipe Borges
36db009819 notifications: Invert the "Do not disturb" switch
The switch is binded to the "show-banners" gsetting. When DnD is
ON, users don't want banners, therefore "show-banners" is OFF.

For this reason we need to invert the switch.

Fixes #878
2020-02-20 15:05:09 +00:00
Tobias Bernard
27b88c2ce6 Background: change thumbnail size to 154 2020-02-19 10:59:28 +00:00
Julian Sparber
2e1dc3da00 background: add remove button overlay to recent section 2020-02-19 09:37:26 +00:00
Florian Müllner
33c23eaef6 background: Remove lock-screen preview
Without different lock-screen settings, there's little reason to
keep showing a lock-screen preview. So rather than updating the
preview to a blurred version of the regular background, just remove
it altogether.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/864
2020-02-19 09:37:26 +00:00
Florian Müllner
7c436727a3 background: Simplify background-chosen signal
Now that there's only a single background to set, there's no use for
a flag parameter to specify the background(s).

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/864
2020-02-19 09:37:26 +00:00
Julian Sparber
159c9afe93 background: Remove the popover
In 3.36, we will use a heavily blurred wallpaper on the lock screen.

As that wallpaper will be unrecognizable, there is no good reason to
pick a different one from the regular session. The shell will therefore
stop using the separate lock-screen settings.
The popover isn't needed anymore because it would only have one option:
to set the wallpaper. And an additional option for the recent section to
remove the wallpaper for the list, which can be done via a overlay
button.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/864
2020-02-19 09:37:26 +00:00