From a Coverity scan:
panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop
increment "i++;" is unreachable, the loop body will never execute more
than once.
This seems like a logic thinko introduced in commit
3207fe97ec . In practice it was unlikely
to be a problem since we don't have repeated shortcut gsettings key
names in all our KeyListEntries files.
Add an extra button "Clean Print Heads" that will be shown when the relevant
maintenance command is available for a printer, to bring this feature back.
Additionally, this commit adds a 'parameters' attribute to PpMaintenanceCommand,
which is needed as the "Clean" command requires to at least be passed "all" as
its single parameter: https://www.cups.org/doc/spec-command.html#Cleanhttps://bugzilla.gnome.org/show_bug.cgi?id=764620
Widgets on local and enterprise pages of add user dialog don't have
same width regardless of size groups. It is caused by different margins
and borders of various widgets. Let's change them to be like in mockup.
https://bugzilla.gnome.org/show_bug.cgi?id=778457
This ensures that:
- the AP list shown on startup when the Hotspot is disabled on
startup, or when disabling it at run-time
- the hotspot page is shown on startup when the Hotspot is enabled,
or when it gets enabled at runtime
https://bugzilla.gnome.org/show_bug.cgi?id=705546
The dialogue offers the 5 separate cursor sizes that adwaita's cursor
theme supports, aligned in a row.
The cursor sizes are described in a way that doesn't judge their
respective sizes, but simply describes them.
https://bugzilla.gnome.org/show_bug.cgi?id=608231
The flatpak notification portal reads permissions out
of the permission store, so forward the notification
permissions there in order to prevent sandboxed
applications from sending notifications.
The difference is a bit cosmetic, since the shell would
not show the notification anyway in this case, but it
is nicer to just cut off the calls and not let them
through the portal in the first place.
https://bugzilla.gnome.org/show_bug.cgi?id=778851
In the Printers panel, the model label of a given printer
may be a long string, specially when it's composed of the
versioning and specifics of the printer.
Because the model label doesn't ellipsize, we may have very
long labels, making the entire Control Center very wide and
unresizeable.
Fix that by making the model label ellipsize.
https://bugzilla.gnome.org/show_bug.cgi?id=779376
We were actualizing the whole printers collection everytime
something should change.
These patch introduces a HashTable keyed by the unique printer.name,
which allows us to access individual instances of PpPrinterEntry.
https://bugzilla.gnome.org/show_bug.cgi?id=779079
The previous implementation of the panel was unable to individually
update a PpPrinterEntry jobs count and its PpJobsDialog.
These changes make the job notifications trigger updates in the
PpPrinterEntry UIs, keeping track of job events on the go.
https://bugzilla.gnome.org/show_bug.cgi?id=779079
Long location names were causing the whole dialog to expand
horizontally.
This patch ellipsizes the "location" string just like the
other fields of a printer entry.
https://bugzilla.gnome.org/show_bug.cgi?id=779071
The label indicating which photo in the Carousel belongs to the
current user had the <small> markup within the translatable string,
causing unnecessary work for translators. See
https://wiki.gnome.org/TranslationProject/DevGuidelines/Avoid%20markup%20wherever%20possible
This patch formats the string with g_strdup_printf, leaving the
markup tags out of the translatable message.
When credentials expire, they're being added horizontally since
this is the default value of the GtkOrientable:orientation property.
Fix that by making the account editor box vertical, and adding some
spacing.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
When the user has no account set, the current implementation of the
Online Accounts panel shows a weird 1px line that is the empty list.
Fix that by only showing the list when there are accounts available.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
We have different variants of the same code that iterates over all the
rows in a GtkListBox to find the one that corresponds to a given
account. Some action is then performed on the row, depending on the use
case at hand. In future we might want to look at the other rows in the
list to decide whether to hide the entire GtkFrame or not.
Let's consolidate this to reduce some duplication.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
This will make the subsequent commits easier to read.
We are going to change get_row_for_account to be more generic. Moving
this code higher up will let us use it from a few more call sites.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
The current implementation of the Online Accounts panel allows
2 states: either the widgets of the panel fill the whole horizontal
space, or they shrink and fill only the absolutely minimum. The
ideal solution, however, is to make them grow with the panel.
Fix that by turn the main box into a GtkGrid, and adding stub widgets
that expand horizontally and pull the main widgets to the middle,
allowing them to cover at most 1/3 of the screen. The widgets themselves
are inside a GtkBox, so that hiding them automatically removes the
spacing in between.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
When offline, we currently block the new accounts listbox
so that users can't add new accounts. There is, however,
no visual indication that we're offline, besides the listbox.
Fix that by adding a descriptive label that's only visible
when offline.
https://bugzilla.gnome.org/show_bug.cgi?id=774222
pp_printer_rename_async is better than the old printer_rename
utility.
The PpDetailsDialog doesn't need to do anything in the callback
since we are emiting the "printer-changed" signal when the dialog
is closed.
https://bugzilla.gnome.org/show_bug.cgi?id=769114
