This fixes an issue when on_get_job_attributes_cb()
was called after Printers panel has been finished.
It adds a GCancellable to pp_job_get_attributes_async()
calls.
`dest_x` is not set if `gtk_widget_translate_coordinates()` fails, which
it can do before the widget is realised.
This fixes a valgrind warning, but doesn’t change any user-visible
behaviour as far as I can tell.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
!97 added a do not disturb switch to GNOME Shell. This works by
changing the org.gnome.desktop.notifications.show-banners setting.
The switch that controls this setting in the control center should
therefore use the same Do Not Disturb label as the switch in the
shell.
Changes made by GNOME/gnome-control-center!359 caused that the username
hint ("This will be used to name your home folder and can’t be changed.")
is not shown immediately after opening the "Add User" dialog. This change
was unwanted. Let's show the hint immediately after opening the dialog as
it was before.
gtk_widget_translate_coordinates() doesn't have to always set the
dest_x argument. Let's initialize the argument before use to prevent
usage of uninitialized value, which also prevents "Conditional jump
or move depends on uninitialised value(s)" messages from valgrind.
Make it clearer in two ways:
• Explicitly mention ‘metered data’, as that’s a commonly used phrase.
• Explicitly mention automatic software updates as being disabled on
metered connections, to make the implications of this checkbox a
little clearer.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Helps: https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/339
The "CcPermissionInfobar" widget is a more descriptive way to
communicate that some Settings panel needs authentication in order
to perform certain actions.
This widget doesn't handle the permissions (as in GPermission)
itself. It needs to be binded to an existing instance of GPermission,
and it will react to the permission's state (show when the current
user is not authorized, and hide when the user is authorized).
This is part of a big set of changes that aim to set a consistent
authentication method accross Settings panels.
See #685, #556, and #771
The same way that GNOME Shell does it, we set:
* audio-volume-muted-symbolic when mute button is toggled*
* audio-volume-low-symbolic when 0 < volume < 30%
* audio-volume-medium-symbolic when 30% < volume < 70%
* audio-volume-high-symbolic when 70% < volume <= 100%
When "muted" we can't actually rely on volume (it can be close
to zero but not absolute zero). Instead of requiring volume == 0,
we track the state based on whether the mute button is active.
Fixes#521
A little above in the function, we update the page UI, maybe destroying
the bits that allow decoupling display-attached tablets from their display.
Later on, we unconditionally update its GtkSwitch.
This can't bode well on tablets where the widget was already destroyed.
We store the list of "Search Locations" in a gsetting. When a location
gets added and then removed, the gsetting still stores its path.
These changes verify the existance of a file before loading it in the UI,
and also removes the path from the gsetting when the location can't
be found.
Fixes#812
While dragging a row in order to reoder the search list, we create
a fake copy of the row that gets dragged into the position where
the user wants the row to be in. This fake row should have its
switch matching the state of its master copy.
Fixes#810
Being the VPN list actually a collection of listboxes, this function
ensures it looks alright in other places. However the case of removing
all VPN connections till we're back empty was missed.
