Instead, instantly show a primary click was successful. For a double
click, it will remove the primary click success. This makes the testing
feel a little more responsive.
Closes#2991
- Add GtkLabel:wrap, otherwise qr-code-dialog width will grow
if the label is long
- Justify the label to the center so it looks more balanced
when it wraps
The "Network Name" and "Password" labels look unbalanced if they
are long. To fix this, use property rows to show the network
information, which also involves porting the GtkScrolledWindow
to AdwPreferencesPage.
- Make the QR code focusable, so the alternative text can be read
by Orca
- Make all labels selectable, but with a workaround to prevent them
showing selected without any user interaction (labels need to be
selectable so they can be read)
This placeholder row will never show because the list box will never be
empty due to the presence of the "Add Input Source" row, which also acts
as a placeholder. Also, the placeholder row broke the list box row
counting even more.
So, remove the "No input source selected" placeholder row, as it's
unnecessary.
The indicators should only light up for primary or secondary clicks, but
not for a middle click.
To make this clearer too, we can use Gdk constants.
Fixes#3079
This saves a lot of code and translatable strings. Also, this will make
it easier to change the list values in the future, as they will be added
to the list even if a value is set that is not in the list.
By binding to the GSettings keys directly, even more code can be
removed.
This reverts commit 62564c623f.
The custom style class was used to provide different styling than the default destructive style, since the custom style class doesn't affect the opacity of the background.
Similarly to fd65182, rpminspect catched that gnome-wifi-panel.desktop
references an icon name that doesn't exist.
```
Desktop file /usr/share/applications/gnome-wifi-panel.desktop on x86_64 references icon network-wireless but no subpackages contain network-wireless
```
The way the icon lookup works will suffix it with "-symbolic", resulting
in "network-wireless-symbolic", which exists.
While MR !2452 provided settings icons for various panels, it didn't for
the Wifi panel.
Apparently, the coverage-html target can't be directly compiled via
meson, but ninja has to be used directly.
So, revert the change from commit 7f541b42 for the coverage job.
Coverage needs to do its own configuration for the coverage report.
Perhaps it can reconfigure the meson directory from the build stage, but
let's just have Coverage do the build as well.
So, don't depend on anything but the container.
This simplifies the Meson build file, and removes the inline mkenums
template code, which is now inside Meson itself.
Also, we can now use the better prefix `G_DESKTOP_TYPE` instead of
`G_DESKTOP_TYPE_DESKTOP`.
This simplifies the Meson build file, and removes the inline mkenums
template code, which is now inside Meson itself.
Also, we can now use the better prefix `G_DESKTOP_TYPE` instead of
`G_DESKTOP_TYPE_DESKTOP`.
The most common use case for CcNumberRow is to bind it to a GSettings
key value.
So, let's add an easy function to perform such a binding. It binds the
"selected" property of the underlying AdwComboRow GSettings value using
mapping functions. If the value does not exist in the CcNumberRow yet,
it will be added to the list of the row and selected.
It makes sure both unsigned and signed values are properly handled, as
CcNumberRow only holds signed values.
To make the CcNumberRow easier to use for newcomers as well, let's stop
using GtkExpression directly. Instead, we introduce a `value-type`
property that tells the CcNumberRow how to interpret values and map them
to strings.
With the `custom` value type, a custom GtkExpression is still usable.
When a new account is successfully added, simply close the dialog,
revealing it to be in the list of accounts, rather than showing
the account details.
closes#3067
The current GTK 4.15.1 contains an issue for CSS deprecation warnings
that causes criticals, making our tests fail.
This was fixed by gtk!7306, so build from source to have that available.
Again, we do this in the container, to speed up builds but to also have
a stable version in CI for longer.
Building dependencies from source (like Libadwaita) can take some time,
so doing it for every build is inneficient.
But more importantly, since commit bc5c9976, the tests depend on the
build output, but don't actually build. So any dependencies for running
the tests must be available globally.
Therefore, build dependencies into the container.
Also, only clone with depth 1, as nothing more is needed.
Doing, so this will improve consistency as other places in
Settings use property rows [1]. This also ensures that the
network name doesn't get ellipsized if it's long when using
a narrow window width.
[1]
- feb2c8c514
- 5cd300c65a
- d5c66d25a0
Now that the search entry was put in a GtkSearchBar in [1],
the search entry got a bit smaller, breaking a little what
[2] fixed.
To fix this, remove the "maximum-size" and the
"tightening-threshold" from the AdwClamp that contains the
search entry. This will also make the search entry size to
be consistent with the one from cc-keyboard-shortcut-dialog,
which is also a top child of AdwToolbarView.
[1] cd97e4f518
[2] ec01b9d629
When the entry changes, it triggers the callback dance to store the
values in the backend. Causing `gtk_editable_set_text` to be essentially
called every REMOTE_DESKTOP_STORE_CREDENTIALS_TIMEOUT_S seconds (2
seconds) even when credentials have changed. This call has visual
effects, such as moving the cursor caret and changing the entry
selection state.
Fixes#3077
Also:
- Remove "select_from_database_button" and "install_ppd_button"
object IDs, as they are unused by the C code.
- Remove the default-height from the window to avoid showing an
unnecessary scrollbar now that the AdwButtonRows takes more vertical
space
The goal here is to avoid the dialog and follow a pattern of subpages we
have in other panels.
This dialog is often launched from Nautilus over the
`gnome-control-center search locations` launching argument, making it
even worse as a dialog.
