Commit graph

8179 commits

Author SHA1 Message Date
Automeris naranja
19db526413 column-chooser: Move AdwBanner to the content widget
AdwBanner isn't a toolbar and AdwToolbarView won't
be able to style it correctly.

Wrap AdwPreferencesPage and AdwToolbarView into a
GtkBox and place it inside the content widget.
2024-02-01 09:16:55 +00:00
velsinki
869dfb990e system/about: Fix crash after dark mode switch
Commit f3f81d37 added a signal connection between dark mode changes and
updating the OS logo in the About page. However, this signal was not
disconnected, causing a crash when changing the dark mode after leaving
the About page.

Fix this by using `g_signal_connect_object ()` instead.

Fixes #2854
2024-01-31 14:03:05 +01:00
Felipe Borges
484866e27e system, wwan: Depend on gcr4 2024-01-31 10:38:07 +01:00
Felipe Borges
5ed0b3e1f8 sharing: Remove unused pwquality and pwd.h dependencies
Those were leftovers from when the Remote Desktop settings got moved
into the System panel.
2024-01-31 10:38:07 +01:00
Felipe Borges
dc514d3df1 sharing: Remove unused "gcr/gcr-base.h" include
This was part of the Remote Desktop code that now is part of the
System panel.
2024-01-31 10:38:07 +01:00
Felipe Borges
196987d7ad system, remote-desktop: Use a single rdp_settings object
A GSettings object was being created in multiple places when that
could be simplified.
2024-01-31 09:37:20 +00:00
Felipe Borges
590513352a system, remote-desktop: Don't show the panel when backend is unavailable
Let's not show the page neither crash when there are issues with
finding the remote desktop gsettings in the system, or when the
RemoteDesktop name didn't appear on dbus.

Fixes #2874
2024-01-31 09:37:20 +00:00
Felipe Borges
61dd1b2adf system, remote-desktop: Remove sharing proxy connection
This is a leftover from the previous implementation in the Sharing
panel and has no use here.
2024-01-31 09:37:20 +00:00
velsinki
9716575162 network: Fix missing VPN entries
This required some archeology: 52d28579 introduced virtual device
support. This was done by getting the virtual device name and testing if
that was `NULL`. Then came 8861d440, which removed virtual devices, but
did not revert fully to the behavior before 52d28579. Combined with
9183d349, this meant that any VPN that has an interface name set, will
never be displayed.

Fix this by reverting to the behavior before 52d28579, while keeping
wireguard support. The added check from ddc35609 is left in, although it
is not clear to me if that is still needed.

Fixes #2822
2024-01-30 17:02:00 +00:00
Florian Müllner
feddd1b559 universal-access: Stop tracking old GTK theme
Nothing uses it anymore.
2024-01-30 14:45:26 +00:00
Florian Müllner
3cc39bd280 universal-access: Stop forcing HighContrast icon theme
The theme is considered deprecated in favor of symbolic icons from
the regular theme, and both gnome-shell and the gnome portal stopped
linking it to the high-contrast setting.
2024-01-30 14:45:26 +00:00
Automeris naranja
a3681a50fd search-locations-dialog: Add tooltip to the remove button 2024-01-30 13:44:07 +00:00
Automeris naranja
00d9cd012f sharing: Add tooltips to some icon-only buttons
Also, remove a11y labels from these buttons,
because a11y labels and tooltips are redundant
(Orca reads both).
2024-01-30 13:44:07 +00:00
Felipe Borges
305c89e71d system, about: Use CcHostname to obtain properties from system-hostnamed 2024-01-30 13:34:10 +00:00
Felipe Borges
47774b9968 privacy: Use CcHostname to detect when running in a VM
We currently hide "Device Security" when running in a VM or an
undefined systemd-hostnamed chassis-type.

This makes our existing check use the CcHostname utility.
2024-01-30 13:34:10 +00:00
Felipe Borges
cd911dfa5d display: Use CcHostname to detect when running in a VM
Instead of a manual call to system-hostnamed to obtain the chassis-type
and compare whether it is equal to "vm".
2024-01-30 13:34:10 +00:00
Felipe Borges
70888ea71d power: Use CcHostname to obtain the systemd-hostnamed chassis-type 2024-01-30 13:34:10 +00:00
Felipe Borges
270347e66c system, remote-desktop: Use CcHostname to get the host display name 2024-01-30 13:34:10 +00:00
Felipe Borges
69a6abd0fa network: Make NetDeviceWifi use CcHostname to obtain the display name 2024-01-30 13:34:10 +00:00
Felipe Borges
e924a830b4 common: Make CcHostnameEntry use CcHostname to access hostnamed 2024-01-30 13:34:10 +00:00
Felipe Borges
8def72a266 common: Introduce CcHostname
This object allows for panels to interact with systemd-hostnamed over
DBus using a simple API that abstracts the GVariant and DBus specifics
involved.
2024-01-30 13:34:10 +00:00
Automeris naranja
2c04c9dfc9 sharing: Move switches out of the headerbar
In the "Media Sharing" and "File Sharing"
dialogs, move the main switches out of the
headerbar and show them in a row.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1930
2024-01-30 13:33:35 +00:00
Automeris naranja
b1d1302053 general: Remove a11y labels from buttons that have tooltips
Orca also reads tooltips, so having both a11y labels
and tooltips is redundant.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2023#note_1915854
2024-01-30 13:28:48 +00:00
Automeris naranja
e5a4332a65 privacy: Set some switches as activatable-widgets
The switches from app rows in the Location, Camera
and Microphone pages can't be interacted by clicking
on the rows. Mark these switches as activatable-widgets
to fix that.
2024-01-30 13:26:49 +00:00
Automeris naranja
735e12ada6 xkb-modifier-dialog: Use AdwActionRow to show the key options
Ditch GtkListBox and use AdwActionRow to display
the key options, adding them directly to the
preferences group.

This fixes two issues:
- Orca not reading the key options and their states
- The xkb-modifier-dialog rows looking inconsistent
with other rows with radio buttons, such as the ones
from the Multitasking and Keyboard panels

Also, remove visible=true from the AdwActionRow,
since GTK4 shows all widgets by default.
2024-01-25 12:58:00 +00:00
Peter Hutterer
c5dc74f8b6 wacom: The only stylus with rotation is the Art pen 2024-01-24 09:50:15 +00:00
Peter Hutterer
e8c1e0e778 wacom: Don't call the standard styli "Standard stylus"
The overwhelmingly vast majority of users will never see anything else
than a "Standard" (i.e. pen-shaped) stylus. And there's a mismatch
between e.g. the Pro Pen 3 being labeled as "Standard stylus" when users
spent money on getting a Pro pen.

Let's drop the "Standard" prefix, it adds nothing in this context.
2024-01-24 09:50:15 +00:00
Automeris naranja
08b2ece830 usage-page: Fix mnemonic from clear history confirmation dialog
The letter C was both used for the "Clear History"
and "Cancel" actions, causing both mnemonics to
not work. Fix that by choosing a different letter
for the "Clear History" action.
2024-01-24 09:45:19 +00:00
Bharat
84a53eb9d4 mouse-panel: Add "Test Settings" to mouse-panel
This relates to issue #2839
Remove Test Settings from the header
Moves Test Settings to bottom of mouse-panel ui
Fixed style changes (using '-' instead of '_') for property names
Remove unnecessary whitespaces
Drop the id from the Test Settings buttons

Initial implementation in order to move the "Test Settings" button from
the header to the AdwPreferencesPage of the mouse-panel.
2024-01-23 13:24:08 +00:00
Automeris naranja
617f084332 removable-media-settings: Minor fixes for the "Other Media" window
- Set window title in the .ui file

- Remove `gtk_window_set_modal` from the
C code, since the window is already set
as modal in the .ui file

- Change GtkDialog to AdwWindow
in struct _CcRemovableMediaSettings.
This window is no longer a GtkDialog
2024-01-23 11:14:19 +00:00
Automeris naranja
c024d79cb8 removable-media-settings: Modernize the "Other Media" window
- Use AdwPreferencesPage, AdwPreferencesGroup
and put the GtkDropDowns inside AdwActionRows;
- Set a minimum window size
2024-01-23 11:14:19 +00:00
Automeris naranja
faef4a5915 background: Add missing mnemonics 2024-01-23 11:09:19 +00:00
Automeris naranja
58b0d7392a net-proxy-page: Add mnemonic to the "Configuration URL" entry 2024-01-23 11:09:19 +00:00
Automeris naranja
a5aca4704a add-user-dialog: Add missing mnemonics 2024-01-23 11:09:19 +00:00
Automeris naranja
36edfe89a0 users-page: Add mnemonic to the "Add User" button 2024-01-23 11:09:19 +00:00
Automeris naranja
8502577aa3 user-page: Add missing mnemonics 2024-01-23 11:09:19 +00:00
Automeris naranja
a2c245fc1a remote-desktop-page: Add missing mnemonics 2024-01-23 11:09:19 +00:00
Automeris naranja
35b8a13634 about-page: Add mnemonic to the Device Name entry
Also, change the mnemonic of the System Details
row, so the Device Name entry mnemonic can use
the letter "D". This will be consistent
with the mnemonic of the Device Name entry
from the Sharing panel, added in
d3ca140cafd83398db6f587250120fe7f891e9e2
2024-01-23 11:09:19 +00:00
Automeris naranja
745efc6e22 system: Fix and add mnemonics
Add mnemonics to Users and About rows.
Also, fix the mnemonic of the Remote Desktop
row, which was using the same letter that
the Region & Language row uses.
2024-01-23 11:09:19 +00:00
Automeris naranja
5ba750522c sharing: Add missing mnemonics
Add mnemonics to:
- Device Name entry row
- Remote Login row (from the Remote Login window)
2024-01-23 11:09:19 +00:00
Automeris naranja
f7b41b23f5 power-profile-row: Port to AdwActionRow and add mnemonics
This helps to clean the	code a bit. Also, it makes
the rows to look consistent with other rows with
radio buttons, such as the ones from the
Multitasking and Keyboard panels
2024-01-23 11:05:04 +00:00
Automeris naranja
547b4542be network-ethernet: Tweak network options button tooltip
- Change "Options" to "Network Options" to
provide more context

- Remove the a11y label, which is redundant,
because this button already have a tooltip (the
screen reader also reads tooltips)
2024-01-23 10:55:23 +00:00
Automeris naranja
7fd77c339d wifi-connection-row: Tweak tooltips
- Rename "Show QR Code" to "Share Network",
since the latter is is the proper name of
this action

- Change "Options" to "Network Options" to
provide more context

- Add tooltip to the forget network button

- Removes a11y labels from buttons that already
have tooltips, since the former is redundant
due to the fact that the screen reader reads
tooltips
2024-01-23 10:55:23 +00:00
Automeris naranja
61707f7a1d ua-typing-page: Port Test Entry to AdwEntryRow 2024-01-23 10:42:25 +00:00
Felipe Borges
8d994f3b32 system, about: Report our own GNOME Settings version as GNOME Version
Fixes #2072
2024-01-23 10:41:44 +00:00
Bharat
19e75e0fb0 Keyboard: Add title to AdwNavigationPage
Add blank title to AdwNavigationPage
in the cc-keyboard-shortcut-dialog.ui

Fixes #2850
2024-01-22 14:10:12 +00:00
Will Thompson
f46fbd18a6 privacy: Hide non-functional microphone panel
There is currently no portal through which applications can request
access to the microphone. So all applications either access the
PulseAudio/Pipewire socket directly (which cannot be controlled by this
panel) or do not access the microphone (in which case they do not appear
here).

Hide the panel until such a portal exists. Remove the “microphone”
keyword from the panel's desktop file, used for in-app and desktop
search results.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2848
2024-01-22 09:20:41 +00:00
Hari Rana
d0bcdc9645 wacom: Port to AdwSwitchRow 2024-01-22 09:08:43 +00:00
Automeris naranja
aaa726a662 users-page: Add arrow icon to other users rows
The other users rows open a subpage, but they
don't show an arrow icon to indicate that.
Fix such issue by adding an arrow icon.
2024-01-22 09:04:29 +00:00
Hari Rana
a936ac6bc9 power-panel: Port to AdwSwitchRow 2024-01-18 13:28:54 +00:00