Commit graph

795 commits

Author SHA1 Message Date
Jasper St. Pierre
dd52ac9417 Add NoDisplay to all gnome-control-center panel .desktop files
These aren't apps -- they're simply launchers for gnome-control-center.
They should not be shown as apps in the UI at all.

https://bugzilla.gnome.org/show_bug.cgi?id=712246
2013-11-15 08:44:53 -05:00
Bastien Nocera
b921ce215f network: Only start the spinner when we can stop it
https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 18:31:59 +02:00
Bastien Nocera
57b64368ef network: Merge two similar functions
Merge connection_add_activate_cb() and connection_activate_cb(),
the code is too similar.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:58:19 +02:00
Bastien Nocera
3c1b58ab2a network: Fix warnings when clicking Wi-Fi network
Those 2 widgets (the edit page, and the spinner) might be available
but we need to read about them from the correct widget, eg. the
GtkListBoxRow, not the GtkBox it contains.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Bastien Nocera
ce8c2eb6f6 network: Fix run-time warning
The "edit" widget is only set as data when there is a connection
(in make_row) so only hide it when there is a connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Gary Ching-Pang Lin
fc181a2d64 network: Use the parameters property for 8021x
The argv property was deprecated. This commit converts the 8021x
settings to the parameters property so that the user is able to
setup the 8021x connections.

https://bugzilla.gnome.org/show_bug.cgi?id=709545
2013-10-07 16:50:13 +02:00
Rui Matos
fb9d98bff1 network: Update forget button sensitivity when rows are destroyed
Doesn't make sense to keep it sensitive after the dialog returns OK.

This also avoids using finalized objects if the forget button is
clicked after some previously checked rows were destroyed because
their connection got removed elsewhere.

https://bugzilla.gnome.org/show_bug.cgi?id=709118
2013-10-01 15:09:38 +02:00
Rui Matos
22ff598b78 network: Destroy connection row widget when connection is removed
Otherwise all sorts of crashes may happen if it's interacted with.

https://bugzilla.gnome.org/show_bug.cgi?id=709104
2013-10-01 15:09:37 +02:00
Rui Matos
1650293719 network: Get the correct widget holding the "connection" object data
The check button isn't a direct child of the GtkListBoxRow instance
that contains the "connection" object data so we are adding the wrong
widget to the "rows" list which then gives us a NULL for "connection"
in really_forget() and making us fail to remove the connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:36 +02:00
Rui Matos
b68f7421c6 network: Just dismiss forget dialog if response is not OK
If the dialog is deleted, for instance, we don't want to take that as
OK.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:34 +02:00
Rui Matos
e0583d0c0a network: Remove an unused dialog
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
2d18798d79 network: Don't leak a builder instance
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
db62c4f8e6 network: Don't leak a couple of dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
c5b70a7876 network: Remove unused toplevel windows from .ui files
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:02 +02:00
Rui Matos
fecc2eca87 network: Correctly unref NetDevice instances when needed
We have to take the GtkListStore own reference into account.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Rui Matos
d8bfc9e937 network/net-device-ethernet: Disconnect from NMConnection signals
Otherwise we'll crash in our handler if the signal fires after we're
finalized i.e. user leaves the network panel.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Rui Matos
0f64dd1a11 network: Fix empty ignore-hosts setting
If the ignore-hosts setting is set to an empty array we were using
unintialized memory.

This also now ignores zero length strings if there are any in the
array.

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:58 +02:00
Rui Matos
fb74444eec network: Don't include spaces in proxy's ignore-hosts setting
We should also ignore any zero length strings resulting from
g_strsplit_set().

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:56 +02:00
Rui Matos
aee3f9d82d network: Remove a spurious signal handler
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:46:35 +02:00
Kalev Lember
f8f420256b network: Fix a possible crash with no active connections
As a precaution, check the return value of get_active_connections to
avoid dereferencing a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=990196
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:22:01 +02:00
Dan Winship
fea9da1b2e network: don't show unmanaged devices
And in particular, in NM 0.9.10, don't show NM_DEVICE_TYPE_GENERIC
devices.

https://bugzilla.gnome.org/show_bug.cgi?id=706868
2013-09-10 15:54:30 -04:00
Debarshi Ray
0c1ac731ff network: Silence compiler warning
Use an explicit typecast from gpointer to const gchar **.
2013-09-09 16:17:56 +02:00
Bastien Nocera
e267515ed6 network: Disconnect from signal on finalize
The connection editor connects to permission-changed on its NMClient,
but didn't disconnect from that signal when dropping the NMClient
reference in finalize.

https://bugzilla.gnome.org/show_bug.cgi?id=700989
2013-09-07 19:09:22 -03:00
Matthias Clasen
4151cf76b0 network: Fix hover highlight in the wifi list
Setting a margin on the list box row widget causes the highlight
not to extend to the edge of the list. Instead, set the margin
on the box inside the row.
2013-08-30 23:37:19 -04:00
Matthias Clasen
e165efc6f9 network: Mark connection editor as changed when appropriate
We were forgetting to do so when toggling the 'Only use for resources
on its network' checkbox.

https://bugzilla.gnome.org/show_bug.cgi?id=703959
2013-08-30 23:12:44 -04:00
Matthias Clasen
826646f7fc Hide airplane mode completely
Recently, code was added to hide the airplane mode switch
when the funcitonality is not present. However, the 'Airplane mode'
label was left behind. We already have a container that holds
the entire header content of the network panel, just hide that
instead.

https://bugzilla.gnome.org/show_bug.cgi?id=706687
2013-08-25 11:35:55 -04:00
Bastien Nocera
9745a6b128 network: Wrap the DNS list for mobile networks
Word-wrap the DNS list as we do in other panels.
2013-08-22 19:17:19 +02:00
Bastien Nocera
add1adfdb7 network: Remove unused top-level widget
The "window1" widget in the GtkBuilder file was never used.
2013-08-22 19:17:19 +02:00
Giovanni Campagna
57f85eb4da network: remove placeholder label contents
We don't want these to appear, not even for a frame.

https://bugzilla.gnome.org/show_bug.cgi?id=706330
2013-08-21 09:41:22 +02:00
Bastien Nocera
4a53e93c69 network: Correctly check for error conditions 2013-08-19 22:34:55 +02:00
Bastien Nocera
0f5122eb9a network: Remove unused include 2013-08-19 22:34:55 +02:00
Jasper St. Pierre
a5cdade1a7 network: Use HasAirplaneMode to determine whether to show the switch
Not all systems have rfkill toggles we can set; if we don't have any,
we shouldn't show any switch at all.

https://bugzilla.gnome.org/show_bug.cgi?id=706042
2013-08-16 13:37:20 -04:00
Jasper St. Pierre
6d353f296e network: Sync airplane mode status on startup
https://bugzilla.gnome.org/show_bug.cgi?id=706042
2013-08-16 13:37:20 -04:00
Matthias Clasen
539b5e0710 network: activate wired profiles when clicked
This was always the intention of the design; we just
didn't get around to it. It is becoming more important now
that the shell system status does not show wired profiles
anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=705935
2013-08-16 11:33:08 -04:00
Yosef Or Boczko
30e0080ccc network: Fix stretched header bar switch
and add padding of 4px

https://bugzilla.gnome.org/show_bug.cgi?id=703974
2013-07-30 15:32:27 +03:00
Yosef Or Boczko
e611930dfb network: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:56:26 +03:00
Jasper St. Pierre
085e769513 network: Use gnome-settings-daemon interface for switching on/off Airplane Mode
Having this in one place is a lot cleaner.

https://bugzilla.gnome.org/show_bug.cgi?id=703411
2013-07-17 21:13:10 -04:00
Kalev Lember
62f18a2e32 network: Convert connection editor to GtkListBox
https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-07-02 16:19:09 +01:00
Alexander Larsson
b0356fdfc7 network: Convert to GtkListBox
https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-07-02 16:19:09 +01:00
Thomas Wood
f17b62ceb3 network: prevent the "Details" and "Hotspot" dialogs from being resizable
https://bugzilla.gnome.org/show_bug.cgi?id=702487
2013-06-18 17:38:37 +01:00
Adel Gadllah
90f49a4d5d rfkill-glib: Don't use g_assert_not_reached in type_to_string
New kernel versions can add new RFKILL types, we should now crash here,
just say that we don't know what the switch is.
2013-05-16 15:49:55 +02:00
Lionel Landwerlin
f9000c6f5e network: vpn: disconnect signals from NM's objects
https://bugzilla.gnome.org/show_bug.cgi?id=700379
2013-05-15 14:33:56 +01:00
Lionel Landwerlin
94ce9bb9bc network: update on/off switch button when vpn becomes active/inactive
https://bugzilla.gnome.org/show_bug.cgi?id=699275
2013-05-15 14:33:49 +01:00
Lionel Landwerlin
d1bbe95143 network: prevent ethernet device to switch back to 'on' state
Calling nm_client_deactivate_connection() stops a connection and set
it back to auto-activation. In the case of ethernet, that means the
ipconfig scripts start again and the ethernet device becomes 'on'
again, even though the user clicked 'off' in the control center panel.

https://bugzilla.gnome.org/show_bug.cgi?id=700300
2013-05-15 12:06:55 +01:00
Giovanni Campagna
d59a1b068f network: properly namespace wireless security boxed types
These types appear with the same name in libnm-gtk, but they're
not shared because they come from different code, so they
need namespacing.
This prevents a crash that happens if you open a wifi property
dialog and then click "Connect to hidden network"

https://bugzilla.gnome.org/show_bug.cgi?id=700137
2013-05-13 21:42:09 +02:00
Matthias Clasen
f937b7db88 network: Add more keywords
My search for vpn in the shell came up empty; add vpn, vlan, bond,
bridge as keywords to the desktop file to correct this.

https://bugzilla.gnome.org/show_bug.cgi?id=698170
2013-04-17 18:11:46 -04:00
Matthias Clasen
eb9c61f3e0 network: Avoid jumping dialogs
The connection editor window is shown before all of its pages are
initialized, causing it to jump when it gets its final size. Avoid
that by not showing it before it is ready.

https://bugzilla.gnome.org/show_bug.cgi?id=693781
2013-04-16 11:28:16 +02:00
Matthias Clasen
2e626e0535 network: Set connection editor title for wired
https://bugzilla.gnome.org/show_bug.cgi?id=693780
2013-04-15 08:27:53 -04:00
Matthias Clasen
58a09ae1a7 network: Set the connection editor title for VPN
https://bugzilla.gnome.org/show_bug.cgi?id=693780
2013-04-15 08:27:45 -04:00
Matthias Clasen
7618df792f network: Allow setting title on connection editor
We want the title to match whats in the device list, which
sometimes does not match the connection id exactly. This
API lets us do so.
https://bugzilla.gnome.org/show_bug.cgi?id=693780
2013-04-15 08:27:36 -04:00