Commit graph

165 commits

Author SHA1 Message Date
Automeris naranja
47523f03a2 privacy: Update subpage tags in the main page
Each page had its AdwNavigationPage tag updated in [1],
but the tags in the Privacy panel main page weren't
updated, which made all the subpages fail to open.

[1] 917248d7bf
2024-03-14 11:59:39 +01:00
Felipe Borges
76245d592e privacy: Open subpage when CcPanel.subpage is set
Fixes #2940
2024-03-12 12:17:49 +01:00
Felipe Borges
bec20d6cc0 privacy: Update subpages tags to match expected cmdline args 2024-03-12 12:17:42 +01:00
Sam Hewitt
a5f6efaddb Update and clean up symbolic icon assets
- refresh the symbolic icons to sync some style changes and update the source sheet
- rename assets for the privacy subpanel's symbolic icons
- delete deprecated/unused symbolic icons
- add new icon for system panel
- add new icon for remote desktop so it isn't using displays icons
2024-02-10 16:17:35 +00:00
Monster
641633cf25 privacy: Remove periods from descriptions and subtitles 2024-02-05 10:55:38 +00:00
Felipe Borges
47774b9968 privacy: Use CcHostname to detect when running in a VM
We currently hide "Device Security" when running in a VM or an
undefined systemd-hostnamed chassis-type.

This makes our existing check use the CcHostname utility.
2024-01-30 13:34:10 +00:00
Automeris naranja
e5a4332a65 privacy: Set some switches as activatable-widgets
The switches from app rows in the Location, Camera
and Microphone pages can't be interacted by clicking
on the rows. Mark these switches as activatable-widgets
to fix that.
2024-01-30 13:26:49 +00:00
Automeris naranja
08b2ece830 usage-page: Fix mnemonic from clear history confirmation dialog
The letter C was both used for the "Clear History"
and "Cancel" actions, causing both mnemonics to
not work. Fix that by choosing a different letter
for the "Clear History" action.
2024-01-24 09:45:19 +00:00
Will Thompson
f46fbd18a6 privacy: Hide non-functional microphone panel
There is currently no portal through which applications can request
access to the microphone. So all applications either access the
PulseAudio/Pipewire socket directly (which cannot be controlled by this
panel) or do not access the microphone (in which case they do not appear
here).

Hide the panel until such a portal exists. Remove the “microphone”
keyword from the panel's desktop file, used for in-app and desktop
search results.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2848
2024-01-22 09:20:41 +00:00
Hari Rana
36b8a32545 usage: Port to AdwSwitchRow 2024-01-18 13:25:28 +00:00
Hari Rana
a9f431bdbd diagnostics: Port to AdwSwitchRow 2024-01-18 13:03:31 +00:00
Hari Rana
d4c3782065 screen: Port to AdwSwitchRow 2024-01-18 13:03:13 +00:00
Automeris naranja
df080da61d privacy: Rename "Location Services" page to "Location"
As per latest mockups:
753704dbe4/location-services/location-services.png

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2125#note_1961390
2024-01-09 12:59:31 +00:00
Automeris naranja
661cc8d76f location-page: Remove .dim-label from privacy policy link
The link shouldn't be dimmed[1]. I forgot to make
this change in !2125.

[1] https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2125#note_1960453
2024-01-08 14:55:54 -03:00
Automeris naranja
e3eb30f095 location-page: Rename master switch title to "Automatic Device Location"
Also, remove the master switch subtitle.

Reference:
9ed7088301/location-services/location-services.png
2024-01-08 14:06:02 +00:00
Automeris naranja
abe6aa3416 location-page: Implement the new privacy notice
- Move the privacy notice below the master switch
- Use the new text suggested in https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2817
to mention that data is shared with a another party

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2336 and https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2817
2024-01-08 14:06:02 +00:00
Bart Gravendeel
cacc2b5bef Remove use-underline property from all CCListRows 2024-01-04 10:11:35 +00:00
Automeris naranja
05b9fcd85e location-page: Set up the page description in the C code
This will make easier to translate the strings.
2023-12-21 09:25:57 +00:00
Felipe Borges
f0b8dbc973 privacy: Make app icons larger in Location/Camera/Microphone pages
Fixes #1637
2023-12-11 14:03:06 +00:00
Felipe Borges
1c9c6805a5 privacy: Make firmware page visibility check cancellable
So that the page doesn't crash when closing the panel before the
firmware page visibility has been set.
2023-11-29 10:23:51 +00:00
Felipe Borges
0263993642 privacy: Make Bolt page visibility check cancellable
When the Bolt page gets disposed before it finishes initializing
its client object we get a crash. See #2700

A way to trigger the crash is to switch panels fast enough so that
the sync dbus call is not finished by the time the panel is disposed.

This is not a guaranteed fix since I can't reproduce the issue
consistently.
2023-11-29 10:23:51 +00:00
Automeris naranja
47a0caec34 privacy: Update Privacy panel description
As per suggestion of @aday in the following thread:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2026#note_1918621

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2043>
2023-11-20 02:23:01 +00:00
Felipe Borges
99459f879a privacy: Rename visible name to "Privacy & Security"
Fixes #2742
2023-11-16 08:45:51 +00:00
velsinki
88a582cbed privacy: Fix crash from free bug in cc-camera-page
The GVariant constructor g_variant_new () gives a floating reference,
which will be sunk by the g_dbus_..._call () methods. Unless the
constructed GVariant is manually referenced, it should not be used in a
g_autoptr () setting. Otherwise a use-after-free might occur in the
async g_dbus_..._call () methods.

This problem occurs here, which is simply prevented by not having the
g_autoptr () declaration for the GVariant.

Fixes #2647
Fixes #2704
Fixes #2635
Fixes #2706
2023-11-08 14:08:38 +01:00
Automeris naranja
a910730a76 screen: Add missing mnemonics
Add mnemonics to the following rows
- Restrict Viewing Angle
- Blank Screen Delay

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-05 17:39:31 -03:00
Automeris naranja
21af56aa9c screen-page: Fix mnemonic of the "Lock Screen Notifications" row
It was using the letter L, which is also used by the
"Automatic Screen Lock" row.
2023-11-05 17:39:31 -03:00
Automeris naranja
0d48055f9f firmware-security-page: Add tooltip to fw_help_button
"Controls in the header bars of primary windows should all have tooltips".

https://developer.gnome.org/hig/patterns/feedback/tooltips.html
2023-10-23 13:46:34 +00:00
Automeris naranja
f813d0d1d4 screen: Rename "Forbid new USB devices" to "Forbid New USB Devices"
Header capitalization needs to be used.

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-10-23 13:45:21 +00:00
Marco Melorio
cd5a80c268 privacy: Fix crash in the firmware security page
Make sure the timeouts are stopped when the page is finalized.
2023-09-22 10:41:14 +00:00
Alice Mikhaylenko
4680f362f3 Port to AdwNavigationSplitView 2023-08-25 08:00:43 +00:00
Felipe Borges
6585bba6ec privacy: Fix typo in UI file property parameter 2023-08-15 14:13:54 +02:00
Felipe Borges
0c9498d1f8 Mark some strings as translatable
These are strings that are presented in the UI that were not marked
for translation.

Fixes #2596
2023-08-11 12:07:00 +02:00
Marco Melorio
cdea4b4503 privacy: Make security dialogs consistent
Port them to AdwWindow and AdwToolbarView, simplify the widgetry and use
a consistent styling and window size.
2023-08-06 14:11:08 +00:00
Marco Melorio
49f037595d privacy-panel: Improve subpage row descriptions 2023-08-06 14:11:08 +00:00
Marco Melorio
a2f65a0471 privacy-panel: Group the subpage rows 2023-08-06 14:11:08 +00:00
Marco Melorio
287e2371a4 firmware-security: Simplify widgetry
Use a GtkStack instead of a AdwLeaflet in the security and heavily
simplify the security dialog, because it contained a lot of misued
widgets and also a page that was never made visible.
2023-08-03 08:42:10 +00:00
Marco Melorio
0dcebeee9d privacy: Format all UI files 2023-08-03 08:42:10 +00:00
Marco Melorio
5c75c03b52 privacy: Add thunderbolt page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
71349d80d9 privacy: Add device security page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
8ea49662d6 privacy: Add microphone page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
4eefc51dd2 privacy: Add camera page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
6dac508732 privacy: Add location page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
ef58f0e097 privacy: Add diagnostics page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
c94afe06a8 privacy: Add usage page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
b2eaa54d7d privacy: Add screen lock page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
81dd3de928 panels: Add empty Privacy panel with navigation
It will be filled in later commits.
2023-08-03 08:42:10 +00:00
Matthias Clasen
a4bdc37760 Remove the privacy panel
It has been turned into a herd of panels.
2019-11-07 14:40:07 +13:00
Robert Ancell
97985a664e Remove unused GNOMELOCALEDIR defines 2019-09-09 21:45:53 +00:00
Robert Ancell
1752cf3bb5 Make /etc/os-release support common
The existing code is used in multiple places with slightly different
implementations.
2019-09-09 21:42:10 +00:00
Bastien Nocera
f9d0dc9795 privacy: Rename "Show Notifications" label
To be clearer.

https://bugzilla.gnome.org/show_bug.cgi?id=743307
2019-03-29 17:12:20 +00:00