Commit graph

12 commits

Author SHA1 Message Date
Automeris naranja
745efc6e22 system: Fix and add mnemonics
Add mnemonics to Users and About rows.
Also, fix the mnemonic of the Remote Desktop
row, which was using the same letter that
the Region & Language row uses.
2024-01-23 11:09:19 +00:00
Felipe Borges
d52ec68f8d system: Add "Users" panel
This moves the UserAccounts panel to a page in the System panel.

This simplifies a lot of the existing code in the UserAccounts panel.

I did minimal changes to the sub dialogs so that those can be touched
in following changes, making it easier to review this one alone.

The main panel widget is now CcUsersPage, and is an AdwNavigationView
widget that has a default "current_user_page" page. Each page is a
CcUserPage (careful with the one-character difference between these
two classes).

Each CcUserPage has an associated ActUser object.
2024-01-08 13:59:26 +01:00
Felipe Borges
8da25aaef5 system: Replace dynamic System row subtitles with static text
Row subtitles in Settings are typically a description of the main label or setting.
You can see this in Mouse & Touchpad, Privacy, Sharing, and Wi-Fi.
For the System panel we did something a bit different and used the subtitle to show
the status of each panel.

Given the standard use of subtitles elsewhere, this feels a bit surprising which,
as a result, makes the panel harder to read. I think that a standard description
would probably also be more useful than the current labels.

Mockups https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png?ref_type=heads

This also removes the thin CcSystemPage abstract class because it was
only introduced to add the support for dynamic System row subtitle. Now
this abstraction is no longer necessary.

Fixes #2776
2024-01-04 11:38:47 +00:00
Bart Gravendeel
cacc2b5bef Remove use-underline property from all CCListRows 2024-01-04 10:11:35 +00:00
Felipe Borges
affa60edcf Revert "system: Replace dynamic System row subtitles with static text"
This reverts commit ea224c4045.

This was accidentally included in another MR.
2023-12-05 15:17:11 +01:00
Felipe Borges
ea224c4045 system: Replace dynamic System row subtitles with static text
Row subtitles in Settings are typically a description of the main label or setting.
You can see this in Mouse & Touchpad, Privacy, Sharing, and Wi-Fi.
For the System panel we did something a bit different and used the subtitle to show
the status of each panel.

Given the standard use of subtitles elsewhere, this feels a bit surprising which,
as a result, makes the panel harder to read. I think that a standard description
would probably also be more useful than the current labels.

Mockups https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png?ref_type=heads

This also removes the thin CcSystemPage abstract class because it was
only introduced to add the support for dynamic System row subtitle. Now
this abstraction is no longer necessary.

Fixes #2776
2023-12-05 14:07:13 +00:00
Felipe Borges
79f1b84964 system: Show page summaries as row subtitles in the main page
Per mockups in
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/system/system-panel.png

This adds a thin abstract CcSystemPage object with a "summary" property.

Each CcListRow::subtitle is binded to its corresponded
CcSystemPage::summary.

See #2241
2023-11-02 12:15:11 +00:00
Gotam Gorabh
3bb233b50a system: Add 'Date Time' panel to system panel
Adds Date Time panel to the system panel as a page.

https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png

See #2241
2023-11-02 12:15:11 +00:00
Felipe Borges
fb13e45aba system: Add "About" page 2023-11-02 12:15:11 +00:00
Gotam Gorabh
34fcaa0654 system: Add 'Remote Desktop' panel to system panel
See #2241
2023-11-02 12:15:11 +00:00
Gotam Gorabh
72973b9a8a system: Add 'Region Language' panel to system panel
Adding Region & Language page to the system panel.

https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png

See #2241
2023-11-02 12:15:11 +00:00
Gotam Gorabh
5a92981056 system: Add new Sytem panel
This is the basic panel structure which will contain the
pages for the "System" panel, per mockups in
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/system/system-panel.png

See #2241
2023-11-02 12:15:11 +00:00