Commit graph

905 commits

Author SHA1 Message Date
Robert Ancell
5244b01326 network: Merge together methods
A method was public, and not being used. Simplify the case it's used in.
2019-11-06 10:16:40 +13:00
Robert Ancell
2b3c6ea3e4 network: Don't use refresh virtual method for VPN objects
The refresh is only called internally
2019-11-06 10:16:40 +13:00
Robert Ancell
06e38dac90 network: Tidy up use of modem object in NetDeviceMobile 2019-11-06 10:16:40 +13:00
Robert Ancell
6207f84ba2 network: Remove unused code 2019-11-06 10:16:39 +13:00
Robert Ancell
29734b599c network: Remove net_object_get_client
Better handled inside each object.
2019-11-06 10:16:39 +13:00
Robert Ancell
d7e17ca02f network: Replace method with a helper function.
This removes a case where an object was being temporarily created just to use
this mehtod.
2019-11-06 10:16:39 +13:00
Robert Ancell
966cb97d45 network: Remove net_object_get_cancellable
Only a few objects need it
2019-11-06 10:16:39 +13:00
Robert Ancell
5e4ca84c4c network: Use correct type iterating over list
The list only contains one type of object.
2019-11-06 10:16:39 +13:00
Robert Ancell
c74d26bf3a network: Remove NetObject id property
This is better handled by comparing objects.
2019-11-06 10:16:39 +13:00
Robert Ancell
696e2c7617 network: Remove unused GObject data 2019-11-06 10:16:39 +13:00
Robert Ancell
0b3ce1e15d network: Remove net_object_get_panel
It was only being used for WiFi devices
2019-11-06 10:16:39 +13:00
Robert Ancell
76de0ce408 network: Simplify net_object_add_to_stack function
Except in the WiFi case it was creating a stack with one child.
All the non-WiFi cases had the same logic.
2019-11-06 10:16:39 +13:00
Robert Ancell
8335c088ec network: Simplify handling bluetooth devices 2019-11-06 10:16:39 +13:00
Robert Ancell
a7e3f314e6 network: Rename NetDeviceSimple to NetDeviceBluetooth
It's only being used for bluetooth connections.
2019-11-06 10:16:39 +13:00
Robert Ancell
e90ed2df8a network: Stop NetDeviceEthernet deriving from NetDeviceSimple
It overrode everything anyway.
2019-11-06 10:16:39 +13:00
Robert Ancell
9327a5f4d1 network: Remove unused function 2019-11-06 10:16:20 +13:00
Robert Ancell
d68cb14837 network: Remove unused virtual method 2019-11-06 10:16:20 +13:00
Robert Ancell
0c92c7b461 network: Replace g_object_new with constructors 2019-11-06 10:16:20 +13:00
Robert Ancell
0b481bfb83 network: Remove if statement that is always true 2019-11-06 10:16:20 +13:00
Robert Ancell
6c473c2e14 network: Remove unused net_device_new function 2019-11-06 10:16:20 +13:00
Robert Ancell
6ab75da5c6 network: Use g_clear_pointer 2019-11-06 10:16:20 +13:00
Robert Ancell
8f722a31de network: Fix missing GtkWidget cast 2019-11-06 10:16:18 +13:00
Robert Ancell
d61d13d4e3 network: Hide edit connection buttons if nm-connection-editor not installed 2019-10-31 01:46:19 +00:00
Robert Ancell
4afbeff6ed network: Drop broken patches to import code from network-manager-applet
They are disabled, and aren't going to work due to other changes we have landed.
2019-10-24 08:02:43 +00:00
Robert Ancell
a1439b32b1 network: Remove unused virtual method 2019-10-22 20:11:45 +00:00
Robert Ancell
62af171d8b network: Remove net_object_edit virtual method
It didn't need to be virtual and was only used in two cases
2019-10-22 20:11:45 +00:00
Robert Ancell
926063acb3 network: Remove unused GObject property 2019-10-22 20:11:45 +00:00
Robert Ancell
0e10d2cab4 network: Drop class method for signals
These weren't used and contained a copy/paste error.
2019-10-22 20:11:45 +00:00
Robert Ancell
87b98346df network: Remove virtual method
Nothing ever overrode it; just convert to a normal method.
2019-10-22 20:11:45 +00:00
Robert Ancell
4dbea87109 network: Remove unused includes 2019-10-22 20:11:45 +00:00
Robert Ancell
7f410ee1c6 network: Remove helper functions
They're not complex enough or used in enough places to warrant keeping.
They can be better refactored in the classes that use them.
2019-10-22 20:11:45 +00:00
Robert Ancell
75b4e5e061 network: Simplify helper function 2019-10-22 20:11:45 +00:00
Robert Ancell
f03ae7ff93 network: Move common code UI into each widget using it
It was only used twice and better managed in the actual widgets.
2019-10-22 20:11:45 +00:00
Robert Ancell
9b1226aea5 network: Remove helper function with minimal value
This can be more easily optimised away in the modules that use it.
2019-10-22 20:11:45 +00:00
Robert Ancell
96585c1542 network: Remove unused hotspot connected label 2019-10-22 20:11:45 +00:00
Robert Ancell
4100c69d9c network: Move panel properties into GtkBuilder files 2019-10-22 20:11:45 +00:00
Robert Ancell
708b1fdaf7 network: Use self variable name consistently 2019-10-22 20:11:45 +00:00
Robert Ancell
8b6e3fb736 network: Store widgets inside objects
This is a step towards replacing GtkBuilder with GtkTemplate
2019-10-22 20:11:45 +00:00
Robert Ancell
b331d75df5 network: Rename widget IDs to standard names 2019-10-22 20:11:45 +00:00
Robert Ancell
53f9249b83 network: Remove unused GtkBuilder IDs 2019-10-22 20:11:45 +00:00
Robert Ancell
927f0f7954 network: Remove unused widgets 2019-10-22 20:11:45 +00:00
Robert Ancell
879542d92b network: Merge duplicate signal handlers 2019-10-22 20:11:45 +00:00
Robert Ancell
54f8fce47f network: Connect signals in swapped form 2019-10-22 20:11:44 +00:00
Robert Ancell
d549c9e7bd network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
4b9d8ac058 network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
8a3da8b36d network: Remove shared callback and replace with a method 2019-10-22 20:11:44 +00:00
Robert Ancell
f556af6e67 network: Move includes to correct file locations 2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328 network: Remove unused virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6 network: Refactor widget reference out using virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00