Per discussion in https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1940
we agreed that the number of deprecated warnings is cluttering
significantly our build logs and making it hard for new contributors to
spot new warnings that their code changes introduce.
For now we decided that the default value for deprecated-declarations is
DISABLED.
We have so many deprecation warnings that it becomes impossible to
notice any other useful warning, thus making the compiler output
completely useless.
Ideally, we should fix all of those but, until then, it's better to add
this flag so that we avoid adding even more warnings by accident.
This has some advantages:
- Removes the conditional compilation requirement, which makes testing easier.
- Allows all distributed versions of Settings to have snap support without them supporting snapd-glib.
- Makes it faster to update Settings for Snap features without waiting on snapd-glib releases.
Note that the snap support is only invoked if you have snaps installed.
Downsides:
- Some additional code in Settings. This is manageable as Settings doesn't need much snap information.
libsoup2 didn't support HTTP over Unix domain sockets and would have been too much to support in Settings.
libsoup3 does support this which makes this possible.
- We no longer share code with snapd-glib, so any future changes will have to be made in multiple places.
snapd has a stable API and multiple active clients so this is not likely to be a major concern.
When implementing the workaround to allow us to use libadwaita
as a subproject, we forgot to move the default options to our
subproject declaration. This caused libadwaita's tests to be
built and subsequently fail our test stage.
This commit puts the options in the right place.
- Clarify that 'mm-glib' dep is for ModemManager (not Network
Manager which is below). The comment also helps people
which may confuse it with glibmm library.
- Fix following Meson warning about two deprecated functions:
WARNING: Deprecated features used:
* 0.56.0: {'dependency.get_pkgconfig_variable', 'meson.source_root'}
AdwBanner is a new adaptive widget that replaces GtkInfoBar.
AdwBanner adapts better to mobile sizes and has an API
that fits with how we use infobars.
This commit changes CcPermissionInfobar to use an AdwBanner
internally instead of a GtkInfoBar. It also re-implements
part of GtkLockButton, as AdwBanner does not support adding
arbitrary widgets.
Fixes following Meson warning (given by Meson 0.62.1):
meson.build:33: WARNING: Project targeting '>= 0.57.0' but tried
to use feature deprecated since '0.55.0': ExternalProgram.path.
use ExternalProgram.full_path() instead
panels/network/wireless-security is essentially an old fork of the part
of nm-connection-editor that is now part of libnma.
The UI elements provided by libnma adhere to the same look as the rest
of gnome-control-center for quite some time now. The functinality they
implement the same functionality and more. In particular, libnma uses
Gcr to provide Smart Card access for keys and certificates.
https://bugzilla.redhat.com/show_bug.cgi?id=1992836
This avoids coggling the UI for those devices for which a modem
is not present, as x-scheme-handler/tel and x-scheme-hanlder/sms
are of no use in such cases
The `X-GNOME-Bugzilla-*` entries were for use by bug-buddy, a GNOME 2
technology that's been gone for over a decade. These entries are
obsolete and can be removed from all desktop files.
The `X-GNOME-Settings-Panel` entry is also obsolete as far as I can
tell and only these panels had it in their desktop file: notifications,
sharing, sound and user-accounts. These entries can also be removed.
After removing the `X-GNOME-Bugzilla-*` entries, the desktop files have
no more variables in them. The meson `configure_file` step is therefor
pointless—there are no variables to configure. As such the
`*.desktop.in.in` files are renamed to `*.desktop.in` to reflect this
and `meson.build` files are modified to remove `configure_file` step.
To support commit 9de5b003, the minimum GLib dependency level must be
updated to 2.70 as that release introduced g_pattern_spec_match_string.
This patch updates the GLib minimum required level in accordance.
Currently, we display a 256x256 version of the OS icon from
/etc/os-release. This is too big for my taste, and it's also not
sufficient for distros that want to display a logo that is not an icon.
For instance, because we no longer display the operating system name
immediately beneath the logo, it may be desirable to use a logo variant
that includes text. This patch adds a meson build option that
distributions can use to override the logo, and a second build option to
specify a different logo for use in dark mode.
