Commit graph

15 commits

Author SHA1 Message Date
Felipe Borges
544c146ea8 common: Check for valid GDateTime object before comparing
Avoids the critical below at runtime
11:14:36.7796                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed
11:14:36.7802                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed

Which comes from the location panel passing a NULL date object.

\#0  _g_log_abort (breakpoint=1) at ../shell/cc-log.c:72
        debugger_present = 1
\#1  0x000000000045c3c4 in cc_log_write
    (log_level=10, log_domain=0x7ffff7d592eb "GLib", log_message=0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed", fields=0x7fffffffd740, n_fields=4, user_data=0x0)
    at ../shell/cc-log.c:315
        log_str = 0x234b8d0
        stream = 0x7ffff5dbb4e0 <_IO_2_1_stderr_>
        can_color = 1
\#2  0x000000000045c4f5 in cc_log_handler (log_level=G_LOG_LEVEL_CRITICAL, fields=0x7fffffffd740, n_fields=4, user_data=0x0) at ../shell/cc-log.c:348
        log_domain = 0x7ffff7d592eb "GLib"
        log_message = 0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed"
\#3  0x00007ffff7c9f534 in g_log_structured_array () at /lib64/libglib-2.0.so.0
\#4  0x00007ffff7ca4f57 in g_log_default_handler () at /lib64/libglib-2.0.so.0
\#5  0x00007ffff7c9be29 in g_logv () at /lib64/libglib-2.0.so.0
\#6  0x00007ffff7c9c193 in g_log () at /lib64/libglib-2.0.so.0
\#7  0x00007ffff7c787fa in g_date_time_difference () at /lib64/libglib-2.0.so.0
\#8  0x000000000059c186 in cc_util_get_smart_date (date=0x0) at ../panels/common/cc-util.c:124
        today = 0x2350130
        local = 0x2350100
        span = 10791504
\#9  0x00000000004f8a20 in add_location_app (self=0x1dee1c0, app_id=0x232fef0 "org.gnome.Calendar", enabled=1, last_used=459618461810) at ../panels/privacy/cc-location-page.c:209
        data = 0xffffda80
        app_info = 0x2341c50
        t = 0x0
        row = 0x2348280
        w = 0x234fe00
        icon = 0x2345310
        last_used_str = 0x0
        desktop_id = 0x7fffcc034c30 "DL\310\375\a"
\#10 0x00000000004f8db4 in update_perm_store (self=0x1dee1c0, permissions=0x7fffcc04e2c0, permissions_data=0x7fffcc04ee80) at ../panels/privacy/cc-location-page.c:282
        enabled = 1
        last_used = 459618461810
        iter = {x = {140736616260288, 2, 0, 6386038, 140736616096608, 36922576, 16, 3579507750, 140737488345904, 140737350561909, 33733184, 36922576, 140737488345936, 140737350702366, 36922576, 3278251457363369984}}
        key = 0x232fef0 "org.gnome.Calendar"
        value = 0x7fffcc04e090
\#11 0x00000000004f8f4e in on_perm_store_lookup_done (source_object=0x1e24040, res=0x202ba40, user_data=0x1dee1c0) at ../panels/privacy/cc-location-page.c:324
        error = 0x0
        ret = 0x7fffcc04eef0
        permissions = 0x7fffcc04e2c0
        permissions_data = 0x7fffcc04ee80
\#12 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#13 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
\#14 0x00007ffff7efe88b in reply_cb () at /lib64/libgio-2.0.so.0
\#15 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#16 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
2024-03-27 14:22:53 +01:00
Lukáš Tyrychtr
5d24919f14 common: Mark a string as not containing printf specifiers
The gettext heuristic was erroneously marking one of the date strings as
printf format ones, so it could not get translated properly.

Fixes #2761
2023-11-22 10:40:45 +01:00
Kate Hsuan
fbafcc77a0 firmware-security: improve datetime format parsing
Showing the datetime string using cc_util_get_smart_date_time().
2022-10-25 23:49:16 +00:00
Kate Hsuan
df2bd37837 panels: cc-util: a smart date time
Convert the DateTime to string with time.
The format will be:
smart_date, \%X
2022-10-25 23:49:16 +00:00
Matthew Leeds
7b1bed5ab0 common: Improve how we print time periods
Print e.g. "2 minutes" instead of "2 minutes 0 seconds". Also, update
the path in Totem from which this was copied. The MR to make the same
change in Totem is here:
https://gitlab.gnome.org/GNOME/totem/merge_requests/134
2020-03-30 03:43:09 +00:00
Georges Basile Stavracas Neto
255a1ab948 power: Move helper function to panels/common
It will be used by the Lock Screen panel in the future.
2019-11-07 14:19:23 +13:00
Robert Ancell
86d1d30c63 common: Use g_auto for variables 2018-06-07 01:08:07 +00:00
Rui Matos
11d5d850b2 common: Fix search by skipping soft hyphens when normalizing
Commit b3be07609a introduced soft
hyphens in panel names which causes searches to fail. Fix this by
skipping soft hyphen when normalizing strings.

https://bugzilla.gnome.org/show_bug.cgi?id=765617
2016-04-26 17:17:31 +02:00
Zeeshan Ali (Khattak)
5ebf3d8ddf common: Fix codying-style in cc_util_get_smart_date()
https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Zeeshan Ali (Khattak)
afebec5d9a common: Move get_smart_date() to common utils
And rename it to cc_util_get_smart_date().

In a following patch, we'll need to use it from privacy panel.

https://bugzilla.gnome.org/show_bug.cgi?id=761245
2016-03-03 16:07:58 +00:00
Rui Matos
1f03f33230 Remove the input-source-switcher setting
Mutter now has a special modifiers-only shortcut used by gnome-shell
to switch input sources which no longer uses this setting.

This reverts commit ae3014ba3e.
This reverts commit 77b7569c3d.

https://bugzilla.gnome.org/show_bug.cgi?id=700346
2013-05-27 10:23:26 +02:00
Rui Matos
0b7479572e Revert "Revert "Use a common definition for modifier-only keybindings array""
This reverts commit 34906dba27.
2013-05-13 16:26:01 +02:00
Rui Matos
34906dba27 Revert "Use a common definition for modifier-only keybindings array"
This reverts commit ae3014ba3e.
2013-05-13 16:22:00 +02:00
Rui Matos
ae3014ba3e Use a common definition for modifier-only keybindings array 2013-02-19 12:25:56 +01:00
Rui Matos
cfa16a070d Move cc-util into panels/common
We need this in some panels too.
2013-02-19 12:25:54 +01:00
Renamed from shell/cc-util.c (Browse further)