Commit graph

622 commits

Author SHA1 Message Date
Bastien Nocera
e824868976 network: Re-set the SSID when enabling the Hotspot
Instead of expecting the hostname to stay the same.

https://bugzilla.gnome.org/show_bug.cgi?id=705546
2016-08-30 17:17:27 +02:00
Bastien Nocera
2a6706fe4c network: Avoid setting a GError if already set
If the wireless security is invalid, don't try to set the GError if the
ad-hoc mode is invalid as well.

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
b0329f8ef6 network: Return better error when 8021x security is invalid
Rather than the generic "Invalid 802.1x security".

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
73a8d38946 network: Remove unused ->validate class implementations
The implementation of ->validate in the parent class will return TRUE if
there's no implementation in the child class, so no need to implement
those.

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
a90dc605d6 network: Fix IPv6 settings not being applicable when method changes
When changing the method from Manual to Automatic, we need to clear the
gateway setting, otherwise the settings verification will fail:
ipv6.gateway: gateway cannot be set if there are no addresses configured

Another fallout of the libnm 1.2 port

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
94e2be8ff6 network: Fix warning if IPv6 gateway is empty
GtkEntry doesn't like NULL text.

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
dc14602e55 network: Fix saving of IPv6 gateway
https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
cdb6a6c682 network: Fix warning when enabling hotspot
GLib-GObject-WARNING **: g_object_set_valist: object class 'NMSettingWireless' has no property named 'security'

https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-08-30 17:15:33 +02:00
Bastien Nocera
c6f1b3a2be network: Simplify complete_connection_for_type()
Now that there's only one type to be added (VPNs).

https://bugzilla.gnome.org/show_bug.cgi?id=767614
2016-06-24 17:26:10 +02:00
Bastien Nocera
d0fcd5843c network: Remove the first page of the "Add Connection" wizard
We still offered to add Bond, Team, Bridge and VLAN connections even
though we don't support them any more. Remove the first page as we only
offer to add VPN connections.

https://bugzilla.gnome.org/show_bug.cgi?id=767614
2016-06-24 17:26:10 +02:00
Bastien Nocera
7adfaf1ed9 network: Fix VPN UI not showing up
The VPN editor API changed as well.

https://bugzilla.gnome.org/show_bug.cgi?id=767614
2016-06-24 17:26:10 +02:00
Bastien Nocera
2a7b19202b network: Fix crash creating a VPN
The listing of VPN plugins was done using the nm-glib API instead of the
new libnm 1.2 one.

https://bugzilla.gnome.org/show_bug.cgi?id=767614
2016-06-24 17:26:10 +02:00
Georges Basile Stavracas Neto
2777fd583d panels: use the new categories
Following the previous patch, this patch adds the new alternative
categories to the panels' Desktop files. These alternative categories
are only relevant for the alternative Shell, and do not break the
current Shell in any way.

https://bugzilla.gnome.org/show_bug.cgi?id=767301
2016-06-14 12:16:43 -03:00
Bastien Nocera
44c16fc6ff network: Use the correct type for the "ssid" property
Set the Hotspot SSID property correctly for libnm 1.2.
2016-06-10 17:21:40 +02:00
Bastien Nocera
e66941753b network: Fix hotspot silently failing with long hostname
By truncating the SSID to 32 bytes.

network-cc-panel-WARNING **: Failed to add new connection: (32) 802-11-wireless.ssid: SSID length is out of range <1-32> bytes

See https://bugzilla.redhat.com/show_bug.cgi?id=1309331
2016-06-10 17:10:35 +02:00
Bastien Nocera
8f359fbe5e network: Remember "Ignore CA certificate"
The CA certificate, when not needed, is saved somewhere in the same
GSettings schema used by nm-connection-editor.
2016-06-07 18:50:38 +02:00
Bastien Nocera
9d4800b5b2 network: Fix warning when BSSID is empty
libnm-CRITICAL **: _nm_utils_hwaddr_to_dbus: assertion 'len > 0 && len
<= NM_UTILS_HWADDR_LEN_MAX' failed
2016-06-07 18:50:38 +02:00
Bastien Nocera
8386631dcd network: Update wireless-security from network-manager-applet
To replace the WIP code that landed earlier.
2016-06-07 18:50:38 +02:00
Bastien Nocera
b9d619fb54 network: Update the script to update from nm-applet again
Separating out the UI from the backend code.
2016-06-07 18:50:38 +02:00
Bastien Nocera
f5bcb2ed83 network: Fix crash in VPN when removing Wi-Fi connection
Wrong number of arguments to the callback.
2016-06-07 18:50:38 +02:00
Bastien Nocera
7250d49513 network: Fix warning when Wi-Fi connections are removed
Bug introduced with the fix from 199bd2c. For Wi-Fi, a row might not
have an associated connection.
2016-06-07 18:50:38 +02:00
Dan Williams
1428912da0 network: fix some SSID escaping issues
nm_utils_escape_ssid() should only be used for debugging purposes,
but was used in one place for UI display and another place
for doing actual AP comparison.  Instead, the comparison should
just operate on the SSID bytes, and the UI display should use
nm_utils_ssid_to_utf8() which tries to interpret non-ASCII
characters for better display.

https://bugzilla.gnome.org/show_bug.cgi?id=767205
https://bugzilla.redhat.com/show_bug.cgi?id=1336714
2016-06-07 10:53:40 -05:00
Bastien Nocera
764208d8e9 network: Add missing nm-default.h file 2016-06-07 14:38:27 +02:00
Bastien Nocera
c316e301ce network: Separate UI changes from code changes 2016-06-07 14:25:20 +02:00
Bastien Nocera
27c9aff3af network: Update wireless-security UI from network-manager-applet
The list of changes compared to the nm-connection-editor code is:
- Remove ":" from the control labels
- Right-justify the control labels
- Shrink the column spacing to 6
2016-06-07 14:21:36 +02:00
Bastien Nocera
92b044ba7f network: Update wireless-security from network-manager-applet 2016-06-07 13:11:07 +02:00
Bastien Nocera
36576a5cb6 network: Update security page for recent changes 2016-06-07 13:11:07 +02:00
Bastien Nocera
e6bccd6646 network: Update wireless-security patch 2016-06-07 13:11:07 +02:00
Bastien Nocera
25feb13ee9 network: Remove nag-user-dialog.ui
It's now unused.
2016-06-07 13:11:07 +02:00
Bastien Nocera
7cc463a067 network: Automate updating wireless-security UI files
from network-manager-applet.
2016-06-07 13:10:55 +02:00
Bastien Nocera
280cff67db network: Add utils from network-manager-applet
The minimum necessary utilities from
network-manager-applet/src/utils/utils.[ch]
for the wireless-security rebase.
2016-06-07 13:10:10 +02:00
Bastien Nocera
199bd2c343 network: Fix removed connections not disappearing
A regression introduced in commit 9183d34, when we ported to libnm 1.2.
2016-06-07 13:10:09 +02:00
Bastien Nocera
9183d34947 network: Port to libnm 1.2
We also remove support for WiMAX (now unsupported by NetworkManager),
and InfiniBand (Enterprise feature), and the use of
the deprecated NM_SETTING_WIRELESS_SEC property.

With help from network-manager-applet patches by Jiří Klimeš and
Dan Winship.

https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-05-27 18:23:33 +02:00
Bastien Nocera
8861d44099 network: Remove now unused virtual devices support
https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
da96effab7 network: Remove HAVE_NM_UNSTABLE check
We don't have any code that relies on it anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
a4729411b5 network: Remove VLAN support
It is supported by Cockpit already:
https://github.com/cockpit-project/cockpit/issues/1007

https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
9974342865 network: Remove team support
It will be supported by Cockpit in the near future:
https://github.com/cockpit-project/cockpit/issues/4330

https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
b38bf8b672 network: Remove bond support
It is supported by Cockpit already:
https://github.com/cockpit-project/cockpit/issues/458

https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
20b634b454 network: Remove bridge support
It is supported by Cockpit already:
https://github.com/cockpit-project/cockpit/issues/459

https://bugzilla.gnome.org/show_bug.cgi?id=747443
2016-05-26 14:49:28 +02:00
Bastien Nocera
5c10ce45b8 panels: Fix translators comments being truncated
Commit b3be076 added soft hyphens along with a comment for translators
to use those soft hyphens. Except that gettext would only grab the one
line out of the four we wrote for translators to read. Put them all on
the same line so that gettext actually extracts those.

https://bugzilla.gnome.org/show_bug.cgi?id=765778
2016-04-28 23:38:00 +02:00
Cosimo Cecchi
cce521db4a network: fix a GCC warning
https://bugzilla.gnome.org/show_bug.cgi?id=764296
2016-04-14 12:31:49 -07:00
Bastien Nocera
67c1755fe7 network: Fix warning about renamed theme property
Theme parsing error: <data>:1:54: The 'outline-radius' property has been renamed to '-gtk-outline-radius'
2016-04-13 13:44:30 +02:00
Michael Catanzaro
5036ff0f80 network: Hide firewall zone combo when firewalld is not running
Currently, if firewalld is not running, then the firewall zone combo is
always insensitive. This would make sense if firewalld was great and we
were to consider it a distro bug to not have firewalld running and
enabled, then users would be able to see the option is disabled and
think "maybe my distro has done something wrong."

But in actuality, firewalld is not really great, only Fedora ships it
and we're not really recommending it to other distros. So hide the combo
if it's not running, else it's just broken on $NOTFEDORA.

https://bugzilla.gnome.org/show_bug.cgi?id=763477
2016-04-11 14:53:08 -05:00
Bastien Nocera
9c70369a34 network: Fix "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764727
2016-04-08 11:31:24 +02:00
Bastien Nocera
b3be07609a panels: Fix truncated panel names for larger fonts
Note that this fix will not automatically fix translations, which will
need to add soft-hyphens (U+00AD) to their translations themselves, and
will not fix larger fonts for which the split up syllables end up
being bigger than the maximum text width.

It's the best we can do without redesigning the Settings shell, which is
already something planned.

https://bugzilla.gnome.org/show_bug.cgi?id=647087#c13
2016-04-07 16:06:35 +02:00
Jonathan Kang
28c54f3d55 network: Fix empty Wifi list
Add a callback function for signals "access-point-added" and
"access-point-removed" to update the Wifi list.

https://bugzilla.gnome.org/show_bug.cgi?id=709641
2016-04-05 14:15:20 +08:00
Juan A. Suarez Romero
675ac22c44 network: use VPN plugin paths as specified in the .name files
Since LIBDIR of gnome-control-center and the VPN plugins aren't
necessarily the same, use the paths as specified by the VPN plugins and
only reconstruct the path if it is not absolute or we fail to load the
plugin.

Patch from Debian package, by Michael Biebl <biebl@debian.org>

https://bugzilla.gnome.org/show_bug.cgi?id=764509
2016-04-04 21:46:33 -07:00
Rui Matos
e45b5c8a38 network/vpn: Fix the options button icon alignment
No idea why this was set but it's clearly wrong and this property has
even been deprecated in GtkButton since 3.14 .

https://bugzilla.gnome.org/show_bug.cgi?id=764479
2016-04-02 17:33:55 +02:00
Rui Matos
d8d0c71318 network/device-wifi: Silence a critical when creating a connection 2016-04-01 16:08:28 +02:00
Rui Matos
2e7b23aa00 network: Fix a crash when clicking to forget a VPN on the editor
We need to keep a reference to the NetVpn instance or it might already
be finalized when the editor window closes.
2016-01-26 18:40:47 +01:00