Commit graph

27 commits

Author SHA1 Message Date
Felipe Borges
5c679301ec search: Invalidate "Search Locations" list when folders can't be found
We store the list of "Search Locations" in a gsetting. When a location
gets added and then removed, the gsetting still stores its path.

These changes verify the existance of a file before loading it in the UI,
and also removes the path from the gsetting when the location can't
be found.

Fixes #812
2019-12-17 22:16:08 +00:00
Iain Lane
b5ff6d1b21
cc-search-locations: Use g_new0 instead of the slice allocator 2019-10-30 16:07:18 +00:00
Iain Lane
2c8cce0dcc
search: Factor out creation of Place objects.
If we always construct these objects via a constructor, then we can help
to avoid bugs like that fixed by
2fb0ff250b.
2019-10-30 16:07:14 +00:00
Mohammed Sadiq
2fb0ff250b search: Fix crash on clicking 'Search Locations'
When creating a Page, the dialog variable wasn't set and thus
dereferencing a NULL in a later code resulting a crash.

This was introduced in 14b9f65ba4
2019-09-19 22:45:23 +05:30
Robert Ancell
8855254486 search: Make .ui filename match the .c filename 2019-09-09 21:58:00 +00:00
Robert Ancell
14b9f65ba4 search: Remove global variable that could get leaked
Tracker GSettings were previously stored in a global variable. This
seems to have been done to avoid difficulty passing the settings via
callbacks. Global variables are easy to leak and make mistakes with.

Update the code to have better callback handling so the variable can
be stored inside the object.
2019-08-26 11:57:53 +00:00
Mohammed Sadiq
53ba6dcd2e search: Make search locations dialog adaptive 2019-07-26 01:21:27 +00:00
Robert Ancell
6e3adb6568 search: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-11 22:21:34 +00:00
Robert Ancell
a64ef75ad7 Simplify use of GCancellable
g_cancellable_cancell can be called without checking for a NULL value.
Use g_clear_object instead of g_object_unref
2018-06-01 21:03:19 +00:00
Robert Ancell
59e420b774 search: Fix crash introduced in 58a6432 2018-05-31 12:16:04 +12:00
Robert Ancell
58a64323c4 search: Use g_auto for variables 2018-05-30 23:24:21 +00:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Rui Matos
f32b305a1a search: Fix a GFile leak
https://bugzilla.gnome.org/show_bug.cgi?id=783885
2017-06-19 11:31:06 +02:00
Mohammed Sadiq
38ac1d1d76 search: Fix memory leak
The container returned by g_variant_get_strv() should be
freed with g_free().

https://bugzilla.gnome.org/show_bug.cgi?id=783885
2017-06-19 11:23:42 +02:00
Felipe Borges
e67cd42a45 search: use-header-bar for Search Locations dialog
https://bugzilla.gnome.org/show_bug.cgi?id=766513
2016-05-30 15:32:38 +02:00
Felipe Borges
f473ec45c7 search: introduce the new Search Locations dialog
https://wiki.gnome.org/Design/SystemSettings/Search

https://bugzilla.gnome.org/show_bug.cgi?id=766513
2016-05-30 15:22:44 +02:00
Rui Matos
d3b6add75e search: Drop deprecated API usage
https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Yosef Or Boczko
38119b3f29 search: Use margin-start/end instead of margin-left/right
This is part of previous patch which fell accidentally.

https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:38:47 +02:00
Yosef Or Boczko
6926cf08b9 search: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:58:09 +03:00
Alexander Larsson
a46a652093 search: Convert to GtkListBox
https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-07-02 16:19:09 +01:00
Matthias Clasen
16c2a04e5e Add context to some translated strings
We are using "Other" in various contexts that may require
different translations.
https://bugzilla.gnome.org/show_bug.cgi?id=697211
2013-05-18 18:05:18 -04:00
Kalev Lember
c8b3bc5948 search: Unescape the names in Search Locations
Instead of using g_path_get_basename() on raw URIs, use GFile functions
for getting the properly unescaped basenames of the files.

https://bugzilla.gnome.org/show_bug.cgi?id=694447
2013-02-28 19:44:14 +01:00
Cosimo Cecchi
28b6974b83 search: use a GResource for GtkBuilder UI definition
https://bugzilla.gnome.org/show_bug.cgi?id=691132
2013-01-07 10:57:16 +01:00
Bastien Nocera
63521fe34e search: Use correct ref increasing function 2012-12-03 11:08:59 +01:00
Cosimo Cecchi
2ad13d89f3 search: make options insensitive if tracker is not available
Instead of either hard-depending on Tracker being installed, or crashing
when the Tracker GSettings schema is not found, make the configuration
insensitive if the schema is not available.

https://bugzilla.gnome.org/show_bug.cgi?id=687490
2012-11-27 12:33:00 +01:00
Cosimo Cecchi
defe92ec34 search: add a dialog to configure Tracker search locations
Ideally applications could configure Tracker independent from each
other, but we don't have such a feature currently.
In the meanwhile, bring up a settings dialog that can allow
configuration of the locations indexed by the Tracker files miner, as
suggested by the current design.

https://live.gnome.org/Design/SystemSettings/Search

https://bugzilla.gnome.org/show_bug.cgi?id=687490
2012-11-27 12:33:00 +01:00