Commit graph

4997 commits

Author SHA1 Message Date
Benjamin Berg
3c76d52e8e Move info panel test to tests subdirectory 2018-04-17 15:26:59 +02:00
Benjamin Berg
a9d8ec5747 Move printers panel tests into tests folder 2018-04-17 15:26:59 +02:00
Benjamin Berg
d2d4980ce8 Move panel/common tests into new tests subdirectory 2018-04-17 15:26:59 +02:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Benjamin Berg
e1593b3c02 shell: Remove CcEditableEntry, it is not used anywhere 2018-04-17 14:59:31 +02:00
Georges Basile Stavracas Neto
958bb8fe6b thunderbolt: Fix coding style
Not everything was fixed, but why bother.
2018-04-14 19:26:12 -03:00
Piotr Drąg
8d2fb2199e thunderbolt: fix grammar in a translatable string 2018-04-13 18:54:57 +02:00
Piotr Drąg
da0172274f thunderbolt: add a translator comment to the .desktop file 2018-04-13 18:51:53 +02:00
Christian Kellner
25a302ae98 thunderbolt: move to the 'Devices' page
The 'Devices' page is a fitting place for the thunderbolt, being
an IO technology. It is expected that people that need to go to
that page will be sent there via a gnome-shell notification, so
there is no need for it to be on the main page.
Ok'ed by the design team (jimmac).
2018-04-13 16:03:21 +02:00
Christian Kellner
47f241b10c thunderbolt: new panel for device management
Thunderbolt devices need to be approved before they can be used.
This is done via the boltd system daemon and gnome-shell. The new
panel enables the user to manage thunderbolt devices, i.e.:

 - forget devices that have previously been authorized
 - authorize currently unauthorize devices

Additionally authorization of devices an be temporarily disabled
to ensure no evil device will gain access to the computers
resources.

File starting with "bolt-" are copied from bolt's source tree
and currently correspond to the bolt upstream commit with the id
f22b1cd6104bdc2b33a95d9896b50f29a141b8d8
They can be updated from bolt via the update-from-bolt.sh script.
2018-04-13 15:08:16 +02:00
Felipe Borges
8879cd476a printers: Fix crash when panel is closed quickly
Fix a user-after-free while testing the connectivity to a cups
server. This is similar to the fix in commit 1d72a0b.

This is an addition to the changes introduced in commit 2ff5cfd
which allowed the connection testing to be cancellable.

Fixes #51
Fixes https://bugzilla.gnome.org/794632
2018-04-09 13:26:55 +02:00
Georges Basile Stavracas Neto
10dfbb526e region: Cache D-Bus proxy 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
754434fa0d privacy: Cache D-Bus proxies 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
28ad1d1602 printers: Cache CUPS D-Bus proxy 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
eb62419b4b power: Cache D-Bus proxies and NMClient 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
77ac09aa04 notification: Cache D-Bus proxy 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
e46d505182 info: Cache D-Bus proxies 2018-04-06 22:23:39 -03:00
Georges Basile Stavracas Neto
35f948f5fb common: Cache D-Bus proxy 2018-04-06 22:23:38 -03:00
Georges Basile Stavracas Neto
250eb01931 network: Cache D-Bus proxies and objects 2018-04-06 22:23:38 -03:00
Georges Basile Stavracas Neto
cbf0dc99da display: Cache the D-Bus proxy 2018-04-06 22:23:38 -03:00
Georges Basile Stavracas Neto
8e56ea35f3 color: Cache D-Bus proxies 2018-04-06 22:23:38 -03:00
Georges Basile Stavracas Neto
d6535f82f0 bluetooth: Cache the D-Bus proxy 2018-04-06 22:23:38 -03:00
Andrea Azzarone
0d16cd3feb keyboard: Make "Set Shortcut" button accessible
Set 'can-focus' property to True for change_custom_shortcut_button, fixing
keyboard navigation in the shortcut editor dialog.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/45
2018-03-30 15:27:26 +00:00
Benjamin Berg
adf5a42f01 display: Show insensitive apply button for invalid configurations
When the user creates temporary invalid configurations the dialog used
to hide the apply button as if no change had been done so far. Change
this to show the normal "Apply"/"Cancel" titlebar but make the "Apply"
button insensitive and modify the title to indicate the error.

Unfortunately we don't currently get the reason in a way that we could
translate it. Ideally we would special case common error scenarios and
present the user with a better explanation or even correct the mistake.

See https://bugzilla.gnome.org/show_bug.cgi?id=790891 for the related
mutter bug.

https://bugzilla.gnome.org/show_bug.cgi?id=790792
2018-03-29 12:09:59 +02:00
Andrea Azzarone
d918b02c1f online-accounts: Complete account removal in cc_goa_panel_finalize()
When removing an online account, gnome-control-center gives the user
the possibility to undo the action showing an "undo notification".
Right now if you close the gnome-control-center window, without dismissing
the notification, the online account will not be properly removed.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/25
2018-03-27 21:09:46 +00:00
Ondrej Holy
05c86d3fdc user-accounts: Prevent freeze caused by external cameras
cheese_camera_device_monitor_new freezes the whole panel when opening
for a couple of seconds if external camera is connected. This is not
acceptable. Probably it is bug in kernel. Let's use GAsyncInitable if
available.

Bump the cheese dependency accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=783789
2018-03-26 10:15:31 +02:00
Rasmus Thomsen
f957ce1776
user-accounts: fix building without cheese
https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/10
2018-03-20 17:24:04 +01:00
Georges Basile Stavracas Neto
a1bace4683 build: Drop libgd
Settings does not use libgd.
2018-03-16 15:55:10 -03:00
Georges Basile Stavracas Neto
9a611e0d69 keyboard: Remove deprecated gdk_error_trap_push|pop calls
Instead, implement custom error push and pop functions that mimic
what GDK used to do, but using only non-deprecated functions.
2018-03-16 14:56:28 -03:00
Georges Basile Stavracas Neto
0269f6e5b2 keyboard: Trivial update to code style
This fixed many code style issues in wm-common, and add
a few g_autofree when possible.
2018-03-16 14:39:31 -03:00
Georges Basile Stavracas Neto
aba1647bea keyboard: Silence initialization warning
This field is always initialized properly before being
used, so let's not initialize it when declaring.
2018-03-16 14:19:43 -03:00
Georges Basile Stavracas Neto
ee66dc5f3f keyboard: Turn gchar** into GStrv and use g_auto 2018-03-16 14:18:45 -03:00
Georges Basile Stavracas Neto
4496b60c73 keyboard: Make unused public function static
It is not used outside wm-common.c, so let's not export
it as a public function.
2018-03-16 14:14:41 -03:00
Georges Basile Stavracas Neto
2416b4278d keyboard: Remove unused include 2018-03-16 14:14:11 -03:00
Georges Basile Stavracas Neto
1643674a24 bluetooth: Replace GtkAlignment by halign and valign properties
This removes the last deprecation warning in the Bluetooth panel.
2018-03-16 13:51:25 -03:00
Georges Basile Stavracas Neto
5659271ec3 build: Drop remaining libnm-glib usage
This library is deprecated for a long time now, and Fedora Rawhide
removed the package. Since our CI is based on Rawhide, it began
to fail.

In the end, the usage was just legacy code that doesn't exist anymore,
so it's pretty safe to just plain drop it.
2018-03-16 13:03:04 -03:00
Mohammed Sadiq
f6b3afb9d2 display: Increase popover margins to match mockup
https://bugzilla.gnome.org/show_bug.cgi?id=793165
2018-03-16 02:32:55 -03:00
Georges Basile Stavracas Neto
cf163ef0df universal-access: Use transient-for display
This prevents us from triggering a warning.
2018-03-16 02:07:17 -03:00
Georges Basile Stavracas Neto
a5b766f7f0 universal-access: Move widget setup code to constructed()
This is in preparation for using the transient-for window to
retrieve the GdkMonitor.
2018-03-16 02:06:28 -03:00
Georges Basile Stavracas Neto
6cd9461807 universal-access: Turn ZoomOptions into a template class
This commit turns the ZoomOptions into a template class that
subclasses GtkDialog.

This is also a follow-up from commit c82deede1 where we started
using the non-deprecated GdkMonitor API.
2018-03-16 02:01:38 -03:00
Mario Sanchez Prada
ca9228bb59 display: Early return in monitor_labeler_show() if no outputs are available
The GVariant constructed here would be useless otherwise, since there are
no outputs to show the labels for. Besides, calling g_variant_builder_close
in this scenario would hit an assertion and the program would crash.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/12
2018-03-14 23:27:44 +00:00
Benjamin Berg
729db87249 network: Remove dead code trying to use NMConnection as NMActiveConnection
These code paths could never be hit as an NMConnection cannot be an
NMVpnConnection which is a descendant of NMActiveConnection.

https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 17:29:53 +01:00
Benjamin Berg
72ef675a36 network: Fix warning about missing cast to GtkWidget*
https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 16:15:19 +01:00
Benjamin Berg
3117e2dc4a network: Remove nagging code which removed from libnma
This has been removed long ago and there are only stubs left for g-c-c.

See also:
- https://bugzilla.gnome.org/show_bug.cgi?id=706964
- https://git.gnome.org/browse/network-manager-applet/commit/?id=e21d598896ccd2c52850f52d21fe1d5aaa4e5410

https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 16:14:47 +01:00
Bastien Nocera
4663ba2fac network: Fix crash opening "Hidden network" dialogue
Both the Network panel and libnma expect UI resources in the
same location, which will cause problems when the Network panel loads
its own version that doesn't quite match up to the code used in libnma.

This fixes a crash when nma_wifi_dialog_new_for_hidden() is called and
libnma expects a domain widget to be present, which it isn't in our
version of the UI files.

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:39:10 +01:00
Bastien Nocera
7289e21ef1 network: Fix crash due to object name clashes in NM and g-c-c
1. open Wi-Fi Settings
2. Menu -> Known Wi-fi Networks
3. Click settings of some Wi-Fi network listed there.
4. Press escape twice to close all the dialogs
5. Menu -> Connect to Hidden network..,

Fix crashes when some object type names (WirelessSecurity and
EAPMethod in this case) are duplicated across the Network
panel and libnma.

Fixes a regression in commit 0470c04

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:27:18 +01:00
Georges Basile Stavracas Neto
c82deede1c universal-access: Port to GdkMonitor API
This removes the last deprecation warning of the Universal
Access panel by porting the GdkScreen API usage to the
GdkMonitor API.
2018-03-07 12:10:22 -03:00
Georges Basile Stavracas Neto
cec979ae0c universal-access: Replace GtkHScale
Following the previous commit, this one replaces GtkHScale
by GtkScale. No GtkVScale was found in Universal Access
panel (or any other panel).
2018-03-07 11:56:26 -03:00
Georges Basile Stavracas Neto
86413dc6d5 universal-access: Replace GtkHBox and GtkVBox
We can simply use a GtkBox and set the orientation property.
Since this property defaults to 'horizontal', we actually
only need to set it when replacing GtkVBox.
2018-03-07 11:50:07 -03:00
Georges Basile Stavracas Neto
9e8a4729f0 color: Remove deprecated functions and silence compiler warnings
The color calibration code called on GdkScreen API, an API that is
now mostly deprecated in favour of GdkDisplay and GdkMonitor.

This commit updates that, and also removes a compiler warning about
different enum types.
2018-03-07 11:08:43 -03:00