Commit graph

91 commits

Author SHA1 Message Date
Lukáš Tyrychtr
1bfa4be664 info-overview: Actually don't show the firmware version row when in a VM
The previous logic was hiding the row when we were not under virtualization.
Fixes #2351
2023-02-21 10:04:27 +00:00
Marco Melorio
9fc2b6c7f9 overview: Remove deprecated gtk_widget_show/hide usage 2023-01-02 22:10:39 +00:00
Felipe Borges
9871a09143 common, info-overview, sharing: Use AdwEntryRow for Hostname entries
See mockups in https://gitlab.gnome.org/Teams/Design/settings-mockups/-/issues/48
2022-12-13 16:16:08 +00:00
Bastien Nocera
6b97d27ea3 info-cleanup: Add test for info-cleanup
To make it easier to see whether our changes had the intended effect.
2022-12-02 13:11:13 +00:00
Bastien Nocera
a9ff350dbf info-overview: Remove "Mesa" prefix for Intel Iris driver
Remove "Mesa" from the start of the device name, it's data about the
driver which isn't relevant to us. It's always added before the name
of the device in `src/gallium/drivers/iris/iris_screen.c` in mesa.
2022-12-02 13:11:13 +00:00
Felipe Borges
f3f81d37b2 info-overview: Update logo when dark-mode changes
Otherwise the logo will only change once the panel gets reloaded.

Fixes #1627
2022-12-02 12:12:48 +01:00
Felipe Borges
e39e21eac3 info-overview: Don't show "Firmware Version" row in virtual machines
This value comes from systemd-hostnamed, which harvests it from
/sys/class/dmi/id/bios_version, which happens to be empty/invalid
in virtual machines (at least KVM powered virtualization).

For this reason, we are better off hiding the "Firmware Version"
row when gnome-control-center is running in a VM.

Fixes #2181
2022-11-28 16:45:06 +00:00
Nitin Joshi
57405b83d2 info-overview: Add "Firmware Version" row
Users often need information like Firmware version, serial number. Hence, it's
better to provide it by default in GNOME.
This changes is to display Firmware version only in "About" menu.

Reference: #1543
2022-11-16 09:34:56 +00:00
Michael Catanzaro
bc01d726f5 info-overview: never upscale the system logo
If we scale up, the logo will become blurry. We should only ever be
willing to scale down, not scale up.

Hopefully fixes #1709
2022-10-25 15:08:53 -05:00
Jake Dane
89443fe550 desktop: Remove obsolete Bugzilla entries
The `X-GNOME-Bugzilla-*` entries were for use by bug-buddy, a GNOME 2
technology that's been gone for over a decade. These entries are
obsolete and can be removed from all desktop files.

The `X-GNOME-Settings-Panel` entry is also obsolete as far as I can
tell and only these panels had it in their desktop file: notifications,
sharing, sound and user-accounts. These entries can also be removed.

After removing the `X-GNOME-Bugzilla-*` entries, the desktop files have
no more variables in them. The meson `configure_file` step is therefor
pointless—there are no variables to configure. As such the
`*.desktop.in.in` files are renamed to `*.desktop.in` to reflect this
and `meson.build` files are modified to remove `configure_file` step.
2022-10-20 13:20:09 +00:00
Felipe Borges
b5a62e9c6e info-overview: Add "Kernel Version" row
Fixes #1112
2022-10-20 10:07:51 +00:00
Felipe Borges
afd173c799 info: Make get_hardware_model use a hostnamed property getter
This way we have a convenient way to obtain systemd-hostnamed
properties.
2022-10-20 10:07:51 +00:00
Mohammed Sadiq
a4aa214d76 info-overview: Use adw-external-link icon
Replace the use of external-link-symbolic which doesn't
work with dark theme
2022-08-17 08:09:15 +00:00
Will Thompson
50a92f110d info-overview: show BUILD_ID in separate row
Previously, if os-release included the BUILD_ID field, it was smushed
into the OS Name row as follows:

    OS Name                    Endless OS 5.0.0; Build ID: 220810-230009

This is unsightly in English; and in languages where the translations of
"OS Name" and "Build ID" are long, the build ID may be ellipsised and
hence useless:

    Nom du système   Endless OS 5.0.0 ; (identifiant de construction ...
    d'exploitation

Instead, display the build ID in a separate row, and hide it if not
present.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1347
2022-08-12 01:24:37 +00:00
Amy
8949aeb338 info-overview: remove extra whitespace
Commit 61908b02 ("
info-overview: change fetch order for consistency") introduces
undesired whitespace. While remaking the commit is not necessary, as it
will not affect bisecting, the whitespace should be eliminated.

This patch removes the whitespace, leaving only one preceding and
proceeding line for the get_hardware_model call.
2022-06-10 17:40:34 +00:00
Amy
f2f2807e84 info-overview: change fetch order for consistency
Currently, the order in which info_overview_panel_setup_overview fetches
data is essentially random. For ease of maintainability and
understanding, the fetches should be ordered by their appearance as rows
in the panel.

This patch changes the order so that it corresponds with the panel's UI
order.
2022-06-10 17:40:34 +00:00
Robert Ancell
4f3eb61395 info-overview: Replace deprecated g_spawn_check_exit_status 2022-05-31 15:21:48 +12:00
Adrien Plazas
d548309f34 info-overview-panel: Use the external link icon for the updates link
This makes it explicit it opens another application to perform the
action.
2022-05-12 23:04:51 +00:00
Michael Catanzaro
69f51bdab0 info-overview: add build option to control distributor logo
Currently, we display a 256x256 version of the OS icon from
/etc/os-release. This is too big for my taste, and it's also not
sufficient for distros that want to display a logo that is not an icon.
For instance, because we no longer display the operating system name
immediately beneath the logo, it may be desirable to use a logo variant
that includes text. This patch adds a meson build option that
distributions can use to override the logo, and a second build option to
specify a different logo for use in dark mode.
2022-05-10 23:16:40 +00:00
Bastien Nocera
88f87de748 info-overview: Remove old version.xml loading code 2022-05-10 23:00:59 +00:00
Bastien Nocera
bfc567955f info-overview: Load GNOME version from gnome-shell
See https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5406
2022-05-10 23:00:59 +00:00
Bastien Nocera
d253fe188c info-overview: Add a placeholder while the GNOME version loads 2022-05-10 23:00:59 +00:00
Bastien Nocera
8914fae8da info-overview: Don't load version.xml info we don't use
We don't use the distributor or date info from gnome-desktop's version.xml
so no need to parse it.
2022-05-10 23:00:59 +00:00
Lukáš Tyrychtr
df30f44709 Fix indent 2022-05-10 21:35:50 +00:00
Lukáš Tyrychtr
450c05471b Label the device name textbox for a11y 2022-05-10 21:35:50 +00:00
Norbert Pfeiler
88e19f50c9 info-overview: Replace llvmpipe with “Software Rendering” 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
a57d31f0cf info-overview: Add some commonly used trademarks
Those are not always present in the device string.
Guidance was taken from the usage on vendor websites.

NVIDIA actually has the rights to GTX™ but doesn’t seem to use it,
in contrast to RTX™.
2022-03-23 09:36:24 +00:00
Norbert Pfeiler
16fc5a95f8 info-overview: Remove some rare @ x.yz GHz specification 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
4b17d9be8e info-overview: Remove redundant/elaborate info
Remove redundant/elaborate in strings like CPU, Core and Processor.
2022-03-23 09:36:24 +00:00
Norbert Pfeiler
50ab1b0742 info-overview: Remove some junk info, like PCIe and SSE 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
02bbab7b8a info-overview: Replace the trademark symbols in a more generic way 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
54b215e1e9 info-overview: Use a more generic regex to match the Mesa infos 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
827369fe94 info-overview: Always omit Gallium, not just for AMD 2022-03-23 09:36:24 +00:00
Norbert Pfeiler
4b6786bd44 info-overview: If names are all caps, leave them be
This made everything AMD lower case after the second word
and is likely unintentional for something like EPYC™.

e.g. was
AMD Ryzen threadripper 1950x 16-core processor
AMD Radeon rx 580 series
2022-03-23 09:36:24 +00:00
Norbert Pfeiler
68d67adf12 info-overview: There is no “AMD®”
AMD doesn’t have a registered trademark for the string only.
2022-03-23 09:36:24 +00:00
Felipe Borges
b094a0b392 info-overview: Allow changing "Device Name" by pressing "Enter"
The hostname/device name dialog has only a GtkEntry. So a user
navigating with only a keyboard should be able to apply their
changes by pressing "Enter".
2022-03-07 17:02:20 +00:00
Jakub Steiner
13376ecb8b Add individual app icons 2022-01-31 14:08:22 +00:00
Norbert Pfeiler
c340798b5c info-overview: Remove trailing space after CPU name
It was apparent when selecting the text, as the text is right aligned.

»AMD® Ryzen threadripper 1950x 16-core processor × 32 «
↓
»AMD® Ryzen threadripper 1950x 16-core processor × 32«
2022-01-29 12:39:12 +01:00
Bastien Nocera
25518a6bca info: Use udev to get the hardware RAM size
libgtop gets the RAM size as is visible to the OS, so the physical RAM
size minus all the reserved areas listed at the top of your usual Linux
dmesg output.

Use systemd 248's MEMORY_ARRAY_* properties attached to the pseudo-DMI
device to get the size of the RAM sticks/chips as the user expects.

Closes: #1540
2022-01-27 10:08:37 +01:00
Bastien Nocera
a079eba2a7 info: Split code that fetches RAM amount 2022-01-27 10:07:41 +01:00
Christopher Davis
05187608f5 info-overview: Fix Software Updates row
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1587
2022-01-22 13:16:37 -08:00
Georges Basile Stavracas Neto
0ab20af9ba panels: Switch to CcPanel content
Start porting panels to the new panel format. This commit
temporarily makes panels have two titlebar, which will be
fixed soon.
2022-01-20 02:23:42 +00:00
Jan Beich
37b29c32cb meson: drop unused argument for i18n.merge_file()
Ignored in Meson < 0.60.0, deprecated since 0.60.1 and fatal since 0.61.0.

panels/applications/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/background/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/camera/meson.build:10:5: ERROR: Function does not take positional arguments.
[...]
2022-01-07 17:22:43 +00:00
Christopher Davis
88027fc310 info-overview: Vertically clamp OS Logo
Otherwise it would grow as large as the page would let
it.
2022-01-06 22:15:30 +00:00
Christopher Davis
96ecd3acdf info-overview: Use AdwPreferences{Page,Group} 2022-01-06 22:15:30 +00:00
Christopher Davis
e637f47e78 cc-list-row: Subclass AdwActionRow
AdwActionRow handles many of the properties we use
CcListRow for. We can re-use it instead of re-creating it.

CcListRow is now an AdwActionRow with three suffixes.
The `activatable-widget` is set when the switch is visible.

Since our `icon-name` property was only used for the arrow
icon, it has been replaced with a `show-arrow` property.

The `bold` property has been removed - it was only used in
one place, and it's not a pattern used in other apps.

I decided to go this route because replacing all the
instances of CcListRow with AdwActionRow directly would
end up being more code.
2022-01-06 08:56:12 -08:00
Christopher Davis
981a8cea7b panels: Use .boxed-list instead of .content
The `.content` style class is deprecated in favor
of the `.boxed-list` style class, which is named
after the design pattern it's used for.
2021-12-16 12:52:44 -08:00
Georges Basile Stavracas Neto
3c8a0aa0b1 info-overview: Port to GTK4
- Remove visible=True properties from the UI file
 - Use GtkPicture for the OS logo
 - Drop gtk_dialog_run()
 - Port gnome-control-center-print-renderer to GTK4
   by using GdkSurface to create the GL context
2021-12-14 22:34:21 -03:00
Bastien Nocera
43b40b3b4a info-overview: Make sure -dark non-text logo variant is handled
gtk_image_set_from_icon_name() would fallback from $LOGO-text-dark to
$LOGO-text to $LOGO, leaving out $LOGO-dark which might be available.

Make sure it's in the list of possibilities by using
g_themed_icon_new_from_names() and listing it explicitly as a possible
icon name instead.

Fixes: a3b8964a19
Closes: #1415
2021-08-23 18:39:34 +02:00
Mohammed Sadiq
5ba4bc0fa9 info: Initialize autoptr variables with NULL
So as to avoid invalid free
2021-08-12 15:02:12 +00:00